rizsotto.mailinglist added a comment.
hey Devin, thanks for looking to it.
================
Comment at: tools/scan-build-py/libscanbuild/clang.py:90
@@ -89,2 +89,3 @@
- {<plugin name>: (<plugin description>, <is active by default>)} """
+ predicate.patterns = [re.compile(r'^' + a + r'(\.|$)') for a in checkers]
+ return predicate
----------------
dcoughlin wrote:
> What's the benefit of using a function attribute here rather than simply
> closing over a local variable?
there is no difference between the two. (it even can be written in the same
order.) i guess, just wanted to decorate the name of the variable. i have no
preference.
http://reviews.llvm.org/D19260
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
