[PATCH] D129934: [clang-format][docs] Fix incorrect 'clang-format 4' option markers

kuzkry added a comment. Hi! Here's a list of earliest commits where each option changed in this PR was introduced: ReflowComments - a0a5039d2e520fd42646cb305ed8b696acb41e63 SortIncludes - da446770823be1b1d1562734e55da7c1a5f2579c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129934: [clang-format][docs] Fix incorrect 'clang-format 4' option markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers

kuzkry added a comment. I forgot to add "Differential revision" footer to the commit message and so I've got to manually close this review. Sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124625/new/ https://reviews.llvm.org/D124625 _

[PATCH] D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers

kuzkry added a comment. Here's a list of earliest commits where each option changed in this PR was introduced: AlwaysBreakTemplateDeclarations - 61e6bbf8508a46ad1269c8ea67dc0372b84e9a3b IncludeBlocks - 4c2c9c3620e3bed9cb6fa709ec3b3cc454eb5748 IncludeCategories - introduced in 85c472dccdf536fb185

[PATCH] D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG712b59cdc5a7: [clang-format][docs] Fix incorrect 'clang-format 9' option marker (authored by kuzkry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123299/ne

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry added a comment. Hi, I've got yet another one. Luckily, nothing wrong with clang-format 10, all were fine. This one was the only option incorrectly marked as clang-format 9. Note, AllowShortIfStatementsOnASingleLine was introduced by 1b750edda14879a16ce782b3ade3af599bfbb717 Repository:

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a subscriber: owenpan. kuzkry added a comment. @owenpan, thank you for delivery. > You just could ask for push rights, especially if you want to change > something more in the future. I will request it then. Hopefully I get accepted as apparently they check for a good "record of s

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a comment. Kind reminder, please deliver this revision. I don't have write access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122064/new/ https://reviews.llvm.org/D122064 ___ cfe-commits

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a comment. Hi. Could you deliver this, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122064/new/ https://reviews.llvm.org/D122064 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a comment. Thanks for the review. Could you please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122064/new/ https://reviews.llvm.org/D122064 _

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a comment. Here's a list of earliest commits where each option changed in this PR was introduced: AllowShortBlocksOnASingleLine - introduced by 17605d396118f3066a0bd4dfd128b7a8893f8b94 DeriveLineEnding - introduced by 358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added a subscriber: MyDeveloperDay. kuzkry added a comment. I removed @MyDeveloperDay, as this is a trivial PR and already got 3 approvals. Anyway, could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorep

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added a comment. @sstwcw, I think you must have forgotten to regenerate the rst file :) I added you as a reviewer to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry created this revision. kuzkry added reviewers: sstwcw, MyDeveloperDay. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Misalignment of clang/docs/ClangFormatSt

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. Herald added a project: All. Kind reminder, please deliver this one for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120631/new/ https://reviews.llvm.org/D120631 ___ cfe-comm

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. In D120631#3348337 , @MyDeveloperDay wrote: > once again thank you! You're welcome :) Could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorep

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. Here's a list of earliest commits where each option changed in this PR was introduced: AlignOperands - introduced by 3219e43c9467e47be9b1a9e32b3ed42a50f6b280 AllowShortEnumsOnASingleLine - introduced by 292058a5d6d708ec7d285a452d4350b33ba080dc

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D120618: [clang-format][docs] Fix a bad comment

kuzkry added a comment. Hey @HazardyKnusperkeks, I've just noticed that the suggestion from your inline comment in D119682 is slightly incorrect. The first commit that introduced `IndentRequires` was 840e651dc6d7fe652667eb8b4d04ef4daf4769df

[PATCH] D120618: [clang-format][docs] Fix a bad comment

kuzkry created this revision. kuzkry added a reviewer: HazardyKnusperkeks. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to 8f310d1967c20d348c617af3a30999031c71fee0

[PATCH] D120221: [AST] Fix typos

kuzkry added a comment. Can I ask you to deliver this one for me? I don't have permissions. My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120221/new/ https://reviews.llvm.org/D120221 __

[PATCH] D120221: [AST] Fix typos

kuzkry created this revision. kuzkry added a project: clang. kuzkry requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120221 Files: clang/lib/AST/ASTDiagnostic.cpp Index: clang/lib/AST/ASTDiagnostic.cpp

[PATCH] D120220: [clang-format] Fix typos and consistency

kuzkry added a comment. Can I ask you to deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120220/new/ https://reviews.llvm.org/D120220

[PATCH] D120220: [clang-format] fix typos and consistency

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. Can I ask you to deliver this one for me? My name and email in git format is "Krystian Kuzniarek " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https://reviews.llvm.org/D119682 ___ cfe-commits mailing lis

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/include/clang/Format/Format.h:2540-2541 ///} /// \endcode - /// \version 13 + /// \version 15 bool IndentRequiresClause; MyDeveloperDay wrote: > HazardyKnusper

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry updated this revision to Diff 409935. kuzkry added a comment. Review fix: added note about IndentRequires. The generated HTML looks like this: F22153448: IndentRequires note.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119682/new/ https:/

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. First of all, thanks @MyDeveloperDay for the approval. In D119682#3321965 , @MyDeveloperDay wrote: > @HazardyKnusperkeks could you validate the `IndentRequiresClause` I know I > added `IndentRequires` in 13 but is this the same

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note: Option 'IndentRequiresClause' was previously known as 'IndentRequires' but the version marker should still i

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry added a comment. In D118991#3298823 , @MyDeveloperDay wrote: > Do you need someone to land this for you? if so we need your "name > " Yes, I need someone to do that. Could you do this for me, please? It's "Krystian Kuzniarek ". Thanks in advanc

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry added a comment. Hey @MyDeveloperDay, Thank you for your positive feedback :) You asked about my technique. Well, I did it empirically. There is a really splendid repository on GitHub by muttleyxd, i.e. https://github.com/muttleyxd/clang-tools-static-binaries. What muttleyxd did is he

[PATCH] D118991: [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers Introduced by 23a5090c6

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2602523 , @HazardyKnusperkeks wrote: > In D87587#2597241 , @kuzkry wrote: > >> Thank you for delivering it, @HazardyKnusperkeks. >> >> One thing concerns me though. I'm not an auth

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. Thank you for delivering it, @HazardyKnusperkeks. One thing concerns me though. I'm not an author of changes done in clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-3073, 3075, 3077, 3082-3086, 3088, 3093-3097, 3099, 3104-3108, and 3110-3111. Perhaps it's just

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2592722 , @HazardyKnusperkeks wrote: > In D87587#2592605 , @kuzkry wrote: > >>> Do you need someone to push it? >> >> Yes, I need someone to do that. I don't have write permissions

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. > Do you need someone to push it? Yes, I need someone to do that. I don't have write permissions. I'm new here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 _

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1162 + + EXPECT_EQ(DefaultUnwrappedLines, Style.ShortNamespaceLines); + EXPECT_EQ("namespace ShortNamespace {\n" curdeius

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 323289. kuzkry marked 2 inline comments as done. kuzkry added a comment. Rebased to the tip of the main branch, merged similar tests (requested by @curdeius) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/n

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552314 , @curdeius wrote: > Please regroup tests and add release notes. Regroup tests - by that I think you meant all your 4 remarks about the tests. So I've done 3/4 :D Release

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552232 , @HazardyKnusperkeks wrote: > Apart from my comments, this looks good to me and I really wonder why it > hasn't been pushed. (I would directly use it!) I don't know, may

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 322880. kuzkry added a comment. Sorted code alphabetically as suggested by @HazardyKnusperkeks and applied almost all fixes proposed by @curdeius (entry in release notes + some changes in unit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 313218. kuzkry retitled this revision from "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option" to "[clang-format][PR47290] Add ShortNamespaceLines format option". kuzkry added a comment. Renamed MaxUnwrappedLinesForShortNamespace to

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

kuzkry updated this revision to Diff 312940. kuzkry retitled this revision from "[clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation" to "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option". kuzkry edited the summary o

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good reviewer. :) Also, I think you've made some good points there and I'm going to turn this review into "non-breaking the world" one. I'll be back in a few days with a new diff. Repository: rG

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. Hey @MyDeveloperDay, thanks for the review. On the one hand, you're right, it's a breaking change and I dislike it too. But please, reconsider because on the other hand: a) adding a new option means increasing our maintenance cost by possibly adding a rarely-used switch (

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. Thanks @JakeMerdichAMD for your quick feedback. > In any case, can you also add the full diff context? It makes it easier for > us to review. I'll do that starting from the next patch because I'm afraid if I resubmit the longer version of the same patch, your comment wo

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry updated this revision to Diff 291468. kuzkry added a comment. Formatted code after CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 Files: clang-tools-extra/unittests/clang-include-fixer

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry updated this revision to Diff 291466. kuzkry added a comment. Adjusted tests IncludeFixerTest.cpp after CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 Files: clang-tools-extra/unittest

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. This fixes https://bugs.llvm.org/show_bug.cgi?id=47290. @Jake I decided I would at least create this pull request so you can decide whether you want it or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry created this revision. kuzkry added reviewers: krasimir, JakeMerdichAMD, jmerdich, rsmith. kuzkry added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. kuzkry requested review of this revision. clang-format documentation states that having ena