[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. sanitizer-x86_64-linux https://lab.llvm.org/buildbot/#/builders/37/builds/4244 FAIL: ScudoStandalone-x86_64 :: preinit.c (772 of 856) ppc64be-clang-test https://lab.llvm.org/buildbot#builders/52/builds/7794 TEST 'ScudoStandalone-powerpc64 :: preinit.c' FAILED among othe

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I saw some bots failure for preinit.c: FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) TEST 'ScudoStandalone-i386 :: preinit.c' FAILED Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux/build/clang_bui

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad accepted this revision. cryptoad added a comment. This revision is now accepted and ready to land. I think this is good, with the additional arch Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I think one of the remaining things to address is the supported architectures: set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) I am unclear as to whethe

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. Thanks a lot Mitch! Couple of comments from a first look, I'll give it another go later. Comment at: compiler-rt/lib/scudo/standalone/wrappers_cpp.cpp:42 + if (Allocator.canReturnNull()) { \ +errno

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41751b637317: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case (authored by cryptoad). Repository: rG LLVM Github Mon

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad updated this revision to Diff 326516. cryptoad added a comment. Opt for a version that satisfies `clang-diagnostic-covered-switch-default` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97496/new/ https://reviews.llvm.org/D97496 Files: c

[PATCH] D97496: [Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

cryptoad created this revision. cryptoad added reviewers: delcypher, vitalybuka. Herald added a subscriber: dexonsmith. cryptoad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Post D96572 , a warning starte

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad abandoned this revision. cryptoad added a comment. This is an arc fail on my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92413/new/ https://reviews.llvm.org/D92413 ___ cfe-commits mailing

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cryptoad requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92413 Files:

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. Thank you for all your work! IIRC everything was working except as you point out some of the very Unixy tests. Is your build creating a `clang_rt.scudo_cxx` library that also needs to be link as well? The C++ specific interceptors usually end up in a separate library t

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2287242 , @russell.gallop wrote: > I'm considering a slight change of plan. @cryptoad, in the name of > incremental development, would you be happy for me to put the scudo sanitizer > version up (with working tests),

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2277371 , @aganea wrote: > @cryptoad What happens if the primary was much smaller? Or if pages were > //reserved// in much smaller ranges? The Primary can be made smaller, but this works better with the Standalone ver

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2274548 , @russell.gallop wrote: > I guess using scudo as a general purpose allocator that could set a limit on > the number of cores that can be used at once as @aganea found. Would there be > any problem with making

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2273815 , @aganea wrote: > If 4.4 TB of virtual pages are mapped in each process (this happens on > startup), then we quickly exaust the 48-bit (256 TB) addressable space with > 72+ programs running (on a 36-core). Any

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2268182 , @russell.gallop wrote: > > Thanks. I'm looking at porting the standalone variant, drawing on D42519 > and Windows support from sanitizer_common. > Does that sound like a

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2242150 , @russell.gallop wrote: > In D86694#2242140 , @cryptoad wrote: > >> That's awesome! Is it meant to eventually be committed or only be used for >> comparison purposes? >

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. That's awesome! Is it meant to eventually be committed or only be used for comparison purposes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86694/new/ https://reviews.llvm.org/D86694 ___

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2030005 , @craig.topper wrote: > I've deleted the branch in the github web interface. I didn't know I could do > that. Ok thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2029752 , @craig.topper wrote: > I noticed when I pulled this morning that this seems to have been pushed as a > branch to the repo > > From https://github.com/llvm/llvm-project > > eb7d32e..63a4fdd master ->

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rG9959eb918acf: Add vendor identity check for Hygon Dhyana processor in Scudo (authored by cryptoad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2027895 , @fanjinke wrote: > Hi Cryptoad， > > Could you help me to commit the patch? Because I don't have access. > > Thanks. Done, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. A couple of style issues to address. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:66 + +#ifndef signature_HYGON_ebx // They are not defined in the gcc. +/* HYGON: "HygonGenuine" */ s/the gcc/gcc/ Comment at: c

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Hey, `clang/lib/Headers/cpuid.h` would have to be in its own CL that would have to be sent separately from the Scudo one. It would have to be reviewed by clang people and likely some tests added. Once this is done and landed, then the Scudo part can happen. Thanks!

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version. This won't compile on systems without a `signature_HYGON_*`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

cryptoad added a comment. In D61923#1502337 , @eugenis wrote: > I think the idea is that implementing our own spinlock is not much harder > than having 3 platform-specific implementations (posix, window, fuchsia). > Also, scudo_standalone is doing the sa

[PATCH] D48833: [Driver] Add PPC64 as supported for Scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rC336202: [Driver] Add PPC64 as supported for Scudo (authored by cryptoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D48833?vs=153727&id=153915#toc Repository: rC Clang https:/

[PATCH] D48833: [Driver] Add PPC64 as supported for Scudo

cryptoad created this revision. cryptoad added reviewers: eugenis, alekseyshl. Scudo works on PPC64 as is, so mark the architecture as supported for it. This will also require a change to config-ix.cmake on the compiler-rt side. Update the tests accordingly. Repository: rC Clang https://revi

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC335620: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android (authored by cryptoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D48570?vs=152900&id=152901#toc Repos

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

cryptoad updated this revision to Diff 152900. cryptoad added a comment. Rebasing. Repository: rC Clang https://reviews.llvm.org/D48570 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c =

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

cryptoad created this revision. cryptoad added reviewers: eugenis, pirama, srhines. I am not sure anyone has tried to compile an application with sanitizers on Android with `-static-libsan`, and a recent NDK, but it fails with: .../i686-linux-android/bin/ld.gold: error: cannot find -lpthread

[PATCH] D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rC335352: [Driver] Make scudo compatible with -fsanitize-minimal-runtime (authored by cryptoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D48373?vs=152171&id=152476#toc Repository

[PATCH] D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime

cryptoad updated this revision to Diff 152171. cryptoad added a comment. Adding tests. Repository: rC Clang https://reviews.llvm.org/D48373 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/CommonArgs.cpp test/Driver/fsanitize.c test/Driver/sanitizer-ld.c Index: test/Driver/

[PATCH] D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime

cryptoad created this revision. cryptoad added a reviewer: eugenis. Herald added a subscriber: cfe-commits. This is the clang side of the change, there is a compiler-rt counterpart. Scudo works with UBSan using `-fsanitize=scudo,integer` for example, and to do so it embeds UBSan runtime. This mak

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

cryptoad added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:89 set(RUNTIMES_${target}-fuchsia_CMAKE_SYSROOT ${FUCHSIA_${target}_SYSROOT} CACHE PATH "") - set(RUNTIMES_${target}-fuchsia_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "") - set(RUNTIMES_${targe

[PATCH] D42416: [Driver] Add support for mips32 and scudo

cryptoad added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:850 + const bool IsMIPS = getTriple().getArch() == llvm::Triple::mips || +getTriple().getArch() == llvm::Triple::mipsel; const bool IsMIPS64 = getTriple().getArch() == llvm::Tr

[PATCH] D42416: [Driver] Add support for mips32 and scudo

cryptoad accepted this revision. cryptoad added a comment. Cool thanks! Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

cryptoad added a comment. So if I understand correctly, the consensus is to abandon this and rewrite it to be part of the clang static analyzer? https://reviews.llvm.org/D29839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

cryptoad updated this revision to Diff 88048. cryptoad added a comment. Missing line separators. https://reviews.llvm.org/D29839 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/IstreamOverflowCheck.cpp clang-tidy/misc/IstreamOverflowCheck.h clang-tidy/misc/MiscTidyModule.cpp doc

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

cryptoad updated this revision to Diff 88047. cryptoad added a comment. Addressing first batch of comments. https://reviews.llvm.org/D29839 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/IstreamOverflowCheck.cpp clang-tidy/misc/IstreamOverflowCheck.h clang-tidy/misc/MiscTidyModul

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

cryptoad marked 5 inline comments as done. cryptoad added inline comments. Comment at: clang-tidy/misc/IstreamOverflowCheck.cpp:78-80 +if (!Arg->isIntegerConstantExpr(WidthSize, Context)) { + llvm::errs() << "Couldn't get width() size.\n"; +} Prazek

[PATCH] D28530: [Driver] Correct empty files in D28238

cryptoad abandoned this revision. cryptoad added a comment. Nevermind, it seems to be working with empty files! https://reviews.llvm.org/D28530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D28530: [Driver] Correct empty files in D28238

cryptoad created this revision. cryptoad added a reviewer: rengolin. cryptoad added a subscriber: cfe-commits. The binary files added as part of https://reviews.llvm.org/rL291598 seem to be empty. Those are the actual files that should have been uploaded by arc. https://reviews.llvm.org/D28530

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad marked 4 inline comments as done. cryptoad added a comment. Thank you for the review Renato! https://reviews.llvm.org/D28238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad added inline comments. Comment at: test/Driver/linux-ld.c:623 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=arm64-unknown-linux-gnu \ +// RUN: --gcc-toolchain="" \ rengolin wrote: > cryptoad wrote: > > rengolin w

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad added inline comments. Comment at: test/Driver/linux-ld.c:623 +// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// RUN: --target=arm64-unknown-linux-gnu \ +// RUN: --gcc-toolchain="" \ rengolin wrote: > shouldn't you have used your t

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad updated this revision to Diff 83376. cryptoad added a comment. Adding tests to test/Driver. https://reviews.llvm.org/D28238 Files: lib/Driver/ToolChains.cpp test/Driver/Inputs/opensuse_42.2_aarch64_tree/ test/Driver/Inputs/opensuse_42.2_aarch64_tree/usr/ test/Driver/Inputs/open

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

cryptoad added a comment. Understood. I'll let someone else chime on on the TSAN aspect of the patch. https://reviews.llvm.org/D28304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

cryptoad added a comment. Hey Michal, If I understand correctly, my next move is to move the CRC32 code into it's own file an only enable SSE 4.2 for this file? Shouldn't COMPILER_RT_HAS_MSSE4_2_FLAG be kept for that purpose or is there an alternative way to do it? Thanks https://reviews.llvm.

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad created this revision. cryptoad added reviewers: chandlerc, bruno, bkramer. cryptoad added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. openSuse has AArch64 support, with images running on the Raspberry Pi 3. The libraries and headers live under the aarch64-sus