[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

juliehockett resigned from this revision. juliehockett added a comment. Apologies, i's been a good long while since I was active in this area. @phosek is the most likely to know who would be the best contact in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM -- thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66783/new/ https://reviews.llvm.org/D66783 __

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e1f7f960d5: [clang-doc] Switch Generator::CreateResources to use llvm::Error (authored by juliehockett). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

This revision was automatically updated to reflect the committed changes. Closed by commit rL369811: [clang-doc] Bump BitcodeWriter max line number to 32U (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

juliehockett created this revision. juliehockett added a reviewer: phosek. juliehockett added a project: clang-tools-extra. b43039 reports hitting the assert on a very large file, so bumping this to allow for larger files. https://reviews.llvm.org/D66681 Files: clang-tools-extra/clang-doc/Bi

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

juliehockett created this revision. juliehockett added reviewers: DiegoAstiazaran, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. https://reviews.llvm.org/D66502 Files: clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/c

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

juliehockett added a comment. LGTM, for posterity Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66378/new/ https://reviews.llvm.org/D66378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 ___ cfe-commits mailing list c

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:487-489 +static std::unique_ptr +genFileMainNode(StringRef InfoPath, +std::vector> &MainContentInnerNodes, Would you be able to briefly comment on each o

[PATCH] D66298: [clang-doc] Fix records in global namespace

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299 RecordInfo *G = InfoAsRecord(Infos[2].get()); - RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E"); + RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"Gl

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeWriter.h:33 // BitCodeConstants, though they can be added without breaking it. static const unsigned VersionNumber = 2; I definitely haven't been particularly good about bumpin

[PATCH] D66151: [clang-doc] Fix bitcode writer

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. One comment then LGTM Comment at: clang-tools-extra/clang-doc/Serialize.cpp:507 Reference{ParentUSR, Parent->getNameAsString(), InfoType::IT_record}; - Fu

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett accepted this revision. juliehockett marked an inline comment as done. juliehockett added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" ins

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter version. StringRef Dir = Directory; --

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 ___ cfe-commits mailing list c

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65915/new/ https://reviews.llvm.org/D65915 ___ cfe-commits mailing list c

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (after comment nit addressed) Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249 + Error = false; + llvm::ThreadPool Pool(ExecutorConcurrenc

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:385 +SourceRoot(SourceRoot), UserStylesheets(UserStylesheets), +JsScripts(JsScripts) { +if (!RepositoryUrl.empty()) { Move to .cpp file (now that it h

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this next time) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65827/new/ https://reviews.llvm.org/D65827 _

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 ___ cfe-commits mailing list c

[PATCH] D65622: [clang-doc] Update documentation

juliehockett added a comment. Sorry for the delayed review, but a few things I caught :) Also, please make sure to update the the release notes/flag documentation for the patches you have in progress that add features or flags. Comment at: clang-tools-extra/trunk/docs/Release

[PATCH] D65690: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext &CDCtx) { + std::error_code OK; Why is this implementation in the generic Generator? It's fairly HTML-specific -- ne

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + DiegoAstiazaran wrote: > juliehockett wrote: > > Formatting is a bit weird for sublists > Fi

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name), Pat

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); + Node->Children.emplace_back(llvm::make_unique("

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", Can we use the pre-existing concurrency flag instead (https://github.com/llvm/llvm-project/blob/91e5cdf

[PATCH] D65309: [clang-format] Fix style of css file paths

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM after adding a comment to explain Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:234 llvm::sys::path::filename(FilePa

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Make sure you update the other stylesheet patch, as well, before landing that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65306/new/ https://reviews.llvm.org/D65306

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D64938 ___ cfe-commits mailing list c

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. Looks mostly good to me, with a small formatting thing Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:490 Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H3, I.Name)); + Out.back()->Attributes.try_emplace("id", +

[PATCH] D65003: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.h:28 + static Index genIndex(const std::vector> &Infos); + Add a comment here indicating that this should be created before calling any `generateDocForInfo`s. Also add a fi

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett added a comment. Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths? Comment at: clang-tools-extra/cla

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65107/new/ https://reviews.llvm.org/D65107 ___ cfe-commits mailing list c

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:26 + ClangDocContext CDCtx; + CDCtx.UserStylesheets = {"../share/clang/clang-doc-default-stylesheet.css"}; + return CDCtx; Can you write a test for the

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett accepted this revision. juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rL366354: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64669: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL365967: [clang-doc] Fix failing tests on Windows (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64669: [clang-doc] Fix failing tests on Windows

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64669/new/ https://reviews.llvm.org/D64669 ___ cfe-commits mailing list c

[PATCH] D63663: [clang-doc] Add html links to references

This revision was automatically updated to reflect the committed changes. Closed by commit rL365937: [clang-doc] Add html links to references (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:242 + // Generate css stylesheet + if (Format == "html") { On second thought, can you create a virtual method to the Generator along the lines of `Generator::cr

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:110-113 +Inherits from +F +, +G This text should be rendered inline Comment at: clang-tools-extra/unittests/clang-doc/

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:247 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { Eventuall

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:246-271 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { + llvm::errs() <<

[PATCH] D63857: [clang-doc] Add a structured HTML generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL365687: [clang-doc] Add a structured HTML generator (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL365682: Update libc++ include path detection to use VFS on Linux (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added a comment. I've also just noticed that the YAML generator is missing from this -- could you add the `Path` fields to hat output as well? Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:213 + llvm::SmallString<128> Path = Type.Path; + llvm::sys::p

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:206 + llvm::SmallString<128> Path = Type.Path; + ::llvm::sys::path::append(Path, Type.Name + ".html"); + return genLink(Type.Name, Path); You shouldn't need the prefi

[PATCH] D63857: [clang-doc] Add a structured HTML generator

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM, unless Jake has further comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:503 + } + // std::move(Nodes.begin(), Nodes.end(), std::back_

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

juliehockett created this revision. juliehockett added reviewers: dlj, phosek. Herald added a reviewer: EricWF. The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates it to use llvm::vfs::directory_iterator. https://reviews.llvm.org/D64381 File

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

This revision was automatically updated to reflect the committed changes. Closed by commit rL364963: [clang-doc] Serialize child namespaces and records (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

This revision was automatically updated to reflect the committed changes. Closed by commit rL364949: [clang-doc] Fix segfault in comment sorting (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

juliehockett created this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63962 Files: clang-tools-extra/clang-doc/Representation.h Index: clang-tools-extra/clang-doc/Representation.h ===

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't this do the > same thing? Diego, why don't

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:366 + + if (I->Namespace[0].RefType == InfoType::IT_namespace) { +auto Parent = llvm::make_unique(); Can you make this a switch statement, doing the appropriate things

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL364674: [clang-doc] Handle anonymous namespaces (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL364670: [clang-doc] De-duplicate comments and locations (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

This revision was automatically updated to reflect the committed changes. Closed by commit rL364663: Update CODE_OWNERS.txt for clang-doc (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 206979. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341 + Parent->USR = ParentUSR; + Parent->ChildNamespaces.emplace_back(I->USR, I->Name, InfoType::IT_namespace); + return {std::unique_ptr{std::move(I)}, You're probably

[PATCH] D63857: [clang-doc] Structured HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 +class HTMLTag { +public: Put the class definitions in an anonymous namespace (https://llvm.org/docs/CodingStandards.html#anonymous-namespaces)

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

juliehockett added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63734/new/ https://reviews.llvm.org/D63734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 namespace { Eugene.Zelenko wrote: > Anonymous namespace is used for functions when LLVM Coding Guidelines tells > using static for same purpose. Actually, since

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL364222: [clang-doc] Add basic support for templates and typedef (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

juliehockett created this revision. juliehockett added a reviewer: klimek. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63734 Files: clang-tools-extra/CODE_OWNERS.TXT Index: clang-tools-extra/CODE_OWNERS.TXT ===

[PATCH] D63666: [clang-doc] Add templates to HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:59 + Items += + applyHTMLTemplate(HTMLTemplates::BlockItem, M.str().str().c_str()); +} Put `FIXME: Transition Members from llvm::SmallString to std::st

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added a comment. General design thought: could we move the path name construction to `Serialize.cpp`? Essentially, move the logic that builds the path name from the namespaces and name to the serialize step (you'll have to add the `OutDirectory` to the `ClangDocContext` so that you

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:87 +std::string CloseTag = I.SelfClosing ? "/>" : ">"; +writeLine("<" + I.Name + Attrs.str() + CloseTag, OS); + } else if (I.Kind == "HTMLEndTagComment") { You

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363712: [clang-tidy] Split fuchsia-default-arguments (authored by juliehockett, committed by ). Herald added a project: LL

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared using typedef llvm::SmallVector Run

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. In D62970#1533229 , @jakehehrlich wrote: > Actually if we can make Description a hash set that would be best. I think > using std::set would require an awkward < operator to be defined. There > should be standard ways of ge

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. Please add a test case to `unittests/clang-doc/MergeTest.cpp`. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124-127 +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Co

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

juliehockett added a comment. Sorry for the delay! Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:24 + const auto *S = Result.Nodes.getNodeAs("stmt"); + if (S == nullptr) +return; Just `if (!S)` should be sufficient here.

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett abandoned this revision. juliehockett added a comment. @hintonda Aha so it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

juliehockett created this revision. juliehockett added reviewers: alexfh, hokein. juliehockett added a project: clang-tools-extra. This removes the else clause that adds a default `-header-filter` flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any He

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

juliehockett added a comment. This is also making our Mac builders fail on configuration, and looks like a directory wasn't included properly when a test moved to a subdirectory -- would you mind taking a look? The CMake command we're running is at the top of the attached log. CMake Error at

[PATCH] D59975: [fuchsia] Add clang-doc to Fuchsia distribution

juliehockett closed this revision. juliehockett added a comment. Closed and submitted in r357275 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59975/new/ https://reviews.llvm.org/D59975 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D59974: [clang-doc] Build as clang_tool

This revision was automatically updated to reflect the committed changes. Closed by commit rL357274: [clang-doc] Build as clang_tool (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D59974: [clang-doc] Build as clang_tool

juliehockett created this revision. juliehockett added reviewers: phosek, leonardchan. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. Instead of as clang_executable. https://reviews.llvm.org/D59974 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt I

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56825/new/ https://reviews.llvm.org/D56825 ___ cf

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 180182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff

This revision was automatically updated to reflect the committed changes. Closed by commit rL349930: [clang-tidy] Add export-fixes flag to clang-tidy-diff (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55848

[PATCH] D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. So that you can export the fixes generated. https://reviews.llvm.org/D55848 Files: clang-tools-extra/clang-ti

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett abandoned this revision. juliehockett added a comment. After a lot of discussion, we'll do this migration internally. Thanks for your comments! https://reviews.llvm.org/D54168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett abandoned this revision. juliehockett added a comment. After a lot of discussion, we'll do this migration internally. Thanks for your comments! https://reviews.llvm.org/D54169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett updated this revision to Diff 172892. juliehockett marked 2 inline comments as done. https://reviews.llvm.org/D54168 Files: clang-tools-extra/clang-tidy/zircon/CMakeLists.txt clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett updated this revision to Diff 172891. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D54169 Files: clang-tools-extra/clang-tidy/zircon/CMakeLists.txt clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp clang-tools-extra/clang-tidy/zircon/FblLimitsChe

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett updated this revision to Diff 172889. juliehockett marked 4 inline comments as done. https://reviews.llvm.org/D54168 Files: clang-tools-extra/clang-tidy/zircon/CMakeLists.txt clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett added a comment. In https://reviews.llvm.org/D54168#1289128, @JonasToth wrote: > I think this check is ok in the current form, but does it really need to be > in upstream clang-tidy? You said its for migration only, so it is not > valuable for you for a long time either? So yes,

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to convert to std . This check is part of a set of migration checks as we prepare to move Zi

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to convert fbl::move to std::move. This check is part of a set of migration checks as we prep

[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

juliehockett planned changes to this revision. juliehockett marked 5 inline comments as done. juliehockett added a comment. In https://reviews.llvm.org/D53882#1282219, @aaron.ballman wrote: > I am a bit confused by what this check is trying to accomplish. It seems like > this is intended to catc

[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

juliehockett updated this revision to Diff 171810. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D53882 Files: clang-tools-extra/clang-tidy/zircon/CMakeLists.txt clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp clang-tools-extra/clang-tidy/zircon/NoStdNa

[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:71 +void NoStdNamespaceCheck::check(const MatchFinder::MatchResult &Result) { + if (const auto *D = Result.Nodes.getNodeAs("stdVar")) +diag(D->getBeginLoc(), -

[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to warn against using the std namespace, as Zircon's kernel lib++ policy does not al

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345418: [clang-doc] Switch to default to all-TUs executor (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D53170?vs=169414&id=171331#toc Repository: rCT

  1   2   3   4   5   >