[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

2023-04-07 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri added a reviewer: aaron.ballman. J-Camilleri added a comment. Firstly, If there are other reviewers which I should include instead please let me know, the developers that changed around this area did so a long time ago and I do not know who to add. I have described the problem in th

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

2023-04-07 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri created this revision. Herald added a project: All. J-Camilleri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If implicitly declared 'operator=' declarations are generated before encountering a use in a nested class, custom de

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

2022-09-22 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri marked 2 inline comments as done. J-Camilleri added a comment. In D134339#3808998 , @dblaikie wrote: > I'll commit this shortly. Ok, thanks for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

2022-09-22 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri marked 3 inline comments as done. J-Camilleri added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:23-27 + + // CHECK-DAG: !DIDerivedType(tag: DW_TAG_typedef, name: "pub_typedef",{{.*}} line: [[@LINE+1]],{{.*}} flags: DIFlagPublic) + typed

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

2022-09-22 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri updated this revision to Diff 462092. J-Camilleri added a comment. Addressing reviewer comments: Comply to offical style, Simplify test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134339/new/ https://reviews.llvm.org/D134339 Fi

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

2022-09-21 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri added a comment. The premerge checks have failed but the only message I can see is `HTTP 28` in the log. I am not sure where to look for more information about the failure, Can someone please point me in the right direction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134339: [clang][llvm] generate accessibility metadata for type aliases

2022-09-21 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri created this revision. J-Camilleri added a reviewer: dexonsmith. Herald added subscribers: jeroen.dobbelaere, hiraditya. Herald added a project: All. J-Camilleri requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

2019-05-27 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri added a comment. In D61861#1517812 , @madsravn wrote: > This patch has now been merged. > https://github.com/llvm/llvm-project/commit/bd324fa2273778430a4fdf8371fec5d64d2231bb Great, thanks. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

2019-05-14 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri added a comment. In D61861#1500868 , @madsravn wrote: > Looks good to me :) Thanks for the review and suggestion, who should I contact now in order to push the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

2019-05-13 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri updated this revision to Diff 199315. J-Camilleri added a comment. Added a new unit test and restored the modified test as it was. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61861/new/ https://reviews.llvm.org/D61861 Files: clang-

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

2019-05-13 Thread Jonathan Camilleri via Phabricator via cfe-commits
J-Camilleri created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug Fix for #35811 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61861 Files: clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tools-extra/te