[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 updated this revision to Diff 473684. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Rebase, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133890/new/ https://reviews.llvm.org/D133890 Files: bolt/

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. I have done the deduping @phosek requested, and changed the variable names from `CMAKE_*` to `LLVMPROJ_*` which hopefully satisfies everyone's criteria. Happy with other non `LLVM_` options too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 473679. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Dedup code, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: b

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

Ericson2314 added a comment. This change introduces a lot of conditional code, that is not necessary. This change also uses `CLANG_` outside `clang/` which is messy. and confusing. Please clean up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

Ericson2314 accepted this revision. Ericson2314 added a comment. LGTM. I also can't see why it would act differently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/ https://reviews.llvm.org/D137224 __

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. Thanks @MaskRay that's good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. @tianshilei1992 that is a fair point. I would be open to calling them something else. I just don't want to call them `LLVM_*` because that would be confusing since there is (a) LLVM in particular (b) the monorepo / project as a whole, and this variable are about *n

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added inline comments. Comment at: libcxx/CMakeLists.txt:421 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(default_install_path "${CMAKE_INSTALL_INCLUDEDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++/v1") +else() ldionne wrote: > ldionne wrote:

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 460222. Ericson2314 added a comment. Rebase, fix some issues (by the looks of it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: clang/CMakeLists.txt

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 created this revision. Ericson2314 added reviewers: phosek, ldionne, sebastian-ne, beanz. Herald added subscribers: libc-commits, bzcheeseman, ayermolo, sdasgup3, abrachet, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufen

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 460191. Ericson2314 added a comment. Fix misspelled variable `CLANG_CURRENT_SOURCE_DIR` -> `CLANG_SOURCE_DIR` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 File

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1c81e32739: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 460099. Ericson2314 added a comment. Fix typo in compiler-rt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: bolt/CMakeLists.txt clang/CMakeLists.txt

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:3 + get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME) +endif() + compnerd wrote: > Should this perhaps be moved further down near the usage? Sure ==

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 459985. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase, avoid sed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: bolt

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 added a comment. I think I fixed the issue: I was confusing `/lib` stemming from lib subdirs in the source and `/lib` stemming from building things in a lib directory that will later be installed also to a lib directory. It is just the latter case that uses the suffix, and so just t

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 updated this revision to Diff 459975. Ericson2314 added a comment. Require `LLVM_LIBDIR_SUFFIX` in the sed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: clang/cmake/modules/CMakeLis

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 updated this revision to Diff 459968. Ericson2314 added a comment. Rebase on top of D133828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Let's just revert this. I'll do it later today if no one beats me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-co

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, phosek, ldionne. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, pmatos, asb, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Whew, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. https://lab.llvm.org/buildbot#builders/13/builds/24958 I am worried this failure is not spurious? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454982. Ericson2314 added a comment. Convert `CMAKE_CFG_INTDIR` as @sebastian-ne suggests, also .../bin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: b

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. That sounds good to me too. Sorry I did unquestionably jump the gun here --- I suppose I was surprised to get a fairly simple approval when I put on the `[RFC]`, and thought "hmm, maybe this isn't so controversial as I feared because indeed the deprecation cycle ha

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454829. Ericson2314 added a comment. Redo sed mandating ending on word boundary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib/Target/AArch64/C

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/D132411 should fix the issue @aaron.ballman mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 ___

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/rZORG3a209ca6c1b9 This s what I had started doing. but I am not sure it is a very good solution. I think I might write a discourse post with my thoughts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. I did a "soft revert" in rG952f90b72b3546d6b6b038d410f07ce520c59b48 which makes it a non-fatal error so everything keeps on working, but I can do a real revert too if that is preferred. Reposito

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. In 952f90b72b3546d6b6b038d410f07ce520c59b48 I relented and made it a non-fatal error until the remaining jobs are figured out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. Ah I see email about sphinx jobs defined out of tree :/ I will take a look at that, see if it is easy to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rG176db3b3ab25: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJEC

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 updated this revision to Diff 454271. Ericson2314 added a comment. Do the rename @phosek suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 Files: clang/lib/Driver/ToolChains/Linux.cp

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 created this revision. Ericson2314 added reviewers: ldionne, phosek. Herald added subscribers: Enna1, arichardson, mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added subscribers: llvm-commits, libcxx-commits, Sanitizers, cfe-commits, MaskRa

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 created this revision. Ericson2314 added reviewers: phosek, sebastian-ne, beanz. Herald added subscribers: bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jac

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. OK Thanks @thakis --- I was confused why the last GN fixup added but didn't remove lines. That clears it up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. `D130586` was approved; this is a subset; this had no test failures, so I just went ahead and landed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adda398cef7: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASEN

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 created this revision. Ericson2314 added a reviewer: sebastian-ne. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, MaskRay. Herald added projects: clang, LLD

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 454212. Ericson2314 added a comment. Rebase; Include d3a1dbc4907b59690f9013cdb6221573ca4233f1 as requested Thanks @thakis for letting me know. Repository: rG LLVM Github Monorepo

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Sorry. I have reverted this. I see why the `lib` and `lib64` mixup could be caused by this, but I am baffled how the missing headers could be. Headers search paths should be unaffected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a33090a910: [cmake] Use `CMAKE_INSTALL_LIBDIR` too (authored by

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. OK I was worried the debuginfod one was unique to this PR; glad to hear it isn't. I'll give it a shot then, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 __

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Anyone have any idea what this Debian test failure is about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 ___ cfe-commits mailin

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 453328. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Rebase, fix outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Fi

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2b158e29eed: clang/cmake: Drop use of llvm-config for LLVM install discovery (authored by tstellar, committed by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

Ericson2314 updated this revision to Diff 450529. Ericson2314 added a comment. Add my changes but split to just Clang as @tstellar requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files: clang/

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 abandoned this revision. Ericson2314 added a comment. Abandoing based on @phosek's point in D128777 about it being nice to have it easy to revert them individually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. @tstellar There wasn't a configuration necessitating these changes. The CMake config file currently distinguishes a main include dir and secondary include dir, which feels to me like it is leaking the implementation details of which headers are generated or not. I w

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 added a comment. Should I wait for anyone else / do something like announcing this on discourse? It looks like the only other use case is libclc, which sadly only supports the old way so we will need to do another deprecation cycle I'd think for it. Repository: rG LLVM Github Mon

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, mstorsjo, compnerd, beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thi

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. I tested this in my distro build setup, and reread the LLVM source to make sure the list was as I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130553/new/ https://reviews.llvm.org/D130553 __

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc56a5022c94: [clang][lld][cmake] Simplify header dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLV

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448459. Ericson2314 added a comment. Rebase so libcxx and friends are hopefully fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeL

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448458. Ericson2314 added a comment. `WARNING` -> `DEPRECATION` in `message` call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeLists

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. @sebastian-ne Thanks. Your commit 100% makes it better than it was (straight typo on my part), so I cherry-picked it to `release/15.x`: 2647f7274782e4a529d7c3a9920de86ddfe72324 @sylvestre.ledru T

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" compnerd wrote: > Does this not potentially break downstre

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked 6 inline comments as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:65 set(output_dir "${LLVM_LIBRARY_OUTPUT_INTDIR}") - set(install_dir "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}") +

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448058. Ericson2314 added a comment. Add deprecation notice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeLists.txt clang/CMakeList

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448053. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Fix review comments. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D1305

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Thanks so much @sebastian-ne for the thorough review! Unlike the other patches rather than being cleaned up code that needs more testing, this is closer to the original patch we've been using for a while (tested but not cleaned up); sorry there were so many things t

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. @sebastian-ne I didn't quote it because it is a list, but this might be shell script habit sneaking through. I am not sure what is best for CMake. Checking now, https://stackoverflow.com/questions/35847655/when-should-i-quote-cmake-variables says "If your variable

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Thanks @stella.stamenova for looking into this. I agree the `extend_path` should go back so it properly becomes the install dir. I can't think why I removed it in the first place! The point was to not export the other var, and indeed having that one properly alterna

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 447757. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere, ormris. Forgot to define `CLANG_INSTALL_LIBDIR_BASENAME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, compnerd, phosek. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, J

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. Hmm I am getting failed builds from this one but not quite sure what the problem is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130545/new/ https://reviews.llvm.org/D130545 _

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:81 # path is removed. -set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") +set(INCLUDE_DIRS ${LLVM_INCLUDE_DIRS}) set(LLVM_OBJ_DIR "${LLVM_BINARY_DIR}") sebastian-ne wrote: > Do we nee

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28e665fa054d: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs (authored by Ericson2314). Repository: rG LLVM Github Mono

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added inline comments. Comment at: openmp/CMakeLists.txt:3 -# Add cmake directory to search for custom cmake functions. -set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH}) +set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, sebastian-ne, mstorsjo. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't need to reco

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 updated this revision to Diff 447569. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Add another fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, phosek, sterni, lebedev.ri. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added projects: clang, OpenMP. Herald added subscribers: openmp-comm

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9e6f6fa654: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs (authored by Ericson2314). Repository: rG LLVM Github

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

Ericson2314 updated this revision to Diff 447465. Ericson2314 added a comment. Avoid extend_path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 Files: llvm/cmake/modules/AddLLVM.cmake llvm/cmake/modu

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5acd376438a5: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs (authored by Ericson2314). Repository: rG LLVM Github

[PATCH] D117973: [cmake] Support custom package install paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked 2 inline comments as done. Closed by commit rGac0d1d5c7b7e: [cmake] Support custom package install paths (authored by Ericson2314). Repository: rG

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

Ericson2314 added a comment. Also sorry, I had missed D130256 all along! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 ___

[PATCH] D101070: [llvm][cmake] Make `install_symlink` workflow work with absolute install dirs

Ericson2314 updated this revision to Diff 447391. Ericson2314 added a comment. Oops! `ExtendPath` was not already imported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 Files: llvm/cmake/modules/AddLL

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30 + if(IS_ABSOLUTE "${path_to_leave}") +set(prefix_var + "# Installation prefix is fixed absolute path" sebastian-ne w

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 447361. Ericson2314 added a comment. Fix bug, and add comments to both branches for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files: clang/cmake/m

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447358. Ericson2314 added a comment. Rebase, make caller responsible for making paths absolute This avoids module resolution issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://review

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 added a comment. @sebastian-ne Thanks yes I was worried that might happen. I think I will just move the `extend_path` to the caller then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 _

[PATCH] D101070: [llvm][cmake] Make `install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447108. Ericson2314 added a comment. Rebase to retrigger CI I think it tried to cherry-pick an already-landed patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D1010

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 updated this revision to Diff 447107. Ericson2314 added a comment. Rebase, hopefully fix, and also fix stray GNUInstallDirs violation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070 Files: l

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32560211c620: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR` (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

Ericson2314 created this revision. Ericson2314 added a reviewer: tstellar. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to D117977

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Will make patch forit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. @tstellar Thank you! That is an error I do understand, and yes your example is exactly right. Sorry, I thought I had checked every rebase that no new usages cropped up, but I guess I missed one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. https://lab.llvm.org/buildbot#builders/74/builds/12262 here is a failure with only me in the blamelist, but I cannot see how those failures have anything to do with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a subscriber: nikic. Ericson2314 added a comment. @nikic if you are still around, might you want to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 _

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 446609. Ericson2314 added a comment. - Rebase - Some `set` -> `extend_path` - Fix spelling / comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files: c

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Thanks @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b749800c5c: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. https://reviews.llvm.org/D130254 oh yay I learned from this the openmp failure is in fact spurious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 __

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. https://reviews.llvm.org/D130254 oh yay I learned from this the openmp failure is in fact spurious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 __

  1   2   3   >