[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

2018-07-24 Thread Joel Galenson via Phabricator via cfe-commits
jgalenson abandoned this revision. jgalenson added a comment. I just committed https://reviews.llvm.org/rL337830, which solves this problem the way eugenis suggested. Repository: rC Clang https://reviews.llvm.org/D49492 ___ cfe-commits mailing l

[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

2018-07-18 Thread Joel Galenson via Phabricator via cfe-commits
jgalenson added a comment. Good call; I had figured that running it earlier might just impede other optimizations, but I forgot that it would also hide size information. I thought this was the easiest approach compared to changing the pass pipeline or adding extra checks in here. But I hadn't

[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

2018-07-18 Thread Joel Galenson via Phabricator via cfe-commits
jgalenson added a comment. In https://reviews.llvm.org/D49492#1167064, @efriedma wrote: > Are you sure this will actually do what you want, in general? I suspect it > will end up missing bounds checks in some cases because it's running it too > early (before mem2reg/inlining/etc). No, I'm no

[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

2018-07-18 Thread Joel Galenson via Phabricator via cfe-commits
jgalenson created this revision. jgalenson added reviewers: eugenis, chandlerc. Herald added a subscriber: cfe-commits. Running the bounds checking sanitizer earlier makes it easier for other optimizations to remove the checks it inserts. While it could also inhibit other optimizations, I ran a

[PATCH] D46406: [docs] Fix typos in the Clang User's Manual.

2018-05-03 Thread Joel Galenson via Phabricator via cfe-commits
jgalenson created this revision. jgalenson added reviewers: hans, sylvestre.ledru. Repository: rC Clang https://reviews.llvm.org/D46406 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ d