jgalenson added a comment.

Good call; I had figured that running it earlier might just impede other 
optimizations, but I forgot that it would also hide size information.

I thought this was the easiest approach compared to changing the pass pipeline 
or adding extra checks in here.  But I hadn't realized I could use SCEV that 
easily.  From trying it quickly, I think this can remove the check in this 
testcase (and even some others this couldn't remove).  I'll work on making a 
patch that does that instead.

Thanks for the quick feedback and suggestions!


Repository:
  rC Clang

https://reviews.llvm.org/D49492



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to