Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

2017-03-28 Thread Jim Grosbach via cfe-commits
SGTM Sent from my iPhone > On Mar 28, 2017, at 5:25 PM, Eric Christopher wrote: > > > >> On Tue, Mar 28, 2017 at 4:31 PM Craig Topper wrote: >> So if you use -march=hsw the backend will think rtm is enabled, but clang >> will block the intrinsics in the frontend? > > Yeah. I've come to th

Re: r250473 - Add an error when calling a builtin that requires features that don't

2015-10-16 Thread Jim Grosbach via cfe-commits
Woot! Thanks! > On Oct 15, 2015, at 4:47 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires feature

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

2015-09-10 Thread Jim Grosbach via cfe-commits
grosbach added a comment. In http://reviews.llvm.org/D10414#243302, @jmolloy wrote: > In an ideal world, yes. However there's no guarantee that all ARM > implementors will (a) be able to commit to LLVM or (b) use ToT. Perhaps > they're building a project that uses clang, or a specific version o

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

2015-09-10 Thread Jim Grosbach via cfe-commits
grosbach added a comment. In http://reviews.llvm.org/D10414#243056, @jmolloy wrote: > Non-restricted IT blocks are indeed deprecated for ARMv8 in the ARMARM. But > there are circumstances where you may still want to emit them - the biggest > example being you're compiling for a CPU microarchite

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

2015-09-10 Thread Jim Grosbach via cfe-commits
> On Sep 10, 2015, at 1:24 AM, James Molloy wrote: > > jmolloy added a subscriber: jmolloy. > jmolloy added a comment. > > Hi Akira, > > I'm sorry to be contrary (and I missed the discussion on Tuesday because I > was away on vacation) but I think there *is* a usecase for -mno-restrict-it >