[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta marked an inline comment as not done. furkanusta added a comment. That would be great, thanks Comment at: clang/test/CodeCompletion/overrides.cpp:41 +// Runs completion at empty line on line 13. +// RUN: %clang_cc1 -fsyntax-only -code-completion-patterns -code-compl

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 451604. furkanusta added a comment. - [clangd] D130363 (CodeCompletion/overrides.cpp) Move tests to bottom Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta added a comment. I've added a test case but I have a question. This is regardless of the current issue (i.e. no function context, clang++14 with no patches) struct X { virtual void foo(); }; struct Y : public X { over }; I am trying to complete override in class Y here, b

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 448694. furkanusta added a comment. - [clang] Add test case for D130363 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https://reviews.llvm.org/D130363 Files:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. furkanusta requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Fixes: https://github.com/clangd/clangd/issues/290 Repo

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta added a comment. I don't think I have a commit access this is my first contribution. I appreciate if you can do it for me. My mail address is: furkanust...@gmail.com I had my github account linked and expecting for my mail to get fetched automatically. To make things easier should

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta updated this revision to Diff 436369. furkanusta added a comment. [clang] Use correct visibility parameters when following a Using declaration Fixes https://github.com/clangd/clangd/issues/1137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta added a comment. I wasn't sure if I should add a URL to the commit message for easy access but here is the corresponding clangd issue: https://github.com/clangd/clangd/issues/1137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127629/new

[PATCH] D127629: [clang] Use correct visibility parameters when following a Using declaration

furkanusta created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. furkanusta requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes clangd issue #1137 Re