furkanusta marked an inline comment as not done.
furkanusta added a comment.
That would be great, thanks
================
Comment at: clang/test/CodeCompletion/overrides.cpp:41
+// Runs completion at empty line on line 13.
+// RUN: %clang_cc1 -fsyntax-only -code-completion-patterns
-code-completion-at=%s:13:1 %s -o - | FileCheck -check-prefix=CHECK-CC4 %s
+// CHECK-CC4: COMPLETION: Pattern : void vfunc(bool param) override{{$}}
----------------
kadircet wrote:
> no need for `-code-completion-patterns`. can you also move the new test case
> below (after `CHECK-CC3-NOT`) that way we get to keep the line numbers for
> old tests the same.
I put the test in between because anything after vf on line 14 gives an error.
error: unknown type name 'vf'
vf
^
It still outputs the correct completions but since the return code is non-zero,
FileCheck fails
================
Comment at: clang/test/CodeCompletion/overrides.cpp:41
+// Runs completion at empty line on line 13.
+// RUN: %clang_cc1 -fsyntax-only -code-completion-patterns
-code-completion-at=%s:13:1 %s -o - | FileCheck -check-prefix=CHECK-CC4 %s
+// CHECK-CC4: COMPLETION: Pattern : void vfunc(bool param) override{{$}}
----------------
furkanusta wrote:
> kadircet wrote:
> > no need for `-code-completion-patterns`. can you also move the new test
> > case below (after `CHECK-CC3-NOT`) that way we get to keep the line numbers
> > for old tests the same.
> I put the test in between because anything after vf on line 14 gives an
> error.
>
> error: unknown type name 'vf'
> vf
> ^
>
> It still outputs the correct completions but since the return code is
> non-zero, FileCheck fails
I've found from one of the others tests it is possible to invert the return
code from clang.
This way I was able to move the newly added test to bottom.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130363/new/
https://reviews.llvm.org/D130363
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
