[PATCH] D150758: [AIX] make integrated-as as default on AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG533af6e5c4b3: [AIX] make integrated-as as default on AIX. (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 534884. Esme added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h clang/test/Driver/aix-as.c clang/tes

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme added inline comments. Comment at: clang/test/Driver/aix-integrated-as.c:9 +// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj" +// CHECK-IAS32: "aix-integrated-as.o" + DiggerLin wrote: > both -fno-integrated-as and -fintegrated-as output t

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 526545. Esme added a comment. Remove unnecessary check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h clang/test/Dri

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 524641. Esme added a comment. Separate the backend changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme created this revision. Esme added reviewers: shchenz, DiggerLin, hubert.reinterpretcast, PowerPC. Herald added a subscriber: hiraditya. Herald added a project: All. Esme requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clan

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated-as mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4054c68644df: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated… (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

Esme updated this revision to Diff 521229. Esme added a comment. Herald added a subscriber: nemanjai. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150181/new/ https://reviews.llvm.org/D150181 Files: clang/lib/Driver/ToolChain

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

Esme created this revision. Esme added reviewers: shchenz, lkail, PowerPC, DiggerLin. Herald added a subscriber: hiraditya. Herald added a project: All. Esme requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. DWARF32

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

Esme added a comment. Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. +

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18f087c21cdb: [DebugInfo][Clang] record the access flag for class/struct/union types. (authored by Esme). Repository: rG LLVM Github Monorepo CHA

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3195171 , @dblaikie wrote: > Ah, cool - could you include % growth on those rows Thanks, I edited the table in the previous comment. > (hmm, .debug_line and .debug_str shouldn't be changing in size with this > change, r

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3192840 , @dblaikie wrote: > Thanks for the data - looks good to me. Maybe include some of that data > (summary of total binary size change/total debug info size change - and if > you could include the flags (was this an

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3188302 , @dblaikie wrote: > Got any data on how much this (combined with the LLVM patch) increases debug > info size of, say, a clang self-host build? I assume not much, but wouldn't > hurt to know. Before: $ size c

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: dblaikie wrote: > shchenz wrote: > > Will we generate a redundant flag if we define a private type in the class > > or a public type in the struct/union?

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393805. Esme added a comment. Add a case to show that the default access flag is not recorded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/ https://reviews.llvm.org/D115503 Files: clang/lib/CodeGen

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393789. Esme retitled this revision from "[DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types." to "[DebugInfo][Clang] record the access flag for class/struct/union types.". Esme added a comment. Thanks! @dblaikie Separate into Clang pa

[PATCH] D115503: [DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types.

Esme created this revision. Esme added reviewers: shchenz, probinson, dblaikie, jhenderson, aprantl, PowerPC. Herald added a subscriber: hiraditya. Esme requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch emits DW_