[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I think this should work-around end-to-end test failure on Windows: diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test index 1197e1ab07c3..68ef54808f09 100644 --- a/clang-tools-extra/clangd/test/crash.test +++ b/clang-

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. Are there any blockers to landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked an inline comment as done. 0x1eaf added a comment. I don't have commit access, so would appreciate if you commit it, thanks! Forgot to mention on Friday: I've instrumented preamble building, but haven't instrumented background indexing which is outside of `TUScheduler.cpp` and wou

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 379124. 0x1eaf added a comment. Updated the AST worker crash handler to avoid `std::string` copy: used a char pointer instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked 9 inline comments as done. 0x1eaf added a comment. I've opted for simulating signals in the unit test on Windows by manually calling the signal handler, and added a list test to test the crash handling integration end-to-end. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 378257. 0x1eaf added a comment. Addressed feedback from the last round of comments. Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status: FAIL: Clangd :: crash.test (1049 of 1049) TEST 'Clangd :: crash.test' FAILED S

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 372515. 0x1eaf retitled this revision from "[RFC] Print current request context along with the stack trance in clangd" to "[clangd] Print current request context along with the stack trace". 0x1eaf edited the summary of this revision. 0x1eaf added a comment.

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf updated this revision to Diff 372510. 0x1eaf added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang-tools-extra/clangd/JSONTransport.cpp clang-t

[PATCH] D109772: [clangd] Print current request context along with the stack trace

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf added inline comments. Comment at: clang-tools-extra/clangd/support/ThreadSignalHandler.cpp:22 + ThreadSignalHandlerCallback *Callback = CurrentCallback.get(); + // TODO: ignore non thread local signals like SIGTERM + if (Callback) { sammcca

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf added a comment. Thank you for such a prompt and thorough review! Please consider all the comments I haven't replied to acknowledged and I'm going to resolve the issues with the next update. Comment at: clang-tools-extra/clangd/JSONTransport.cpp:117 + OS << "S

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf added a comment. > Do you need me to commit on your behalf? Yes, I don't have commit access. The attribution line looks good to me. Thank you! 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93402/new/ https://reviews.llvm.org/D93402

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf updated this revision to Diff 312272. 0x1eaf added a comment. Updated to address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93402/new/ https://reviews.llvm.org/D93402 Files: clang-tools-extra/test/clang-tidy/checkers/

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf created this revision. 0x1eaf added reviewers: alexfh, njames93, aaron.ballman. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: lxfind, modocache, xazax.hun. 0x1eaf requested review of this revision. Herald added a subscriber: cfe-commits. We have an internal bug