0x1eaf marked an inline comment as done.
0x1eaf added a comment.

I don't have commit access, so would appreciate if you commit it, thanks!
Forgot to mention on Friday:

I've instrumented preamble building, but haven't instrumented background 
indexing which is outside of `TUScheduler.cpp` and would require exposing 
`crashDump*` helpers and preferably moving them out of `TUScheduler.cpp`. And I 
think it might be easier to review it separately. Speaking of the helpers, 
where would you prefer those to be: a new file+header under clangd/support, or 
in some existing place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109506/new/

https://reviews.llvm.org/D109506

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to