[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. In D157913#4648296 , @zequanwu wrote: > For some unknown reasons, linker still generates __llvm_prf_names section in > the final binary on mac even if the object file doesn't have this section. > And I cannot use llvm-objdump to g

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. In D157913#4646201 , @zequanwu wrote: > In D157913#4646184 , @ellis wrote: > >> It looks like `debug-info-corre

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. It looks like `debug-info-correlate-coverage.ll` was renamed twice. Is this intended? Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:276-277 __llvm_profile_get_num_counters(CountersBegin, CountersEnd); - const uint64_t NamesSize = Deb

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. In D157913#4638845 , @zequanwu wrote: > In D157913#4638569 , @phosek wrote: > >> In D157913#4626007 , @zequanwu >> wrote: >> It seems that the

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. In D157913#4626007 , @zequanwu wrote: >> It seems that the `__llvm_prf_names` is retained in this mode. What is the >> overhead of this section generally? Can we instead use debug info to lookup >> function names? > > With debug i

[PATCH] D154014: [SpecialCaseList] Add option to use Globs instead of Regex to match patterns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8eb34700c2b1: [SpecialCaseList] Add option to use Globs instead of Regex to match patterns (authored by ellis). Repository: rG LLVM Github Monorep

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. Thanks for working on this! I've added a few other reviewers that might be interested. In particular it might conflict with the stack D138846 IIRC It seems that the `__llvm_prf_names` is retained in this mode. What is the overhead of thi

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 554089. ellis added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. Thanks for adding the test case! Can you also link the original diff in the summary? Comment at: compiler-rt/test/profile/instrprof-merge-empty-data.test:1 +// Test +// RUN:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: > aeuban

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e11d6850a5a: Improve reliability of CompilationDatabaseTest (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c:24 + +// RUN: rm -rf %t.profdir && mkdir %t.profdir + Let's move this line down since we don't use it until line 31. Comment at: compiler-

[PATCH] D157904: Improve reliability of CompilationDatabaseTest

ellis created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. ellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157904 Files: clang/un

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. In D157632#4580576 , @zequanwu wrote: > BTW, I noticed something strange with `-pgo-function-entry-coverage` when > merging via llvm-profdata. This is intentional. The two raw profiles individually store blocks as either covered

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. I've just published https://reviews.llvm.org/D157664, so you'll want to rebase ontop of it if it lands soon. I would also like to see some more tests added to `instrprof-merge-error.c` to make sure two different binaries can't merge profiles together with `--debug-info-co

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. Thanks for working on this! Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:103-104 COMPILER_RT_VISIBILITY int __llvm_profile_merge_from_buffer(const char *ProfileData, uint64_t ProfileSize) { __llvm_pr

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 548693. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 548349. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 542732. ellis added a comment. If `#!special-case-list-v2` is the first line in the special case list, then we will use globs to match patterns. Otherwise, we fall back to the original behavior of using regexes to match patterns. Once this feature is stable, a

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4462886 , @MaskRay wrote: > In D154014#4461076 , @rupprecht > wrote: > >> In D154014#4457883 , @MaskRay >> wrote: >> This is a bre

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 536003. ellis added a comment. Fix memory bug and add TODO about a regex/glob config. Lets wait for others to comment before I put work into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https:

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4461076 , @rupprecht wrote: > In D154014#4457883 , @MaskRay wrote: > >>> This is a breaking change since some SCLs might use .* or (abc|def) which >>> are supported regexes but n

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: MaskRay, phosek, vitalybuka, samsonov, hctim. ellis updated this revision to Diff 535560. ellis added a comment. ellis published this rev

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis abandoned this revision. ellis added a comment. Moved to https://reviews.llvm.org/D154014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152762/new/ https://reviews.llvm.org/D152762 ___ cfe-commits

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis planned changes to this revision. ellis added a comment. In D152762#4421630 , @phosek wrote: > This is unrelated to this change but related to the issue this change is > addressing. The use of regular expressions for special case list with the > s

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis created this revision. Herald added a project: All. ellis retitled this revision from "[clang][docs] Update Sanitizer docs and test" to "[clang][docs] Update SanitizerSpecialCaseList docs". ellis edited the summary of this revision. ellis added reviewers: vlad.tsyrklevich, MaskRay. ellis pub

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85af42df5dbb: [lld] add context-sensitive PGO options for MachO (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 527205. ellis added a comment. Fix paths in clang test to support windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/ https://reviews.llvm.org/D151589 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 526825. ellis marked 3 inline comments as not done. ellis added a comment. Rename test function to `foo` since `_start` is not a necessary symbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/ https://

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 526751. ellis marked 3 inline comments as done. ellis added a comment. Add test to check that `PGOInstrumentationGen`(`Use`) are run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/ https://reviews.llvm.

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis created this revision. Herald added subscribers: wlei, ormris, wenlei, steven_wu, hiraditya. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. ellis added reviewers: int3, tejohnson, xur. ellis updated this revision to Diff 526199. ellis added a comment. ellis edited

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

ellis added inline comments. Comment at: llvm/lib/ProfileData/InstrProfCorrelator.cpp:208 maybeSwap(CounterOffset), + maybeSwap(BitmaskOffset), maybeSwap(FunctionPtr), Since `BitmaskOffset` and `NumBitmaskBytes` are always zero, I would rather

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

This revision was automatically updated to reflect the committed changes. Closed by commit rG970e1ea01aa0: [clang] Fix crash with -funique-internal-linkage-names (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135926/new/ https://

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

ellis created this revision. Herald added a project: All. ellis added reviewers: tmsriram, hoy, dblaikie. ellis published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calling `getFunctionLinkage(CalleeInfo.getCalleeDecl())` will crash when the d

[PATCH] D131195: [InstrProf][attempt 2] Add new format for -fprofile-list=

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4c3c0f6463: [InstrProf][attempt 2] Add new format for -fprofile-list= (authored by ellis). Repository: rG LLVM Github

[PATCH] D131195: [InstrProf][attempt 2] Add new format for -fprofile-list=

ellis created this revision. Herald added a project: All. ellis added reviewers: phosek, davidxl, thakis. ellis published this revision for review. ellis added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/test/CodeGen/p

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis added a comment. In D130808#3700074 , @thakis wrote: > Reverted in 0eb7d86f5873ce897894339a3cc5bc69ca507bee > for now. Thanks for reverting. I'm looking into it. Repository:

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb692312ca432: [InstrProf] Add new format for -fprofile-list= (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130807: [InstrProf] Add the skipprofile attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12e78ff88105: [InstrProf] Add the skipprofile attribute (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D130807: [InstrProf] Add the skipprofile attribute

ellis updated this revision to Diff 449995. ellis added a comment. Rebase and update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130807/new/ https://reviews.llvm.org/D130807 Files: clang/lib/CodeGen/CodeGenFunction.h clang/lib/CodeGen/C

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis updated this revision to Diff 449994. ellis added a comment. Fix case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/ProfileList.h

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis updated this revision to Diff 449469. ellis added a comment. Rebase and rename `omitprofile` => `skipprofile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 Files: clang/docs/UsersManual.rst c

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis updated this revision to Diff 449463. ellis added a comment. Rename `omitprofile` => `skipprofile` since this seems slightly better to me. Of course I'm still open to more suggestions. Also, fix the `profile-function-groups.c` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis added a comment. In D130807#3688798 , @paulkirth wrote: > Do you expect the difference between `noprofile` and `omitprofile` to be > confusing to users? I can certainly see how users could be confused by what > the difference is between `noprofile

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

ellis created this revision. Herald added a project: All. ellis edited the summary of this revision. ellis added a reviewer: phosek. ellis edited the summary of this revision. ellis added a reviewer: davidxl. ellis published this revision for review. Herald added a project: clang. Herald added a su

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

ellis created this revision. Herald added subscribers: Enna1, wenlei, jdoerfert, hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: phosek, davidxl. ellis published this revision for review. Herald added projects: clang, LLVM. Herald added subs

[PATCH] D129594: [InstrProf] Add options to profile function groups

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf58684f2720: [InstrProf] Add options to profile function groups (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://revi

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis updated this revision to Diff 444327. ellis added a comment. Use `crc32` rather than `md5` to compute function hashes faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://reviews.llvm.org/D129594 Files: clang/docs/Clan

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2871 + if (NumGroups > 1) { +auto Group = llvm::MD5Hash(Fn->getName()) % NumGroups; +if (Group != getCodeGenOpts().ProfileSelectedFunctionGroup) ianlevesque wrote: > In D87953 I

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis created this revision. Herald added a subscriber: Enna1. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: ianlevesque, kyulee, MaskRay, phosek, wenlei, davidxl. Herald added a subscriber: StephenFan. ellis updated this revision to Diff 444091. ell

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis abandoned this revision. ellis added a comment. The function `__clang_call_terminate` seems to be a special case that clang builds itself. This diff might be too much for this rare specific case. Closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis planned changes to this revision. ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm:

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile);

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis created this revision. Herald added a project: All. ellis retitled this revision from "[instrprof] Allow compiler generated functions in SCL" to "[InstrProf] Allow compiler generated functions in SCL". ellis edited the summary of this revision. ellis added reviewers: kyulee, phosek. ellis pu

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

ellis added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void, !

[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

ellis added a comment. Herald added a subscriber: ormris. Herald added a project: All. Hi @tmsriram. I found a clang crash when using the flag `-funique-internal-linkage-names` that only happens after this diff. Would you mind taking a look? $ cat test.c inline void foo() {} extern void f

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:284-287 + FE = 0x1, // A frontend clang profile, incompatible with other attrs. + IR = 0x2, // An IR-level profile (default when -fprofile-generate is used). + BB = 0x4, // A profile with entry

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, I've been working on a new coverage instrumentation in D1

[PATCH] D116174: [clang] support relative roots to vfs overlays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f61749e16f6: [clang] support relative roots to vfs overlays (authored by rmaz, committed by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new

[PATCH] D116342: [clang][AST] Fix crash when printing error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe27b5f937138: [clang][AST] Fix crash when printing error (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D116342: [clang][AST] Fix crash when printing error

ellis created this revision. ellis added a reviewer: dblaikie. ellis published this revision for review. ellis added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/AST/TypePrinter.cpp:242 case Type::ObjCObjectPoi

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac719d7c9ae6: [InstrProf] Don't profile merge by default in lightweight mode (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

ellis updated this revision to Diff 395481. ellis added a comment. Expand warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115979/new/ https://reviews.llvm.org/D115979 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/lib/profi

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

ellis created this revision. Herald added a subscriber: ormris. ellis added reviewers: kyulee, MaskRay, alanphipps. ellis published this revision for review. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Profile merging is not supported when using deb

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58d9c1aec88d: [Try2][InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394982. ellis added a comment. Use `std::string` instead of `Twine` to pass around the default raw profile name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115693/new/ https://reviews.llvm.org/D115693 Files:

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis edited the summary of this revision. ellis added reviewers: kyulee, alanphipps, MaskRay, wenlei, davidxl. ellis updated this revision to Diff 394121. ellis added a comment. ellis published this revision for revi

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc809da7d9ce7: Revert "[InstrProf] Attach debug info to counters" (

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This reverts commit 800bf8ed29fbcaa9436540e83bc119ec92e7d40f

[PATCH] D114565: [InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG800bf8ed29fb: [InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394097. ellis added a comment. Rebase and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/include/profile

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392576. ellis added a comment. Fix MachO profile dumping code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392471. ellis added a comment. Add a proper warning and simplify compiler-rt profile writer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 391780. ellis added a comment. Add warning when debug info is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp comp

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961 + DB.finalize(); +} + } kyulee wrote: > I think when `-debug-info-correlate` is used without debug info, we should > fail or emit a warning here instead

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 390855. ellis added a comment. Emit metadata as `ConstantAsMetadata` instead of the more complicated `DIExpression`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Fi

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:273 - if (!DataSize) + if (!CountersSize) return 0; kyulee wrote: > Is it no diff change? I wonder if there is a case where `CountersSize` is 0 > but not `DataSize`

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis edited the summary of this revision. ellis added reviewers: MaskRay, alanphipps, wenlei, kyulee, davidxl. ellis edited the summary of this revision. ellis published this revision for review. Herald added project

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis updated this revision to Diff 388652. ellis added a comment. Remove register names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114268/new/ https://reviews.llvm.org/D114268 Files: clang/test/CodeGen/profile-filter.c clang/test/Profile/b

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis added a comment. In D114268#3143976 , @MaskRay wrote: >> Add names to pgo registers for clarity. > > This may increase memory usage, especially for large LTO applications. Unless > this is very helpful I might omit it. I'll omit it. Thanks for the

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

ellis created this revision. Herald added subscribers: wenlei, arphaman, hiraditya. ellis updated this revision to Diff 388564. ellis added a comment. ellis edited the summary of this revision. ellis added a reviewer: MaskRay. ellis retitled this revision from "[InstrProf] Use i32 for GEP index" to

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#3018935 , @krisb wrote: > @dblaikie yeah, the problem(s) seemed easier and smaller :( > > Basically, we have two issues with local scopes here: > (1) function-scoped entities like static variables, type > definitions/typ

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#2998350 , @krisb wrote: > But it seems imported declarations are broken not just for static locals, but > for all inlined entities, for example > > namespace ns { > inline __attribute__((always_inline)) > int foo()

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#2998350 , @krisb wrote: > In D109703#2998155 , @ellis wrote: > >> I've added this to the added test case. >> >> !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope:

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. Thanks for working on this! `getOrCreateGlobalVariableDIE()` is also called in `constructImportedEntityDIE()` which means that there could be some globals without DIE parents. In D108492 I've added this to the added test case. !18 = !

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis updated this revision to Diff 369496. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c clang/test/CodeG

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis added a comment. @aprantl @dblaikie Can I get a review soon to avoid merge conflicts on these tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 ___

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis added a comment. In D107024#2917202 , @aprantl wrote: > I think that looks fine — I wonder if we should change the IR pretty printer > to display empty arrays inline as `elements: !{}`, too. I think that's a good idea, but it would require changin

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis updated this revision to Diff 362637. ellis added a comment. Fix broken coro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c cl

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis updated this revision to Diff 362614. ellis added a comment. Remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis created this revision. ellis added a reviewer: aprantl. Herald added subscribers: dexonsmith, lxfind, hiraditya. ellis requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. It looks like this array was missed in 4276d4a8d0

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 355066. ellis added a comment. Add min instruction count frontend flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 353705. ellis added a comment. Correctly link the runtime symbol for Mach-O. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 352007. ellis added a comment. MIP does not support windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td clang/inclu

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 351604. ellis added a comment. Move llvm-strip logic into its own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D104088: Add clang frontend flags for MIP

ellis created this revision. Herald added subscribers: dang, phosek, mgorny, emaste. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. ellis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Her

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis updated this revision to Diff 295055. ellis added a subscriber: vsapsai. ellis added a comment. Herald added a reviewer: JDevlieghere. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix a comment to reference the correct method. Thanks to @vsapsai for pointing this o

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis added a comment. Yes please commit for me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

  1   2   >