ellis added inline comments.
================ Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961 + DB.finalize(); + } + } ---------------- kyulee wrote: > I think when `-debug-info-correlate` is used without debug info, we should > fail or emit a warning here instead of silently proceeding it because we > cannot correlate it anyhow down the road. I'll emit a warning. I don't want to fail in this case when a single function doesn't have debug info. Instead, I'm planning on adding a check in the frontend when parsing the `-fprofile-generate-correlate=debug-info` flag (which I will add later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
