[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. In D155775#4652773 , @AlexVlx wrote: > In D155775#4652767 , @dyung wrote: > >> Hi @AlexVlx, the test you added is failing on an linux bot, can you take a >> look and revert if you need time

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. In D155775#4652698 , @AlexVlx wrote: > https://reviews.llvm.org/rG0701ee69f7ac should fix it, once again apologies > for the noise. FYI, the test is still failing on the Windows PS5 bot after your change: https://lab.llvm.org/bui

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

dyung added a comment. Hi @AlexVlx, the test you added is failing on an linux bot, can you take a look and revert if you need time to investigate? It appears it has been failing for over 6 hours. https://lab.llvm.org/buildbot/#/builders/139/builds/50940 Repository: rG LLVM Github Monorepo

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. In D147655#4650663 , @rjmccall wrote: > I've been informed that Apple's change to the default ABI compatibility mode > is in our private fork, so this is not your problem; sorry for the noise. > > I'm not sure why we decided to do

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

dyung added a comment. Hi @sammccall, your change seems to be causing a test failure on several bots, can you take a look and revert if you need time to investigate? TEST 'Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/8/35' FAILED ***

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. Hi @rsmith, we have an internal test where your change seems to have changed the mangling in C++17 mode and wanted to check if that was intentional. Consider the following code: // Literals in templates #include template T returnit() {return I;}; enum colour { R

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

dyung added a comment. Sorry to comment so late, but I just had time to look into this a little bit. This change broke running lit tests for me on Windows, and I wanted to see if there was a way I could restore it. For reference, my sources are stored locally at `C:\Dev\git\dev`, but I until t

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

dyung added a comment. Hi @leonardchan your change was still causing a failure on the PS4 linux bot, so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 . I noticed earlier that the failing test omit-rtti-component-wi

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

dyung added a comment. Hi @serge-sans-paille, the test you added seems to be failing on some bots. Can you take a look and revert if you need time to investigate? - https://lab.llvm.org/buildbot/#/builders/139/builds/48265 - https://lab.llvm.org/buildbot/#/builders/216/builds/26208 Repository:

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

dyung added a comment. In D158227#4610097 , @Manna wrote: > The failure seems unrelated to my change. Hi @Manna, I'm not sure which failure you are referring to, but there is a test failure on at least 2 build bots that seems to have been caused by your

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

dyung added a comment. In D92797#4596289 , @ronlieb wrote: > hi, this seems to be breaking out amdgpu opemp and hip buildbots > https://lab.llvm.org/staging/#/builders/247/builds/4967 And also some GCC based bots: https://lab.llvm.org/buildbot/#/builders/

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

dyung added a comment. Hi @serge-sans-paille, your change is causing the test you modified, `clang/test/AST/ast-dump-attr-json.cpp` to fail. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/47461 https://lab.llvm.org/buildbot/#/builders/109/builds/71264 Repository: rG

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157467/new/ https://reviews.llvm.org/D157467 ___ c

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

dyung added a comment. The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. Is the test missing a `REQUIRES: riscv-registered-target` line by any chance? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4546171 , @dyung wrote: > In D156363#4545474 , @MaskRay wrote: > >> In D156363#4545215 , @dyung wrote: >> >>> If you cannot reproduce thi

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4545474 , @MaskRay wrote: > In D156363#4545215 , @dyung wrote: > >> If you cannot reproduce this issue, I can take my buildbot offline and try >> to reproduce it to pinpoint whic

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. If you cannot reproduce this issue, I can take my buildbot offline and try to reproduce it to pinpoint which command is causing the problem, but I won’t be able to do so until Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4544803 , @aaron.ballman wrote: > In D156363#4544782 , @thakis wrote: > >> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this >> something on my end? > >

[PATCH] D156127: Partially revert changes to test lang-std.cpp

dyung added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 +// UNSUPPORTED: target={{.*-(ps4|ps5)}} /// Test default standards. This should be unneeded now, we recently updated the PS platforms to default to c++17 like the rest of the compi

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

dyung added a comment. Hi @yaxunl, your change appears to have broken the LLDB build. Can you take a look and revert if you time to investigate? https://lab.llvm.org/buildbot/#/builders/243/builds/9581 FAILED: tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.di

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

dyung added a comment. @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 Windows build bots. Can you take a look and fix or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/43856 https://lab.llvm.org/buildbot/#/builders/216/buil

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

dyung added a comment. If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add a negative for that? Or if we do a positive test for it as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 _

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

dyung added inline comments. Comment at: clang/docs/ReleaseNotes.rst:290 + number of code lines it prints has been increased from 1 to 16. This + can be controlled using ``-fcaret-diagnostics-max-lines=``. Is this correct? I notice that all of the tests you u

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

dyung added a comment. In D141627#4374757 , @tianshilei1992 wrote: > In D141627#4374753 , @Northbadge > wrote: > >> FYI this is failing- >> https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. @t-rasmud I am sorry, but I had to revert your change, it is randomly failing on the Windows bots causing a lot of instability. See the revert commit message for examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145739

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. In D145739#4370674 , @barannikov88 wrote: > Hi, just a heads-up, some bots seem to be unhappy with the test: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21765 > > error: 'note' diagnostics expected but not seen: >

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

dyung added a comment. Hi @owenpan and @Sedeniono, this change is causing test failures across many bots, can you take a look and fix or revert if you need time to investigate? Failing bots: - https://lab.llvm.org/buildbot/#/builders/139/builds/41339 - https://lab.llvm.org/buildbot/#/builders/2

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

dyung added a comment. Hi @HerrCai0907, this change is failing on the PS4 linux and PS5 Windows bot. Can you take a look? I'm guessing these failures are likely due to the PS4/PS5 target defaulting to a different C/C++ standard than the rest of clang. https://lab.llvm.org/buildbot/#/builders/13

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

dyung added a comment. I'm not really sure where else to post this, but the pre-merge linux bot still seems to be running 3.18.4. https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

dyung added inline comments. Comment at: clang/test/Driver/ftime-trace.cpp:54 +// RUN: %clang -### -ftime-trace=e -ftime-trace-granularity=0 d/a.cpp d/b.c -o f/x -dumpdir f/ 2>&1 | FileCheck %s --check-prefix=LINK3 +// LINK3: -cc1{{.*}} "-ftime-trace=e/a-{{[^.]*}}.json" "-ftime

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dyung added a comment. Hi @MaskRay, the test you modified clang/test/Driver/split-debug.c is failing on the PS5 Windows bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/20981 # command stderr: Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Driver\split-

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149655/new/ https://reviews.llvm.org/D149655 ___ c

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

dyung added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10: >

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

dyung added inline comments. Comment at: llvm/test/MC/ELF/debug-prefix-map.s:54 + +# MAPABS_V5_A:DW_AT_comp_dir [DW_FORM_string] ("{{(/|\\)+}}src_root/bar") +# MAPABS_V5_A:DW_AT_decl_file [DW_FORM_data4] ("/src_root{{(/|\\)+}}bar{{(/|\\)+}}src.s") This m

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

dyung added a comment. @MaskRay , a test you modified, debug-prefix-map.s is failing on the PS5 Windows bot. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/20460 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4289752 , @argentite wrote: > I made patch with both precompiled library and without cstdio. D148992 > > > @dyung We can also enable this now on PS4/5 if you are interested. Sure. Plea

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. This change is also causing 33 test failures on a build bot https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 __

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. Is there a reason a test was not added with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe

[PATCH] D148112: [include-cleaner] Improve handling for templates

dyung added a comment. @kadircet, your change is causing 3 test failures on Windows bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/19740 https://lab.llvm.org/buildbot/#/builders/123/builds/18332 Repository: rG LLVM Gi

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4231374 , @probinson wrote: > In D141824#4231372 , @probinson > wrote: > >> In D141824#4229953 , @argentite >> wrote: >> >>> Just to co

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. In D141824#4229693 , @argentite wrote: > Hi, @dyung ! It seems the dynamic library generation is failing from the lack > of a linker. We need a test library to load at runtime in clang-repl. Do you > have any idea how we can creat

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

dyung added a comment. Hi @argentite, the test you added is failing on the PS4 linux builder because the test seems to require linking and the PS4 target requires an external linker which is not present on the system. Can the test be rewritten to not require linking? https://lab.llvm.org/build

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203525 , @dyung wrote: > In D143436#4203394 , > @DmitryPolukhin wrote: > >> @dyung I cannot reproduce this issue on two different machines in both cases >> tests work fine. For

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203394 , @DmitryPolukhin wrote: > @dyung I cannot reproduce this issue on two different machines in both cases > tests work fine. For clang and llvm-jitlink binaries (the only binaries used > in the tests) my changes

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/247/builds/2639 TES

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. In D145770#4195018 , @dyung wrote: > @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, > can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/37475 > > I don't know if it matters,

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/37475 I don't know if it matters, but this bot only builds the x86_64 target. Repository: rG LLVM Github Monorepo CH

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

dyung added a comment. I'm still seeing random crashes today on a linux buildbot in the test you added P1689 .cppm. Can you either fix or revert? - https://lab.llvm.org/buildbot/#/builders/139/builds/35899 - https://lab.llvm.org/buildbot/#/builders/139/builds/3588

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

dyung added a comment. @joshua-arch1 and @hiraditya this change is causing a test failure on many bots. Can you take a look and revert if you need time to investigate? Failing bots: - https://lab.llvm.org/buildbot/#/builders/183/builds/10688 - https://lab.llvm.org/buildbot/#/builders/249/builds

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

dyung added a comment. In D91000#4099744 , @whisperity wrote: > In D91000#4099669 , @dyung wrote: > >> -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 >> >> Hopefully this can help you to reproduce the problem. > > A

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

dyung added a comment. In D91000#4099657 , @whisperity wrote: > Ping @dyung, it looks like you're the owner of the relevant build-bot. I > can't find any information what `x86_64-sie` is... > > Meanwhile, it seems my attempt at fix is not actually fixing

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

dyung added a comment. Hi @hctim, the test you added is failing on buildbots where AArch64 is not built, can you either update the test to not require that backend, or mark the test as requiring it? https://lab.llvm.org/buildbot/#/builders/139/builds/35253 error: unable to create target: 'No

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

dyung added a comment. Hi @eopXD this change seems to be causing builds on Windows to time out for some reason. Can you take a look? - https://lab.llvm.org/buildbot/#/builders/83/builds/28484 - https://lab.llvm.org/buildbot/#/builders/172/builds/22803 - https://lab.llvm.org/buildbot/#/builders/2

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

dyung added a comment. In D142046#4071594 , @yonghong-song wrote: > @dyung I just pushed the fix to the 'main' branch > (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b). > Please check it out. Thanks for reporting!

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

dyung added a comment. Hi, our internal release build buildbot seems to have issues with this test. It seems you are expected the following function declaration in the emitted IR: define dso_local void @_Z5test1PKc(ptr noundef %msg) #0 !dbg !19 { But in a release build, it becomes: define

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

dyung added a comment. @serge-sans-paille Your change is causing 24 test failures on the Linux PS4 bot, mostly with an assertion failure it seems. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/32263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

dyung added a comment. @serge-sans-paille, one of our internal tests hit an assertion failure which I bisected back to your change. I have filed issue 59321 with a repro. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

dyung added a comment. @vsapsai I reverted your change because it was causing the test ClangScanDeps/no-werror.cpp to fail on the PS4/PS5 linux/Windows bots: - https://lab.llvm.org/buildbot/#/builders/139/builds/31784 - https://lab.llvm.org/buildbot/#/builders/216/builds/13476 Repository: rG

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. In D137885#3947532 , @dyung wrote: > @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. > Most of the errors look similar to this: > > error: 'error' diagnostics seen but not expected: > (frontend):

[PATCH] D137885: [modules] Support zstd in .pcm file

dyung added a comment. @MaskRay your change seems to be causing 1509 failures on the linux PS4 bot. Most of the errors look similar to this: error: 'error' diagnostics seen but not expected: (frontend): malformed or corrupted AST file: 'LLVM was not built with LLVM_ENABLE_ZSTD or did not

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

dyung added a comment. Hi @lebedev.ri, we recently noticed a failure in one of our internal tests which I bisected back to your change. I have filed the details in Issue #59122 . Can you take a look? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

dyung accepted this revision. dyung added a comment. I'm not really familiar with this code, so I'll leave others to review the actual change, but I can confirm that when I built a compiler with this change and ran it against the failing tests they all now pass. So in that regard, LGTM. Reposi

[PATCH] D136022: [clang] Add time profile for constant evaluation

dyung added a comment. Hi @Izaron, several of our internal tests that run tests using `-ftime-trace` started crashing when run which I bisected back to your change. I have filed issue #58551 for it, can you take a look? Repository: rG LLVM

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

dyung added a comment. Thanks, this is necessary because the Playstation platforms default to C++14, not C++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/ https://reviews.llvm.org/D135486 ___

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768352 , @steven_wu wrote: > In D131469#3768308 , @dongjunduo > wrote: > >> In D131469#3768288 , @dyung wrote: >> >>> In D131469#376828

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768283 , @dongjunduo wrote: > In D131469#3768282 , @dyung wrote: > >> In D131469#3768274 , @dongjunduo >> wrote: >> >>> In D131469#376

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768274 , @dongjunduo wrote: > In D131469#3768260 , @dyung wrote: > >> The test you added is failing on the PS4 linux bot because the PS4 platform >> requires an external linker

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test? Repository: rG LLVM Github Mono

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

dyung added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

dyung added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

dyung added a comment. In D128830#3751368 , @dyung wrote: > We also saw this assert on our Windows build, and it also can be reproduced > in Linux: > > $ cat test2.c > static char *getenv(char *) {} > void foo() { getenv(""); } > $ ~/src/upstream

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

dyung added a comment. We also saw this assert on our Windows build, and it also can be reproduced in Linux: $ cat test2.c static char *getenv(char *) {} void foo() { getenv(""); } $ ~/src/upstream/879f5118fc74657e4a5c4eff6810098e1eed75ac-linux/bin/clang -c -O3 test2.c

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. We are seeing an additional failure on an internal linux bot due to the change to using C++17 by default when using GNU ld: [3/7] Generating GwpAsan-x86_64-Test FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test cd /home/jenkins/j/w/workspace/opens

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. Your change is causing a build failure on the PS4 linux build bot using GCC 9.3. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/26186 FAILED: tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCh

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689918 , @sunho wrote: > In D130788#3689820 , @dyung wrote: > >> In D130788#3689795 , @sunho wrote: >> >>> The test isn't supposed to be

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689795 , @sunho wrote: > The test isn't supposed to be ran on windows -- we don't support exception on > windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working > out. If you don't want the test ru

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. The test simple-exception.cpp is failing on the PS5 Windows bot after this change. Can you take a look? I forced a build using the commit prior to yours which passed: https://lab.llvm.org/buildbot/#/builders/216/builds/7636 And then I forced a build using your commit, and

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

dyung added a comment. Hi @sammccall, your change seems to be causing a build failure on the PS4 linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/25678 FAILED: tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o CCACHE_CPP2=yes

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

dyung added a comment. This change is causing a build failure on the Windows PS4 bot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/7026 FAILED: tools/clang/lib/Analysis/FlowSensitive/CMakeFiles/obj.clangAnalysisFlo

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

dyung added a comment. Hi @masoud.ataei, the test you added in this commit is failing on the PS4 bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/24469 clang (LLVM option parsing): Unknown command line argument '-enable-ppc-gen-scalar-mass'. Try: 'clang (LLVM op

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

dyung added a comment. @mboehme, one of our internal tests started to fail to compile after this change due to the compiler no longer accepting what I think should be a valid attribute declaration. I have filed issue #56077 for the problem, can you take a look? Repository: rG LLVM Github Mo

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. I tried it on Windows building with both ninja and Visual Studio and both seem to work after your change. LGTM. Thanks for looking into this! Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

dyung added a comment. In D126308#3582337 , @mizvekov wrote: > In D126308#3581240 , @dyung wrote: > >> Can you take a look? > > Hi @dyung , thanks for the report and sorry for the trouble! > Can you help me try to

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

dyung added a comment. Hi @mizvekov, this change seems to have broken the location of the hmaptool when using the Visual Studio builder on Windows. After your commit, 7 clang tests fail because hmaptool cannot be found at the expected location. For example, the test clang/test/Preprocessor/head

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

dyung added a comment. Just another data point, but we noticed the same issue of clang++ missing after install on our internal Windows builds, and I bisected it to this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://revi

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

dyung added a comment. In D126651#3574290 , @johannes wrote: > No idea why the conversion fails for the wide string. > First step is to reproduce the problem. I guess we should try in a Ubuntu VM. > Is there an easy way to see if other builders succeeded?

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

dyung added a comment. Hi, the test you modified in your change seems to be failing on the PS4 linux build bot at https://lab.llvm.org/buildbot/#/builders/139/builds/22964. TEST 'Clang :: Tooling/clang-diff-ast.cpp' FAILED Script: -- : 'RUN: at

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

dyung added a comment. In D120201#3547835 , @abrachet wrote: > In D120201#3547834 , @dyung wrote: > >> The test you added seems to be failing on the PS4 Windows bot. A quick >> glance seems to suggest that you ar

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

dyung added a comment. The test you added seems to be failing on the PS4 Windows bot. A quick glance seems to suggest that you aren't properly escaping the path separators somewhere. Can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/bui

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

dyung added a comment. Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and Window buildbots, can you take a look, and revert if it might take a while to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/21573 https://lab.llvm.org/buildbot/#/builders/216/

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

dyung added a comment. I think the problem here is that if zlib is not available, you won't get the clang command line you expect: https://lab.llvm.org/buildbot/#/builders/216/builds/3519 Input was: << 1: clang version 15.0.0 (https://github.com/llvm/llvm-project.git 2d

[PATCH] D121556: [randstruct] Add randomize structure layout support

dyung added a comment. Hi, the test you added is failing on the PS4 Windows bot https://lab.llvm.org/buildbot/#/builders/216/builds/2647. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

dyung added a comment. Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/2452 Repository: rG LLVM Github Monore

[PATCH] D122611: [clang][extract-api] Add support for macros

dyung added a comment. This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/19441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

dyung added a comment. I've reverted this change in order to get the build bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mai

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

dyung added a comment. This change seems to be causing many bots to fail when running the clang :: Preprocessor/init.c test, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/18081 https://lab.llvm.org/buildbot/#/builders/216/builds/881 https://lab.llvm.org/buildbot/#/buil

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. Thanks for fixing the problem with the original commit, but in the future, if you make follow-up commits, can you change the commit message to reflect what the commit contains? Having three different commits with the exact same commit message can be very confusing. Repo

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

dyung added a comment. And the PS4 build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/18001 https://lab.llvm.org/buildbot/#/builders/216/builds/801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D12

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. If it helps, this is the cmake command I am using to build using gcc on linux: CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose -j80 --no-progress-bar --max-tests 10"

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. In D120254#3342570 , @svenvh wrote: > In D120254#3342551 , @dyung wrote: > >> Hi, our internal release build bots are showing failures in two clang-tidy >> tests that I bisected back to you

  1   2   3   >