[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2017-02-15 Thread Dmitry Borisenkov via Phabricator via cfe-commits
dmitry updated this revision to Diff 88529. dmitry added a comment. Byval attribute was added for ndrange in enqueue kernel call. https://reviews.llvm.org/D28058 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/Type.h include/clang/Serialization

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2017-01-13 Thread Dmitry Borisenkov via Phabricator via cfe-commits
dmitry added a comment. @yaxunl, we already have the similar issue for atomics. Probably we can extend typedef semantic checks but I don't think it's a good idea since C and C++ have the similar problem but they don't provide special treatment for types from their standard libraries. I think th

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2017-01-11 Thread Dmitry Borisenkov via Phabricator via cfe-commits
dmitry added a comment. Ping! https://reviews.llvm.org/D28058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2016-12-22 Thread Dmitry Borisenkov via Phabricator via cfe-commits
dmitry created this revision. dmitry added a reviewer: yaxunl. dmitry added subscribers: Anastasia, cfe-commits. Since we don't have an ideal option for ndrange_t implementation (which was discussed there: https://reviews.llvm.org/D23086), I propose to stick with identification by name approach