dschuff wrote:
Thanks for working on this!
This will be the first time I'm not going to oppose an effort to remove Native
Client support 🎉
Although I am going to ask you to wait a couple of months to land it, until we
finally turn it off for good and start deleting the support code from Chromi
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/130220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/129020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5150,9 +5150,14 @@
WebAssemblyCXXABI::emitTerminateForUnexpectedException(CodeGenFunction &CGF,
// Itanium ABI calls __clang_call_terminate(), which __cxa_begin_catch() on
// the violating exception to mark it handled, but it is currently hard to do
// with wasm EH i
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fexceptions
-fcxx-exceptions -emit-llvm -o - -std=c++11 2>&1 | FileCheck %s
dschuff wrote:
should this triple be wasm32-unknown-emscripten? Or do we use em-exceptions by
default on all wasm
@@ -5150,9 +5150,14 @@
WebAssemblyCXXABI::emitTerminateForUnexpectedException(CodeGenFunction &CGF,
// Itanium ABI calls __clang_call_terminate(), which __cxa_begin_catch() on
// the violating exception to mark it handled, but it is currently hard to do
// with wasm EH i
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/128105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/127939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown -fexceptions
-fcxx-exceptions -target-feature +reference-types -target-feature
+exception-handling -target-feature +multivalue -exception-model=wasm
-emit-llvm -o - %s | FileCheck %s
+
+// Check if __builtin_wa
https://github.com/dschuff approved this pull request.
Do you need me to commit?
https://github.com/llvm/llvm-project/pull/124365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo
&CLI,
}
}
}
+
+// If outgoing arguments are passed via the stack, we cannot tail call
+for (const ISD::OutputArg &Out : CLI.Outs) {
dschuff wrote:
Aha, i ju
@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo
&CLI,
}
}
}
+
+// If outgoing arguments are passed via the stack, we cannot tail call
+for (const ISD::OutputArg &Out : CLI.Outs) {
dschuff wrote:
This is a
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/124374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/124042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/122526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/122466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
LGTM for updating the LLVM datalayout string to match clang's, I don't think
this should affect clang's ABI at all.
https://github.com/llvm/llvm-project/pull/119204
___
cfe-commits mailing list
cf
@@ -524,9 +524,7 @@ define i64 @utest_f64i64(double %x) {
; CHECK-NEXT:local.get 0
; CHECK-NEXT:call __fixunsdfti
; CHECK-NEXT:local.get 1
-; CHECK-NEXT:i32.const 8
-; CHECK-NEXT:i32.add
-; CHECK-NEXT:i64.load 0
+; CHECK-NEXT:i64.load 8
-
dschuff wrote:
LGTM too; I just noticed that nowhere does the tool-conventions document
mention that "lime" is short for "linear memory" and that the intention is that
this is the subset of features useful to toolchains or runtimes that focus on
linear memory. Maybe we should add that.
https
https://github.com/dschuff approved this pull request.
I think Emscripten is ready for this now, thanks for working on this!
https://github.com/llvm/llvm-project/pull/112049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
@@ -1,4 +1,4 @@
-; RUN: llc -filetype=obj %s -o %t.o
+; RUN: llc -filetype=obj -mattr=-bulk-memory %s -o %t.o
dschuff wrote:
Hm, interesting, so we are using passive segments anytime bulk memory is
enabled. That makes sense since this was all meant for threads,
@@ -177,8 +177,9 @@ class MergeInputChunk : public InputChunk {
inputSectionOffset = seg.SectionOffset;
}
- MergeInputChunk(const WasmSection &s, ObjFile *f)
dschuff wrote:
the lld changes look reasonable but /cc @sbc100 just to make sure
https://gith
@@ -584,7 +584,7 @@ void llvm_reset_counters(void) {
}
}
-#if !defined(_WIN32)
+#if !defined(_WIN32) && !defined(__wasi__)
dschuff wrote:
This probably makes sense to make `__wasm__` instead of just `__wasi__` since
Emscripten also lacks fork.
https://git
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/108116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1888,18 +1888,15 @@ static __inline__ v128_t __FP16_FN_ATTRS
wasm_f16x8_splat(float __a) {
return (v128_t)__builtin_wasm_splat_f16x8(__a);
}
-static __inline__ float __FP16_FN_ATTRS wasm_f16x8_extract_lane(v128_t __a,
-
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/105434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff wrote:
I'm fine with calling this feature fp16 (I like it better than half-precision
anyway) but I also wanted to point out that consistency with the spec is
probably more important in the long term than consistency with V8, because the
V8 flags eventually disappear (once V8 enabled su
https://github.com/dschuff approved this pull request.
otherwise LGTM
https://github.com/llvm/llvm-project/pull/99388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -702,6 +702,19 @@ defm "" : ReplaceLane;
defm "" : ReplaceLane;
defm "" : ReplaceLane;
+// For now use an instrinsic for f16x8.replace_lane instead of ReplaceLane
above
+// since LL generated with half type arguments is not well supported and
creates
dsch
@@ -842,8 +842,8 @@ class LLVM_LIBRARY_VISIBILITY NaClTargetInfo : public
OSTargetInfo {
} else if (Triple.getArch() == llvm::Triple::mipsel) {
// Handled on mips' setDataLayout.
} else {
- assert(Triple.getArch() == llvm::Triple::le32);
- this->resetDa
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/95151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff closed
https://github.com/llvm/llvm-project/pull/93272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/93272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/93261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string &Name) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
dschuff wr
https://github.com/dschuff edited
https://github.com/llvm/llvm-project/pull/92192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
These changes make sense from the wasm point of view, and it looks like you've
address the comment, so LGTM
https://github.com/llvm/llvm-project/pull/92192
___
cfe-commits mailing list
cfe-commits
https://github.com/dschuff approved this pull request.
LGTM too, I don't see a huge risk of breaking external users using the old
define at this point, and as noted we can fix the library usage without
breaking anything either.
https://github.com/llvm/llvm-project/pull/92604
__
@@ -192,6 +192,7 @@
TARGET_BUILTIN(__builtin_wasm_relaxed_dot_bf16x8_add_f32_f32x4, "V4fV8UsV8UsV4f"
// Half-Precision (fp16)
TARGET_BUILTIN(__builtin_wasm_loadf16_f32, "fh*", "nU", "half-precision")
+TARGET_BUILTIN(__builtin_wasm_storef16_f32, "vfh*", "nU", "half-precision")
https://github.com/dschuff approved this pull request.
LGTM.
Are we currently running wasm-eh tests on the Chromium CI with node 16? If so,
I guess this will have the same issue we had when we tried to turn it on by
default.
I don't think this needs to be a showstopper in the same way (since th
https://github.com/dschuff approved this pull request.
Overall this looks good, and I think it makes sense to model this as short* for
now. I think it will be interesting to see if that ends up causing issues. Out
of curiosity does this work if you try `_fp16`?
https://github.com/llvm/llvm-pro
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/90875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff wrote:
This makes sense to me, I think it was the original intention (although I don't
recall it being important to us or anyone else I'm aware of).
https://github.com/llvm/llvm-project/pull/90875
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/90792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff wrote:
We are also seeing the Windows failure. Given that there appear to be 2
separate problems, this patch should probably be reverted rather than trying to
fix-forward.
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits mailin
https://github.com/dschuff approved this pull request.
(also LGTM FTR)
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff edited
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -147,19 +147,25 @@ void
WebAssemblyTargetInfo::setFeatureEnabled(llvm::StringMap &Features,
bool WebAssemblyTargetInfo::initFeatureMap(
llvm::StringMap &Features, DiagnosticsEngine &Diags, StringRef CPU,
const std::vector &FeaturesVec) const {
- if (CPU == "bleedin
dschuff wrote:
I think "generic" is the default CPU so object files will have it enabled by
default. You can still specify "mvp" as the CPU as before to avoid it.
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits
dschuff wrote:
I am getting one local test failure here, in `/test/CodeGen/BPF/undef.ll`:
The test has a bunch of
[stores](https://github.com/llvm/llvm-project/blob/cdd9221489ec4ed6afc0e5146c2fae4daa8ab260/llvm/test/CodeGen/BPF/undef.ll#L44-L54)
into an alloca, which i think are supposed to get
https://github.com/dschuff updated
https://github.com/llvm/llvm-project/pull/80184
>From 8fce40a38370f92926f1dabbc00c29e2d48b46e7 Mon Sep 17 00:00:00 2001
From: Derek Schuff
Date: Tue, 30 Jan 2024 17:39:00 -0800
Subject: [PATCH 1/6] Use getObjectPtrOffset to generate constant offsets for
memcp
https://github.com/dschuff closed
https://github.com/llvm/llvm-project/pull/79235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -259,10 +259,13 @@ class InputFunction : public InputChunk {
file->codeSection->Content.slice(inputSectionOffset, function->Size);
debugName = function->DebugName;
comdat = function->Comdat;
+assert(s.Kind != WasmSignature::Placeholder);
https://github.com/dschuff updated
https://github.com/llvm/llvm-project/pull/79235
>From 976c98f631e5ed48bb18accbe59c9babd354a924 Mon Sep 17 00:00:00 2001
From: Derek Schuff
Date: Wed, 3 Jan 2024 09:06:37 -0800
Subject: [PATCH 01/12] parse types
---
llvm/include/llvm/BinaryFormat/Wasm.h | 8
@@ -259,10 +259,13 @@ class InputFunction : public InputChunk {
file->codeSection->Content.slice(inputSectionOffset, function->Size);
debugName = function->DebugName;
comdat = function->Comdat;
+assert(s.Kind != WasmSignature::Placeholder);
https://github.com/dschuff created
https://github.com/llvm/llvm-project/pull/79235
This change allows a WasmObjectFile to be created from a wasm file even if it
uses typed funcrefs and GC types.
It does not significantly change how lib/Object models its various internal
types (e.g. WasmSignatu
dschuff wrote:
Yeah, sorry I missed Alex's suggestion there. There's no hurry.
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -839,9 +839,11 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I)
{
unsigned Reg;
-if (Attrs.hasParamAttr(I, Attribute::SExt))
+if (Attrs.hasParamAttr(I, Attribute::SExt) ||
+(IsDirect && Func->hasParamAttribute(I, Attribute::SExt)))
---
https://github.com/dschuff approved this pull request.
Thanks for the fix!
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,125 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -O0 | FileCheck %s
dschuff wrote:
Is there a test that covers this behavior for DAG ISel? Maybe it would make
sense to add test expectations for bot
Author: Brendan Dahl
Date: 2023-09-12T13:07:55-07:00
New Revision: c6a33ff49dfb3498dae15c718820ea3d9c19f3cb
URL:
https://github.com/llvm/llvm-project/commit/c6a33ff49dfb3498dae15c718820ea3d9c19f3cb
DIFF:
https://github.com/llvm/llvm-project/commit/c6a33ff49dfb3498dae15c718820ea3d9c19f3cb.diff
Author: Derek Schuff
Date: 2022-01-24T15:46:54-08:00
New Revision: d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b
URL:
https://github.com/llvm/llvm-project/commit/d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b
DIFF:
https://github.com/llvm/llvm-project/commit/d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b.diff
Author: Derek Schuff
Date: 2021-07-09T16:51:36-07:00
New Revision: ac02baab48c2ff512e40140e2fe6845d2b6a636f
URL:
https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f
DIFF:
https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f.diff
Author: Derek Schuff
Date: 2020-10-28T17:41:22-07:00
New Revision: 77973f8dee6d4d6f1b7c2a026249c1f7068f267b
URL:
https://github.com/llvm/llvm-project/commit/77973f8dee6d4d6f1b7c2a026249c1f7068f267b
DIFF:
https://github.com/llvm/llvm-project/commit/77973f8dee6d4d6f1b7c2a026249c1f7068f267b.diff
Author: Derek Schuff
Date: 2020-10-27T17:57:32-07:00
New Revision: 44eea0b1a7301de4c284afed1c023014c391372f
URL:
https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f
DIFF:
https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f.diff
Author: Derek Schuff
Date: 2020-10-27T17:13:41-07:00
New Revision: bcb8a119df210753c5f1a3ac346d49597fef0f51
URL:
https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51
DIFF:
https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51.diff
Author: Derek Schuff
Date: 2020-09-17T14:42:41-07:00
New Revision: 0ff28fa6a75617d61b1aeea77463d6a1684c3c89
URL:
https://github.com/llvm/llvm-project/commit/0ff28fa6a75617d61b1aeea77463d6a1684c3c89
DIFF:
https://github.com/llvm/llvm-project/commit/0ff28fa6a75617d61b1aeea77463d6a1684c3c89.diff
Author: Yuta Saito
Date: 2020-01-24T10:30:46-08:00
New Revision: c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b
URL:
https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b
DIFF:
https://github.com/llvm/llvm-project/commit/c5bd3d07262ffda5b21576b9e1e2d2dd2e51fb4b.diff
LO
Author: dschuff
Date: Wed Mar 27 15:22:18 2019
New Revision: 357127
URL: http://llvm.org/viewvc/llvm-project?rev=357127&view=rev
Log:
Revert "[WebAssembly] Don't use default GetLinkerPath"
This reverts commit 4dcf3acce6d7455fd079d8e57441906ca2bad254.
(reverts LLVM SVN r356953)
Modified:
cfe/
dschuff added a comment.
Yeah, I don't mean for this to be the final word; mostly this just matches
asm.js.
I do agree with you that the unixy stuff goes with the emscripten environment
rather than wasm per se. I had thought we might define emscripten as an "OS"
(i.e. the third or maybe even 4t
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
Also it matches asm.js @sunfish is planning on unifying the triples, and this
will be part of that (and there may be more defines that we want to add and/or
subtract), but for now it makes m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280420: [WebAssembly] Change wasm SizeType to match asmjs
(authored by dschuff).
Changed prior to commit:
https://reviews.llvm.org/D24134?vs=70008&id=70082#toc
Repository:
rL LLVM
https://reviews.ll
Author: dschuff
Date: Thu Sep 1 17:38:37 2016
New Revision: 280420
URL: http://llvm.org/viewvc/llvm-project?rev=280420&view=rev
Log:
[WebAssembly] Change wasm SizeType to match asmjs
Summary:
We want wasm and asmjs to have matching ABIs, and right now asmjs uses
unsigned int for its size_t. This
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
dschuff added a comment.
test comment
https://reviews.llvm.org/D24134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278051: [Driver] Enable CFI for WebAssembly (authored by
dschuff).
Changed prior to commit:
https://reviews.llvm.org/D23244?vs=67090&id=67226#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23244
Author: dschuff
Date: Mon Aug 8 16:14:15 2016
New Revision: 278051
URL: http://llvm.org/viewvc/llvm-project?rev=278051&view=rev
Log:
[Driver] Enable CFI for WebAssembly
Since CFI support has landed in the WebAssembly backend, enable it in
the frontend driver.
Patch by Dominic Chen
Differential
Author: dschuff
Date: Tue May 10 13:35:31 2016
New Revision: 269099
URL: http://llvm.org/viewvc/llvm-project?rev=269099&view=rev
Log:
[WebAssembly] Reduce strictness of static destructor test
It didn't work on non-asserts builds
Modified:
cfe/trunk/test/CodeGenCXX/static-destructor.cpp
Modi
dschuff added a comment.
Well, I forgot to squash my local commits before landing, so this is r269085
thru r269089 :(
Repository:
rL LLVM
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269085: Do not register incompatible C++ destructors with
__cxa_atexit (authored by dschuff).
Changed prior to commit:
http://reviews.llvm.org/D19275?vs=56218&id=56751#toc
Repository:
rL LLVM
http:/
Author: dschuff
Date: Tue May 10 12:44:55 2016
New Revision: 269089
URL: http://llvm.org/viewvc/llvm-project?rev=269089&view=rev
Log:
Introduce CGCXXABI::canCallMismatchedFunctionType
Modified:
cfe/trunk/lib/CodeGen/CGCXXABI.h
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
cfe/trunk/lib/CodeGen/
Author: dschuff
Date: Tue May 10 12:44:52 2016
New Revision: 269088
URL: http://llvm.org/viewvc/llvm-project?rev=269088&view=rev
Log:
more cleanup
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
Author: dschuff
Date: Tue May 10 12:44:46 2016
New Revision: 269085
URL: http://llvm.org/viewvc/llvm-project?rev=269085&view=rev
Log:
Do not register incompatible C++ destructors with __cxa_atexit
Summary:
For a static object with a nontrivial destructor, clang generates an
initializer function (
Author: dschuff
Date: Tue May 10 12:44:48 2016
New Revision: 269086
URL: http://llvm.org/viewvc/llvm-project?rev=269086&view=rev
Log:
Clean up condition, add ARM to test
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
cfe/trunk/test/CodeGenCXX/static-destructor.cpp
Modified: cfe/trunk/lib/
Author: dschuff
Date: Tue May 10 12:44:50 2016
New Revision: 269087
URL: http://llvm.org/viewvc/llvm-project?rev=269087&view=rev
Log:
Clarify condition, remove redundant check
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
URL:
http://llvm.org/vi
dschuff added a comment.
Ping?
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff updated this revision to Diff 56218.
dschuff added a comment.
- Introduce CGCXXABI::canCallMismatchedFunctionType
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/static-destructor.cpp
Index: te
dschuff added a comment.
Thanks for the feedback, PTAL
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dschuff
Date: Mon May 2 12:26:19 2016
New Revision: 268256
URL: http://llvm.org/viewvc/llvm-project?rev=268256&view=rev
Log:
[WebAssembly] Rename memory_size intrinsic to current_memory
This follows the recent change in the wasm spec.
Modified:
cfe/trunk/include/clang/Basic/Builtins
dschuff added a subscriber: rengolin.
dschuff added a comment.
any comments from @t.p.northover or perhaps @rengolin ?
(This does have a potential new cost on ARM, as it requires one thunk (which is
just a tail call) per static initializer on ARM and WebAssembly)
http://reviews.llvm.org/D19275
dschuff updated this revision to Diff 54274.
dschuff marked 2 inline comments as done.
dschuff added a comment.
- Clean up condition, add ARM to test
- Clarify condition, remove redundant check
- more cleanup
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/ru
dschuff added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:92
@@ +91,3 @@
+ // disabled via a flag, a different helper function is generated anyway.
+ const CXXRecordDecl *Record = type->getAsCXXRecordDecl();
+ bool CanRegisterDestructor = Record &&
j
dschuff updated this revision to Diff 54264.
dschuff added a comment.
- Clarify condition, remove redundant check
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/runtimecc.cpp
test/CodeGenCXX/static-destructor.cpp
Index: test/CodeGenCXX/static-destructor.c
dschuff updated this revision to Diff 54260.
dschuff marked 3 inline comments as done.
dschuff added a comment.
- Clean up condition, add ARM to test
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/runtimecc.cpp
test/CodeGenCXX/static-destructor.cpp
Index:
dschuff added a reviewer: sunfish.
dschuff added a comment.
Will want a reviewer who's involved with ARM too, still looking.
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
dschuff created this revision.
dschuff added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb, aemerson.
For a static object with a nontrivial destructor, clang generates an
initializer function (__cxx_global_var_init) which registers that
object's destructor using __cxa_atexit. H
dschuff added a comment.
This LGTM for PNaCl and WebAssembly.
It's possible that for wasm we may still end up doing our own thing for varargs
instead of using the default, but this still looks like strictly an
improvement, (and it makes bootstrapping a backend simpler).
http://reviews.llvm.or
Author: dschuff
Date: Mon Nov 16 16:21:25 2015
New Revision: 253259
URL: http://llvm.org/viewvc/llvm-project?rev=253259&view=rev
Log:
Derive nacltools::Linker from GnuTool to get response file support
It could be derived from gnutools::Linker directly but this way makes it
consistent with all the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246040: Change Native Client x86 usr include and link path
to match SDK expectations (authored by dschuff).
Changed prior to commit:
http://reviews.llvm.org/D11271?vs=29924&id=33216#toc
Repository:
r
Author: dschuff
Date: Wed Aug 26 12:14:08 2015
New Revision: 246040
URL: http://llvm.org/viewvc/llvm-project?rev=246040&view=rev
Log:
Change Native Client x86 usr include and link path to match SDK expectations
GNU multilib style uses x86_64-nacl/include and x86_64-nacl/usr/include
but the SDK ex
1 - 100 of 115 matches
Mail list logo
