dcci wrote:
Given the fix forward didn't work, I reverted this to unblock
```
commit 61ab36a3e226df32855286dd31a2c3859800475d (HEAD -> main, upstream/main)
Author: Davide Italiano
Date: Sat Dec 14 18:25:50 2024 +
Revert "[Clang-REPL] Fix crash during `__run_exit_handlers` with dynami
Author: Davide Italiano
Date: 2024-12-14T18:26:32Z
New Revision: 61ab36a3e226df32855286dd31a2c3859800475d
URL:
https://github.com/llvm/llvm-project/commit/61ab36a3e226df32855286dd31a2c3859800475d
DIFF:
https://github.com/llvm/llvm-project/commit/61ab36a3e226df32855286dd31a2c3859800475d.diff
LO
Author: Davide Italiano
Date: 2024-12-14T18:25:02Z
New Revision: 9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5
URL:
https://github.com/llvm/llvm-project/commit/9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5
DIFF:
https://github.com/llvm/llvm-project/commit/9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5.diff
LO
https://github.com/dcci approved this pull request.
Thank you for fixing the build
https://github.com/llvm/llvm-project/pull/119903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcci wrote:
Reduced: https://github.com/llvm/llvm-project/issues/99894
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcci wrote:
Notice you already reverted, thanks. I'll follow-up with a reproducer once
`creduce` finishes running.
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
dcci wrote:
> This is clearer, I think I may have figured out where the problem is.
^ I have a reproducer that's running through `creduce`. It should be ready
tomorrow morning PST time, and I'll add you here. In the meanwhile, do you mind
if I revert this given we understand it breaks several
dcci wrote:
Code in question:
https://github.com/facebook/fbthrift/blob/ccfcd6743488c26d720bc4ff3348534491078b43/thrift/compiler/generate/t_py_generator.cc#L881
^ I am trying to find out a reduced testcase, but sending this here in case it
rings a bell.
https://github.com/llvm/llvm-project/pul
dcci wrote:
This commit seems to have broken well-formed code in thrift:
```
fbcode/thrift/compiler/generate/t_py_generator.cc:881:20: error: declaration of
variable 'module' with deduced type 'const auto &' requires an initializer
881 | for (const auto &module : modules) {
|
dcci wrote:
> > > You should also add test coverage (clang/test/SemaCXX) for the changes
> > > and a release note (clang/docs/ReleaseNotes.rst).
> >
> >
> > @AaronBallman -- are you OK with a crash-on-invalid (the one in first
> > post)? The original example we had crashed on valid code, but
dcci wrote:
> You should also add test coverage (clang/test/SemaCXX) for the changes and a
> release note (clang/docs/ReleaseNotes.rst).
@AaronBallman -- are you OK with a crash-on-invalid (the one in first post)?
The original example we had crashed on valid code, but reducing a 35MB file
wit
https://github.com/dcci deleted https://github.com/llvm/llvm-project/pull/98102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5576,6 +5576,10 @@ static void TryOrBuildParenListInitialization(
ExprResult ER;
ER = IS.Perform(S, SubEntity, SubKind,
Arg ? MultiExprArg(Arg) : std::nullopt);
+
+ if (ER.isInvalid())
dcci wrote:
@AaronBallman -- are
https://github.com/dcci approved this pull request.
https://github.com/llvm/llvm-project/pull/93760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcci wrote:
> Just to clarify, these changes are fairly straightforward and shouldn't
> impact any clients.
You can't really make this assumption. Maybe in this case it was true, but in
the other case that I mention (relaxing frames eagerly, your assumption was
incorrect and we had to adapt B
dcci wrote:
Thanks for putting this up for review. I appreciate you doing it, for this and
future MC patches that could impact BOLT.
https://github.com/llvm/llvm-project/pull/97449
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
Author: Davide Italiano
Date: 2024-07-02T08:53:48-07:00
New Revision: 46f7929879a59ec72dc75679b4201e2d314efba9
URL:
https://github.com/llvm/llvm-project/commit/46f7929879a59ec72dc75679b4201e2d314efba9
DIFF:
https://github.com/llvm/llvm-project/commit/46f7929879a59ec72dc75679b4201e2d314efba9.dif
dcci wrote:
Thanks. I'll try to get a repro (it's reducing from a large codebase so it
might take some time)
https://github.com/llvm/llvm-project/pull/93258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
dcci wrote:
Example error while I reduce:
```
fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:404:21:
error: static assertion failed due to requirement
'is_same, std::allocator>,
quic::Interval>::value': std::vector must have the same
value_type as its al
dcci wrote:
I am seeing something similar in vector (without modules). I'm reducing a test
case now.
https://github.com/llvm/llvm-project/pull/92855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/dcci commented:
LG
https://github.com/llvm/llvm-project/pull/78653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcci wrote:
Reverted in
https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
Author: Davide Italiano
Date: 2024-01-16T17:01:01-08:00
New Revision: b6f922fbf5e983122271aa12acb33f6172046d4d
URL:
https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d
DIFF:
https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d.dif
dcci wrote:
Hitting the same problem on a bunch of services. I am going to revert this to
unblock people, our repro is similar enough to the one Jeremy shared.
```
$ ./exe
clang -cc1 version 18.0.0git based upon LLVM 18.0.0git default target
x86_64-redhat-linux-gnu
clang++: /home/davidino/llvm
https://github.com/dcci approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davide
Date: Wed Nov 28 11:15:23 2018
New Revision: 347794
URL: http://llvm.org/viewvc/llvm-project?rev=347794&view=rev
Log:
Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter."
This broke the lldb bots.
Modified:
cfe/trunk/include/clang/AST/ASTImporter.h
cf
Author: davide
Date: Tue Oct 30 13:46:29 2018
New Revision: 345643
URL: http://llvm.org/viewvc/llvm-project?rev=345643&view=rev
Log:
Revert "[ASTImporter] Reorder fields after structure import is finished"
This reverts commit r345545 because it breaks some lldb tests.
Modified:
cfe/trunk/lib
On Thu, Jul 5, 2018 at 11:49 AM Davide Italiano via llvm-commits
wrote:
>
> On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
> Phabricator wrote:
> >
> > dexonsmith added a comment.
> >
> > In https://reviews.llvm.org/D48892#1153473, @davide wrote:
> >
> > > The lldb bot started failin
On Thu, Jul 5, 2018 at 11:37 AM Duncan P. N. Exon Smith via
Phabricator wrote:
>
> dexonsmith added a comment.
>
> In https://reviews.llvm.org/D48892#1153473, @davide wrote:
>
> > The lldb bot started failing very recently and the blamelist hints at this
> > change.
> >
> > http://green.lab.llvm.
On Thu, Jul 5, 2018 at 11:46 AM Louis Dionne via Phabricator
wrote:
>
> ldionne added a comment.
>
> I reverted this commit. Sorry for the blunder. I'll take a look at why LLDB's
> tests are doing this.
>
No need to revert this immediately. I can probably take a look and fix
what the lldb tests
ake-armv7-a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-section-macho.c
>
> Thanks
> Yvan
>
> On 23 February 2018 at 02:25, Davide Italiano via cfe-commits
> wrote:
>> Author: davide
>> Date: Thu Feb 22 17:25:03 2018
>> New Revis
Author: davide
Date: Thu Feb 22 17:25:03 2018
New Revision: 325850
URL: http://llvm.org/viewvc/llvm-project?rev=325850&view=rev
Log:
[Darwin] Add a test to check clang produces accelerator tables.
This test was previously in lldb, and was only checking that clang
was emitting the correct section.
Author: davide
Date: Thu Oct 12 14:08:29 2017
New Revision: 315621
URL: http://llvm.org/viewvc/llvm-project?rev=315621&view=rev
Log:
[SemaChecking] Suppress a GCC warning. NFCI.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/
Author: davide
Date: Sat Sep 30 14:49:15 2017
New Revision: 314605
URL: http://llvm.org/viewvc/llvm-project?rev=314605&view=rev
Log:
[Analysis] Remove unused makeLvalueToRValue variant.
Modified:
cfe/trunk/lib/Analysis/BodyFarm.cpp
Modified: cfe/trunk/lib/Analysis/BodyFarm.cpp
URL:
http://l
Author: davide
Date: Wed Sep 27 17:24:20 2017
New Revision: 314367
URL: http://llvm.org/viewvc/llvm-project?rev=314367&view=rev
Log:
[Targets/X86] Remove unneded `return` in setMaxAtomicWidth(). NFCI.
Modified:
cfe/trunk/lib/Basic/Targets/X86.h
Modified: cfe/trunk/lib/Basic/Targets/X86.h
URL
Author: davide
Date: Thu Jun 1 18:55:18 2017
New Revision: 304499
URL: http://llvm.org/viewvc/llvm-project?rev=304499&view=rev
Log:
[CodeGen] Surround assertion with parentheses.
This should placate GCC's -Wparentheses.
Modified:
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Modified: cfe/trunk/l
Author: davide
Date: Wed May 31 13:51:36 2017
New Revision: 304322
URL: http://llvm.org/viewvc/llvm-project?rev=304322&view=rev
Log:
[CodeGen] Surround assertion with parens and format.
This should placate GCC7 with -Werror.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/tr
Author: davide
Date: Tue Apr 25 13:04:31 2017
New Revision: 301344
URL: http://llvm.org/viewvc/llvm-project?rev=301344&view=rev
Log:
[PGO/tests] Update comment to reflect reality.
Modified:
cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c
Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlt
Author: davide
Date: Tue Apr 25 12:48:10 2017
New Revision: 301339
URL: http://llvm.org/viewvc/llvm-project?rev=301339&view=rev
Log:
[PGO] Update test now that we don't call IndirectCallPromotion.
Modified:
cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c
Modified: cfe/trunk/test/CodeGen/
Author: davide
Date: Mon Apr 3 11:51:39 2017
New Revision: 299364
URL: http://llvm.org/viewvc/llvm-project?rev=299364&view=rev
Log:
[TargetInfo] Use llvm::alignOf() instead of rewriting it. NFCI.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
U
Author: davide
Date: Sat Apr 1 16:07:07 2017
New Revision: 299315
URL: http://llvm.org/viewvc/llvm-project?rev=299315&view=rev
Log:
[Driver] Don't crash on invalid values of -mrelocation-model=.
This is handled in a similar way we handle invalid -mcode-model.
PR: 31840
Added:
cfe/trunk/tes
Author: davide
Date: Fri Mar 17 17:19:20 2017
New Revision: 298160
URL: http://llvm.org/viewvc/llvm-project?rev=298160&view=rev
Log:
[Sema] Unbreak GCC -Werror build (enum compare).
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
URL:
http
Author: davide
Date: Mon Feb 13 10:07:05 2017
New Revision: 294961
URL: http://llvm.org/viewvc/llvm-project?rev=294961&view=rev
Log:
[PM] Add support for instrumented PGO in the new pass manager (clang-side)
Differential Revision: https://reviews.llvm.org/D29309
Modified:
cfe/trunk/lib/Code
On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama wrote:
> On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cfe-commits
> wrote:
>>
>> Author: davide
>> Date: Sat Feb 11 17:44:37 2017
>> New Revision: 294879
>>
>> URL: http://llvm.org/viewvc/llvm-project?r
Author: davide
Date: Sat Feb 11 17:44:37 2017
New Revision: 294879
URL: http://llvm.org/viewvc/llvm-project?rev=294879&view=rev
Log:
[Driver] Use stem() and not filename().
On Windows the filename might have an extension, namely
`.exe`, so the search will fail. Sorry, I don't have a
good way to t
Author: davide
Date: Thu Feb 9 15:19:51 2017
New Revision: 294623
URL: http://llvm.org/viewvc/llvm-project?rev=294623&view=rev
Log:
[CodeGen] Remove unneeded `private`. NFCI.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.or
Author: davide
Date: Wed Feb 1 18:47:53 2017
New Revision: 293848
URL: http://llvm.org/viewvc/llvm-project?rev=293848&view=rev
Log:
[CodeGen] Update test after recent changes in llvm (r293846).
Modified:
cfe/trunk/test/CodeGen/link-bitcode-file.c
Modified: cfe/trunk/test/CodeGen/link-bitcod
Author: davide
Date: Wed Feb 1 14:43:28 2017
New Revision: 293810
URL: http://llvm.org/viewvc/llvm-project?rev=293810&view=rev
Log:
[CodeGen] Update test after recent changes in llvm (r293799).
Modified:
cfe/trunk/test/CodeGen/link-bitcode-file.c
Modified: cfe/trunk/test/CodeGen/link-bitcod
davide added a comment.
And yes, if you can add a test case that will be great (there's no bot that
caught this upstream) but one of our internal bots did.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-comm
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Was going to commit the same. Thanks. LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists
invoked as if it were gold, so clearly gold compatibility is
>> important enough for that. This suggests it is important enough to be
>> compatible from a ThinLTO perspective too.
>>
>> -- Sean Silva
>>
>> On Thu, Oct 13, 2016 at 10:42 AM, Davide Italiano via cfe
Author: davide
Date: Mon Oct 17 15:06:32 2016
New Revision: 284419
URL: http://llvm.org/viewvc/llvm-project?rev=284419&view=rev
Log:
[Coverage] Update test after r284418.
We now strip coverage metadata if debug info are not present.
Modified:
cfe/trunk/test/CodeGen/code-coverage.c
Modified:
On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva wrote:
> Nice to see this land!
>
> One nit:
> Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user
> uses the "gold syntax" then LLD will silently ignore it, which isn't good.
> At the very least, can we issue an error if we see
Author: davide
Date: Thu Oct 13 12:42:38 2016
New Revision: 284137
URL: http://llvm.org/viewvc/llvm-project?rev=284137&view=rev
Log:
[ThinLTO] Update doc to include lld (now supported).
Differential Revision: https://reviews.llvm.org/D25537
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284137: [ThinLTO] Update doc to include lld (now supported).
(authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D25537?vs=74459&id=74545#toc
Repository:
rL LLVM
https://reviews.
davide updated this revision to Diff 74459.
davide added a comment.
I mentioned that's ELF only. Are you OK with that or you want me to put more
detailed info?
https://reviews.llvm.org/D25537
Files:
docs/ThinLTO.rst
Index: docs/ThinLTO.rst
==
davide created this revision.
davide added reviewers: tejohnson, mehdi_amini.
davide added a subscriber: cfe-commits.
https://reviews.llvm.org/D25537
Files:
docs/ThinLTO.rst
Index: docs/ThinLTO.rst
===
--- docs/ThinLTO.rst
+++ do
Author: davide
Date: Tue Oct 4 08:16:00 2016
New Revision: 283217
URL: http://llvm.org/viewvc/llvm-project?rev=283217&view=rev
Log:
[ThinLTO] Spell `llvm-ar` correctly.
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cfe/trunk/docs/ThinLTO.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
davide created this revision.
davide added reviewers: mehdi_amini, tejohnson.
davide added a subscriber: cfe-commits.
This looks like an obvious typo to me, but I don't know the whole ThinLTO
story, so.
https://reviews.llvm.org/D25190
Files:
clang/docs/ThinLTO.rst
Index: clang/docs/ThinLTO
Author: davide
Date: Mon Aug 22 16:33:12 2016
New Revision: 279479
URL: http://llvm.org/viewvc/llvm-project?rev=279479&view=rev
Log:
[AST] Remove unused function, to silence a GCC7 warning.
Modified:
cfe/trunk/lib/AST/StmtProfile.cpp
Modified: cfe/trunk/lib/AST/StmtProfile.cpp
URL:
http://l
davide added a comment.
The `Sema` bits look fine to me. I'll let Filipe comment on the sanitizer part.
https://reviews.llvm.org/D23498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: davide
Date: Thu Jul 21 01:28:48 2016
New Revision: 276242
URL: http://llvm.org/viewvc/llvm-project?rev=276242&view=rev
Log:
[CodeGen] Handle recursion in LLVMIRGeneration Timer.
This can happen when emitting a local decl, which triggers
loading a decl imported from an AST file, which we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276242: [CodeGen] Handle recursion in LLVMIRGeneration
Timer. (authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D20748?vs=58833&id=64826#toc
Repository:
rL LLVM
https://reviews
davide added a comment.
Richard, can you please take a look at this? The more I look at it the more it
seems weird that we can recurse in this case, but I may miss something
https://reviews.llvm.org/D20748
___
cfe-commits mailing list
cfe-commits@l
davide added a comment.
ping?
http://reviews.llvm.org/D20748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I agree with Rafael. I ran with -ftime-report for a couple of weeks on
a lot of tests and never hit this problem.
It actually seems weird we have to handle the timer recursively here
as well (I'd like to avoid it at all), but let's see what Richard has
to say when he gets to this review.
On Wed, J
davide added a comment.
In http://reviews.llvm.org/D21006#449409, @dexonsmith wrote:
> I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c
> -flto`.
>
> In effect, with this change, `-flto -S` would silently ignore the `-flto`
> flag. That doesn't make sense to me.
I gu
davide added a comment.
In http://reviews.llvm.org/D21006#449380, @rafael wrote:
> Can you check what GCC does?
Sure.
$ gcc flto.c -o flto.o -flto -S && cat flto.o |head -n 15
.file "flto.c"
.section.gnu.lto_.inline.513e7babbe55b1f8,"e",@progbits
.string "x\
davide added a comment.
In http://reviews.llvm.org/D21006#449365, @mehdi_amini wrote:
> I'm not sure it is consistent with how we handle -flto, for instance -c means
> usually to output an object file, but adding -flto indicates to dump bitcode
> instead.
I see two alternative approaches:
1.
davide updated this revision to Diff 59679.
davide added a comment.
Add a test, fix a typo.
http://reviews.llvm.org/D21006
Files:
lib/Driver/Driver.cpp
test/CodeGen/2009-10-20-GlobalDebug.c
test/CodeGen/emit-asm.c
test/CodeGenCXX/cxx-apple-kext.cpp
test/Driver/darwin-iphone-defaults.m
davide created this revision.
davide added reviewers: rafael, vsk.
davide added a subscriber: cfe-commits.
See http://reviews.llvm.org/D20735 for more context.
Implementing this clang-side is not as terrible as I originally thought. Maybe
needs a test case, but I wasn't able to reduce one easily
davide added a subscriber: davide.
davide added a comment.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM.
On Tue, Apr 12, 2016 at 2:17 PM, Ed Maste wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for
> -static (authored by emaste).
>
> Changed prior to commit:
> http://reviews.llvm.org/
davide added a comment.
Hmm, I think you're right. It's not actually that silent (it fails with a fatal
error when trying to load/read).
That said, I think it might still be valuable to emit a diagnostic -- Richard
what do you think?
I noticed you reported a very similar problem here:
https://
Author: davide
Date: Wed Mar 9 15:09:51 2016
New Revision: 263060
URL: http://llvm.org/viewvc/llvm-project?rev=263060&view=rev
Log:
[modules] Simplify code logic. NFC.
Modified:
cfe/trunk/lib/Basic/Module.cpp
Modified: cfe/trunk/lib/Basic/Module.cpp
URL:
http://llvm.org/viewvc/llvm-project
davide updated this revision to Diff 50181.
davide added a comment.
Typo.
http://reviews.llvm.org/D18011
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/Frontend/FrontendActions.cpp
test/Modules/Inputs/insufficient-privileges.modulemap
Index: lib/Frontend/FrontendActions.cpp
==
davide created this revision.
davide added reviewers: rsmith, silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I stumbled upon this yesterday. Without this patch in palce, the module map
load is silently ignored, and this might cause subtle breakages.
http://reviews.llvm.org/D18011
Author: davide
Date: Tue Mar 8 17:58:08 2016
New Revision: 262969
URL: http://llvm.org/viewvc/llvm-project?rev=262969&view=rev
Log:
[Modules] Modernize, use range-based loops.
Modified:
cfe/trunk/lib/Lex/ModuleMap.cpp
Modified: cfe/trunk/lib/Lex/ModuleMap.cpp
URL:
http://llvm.org/viewvc/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262789: [Modules] Don't swallow errors when parsing optional
attributes. (authored by davide).
Changed prior to commit:
http://reviews.llvm.org/D17787?vs=49575&id=49888#toc
Repository:
rL LLVM
http:
Author: davide
Date: Sat Mar 5 22:20:05 2016
New Revision: 262789
URL: http://llvm.org/viewvc/llvm-project?rev=262789&view=rev
Log:
[Modules] Don't swallow errors when parsing optional attributes.
Differential Revision: http://reviews.llvm.org/D17787
Added:
cfe/trunk/test/Modules/parse-att
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262463: [modules] addHeaderInclude() can't fail. (authored
by davide).
Changed prior to commit:
http://reviews.llvm.org/D17794?vs=49578&id=49581#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1779
Author: davide
Date: Wed Mar 2 00:09:18 2016
New Revision: 262463
URL: http://llvm.org/viewvc/llvm-project?rev=262463&view=rev
Log:
[modules] addHeaderInclude() can't fail.
Differential Revision:http://reviews.llvm.org/D17794
Modified:
cfe/trunk/lib/Frontend/FrontendActions.cpp
Modifie
davide added a comment.
As an added bonus, this simplifies the code a little bit.
http://reviews.llvm.org/D17794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide created this revision.
davide added reviewers: silvas, rsmith, christof.
davide added a subscriber: cfe-commits.
I noticed that addHeaderInclude() returns bool although it can never fail.
I find this a little bit weird from a semantic point of view. My best guess is
that the 'bool' return
davide added a reviewer: rsmith.
davide updated this revision to Diff 49575.
davide added a comment.
Added a test. Yes, with the patch we stop immediately if we fail to parse
attributes, while the old code kept emitting diagnostics. I like the new
behaviour better, but I'll defer the decision to
davide created this revision.
davide added reviewers: silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I found this by visual inspection while trying to get up-to-speed on modules,
so I'm still uncertain how to test it. If the current one is really the actual
behaviour, then parse ca
Author: davide
Date: Sat Jan 30 02:03:54 2016
New Revision: 259302
URL: http://llvm.org/viewvc/llvm-project?rev=259302&view=rev
Log:
assert(false) -> llvm_unreachable().
Modified:
cfe/trunk/lib/AST/Expr.cpp
cfe/trunk/lib/AST/StmtPrinter.cpp
cfe/trunk/lib/Serialization/ASTWriterStmt.cp
davide closed this revision.
davide added a comment.
Close, this went in a while ago.
Repository:
rL LLVM
http://reviews.llvm.org/D15791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
davide added a comment.
In http://reviews.llvm.org/D15899#319918, @dim wrote:
> In http://reviews.llvm.org/D15899#319902, @davide wrote:
>
> > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3
> > if backported) -- what about people running <= 10.2 ? Isn't this a proble
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Hmm, probably they can use the new frontend options so it's fine. LGTM.
http://reviews.llvm.org/D15899
___
cfe-commits mailing list
cfe-commits@l
davide added a comment.
I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 if
backported) -- what about people running <= 10.2 ? Isn't this a problem for
them?
http://reviews.llvm.org/D15899
___
cfe-commits mailing list
cf
Author: davide
Date: Wed Dec 30 07:53:25 2015
New Revision: 256641
URL: http://llvm.org/viewvc/llvm-project?rev=256641&view=rev
Log:
Disable generating movt on FreeBSD.
It's sort of an hack, but we have no choice.
The linker in the base system doesn't handle that correctly (yet).
Once FreeBSD wil
davide accepted this revision.
davide added a reviewer: davide.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Tools.cpp:941
@@ -940,3 +940,3 @@
- // The kext linker doesn't know how to deal with movw/movt.
- if (KernelOr
davide added a comment.
In http://reviews.llvm.org/D15791#317172, @dim wrote:
> @davide, any idea whether lld will be able to handle movt correctly? If so,
> we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ?
lld/AArch64 can't still handle that properly, so I'd rather
davide added a subscriber: davide.
davide accepted this revision.
davide added a reviewer: davide.
davide added a comment.
This revision is now accepted and ready to land.
The patch looks good, and the changes are localized to the DflyBSD driver so if
you tested and works, I'm fine with it. I'll
Author: davide
Date: Wed Nov 11 14:06:35 2015
New Revision: 252793
URL: http://llvm.org/viewvc/llvm-project?rev=252793&view=rev
Log:
[SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.
davide added a comment.
Gentle Monday morning ping :)
Repository:
rL LLVM
http://reviews.llvm.org/D13854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide added a comment.
Gentle ping.
Repository:
rL LLVM
http://reviews.llvm.org/D13854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davide
Date: Fri Oct 23 11:43:18 2015
New Revision: 251115
URL: http://llvm.org/viewvc/llvm-project?rev=251115&view=rev
Log:
[StaticAnalyzer] Use llvm::utostr and not to_string.
The latter seems unsupported (at least) on MinGW and FreeBSD (where
I hit this failure). We can't have nice thi
davide created this revision.
davide added a reviewer: rsmith.
davide added a subscriber: cfe-commits.
davide set the repository for this revision to rL LLVM.
Richard, this implements what you proposed in
https://llvm.org/bugs/show_bug.cgi?id=25223 , hopefully in the correct way.
This is what we
1 - 100 of 110 matches
Mail list logo
