[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

davidstone created this revision. Herald added a subscriber: martong. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have four places that we try to decide which name to use for the test for stru

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone added a comment. In D149796#4319183 , @aaron.ballman wrote: > LGTM! Do you need me to commit this on your behalf? If so, what name and > email address would you like me to use for patch attribution? Yes please. David Stone, davidfromonl...@g

[PATCH] D149862: Remove `Sema::getFloat128Identifier`

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This function was added prior to clang supporting `__float128` to ensure clang could compile a libstdc++ header. This

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone updated this revision to Diff 519514. davidstone added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149796/new/ https://reviews.llvm.org/D149796 Files: clang/include/clang/Sema/EnterExpressionEvalua

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `Sema.h` is huge. This makes a small reduction to it by moving `EnterExpressionEvaluationContext` into a new header,

[PATCH] D149791: [clang][deps] NFC: Replace a vector with an array

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `ResourceDirectoryCache::findResourceDir` uses a `std::vector` when a `std::array` would do. Make this replacement an

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. In D99134#3331259 , @rsmith wrote: > Looks good. Do you need someone to land this for you? Yes, I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.ll

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone updated this revision to Diff 409710. davidstone added a comment. Add unit test requested by Richard Smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInst

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. Is there anything else I need to do to help move this forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe-commits mailing

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone updated this revision to Diff 385508. davidstone added a comment. Take into account Richard's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInstanti

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

davidstone added a comment. In D69764#2058590 , @rsmith wrote: > I think that if we are reordering `const`, we should be reordering all > //decl-specifier//s -- I'd like to see `int static constexpr unsigned const > long inline` reordered to something li

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone added a comment. In D82880#2651219 , @aaron.ballman wrote: > Do you need me to commit on your behalf? If so, which email address would you > like me to use for attribution? Yeah, I do not have commit access. davidfromonl...@gmail.com, please

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone updated this revision to Diff 69. davidstone added a comment. Reformatted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-print-int

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone marked 2 inline comments as done. davidstone added a comment. I believe this addresses the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880 ___

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone updated this revision to Diff 333135. davidstone added a comment. [clang] Handle 128-bits IntegerLiterals in StmtPrinter This fixes PR35677: "__int128_t or __uint128_t as non-type template parameter causes crash when considering invalid constructor". Repository: rG LLVM Github Mono

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. The previous commit is https://github.com/llvm/llvm-project/commit/a86bc00, and I don't understand enough of what the other code is doing to know if anything else needs to be fixed. I'd also like to add in a test to ensure this doesn't regress in the future, but I'm

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. It looks like this change was originally added 9 years ago with a commit message of "Lambda closure types are always considered to be like "local" classes, even if they are not within a function scope. Teach template instantiation to treat them as such, and make sure

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone created this revision. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp Index: clang/lib/

[PATCH] D88220: [C++20] P1825R0: More implicit moves

davidstone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else Quuxplusone wrote: > Quuxplusone wrote: > > @rsmith @david_stone (or anyone), what is the status in C++20 of the > > following test

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; aaron.ballman wrote: > riccibruno wrote: > > riccibruno wrote: > > > davids

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone marked an inline comment as done. davidstone added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > `i128` and `Ui128` are not valid integer literal suffix

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-print-int128.cpp Index: clang/test/AST/ast-print-int128.cpp

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

davidstone added a comment. I noticed the missing return because there is a warning (not as error) that caught it, I think the warning about falling off the end of a non-void-returning function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

davidstone added inline comments. Herald added a subscriber: sstefan1. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType &M, const NodeType &N) { !(M == N); } Missing `return` Repository: rG LLVM Github Monor

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

david_stone added a comment. In D72552#1832293 , @rsmith wrote: > Mechanically, this looks fine. > > There's an ongoing discussion in the committee as to whether this kind of > caching is permissible. But if this is necessary for acceptable performance,