davidstone marked an inline comment as done.
davidstone added inline comments.


================
Comment at: clang/lib/AST/StmtPrinter.cpp:1159
+  case BuiltinType::UInt128:
+    OS << "Ui128";
+    break;
----------------
riccibruno wrote:
> `i128` and `Ui128` are not valid integer literal suffix. The output of 
> `StmtPrinter` is intended to be valid C++. Unfortunately here I think that 
> your only choice is to print the high and low parts separately. 
I'm confused. i8, Ui8, i16, and Ui16 are also not valid C++ suffixes, but just 
a few lines up we use those. What am I missing here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82880/new/

https://reviews.llvm.org/D82880



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to