[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a14e817eeb: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls. (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3914-3918 + if (Old->hasInheritedPrototype()) +Old = Old->getCanonicalDecl(); Diag(New->getLocation(), diag::err_conflicting_types) << New; Diag(Old->getLocation(), PrevDiag) << Old

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida updated this revision to Diff 431543. cishida added a comment. Restrict using the canonical decl's source location to only when the prototype was inferred from previously seen decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126258/new/

[PATCH] D126258: [Clang] Avoid misleading 'conflicting types' diagnostic with no-prototype decls.

cishida created this revision. cishida added reviewers: jyknight, aaron.ballman. Herald added a subscriber: ributzka. Herald added a project: All. cishida requested review of this revision. Herald added a project: clang. Clang has recently started diagnosing prototype redeclaration errors like rG

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c67c3c6789: [clang] Track how headers get included generally during lookup time (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida updated this revision to Diff 426858. cishida added a comment. Hold include name in `HeaderSearch` itself, keeping HeaderFileInfo lightweight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 Files

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1036 + +// This file is a system header or C++ unfriendly if the dir is. HFI.DirInfo = CurDir->getDirCharacteristic(); tschuett wrote: > Why did the comment move? It refers to sett

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added a comment. In D124638#3481932 , @jansvoboda11 wrote: > Can you describe how come the check is not reliable without this patch? It > might be worth fixing the underlying reason for the unreliability first. Different search paths alter wher

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida created this revision. cishida added reviewers: ributzka, zixuw, jansvoboda11. Herald added a project: All. cishida requested review of this revision. Herald added a project: clang. tapi & clang-extractapi both attempt to construct then check against how a header was included to determine

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

cishida added a comment. > we might not always want to transform an absolute path because the resulting > relative include name might get remapped in a headermap, for example in test > known_files_only_hmap.c. But how does it work with modules where we need > relative includes? Is the setup in

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

cishida accepted this revision. cishida added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148 _

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

cishida added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:66 +// Check if we have looked up this particular file entry previously instead +// of querying the preprocessor for externsal sources. +if (UnknownFileEntries.count(File))

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building. dgoldman wrote: > cishida wrot

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida accepted this revision. cishida added a comment. This revision is now accepted and ready to land. I followed up about this approach with folks more familiar with SourceKit and seems fine, so LGTM. I'd wait a day to see if Jan has any concerns. Comment at: clang/lib/Lex

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added a comment. My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this. It sounds like for the clangd support, you're not as

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG395e1fe30574: [clang] Capture Framework when HeaderSearch is resolved via headermap (authored by cishida). Repository: rG LLVM Github Monorepo CH

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida added a comment. In D111468#3066820 , @jansvoboda11 wrote: > LGTM. > > As a follow-up, do you think it would make sense to improve the > documentation/comments around "index header maps"? Variable names refer to > indexing while the documentati

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida updated this revision to Diff 379721. cishida added a comment. Fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111468/new/ https://reviews.llvm.org/D111468 Files: clang/lib/Lex/HeaderSearch.cpp clang/unittests/Lex/Head

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida created this revision. cishida added reviewers: dexonsmith, ributzka. cishida requested review of this revision. Herald added a project: clang. When building frameworks, headermaps responsible for mapping angle-included headers to their source file location are passed via `-I` and not `-i

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0116d04d04f2: [TextAPI] move source code files out of subdirectory, NFC (authored by cishida). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

cishida created this revision. cishida added reviewers: steven_wu, ributzka. Herald added subscribers: hiraditya, mgorny. Herald added a reviewer: int3. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. cishida requested review of this revision. Herald added projects: clang, LL

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

This revision was automatically updated to reflect the committed changes. Closed by commit rG89a0c4066b0e: [clang][diagnostics] Add '-Wundef-prefix' warning option (authored by zixuw, committed by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

cishida marked an inline comment as done. cishida added inline comments. Comment at: clang/test/InterfaceStubs/driver-test3.c:6 +// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs %s -o %t/driver-test3.o +// RUN: cat %t/driver-test3.ifs | FileCheck %s + ---

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/include/clang/Driver/Options.td:635 + Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub Files, emit merged text not binary.">; def iterface_stub_version_EQ : JoinedOrSeparate<["-"], "interface-stub-version=">, Flags

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3688 .Case("experimental-ifs-v1", "experimental-ifs-v1") - .Default(""); + .Default("experimental-ifs-v1"); nit: no need to check `ArgStr`

[PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida updated this revision to Diff 215174. cishida added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, jdoerfert, asbirlea, Petar.Avramovic, thopre, jsji, jfb, kadircet, rupprecht, arphaman, atanasyan, jkorous, MaskRay, jrtc27, chr

[PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida abandoned this revision. cishida added a comment. Ran into issue with pushing update to this middle of stack revision. Will create new clean revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66149/new/ https://reviews.llvm.org/D66149