[PATCH] D156565: Diagnose use of VLAs in C++ by default

cor3ntin added a comment. > Any concerns with this approach? Sounds reasonable to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 ___ cfe-commits mailing li

[PATCH] D156212: [clang][Interp] Implement remaining strcmp builtins

cor3ntin added a comment. There are still unaddressed comment here. It would be nice to complete this before phab shuts down Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156212/new/ https://reviews.llvm.org/D156212 __

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

cor3ntin added a subscriber: aaron.ballman. cor3ntin added a comment. + @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 ___ cfe-commits mailing l

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. @aaron.ballman Given the recent discussion we had on both github (https://github.com/llvm/llvm-project/pull/66203) and privately, I'm going to accept that. We only create ConstantExpr for

[PATCH] D156565: Diagnose use of VLAs in C++ by default

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 ___ cfe-commits mailing list cfe-comm

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. @hazohelet Please keep this patch on Phab. It's not going to be shutdown. The current consensus is that we will reconsider shutting down phab on November 15 https://discourse.llvm.org/t/update-on-github-pull-requests/71540/125 CHANGES SINCE LAST ACTION https://review

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 7 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3775 bool UseMemberUsingDeclRules, bool ConsiderCudaAttrs = true, - bool ConsiderRequiresClauses = true); +

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/AST/ASTLambda.h:45 + return isLambdaCallOperator(DC) && + !cast(DC)->getType().isNull() && + !cast(DC)->isExplicitObjectMemberFunction(); aaron.ballman wrote: > cor3ntin wrote: > > e

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. I had a chat with @hubert.reinterpretcast and @tahonermann. We reached consensus on wanting to make sure the codepoint value is formatted in a future-proof way so that if we ever implement escaping of lone combining codepoint, this case would be handled as well. To do

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

cor3ntin added a comment. Herald added a project: All. @rnk can we close this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___ cfe-commits mailing list cfe-co

[PATCH] D156890: [clang] Remove outdated INSTALL.txt

cor3ntin added a comment. @stephanlachnit do you need me to land this on your behalf? What email should we use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156890/new/ https://reviews.llvm.org/D156890 ___

[PATCH] D158071: [clang] Remove rdar links; NFC

cor3ntin closed this revision. cor3ntin added a comment. This was landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list cfe-commit

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin accepted this revision. cor3ntin added a comment. @hazohelet Nah, feel free to merge that first! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commi

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

cor3ntin added a comment. @MitalAshok Do you need me to land that for you> If so, what email should i use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156064/new/ https://reviews.llvm.org/D156064 ___ c

[PATCH] D159522: [Clang][C] Fixed a bug where we reject an _Atomic qualified integer in a switch statment

cor3ntin added a comment. @to268 as discussed, i landed the change on your behalf. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159522/new/ https://reviews.llvm.org/D159522 ___ cfe

[PATCH] D159522: [Clang][C] Fixed a bug where we reject an _Atomic qualified integer in a switch statment

This revision was automatically updated to reflect the committed changes. Closed by commit rG624c13057874: [Clang][C] Fixed a bug where we reject an _Atomic qualified integer in a switch… (authored by to268, committed by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0x3086) == '̵'

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

cor3ntin accepted this revision. cor3ntin added a comment. 1 nit but still LGTM Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:4993 - // Copy the inner loc start from the pattern. + // Copy source locations from the pattern. + Function->setLocation(PatternDecl-

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595 ___

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

cor3ntin added subscribers: hubert.reinterpretcast, rsmith, cor3ntin. cor3ntin added a comment. @hubert.reinterpretcast @rsmith Opinions on that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 __

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

cor3ntin added a comment. We should take a decision on this before the move off Phab. Generally the changes look sensible to me so I'm not sure there are blockers left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

cor3ntin added a comment. It would be nice to figure out a plan for this PR in the next few weeks, before we get kicked out of Phab! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ cfe-commits m

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson ^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate

cor3ntin added subscribers: philnik, ldionne, cor3ntin. cor3ntin added a comment. I have a couple questions but overall I think this is a great warning to add. Sorry it took us a while to get to your PR Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1384 +def CTADSel

[PATCH] D134654: [clang] Detect header loops

cor3ntin added a comment. @aaron.ballman @urnathan What is the status of this PR? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commi

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 ___

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr, TPtr,

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr, TPtr,

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:33 #include "clang/Basic/TypeTraits.h" +#include "clang/Basic/TokenKinds.h" #include "clang/Lex/Preprocessor.h" Superfluous change Comment at: clang/lib/Sema/SemaExprC

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (assuming rebase goes well) @tahonermann ping folks in the future, and apologies for taking... 4 years! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

cor3ntin added a comment. @aaron.ballman that's been waiting for a while - i don't feel comfortable reviewing it, mind looking at it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156057/new/ https://reviews.llvm.org/D156057 ___ cfe-commits

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list c

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed9e9e3ace6: [Clang] Add captures to the instantiation scope of lambda call operators (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

cor3ntin added a comment. LGTM, but please wait a few days for @erichkeane CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157526/new/ https://reviews.llvm.org/D157526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @erichkeane Ok, I added a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 556209. cor3ntin added a comment. Add the test case that caused a build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin accepted this revision. cor3ntin added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D152083: [clang] Warning for incomplete array initializer lists

cor3ntin added a comment. Can you test in c++ mode? I'd like to see a test for something like struct { int a, b, c, d = 1; // d has an initializer } bar2 = { .a = 1, .b = 1, .c = 1 }; Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added a comment. @philnik @Mordante were the libc++ concerns addressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM modulo one nit. @hubert.reinterpretcast If you want to make sure this is conforming Comment at: clang/docs/ReleaseNotes.rst:99 + list-initialization from objects of

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added a comment. Generally looks good but still a few unaddressed comments Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return f

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158702/new/ https://reviews.llvm.org/D158702 ___

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 556115. cor3ntin added a comment. Fix libc++ compile @erichkeane I struggle to reduce further, do you think it's worth adding this inscrutable test case somewhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @abrachet Thanks, i've reverted the patch while i investigate a fix I managed to reduced it to template concept cs = requires(b bj) { bj.begin(); }; struct { template requires cs auto operator()(b &&) {} } begin; template concept cu = re

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added a comment. In D159345#4640147 , @tahonermann wrote: > Even better than I asked for. I held back on suggesting the change of `Tok` > to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change > anyway! You must have read m

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb67d28dee5: [Clang] Handle non-ASCII after line splicing (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D159345?vs=55

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. @hazohelet I'm happy with the patch, I just need to make sure Hubert and I agree! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0x3086) == '̵'

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 556076. cor3ntin added a comment. Address Tom's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs/ReleaseNotes.rst clang/include/clang/L

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf725bc9371: [Clang] Add captures to the instantiation scope of lambda call operators (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > cor3ntin wrote: > > erichkeane wrote: > > > Wonder if

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 556068. cor3ntin added a comment. Inherit from FunctionScopeRAII as per @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > Wonder if `LambdaScopeForCallOperatorInstantiationRAII

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

cor3ntin added a comment. Given that we still need to check for substitution errors in untaken branches, this look reasonable (especially as i think you are right that alternative approaches are likely to be more complex) however i think it does require a comment, and I'd like @erichkeane to ha

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @erichkeane @aaron.ballman This now pass the tests and is ready for review :) Thanks to @beanz for the quick turnaround on the HLSL issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 555974. cor3ntin added a comment. Rebase and cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 555973. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaConcept.cpp

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

cor3ntin added a comment. No, existing PRs can stay there. I'm waiting for @aaron.ballman, our resident attributes guru, to look at that - even if the changes look reasonably good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ ht

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

cor3ntin added a subscriber: Fznamznon. cor3ntin added a comment. @Fznamznon This might be of interest to you @faisalv are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

cor3ntin added a comment. @barannikov88 Don't forget to land this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154773/new/ https://reviews.llvm.org/D154773 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. So you can enable some of the sema source location tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D158591: Add support of Windows Trace Logging macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d305e64fd3: Add support of Windows Trace Logging macros (authored by RIscRIpt, committed by cor3ntin). Changed prior to commit: https://reviews.

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt I added release notes, let me know if you are happy with everything before i land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 _

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin updated this revision to Diff 555712. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Se

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Hum. before I do - I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague) - Do we need a release note ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Oh! I should have asked sooner. Will do! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commi

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

cor3ntin added a comment. @MitalAshok Are you still working on this? Do you need further help on this patch? You have commit access, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https://reviews.llvm.org/D154716 _

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson Are you still working on that? It seems it's only missing updates to a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt Do you need further help on this patch? You have commit access, right? (I'm trying to make sure things don't fall through the cracks as we move to github) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/ne

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1761 + getCharAndSize(CurPtr, FirstCodeUnitSize); + const char *CharStart = CurPtr + FirstCodeUnitSize - 1; + const char *UnicodePtr = CharStart; shafik wrote: > Do we need to verify that `Fir

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 63. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890f11d60fef: [Clang] Realize generic lambda call operators are dependent sooner (authored by cor3ntin). Changed prior to commit: https://reviews.

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555375. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555374. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h cla

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing a trailing return type / noexcept / constraint of a generic lambda, we need to know that we are in a dependen

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. int a\ ス; Failed to be parsed as a valid identifier. Fixes #65156 Repository: rG LLVM Github Monorepo https://revie

[PATCH] D159307: [Sema] add test cases for D152495

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (this could be a NFC change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159307/new/ https://reviews.llvm.org/D159307 __

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. I would like @aaron.ballman to weight in, (he might not get back to you until next week), but overall, i think I'm pretty happy with this new direction. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const Functi

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. Thanks for working on this. This is going to conflict with deducing this (https://reviews.llvm.org/D140828) in interesting (ie, horrible) ways, so i guess I'll have to deal with that. For people following along we are trying to fix nasty lambda regression https://review

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. It is used, but only in an assert. Seems like the right fix! In D152495#4628778 , @smeenai wrote: > In D152495#4628028 , @goncharov > wrote: > >> there is a number of unused vaiables in

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

cor3ntin added a comment. I think this should get a mention in clang's releases notes. Otherwise LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 ___ cfe-co

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @beanz Oh wow, excellent, i did not expect a solution so fast! I'm glad to know there may indeed be an issue with HLSL rather than this patch because I'm not sure I could have come up with a different fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a subscriber: beanz. cor3ntin added a comment. @beanz The changes to TreeTransform.h cause a lot of HLSL test failures similar to this one: clang: /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/lib/AST/ExprClassification.cpp:57: Cl clang::Expr::ClassifyImpl(clang::ASTCon

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin created this revision. Herald added subscribers: ChuanqiXu, Anastasia. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like concepts checking, a trailing return type of a lambda in a dependent

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-co

[PATCH] D156565: Diagnose use of VLAs in C++ by default

cor3ntin added a comment. In D156565#4605027 , @shafik wrote: > In D156565#4599812 , @aaron.ballman > wrote: > >> Enable the diagnostic by default in C++ language modes, and under -Wall in >> GNU++ language mode

[PATCH] D158933: [clang] Implement -funsigned-bitfields

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18137 + + // TODO: Somehow get the explicit signdness info, maybe with the usage of + // the typedef's name (Typedef->getDecl()->getNameAsString()), look it up The information seems

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin added a comment. Thanks a lot for working on this. LGTM, except for the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 ___ cfe-commits ma

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-deducing-this.cpp:4 + +struct TrivialStruct { +void explicit_object_function(this TrivialStruct) {} cor3ntin wrote: > aaron.ballman wrote: > > I'd like to see more codegen tests in genera

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs(); + Method->getNonObjectParameter(0)->getType()->getAs(); if (!ParamTy || ParamTy->getPointeeType().isConst

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin added a comment. Still missing a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 3 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/ASTLambda.h:45 + return isLambdaCallOperator(DC) && + !cast(DC)->getType().isNull() && + !cast(DC)->isExplicitObjectMemberFunction(); e

[PATCH] D158718: [Clang] Handle ellipsises in abiguous cast expressions.

cor3ntin abandoned this revision. cor3ntin added a comment. As described here, clang is actually conforming, there is an open core issue with unclear resolution and that ""fix"" doesn't cover all the ambiguous use cases https://github.com/llvm/llvm-project/issues/64926 Repository: rG LLVM Gi

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I'm happy punting the new interpreter to a subsequent PR, maybe there are unresolved issues with string literals? Anyway, we don't have to scope creep further, LGTM Thanks for working on t

  1   2   3   4   5   6   7   8   9   10   >