Author: cbertol
Date: Wed Feb 28 12:48:35 2018
New Revision: 326368
URL: http://llvm.org/viewvc/llvm-project?rev=326368&view=rev
Log:
[OpenMP] Extend NVPTX SPMD implementation of combined constructs
Differential Revision: https://reviews.llvm.org/D43852
This patch extends the SPMD implementation
Author: cbertol
Date: Thu Feb 22 11:38:14 2018
New Revision: 325822
URL: http://llvm.org/viewvc/llvm-project?rev=325822&view=rev
Log:
[OpenMP] Limit reduction support for pragma 'distribute' when combined with
pragma 'simd'
Differential Revision: https://reviews.llvm.org/D43513
This is a bug fi
Ag&c=jf_iaSHvJObTbx-siA1ZOg&r=KVjg5Cs0EAoazAUlw8ewR94xDrSR5dmudAuVb_TqxaY&m=vDNoKAps3Gw9D7TKDTj2OX5kJXxfFuDTg_JeBIO65iw&s=P-lDxQcJiIo4cNAz8ui_t1tCE2_cb2xmPJ1BP9TbdS0&e=>> Thanks!>> Douglas Yung>>> -Original Message->> From: cfe-commits [mailto:cfe-commits-boun...@list
Author: cbertol
Date: Fri Nov 10 08:49:09 2017
New Revision: 317898
URL: http://llvm.org/viewvc/llvm-project?rev=317898&view=rev
Log:
[NFC] Pacify bbot for OpenMP 'teams distribute parallel for'
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_messages.cpp
Modified: cfe/trunk/te
Author: cbertol
Date: Fri Nov 10 08:05:00 2017
New Revision: 317893
URL: http://llvm.org/viewvc/llvm-project?rev=317893&view=rev
Log:
[OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'
https://reviews.llvm.org/D39902
Simply leverage existing implementation and verify correc
Author: cbertol
Date: Wed Oct 4 07:12:09 2017
New Revision: 314905
URL: http://llvm.org/viewvc/llvm-project?rev=314905&view=rev
Log:
[OpenMP] Initial implementation of teams distribute code generation
https://reviews.llvm.org/D38371
This patch implements codegen for the combined 'teams distribu
Author: cbertol
Date: Wed May 3 10:28:48 2017
New Revision: 302031
URL: http://llvm.org/viewvc/llvm-project?rev=302031&view=rev
Log:
[OpenMP] Extended parse for 'always' map modifier
https://reviews.llvm.org/D32807
This patch allows the map modifier 'always' to be separated by the map type
(to
Author: cbertol
Date: Tue Apr 25 13:59:37 2017
New Revision: 301348
URL: http://llvm.org/viewvc/llvm-project?rev=301348&view=rev
Log:
Minor fix for distribute_parallel_for_num_threads_codegen on AARCH64
Modified:
cfe/trunk/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp
Modified:
Author: cbertol
Date: Wed Apr 19 19:39:39 2017
New Revision: 300802
URL: http://llvm.org/viewvc/llvm-project?rev=300802&view=rev
Log:
[OpenMP] Prepare sema to support combined constructs with omp distribute and
omp for
https://reviews.llvm.org/D32237
This patch prepares sema with additional fie
Author: cbertol
Date: Fri Feb 17 15:29:13 2017
New Revision: 295497
URL: http://llvm.org/viewvc/llvm-project?rev=295497&view=rev
Log:
[OpenMP] Prepare Sema for initial implementation for pragma 'distribute
parallel for'
https://reviews.llvm.org/D29922
This patch adds two fields for use in the i
Author: cbertol
Date: Mon Feb 6 10:03:41 2017
New Revision: 294195
URL: http://llvm.org/viewvc/llvm-project?rev=294195&view=rev
Log:
[OpenMP] Remove fixme comment in regression test and related unnecessary
statement
https://reviews.llvm.org/D29501
It looks like I forgot to remove a FIXME comme
Author: cbertol
Date: Fri Feb 3 13:09:16 2017
New Revision: 294026
URL: http://llvm.org/viewvc/llvm-project?rev=294026&view=rev
Log:
[OpenMP] Add missing regression test for pragma distribute, clause firstprivate
https://reviews.llvm.org/D28243
The regression test was missing from the previous
Author: cbertol
Date: Tue Jan 3 12:24:42 2017
New Revision: 290898
URL: http://llvm.org/viewvc/llvm-project?rev=290898&view=rev
Log:
[OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host
code generation
https://reviews.llvm.org/D17840
This patch enables private, firstpri
Author: cbertol
Date: Wed Jul 13 12:16:49 2016
New Revision: 275282
URL: http://llvm.org/viewvc/llvm-project?rev=275282&view=rev
Log:
[OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr'
of target
http://reviews.llvm.org/D22070
Added:
cfe/trunk/test/OpenMP/targe
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 275271.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Wed Jul 13 10:37:16 2016
New Revision: 275271
URL: http://llvm.org/viewvc/llvm-project?rev=275271&view=rev
Log:
[OpenMP] Initial implementation of parse+sema for clause use_device_ptr of
'target data'
http://reviews.llvm.org/D21904
This patch is similar to the implementati
carlo.bertolli updated this revision to Diff 63689.
carlo.bertolli added a comment.
[OpenMP] Add regression test to check correctness of ast building, remove
'brief's, and rebase.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenMPClause.h
include/clang/AS
carlo.bertolli marked 3 inline comments as done.
Comment at: lib/Sema/SemaOpenMP.cpp:11648
@@ +11647,3 @@
+// item should be a pointer or reference to pointer
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
-
carlo.bertolli updated this revision to Diff 63527.
carlo.bertolli added a comment.
[OpenMP] Apply comments: remove creation of private variable and update
regression tests to include references to pointers.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenM
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
> No positive tests for the construct
Do you mean in the regression test? I thought I covered all negative and
positive cases, but please let me know if I missed anything.
Comment at: include/cla
carlo.bertolli updated this revision to Diff 62878.
carlo.bertolli added a comment.
[OpenMP] Remove 'brief' comment tags and change error report to standard
'expected' form.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/Recu
carlo.bertolli marked 4 inline comments as done.
carlo.bertolli added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli updated this revision to Diff 62817.
carlo.bertolli added a comment.
[OpenMP] Remove private variable creation from this patch as requested by
comments and rebase.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST
carlo.bertolli added a comment.
I think that Kelvin is right. This is what that sentence refers to:
int * bla = ..;
#pragma omp target data use_device_ptr(bla)
{
.. bla .. // <-- this is the 'reference' that sentence is about
}
What puzzles me about that sentence is that it seems it is asking
carlo.bertolli added a comment.
Hi
Yes, the purpose of these patches was to check correctness of code gen for the
related clauses when targeting nvptx exclusively.
Since I wrote these tests, the base support changed to generate same code on
host and any device type, and it seemed to me that the
carlo.bertolli added a comment.
Resubmitted at revision 273884 after fixes.
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 273705.
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
carlo.bertolli added a comment.
Thanks for the hint - I have updated the diff to use Context.getSizeType().
Please let me know if this is what you meant.
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits
carlo.bertolli added a comment.
Thanks for these further comments. I have just updated the diff applying the
suggestions.
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
carlo.bertolli marked 2 inline comments as done.
carlo.bertolli added a comment.
Thanks very much for the quick review. I am about to update the patch
reflecting your comments and to the latest trunk.
Comment at: include/clang/AST/StmtOpenMP.h:2884-2896
@@ +2883,15 @@
+
+ ///
carlo.bertolli abandoned this revision.
carlo.bertolli added a comment.
Codegen of region bodies should not be specialized based on target.
Repository:
rL LLVM
http://reviews.llvm.org/D18470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
carlo.bertolli closed this revision.
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Committed revision 267972.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: cbertol
Date: Thu Apr 28 20:37:30 2016
New Revision: 267972
URL: http://llvm.org/viewvc/llvm-project?rev=267972&view=rev
Log:
[OPENMP] Enable correct generation of runtime call when target directive is
separated from teams directive by multiple curly brackets
http://reviews.llvm.org/D184
carlo.bertolli updated this revision to Diff 53425.
carlo.bertolli added a comment.
[OPENMP] Remove unnecessary templating of function.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP/teams_codege
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Great, thanks for the hint. I do much prefer your version of the function. I am
updating the diff.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
___
cfe-commit
carlo.bertolli updated this revision to Diff 53283.
carlo.bertolli added a comment.
[OPENMP] Remove template for intervening statement and only allow CompoundStmt.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/teams_codegen.cpp
Ind
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Alexey
Thanks for the review. I addressed your comment in a new version of the
revision.
Samuel already reviewed the patch, as you can see in the message exchange. I am
very happy to apply any design change you can
carlo.bertolli updated this revision to Diff 52640.
carlo.bertolli added a comment.
[OPENMP] Rebase patch on new support for codegen for teams in nvptx target.
private and firstprivate clauses are now dealt with in the teams patch and this
one only becomes regression tests.
Repository:
rL LL
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 265304.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Mon Apr 4 10:55:02 2016
New Revision: 265304
URL: http://llvm.org/viewvc/llvm-project?rev=265304&view=rev
Log:
[OPENMP] Codegen for teams directive for NVPTX
This patch implements the teams directive for the NVPTX backend. It is
different from the host code generation path
carlo.bertolli added a comment.
Hi Alexey
I understand your concerns and share the danger of working on optimizations
before a correct implementation is actually in place.
I do not think this is the case. My comment was very precise about the
cause-effect: the OpenMP specification was defined i
carlo.bertolli updated this revision to Diff 52416.
carlo.bertolli added a comment.
[OPENMP] Even though this patch was already accepted in its previous form,
comments on depending patch http://reviews.llvm.org/D18286
(http://reviews.llvm.org/D18286) revealed that a new approach for this patch
carlo.bertolli added a comment.
Hi
If I understand correctly the problem, I would like to add something on top of
Samuel's comment.
My understanding is that Alexey is suggesting that we pass a reference type to
kernels for every pointer input parameter, regardless of the actual type and
data s
carlo.bertolli updated this revision to Diff 51676.
carlo.bertolli added a comment.
Simplify the search function and generalize by using a template.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingTeams(const Stmt *TargetBody) {
+ if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir;
+
sfantao wrote:
> I think that this can be simplified t
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, sfantao, Hahnfeld.
carlo.bertolli added subscribers: arpith-jacob, caomhin, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch fixes a bug in code generation of the correct OpenMP ru
carlo.bertolli added a comment.
Hi
Thinking more carefully, I believe you are right - no, it is not. I guess we
would not call at all shouldEmitInlinedTeamsDirective for the case of paralle.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D18286
_
carlo.bertolli added a comment.
Hi Jonas
Thanks for your comment. That scheme would not work for #parallel on the gpu in
case we do not want to inline the parallel region.
There are patches coming in which that is going to happen so I think that we
really need to distinguish between different p
carlo.bertolli updated this revision to Diff 51285.
carlo.bertolli added a comment.
To make clear my comment I an updating the patch following Alexey's comment and
modifying it to make it work.
You can see that now we have the following check:
CGM.getTarget().getTriple().getArch() == llvm::Triple
carlo.bertolli added a comment.
Hi Alexey
Thanks for your comment. The suggested change will not work as I intended in my
patch when using the host as a device. This happens when you select the
following options:
-fomptargets=powerpc64le-ibm-linux-gnu -fopenmp-is-device
In this case we generat
Author: cbertol
Date: Wed Mar 16 14:04:22 2016
New Revision: 263654
URL: http://llvm.org/viewvc/llvm-project?rev=263654&view=rev
Log:
[OPENMP] Support for codegen of private clause of target, host side
This patch adds support for codegen of private clause of target and a
regression test for host
carlo.bertolli updated this revision to Diff 50845.
carlo.bertolli added a comment.
Update against trunk as dependence was committed to trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D18203
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGOpenMPRuntime.cpp
lib/Sema/S
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 263837.
Repository:
rL LLVM
http://reviews.llvm.org/D18203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Fri Mar 18 16:43:32 2016
New Revision: 263837
URL: http://llvm.org/viewvc/llvm-project?rev=263837&view=rev
Log:
[OPENMP] Implementation of codegen for firstprivate clause of target directive
This patch implements the following aspects:
It extends sema to check that a variab
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, kkwli0, Hahnfeld.
carlo.bertolli added subscribers: sfantao, caomhin, arpith-jacob, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
Herald added a subscriber: jholewinski.
This patch adds in
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 263654.
Repository:
rL LLVM
http://reviews.llvm.org/D18105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
carlo.bertolli marked 2 inline comments as done.
Comment at: lib/Sema/SemaOpenMP.cpp:9782-9783
@@ +9781,4 @@
+Diag(ELoc, diag::err_omp_variable_in_map_and_dsa)
+<< getOpenMPClauseName(DSAStack->isFirstPrivate(VD) ?
+ OMPC_first
carlo.bertolli updated this revision to Diff 50829.
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Modify diff to reflect comments.
Repository:
rL LLVM
http://reviews.llvm.org/D18203
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGOpenMPR
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, fraggamuffin,
cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch implements the following aspects:
- It ex
carlo.bertolli updated this revision to Diff 50512.
carlo.bertolli added a comment.
[OPENMP] Add missing check macros in regression test and remove reference to
firstprivate (will come in next patch).
Repository:
rL LLVM
http://reviews.llvm.org/D18105
Files:
lib/CodeGen/CGOpenMPRuntime.cp
carlo.bertolli updated this revision to Diff 50489.
carlo.bertolli added a comment.
[OPENMP] Add testing for 32-bit arch
Repository:
rL LLVM
http://reviews.llvm.org/D18105
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_private_codegen.cpp
Index: test/OpenMP/target_private_cod
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, kkwli0.
carlo.bertolli added subscribers: caomhin, sfantao, arpith-jacob, fraggamuffin,
cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch adds support for codegen of private clause
carlo.bertolli added a comment.
I can actually add a regression test that checks that the compiler does not
break when using a global in a teams region, even without declare target, if
that is what is required here.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
_
carlo.bertolli added a comment.
Support for global variables in a target region requires the global to be
placed in a pragma declare target region. Pragma declare target region is not
currently available in Clang (no parsing, sema, or codegen). I will add a check
for this in the regression test
carlo.bertolli updated this revision to Diff 50187.
carlo.bertolli added a comment.
[OPENMP] This new version of the patch uses the inlining machinery of
CGOpenMPRuntime.cpp instead of just dumping the teams body statement using
EmitStmt.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Addressed comment in new version of diff.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
The support for distribute pragma is the same on host
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
Herald added a subscriber: jholewinski.
This patch imp
Author: cbertol
Date: Mon Mar 7 10:19:13 2016
New Revision: 262833
URL: http://llvm.org/viewvc/llvm-project?rev=262833&view=rev
Log:
[OPENMP] Codegen for distribute directive: fix bug in ordering of parameters.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen
Author: cbertol
Date: Mon Mar 7 10:04:49 2016
New Revision: 262832
URL: http://llvm.org/viewvc/llvm-project?rev=262832&view=rev
Log:
Reapply r262741 [OPENMP] Codegen for distribute directive
This patch provide basic implementation of codegen for teams directive,
excluding all clauses except dis
tests don't pass on Windows:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10365
On Mar 4, 2016 12:29 PM, "Carlo Bertolli via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: cbertol
Date: Fri Mar 4 14:24:58 2016
New Revision: 262741
URL: h
Author: cbertol
Date: Fri Mar 4 14:24:58 2016
New Revision: 262741
URL: http://llvm.org/viewvc/llvm-project?rev=262741&view=rev
Log:
[OPENMP] Codegen for distribute directive
This patch provide basic implementation of codegen for teams directive,
excluding all clauses except dist_schedule. It a
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262741.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262663.
Repository:
rL LLVM
http://reviews.llvm.org/D17582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Thu Mar 3 16:09:40 2016
New Revision: 262663
URL: http://llvm.org/viewvc/llvm-project?rev=262663&view=rev
Log:
[OPENMP] firstprivate and private clauses of teams, host codegeneration
Add code generation support for firstprivate and private clauses of teams on
the host. Add
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262652.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Thu Mar 3 14:34:23 2016
New Revision: 262652
URL: http://llvm.org/viewvc/llvm-project?rev=262652&view=rev
Log:
Add code generation for teams directive inside target region
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
carlo.bertolli updated this revision to Diff 48691.
carlo.bertolli added a comment.
Address latest comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP
carlo.bertolli marked 5 inline comments as done.
carlo.bertolli added a comment.
Updating patch following comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
carlo.bertolli added a comment.
Thanks - waiting for dependence http://reviews.llvm.org/D17019 before commit.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
carlo.bertolli added a comment.
Just wanted to add that tgt_target_teams needs the values for num_teams and
thread_limit because, for some accelerators, it is necessary to know those
values in advance, before teams gets actually executed. For instance, on Nvidia
GPUs we launch one CUDA block fo
carlo.bertolli updated this revision to Diff 48526.
carlo.bertolli added a comment.
Update to trunk and implement suggestions from latest review: do not make
public methods used in static function calling kmpc_for_static_init, but call
those functions in the caller that can access them.
Reposi
carlo.bertolli updated this revision to Diff 48511.
carlo.bertolli added a comment.
Update against trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codegen.cpp
carlo.bertolli updated this revision to Diff 48379.
carlo.bertolli marked 4 inline comments as done.
carlo.bertolli added a comment.
Partially address comments to replace schedule type with schedule num in
interface of static function generating call to kmpc_for_static_init. Still
waiting for up
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208
@@ -185,30 +186,24 @@
+
+public:
/// \brief Values for bit flags used in the ident_t to describe the fields.
/// All enumeric elements are named and described in accordance with the code
carlo.bertolli updated this revision to Diff 48369.
carlo.bertolli added a comment.
Addressed latest comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codege
carlo.bertolli marked 4 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431
@@ +4425,8 @@
+ SourceLocation Loc) {
+ llvm::Value *PushNumTeamsArgs[] = {
+ emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), N
carlo.bertolli updated this revision to Diff 48273.
carlo.bertolli added a comment.
Update to new version of http://reviews.llvm.org/D17148, integrating changes
from the trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPR
carlo.bertolli updated this revision to Diff 48271.
carlo.bertolli added a comment.
Update against dependence http://reviews.llvm.org/D17019.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP
carlo.bertolli updated this revision to Diff 48200.
carlo.bertolli added a comment.
Updated diff reflecting comments.
Note that having the emission of the runtime kmpc_for_static_init function in a
static function (instead of a method of CGOpenMPRuntime) required moving to
public some fields in
carlo.bertolli marked 4 inline comments as done.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2914
@@ -2713,4 +2913,3 @@
if (NT || TL) {
-NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT->getNumTeams(),
-/* IgnoreResultAssign = */ true) :
+NumTeamsVal = (NT) ? CGF.EmitSca
carlo.bertolli updated this revision to Diff 48100.
carlo.bertolli added a comment.
Address comments and rebase over new version of http://reviews.llvm.org/D17148.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
l
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-co
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction &CGF,
+SourceLocation Loc,
carlo.bertolli wrote:
> I added this
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction &CGF,
+SourceLocation Loc,
I added this because OpenMPScheduleC
carlo.bertolli set the repository for this revision to rL LLVM.
carlo.bertolli updated this revision to Diff 47995.
carlo.bertolli added a comment.
Added comment for boolean parameter.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/C
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I updated the patch to reflect the comments. I will wait for an answer to the
comment asking to split the emit function for push_num_teams. Thanks!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1009-10
carlo.bertolli updated this revision to Diff 47921.
carlo.bertolli added a comment.
Reflect changes in http://reviews.llvm.org/D17148 and show full context.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
lib/Code
carlo.bertolli updated this revision to Diff 47890.
carlo.bertolli added a comment.
Apply changes to reflect review: have a single emit outlined function call for
both parallel and teams; call push_num_teams outside of runtime class.
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMP
1 - 100 of 124 matches
Mail list logo
