[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

brad added a comment. You can close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:110 +assert(!Inputs.empty() && "Must have at least one input."); +addLTOOptions(TC, Args, CmdArgs, Output, Inputs[0], + D.getLTOMode() == LTOK_Thin); https:/

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:147 + } + + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs, Add in here.. ``` // Silence warnings when linking C code with a C++ '-stdlib' argument. Ar

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. But the rest LGTM as a start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202 + addSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/local/include")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include")); ---

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.h:81 + + unsigned GetDefaultDwarfVersion() const override { return 5; } + This just overrides the default DWARF version anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. You also have to add Serenity to clang/lib/Lex/InitHeaderSearch.cpp InitHeaderSearch::ShouldAddDefaultIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. Make use of the concat macro with the various header and library paths. https://github.com/llvm/llvm-project/commit/1d0cc510516d50c459f78896a0375fadb13a2b45 Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:78 + + if (Output.isFilename()) { +CmdArg

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. In D154396#4655494 , @ADKaster wrote: > @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I > update the phab patch series, or re-upload the set as GitHub PRs? Update the phab patch series. Repository:

[PATCH] D157896: Clang: Define macro _MIPS_SPFPSET

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f02e3bd6a5: Clang: Define macro _MIPS_SPFPSET (authored by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + UnwindTableLevel Remove the IsIntegratedAssemble

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

brad added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ abrachet wrote: > This test is broken

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brad marked 2 inline comments as not done. Closed by commit rGa3ba9d697b17: [Driver] F

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); uabelho wrote: > @brad : > I think thi

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. In D159054#4638511 , @probinson wrote: > The main thing to worry about, clearly, is what happens as the change > percolates downstream and into distros. But you probably know more about that > than I do anyhow. :) Yes, that is why

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. I was going to hold this over for a bit longer. 2 weeks and if no one says anything then go ahead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 __

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); } trungnt29

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); + addSystem

[PATCH] D159397: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a73e1eb47dd: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555794. brad edited the summary of this revision. brad added a comment. Separate out the GCC path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clan

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555785. brad added a comment. Add some C++ header path tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/tes

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555783. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Driver/haiku.c cla

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555689. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp Index: clang/lib/Driver/ToolChains/Haiku.cpp ==

[PATCH] D159414: Haiku: Fixes for header / library paths

brad created this revision. brad added reviewers: nielx, korli, kallisti5. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Some fixes for the header / library paths.. - Use concat macro for all paths - Correct t

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb70f1f836da9: Haiku: Pick up a few more codegen parametres from downstream (authored by X512 , committed by brad). Repository:

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555626. brad marked an inline comment as not done. brad added a comment. Use --target= for all additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555623. brad added a comment. Bump DWARF version to 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/test/CodeGen/

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad added a comment. Comment at: clang/lib/Driver/ToolChains/Haiku.h:39 + + unsigned GetDefaultDwarfVersion() const override { return 2; } + nielx wrote: > I propose pushing this to version 4. Haiku's GCC also defaults to version 4 > now. I was using the ve

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555622. brad added a comment. More context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/test/CodeGen/dwarf-versio

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555621. brad added a comment. Add a test for the debug handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h clang/tes

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad created this revision. brad added reviewers: nielx, korli. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Pick up a few more codegen parametres from downstream. DWARF version 2, Math Errno handling, ObjC A

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99be6b6d598f: Haiku: Enable thread-local storag, disable PIE / enable PIC by default (authored by Jerome Duval , committed b

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad updated this revision to Diff 555604. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Driver/ToolChains/Haiku.h clang/test/Driver/pic.c clan

[PATCH] D159397: [StaticAnalyzer] Use switch statement in MallocChecker::performKernelMalloc. NFC

brad created this revision. brad added reviewers: vabridgers, NoQ. brad added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. brad requested review of this revisi

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad updated this revision to Diff 64. brad added a comment. x86_64 test for TLS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Driver/ToolCh

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad created this revision. brad added reviewers: joerg, kallisti5, nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Derived from https://reviews.llvm.org/D49481, but added tests and simplified the diff a

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554567. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3476332e453: [Driver] move DragonFly header search path management to the driver (authored by brad). Changed prior to commit: https://reviews.llv

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd267990e8c53: [Driver] move ELFIAMCU / RTEMS header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo

[PATCH] D158920: Delete CloudABI support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5165593a97a0: Delete CloudABI support (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

brad updated this revision to Diff 554553. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158132/new/ https://reviews.llvm.org/D158132 Files: clang/lib/Lex/InitHeaderSearch.cpp Index: clang/lib/Lex/InitHeaderSearch

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; MaskRay wrote: > 5.0 becomes 8.0 after move? > 5.0 becomes 8.0 after move? Read wh

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. Just FYI I am not in a rush to commit this. I am posting this more so as a means of prodding for discussion of the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 _

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554156. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad created this revision. brad added reviewers: MaskRay, tstellar, probinson. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, jgravelle-google, sbc100, dschuff, emaste. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: a

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

This revision was automatically updated to reflect the committed changes. Closed by commit rG196ff0c7ddac: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths() (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159042/new/ h

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 554140. brad added a comment. Remove C_INCLUDE_DIRS bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added a comment. David? Frederic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

brad created this revision. brad added reviewers: MaskRay, kpdev42, abhina.sreeskantharajan. brad added a project: clang. Herald added subscribers: abrachet, phosek. Herald added a project: All. brad requested review of this revision. LiteOS (OHOS) and z/ZOS already have header path handling in th

[PATCH] D158920: Delete CloudABI support

brad added a comment. Looking for any feedback from the FreeBSD guys. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158920/new/ https://reviews.llvm.org/D158920 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D158920: Delete CloudABI support

brad updated this revision to Diff 553815. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158920/new/ https://reviews.llvm.org/D158920 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/Basic/Targets.cpp

[PATCH] D158946: Delete Ananas support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a105105a621: Delete Ananas support (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D158946: Delete Ananas support

brad created this revision. brad added a reviewer: MaskRay. brad added a project: LLVM. Herald added subscribers: ormris, hiraditya. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After looking at this fur

[PATCH] D158920: Delete CloudABI support

brad added a comment. Also.. # RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-cloudabi %s -o %t.o ./lld/test/ELF/aarch64-got-relocations.s // RUN: llvm-mc -filetype=obj -triple=i686-unknown-cloudabi %s -o %t.o ./lld/test/ELF/static-with-export-dynamic.s # RUN: llvm-mc -filetype=obj

[PATCH] D158920: Delete CloudABI support

brad updated this revision to Diff 553705. brad added a comment. Missed BUILD.gn, a unit test and one or two other files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158920/new/ https://reviews.llvm.org/D158920 Files: clang/docs/tools/clang-fo

[PATCH] D158920: Delete CloudABI support

brad created this revision. brad added reviewers: MaskRay, ed, dim. brad added projects: LLVM, clang. Herald added subscribers: steakhal, martong, hiraditya, krytarowski, arichardson, emaste. Herald added a reviewer: NoQ. Herald added a project: All. brad requested review of this revision. After

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad closed this revision. brad added a comment. Oops. I missed pasting the URL when commiting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158715/new/ https://reviews.llvm.org/D158715 ___ cfe-com

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 553310. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/Driver/ToolChains/Dr

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Cleanup what is left after https://reviews.llvm.org/D158461 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158715 Files

[PATCH] D158706: [Driver] Remove Myriad.cpp

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } You might as well remove this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

brad added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Driver/BUILD.gn:69 "ToolChains/CommonArgs.cpp", "ToolChains/Contiki.cpp", "ToolChains/CrossWindows.cpp", Here too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158183: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee3b2a6: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown (authored by wzssyqa, committed by brad). Herald added a project: c

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

brad added a comment. Isn't there more than this to do a full proper removal? Looking around it looks like the Ananas and Contiki support can be removed. Ananas used to use Clang but switched back to GCC and the bits there are not maintained. The Contiki support never went anywhere. Repositor

[PATCH] D158378: [Driver] move Minix header search path management to the driver

brad added a comment. In D158378#4602289 , @MaskRay wrote: > Thank you for driving the migration! > > case llvm::Triple::Minix: > AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", > "", "", "", triple); > > Th

[PATCH] D78441: Delete NaCl support

brad added a comment. In D78441#4593287 , @dschuff wrote: > Deprecation is progressing > (https://groups.google.com/a/chromium.org/g/chromium-extensions/c/v8H1UHnPotY/m/NmzrIv_VBAAJ) > but we are still supporting it on some platforms, (and using clang's

[PATCH] D158378: [Driver] move Minix header search path management to the driver

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. As has been done for other OS's. Move the header path management to the driver. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 551872. brad added a comment. Also use concat() in addLibStdCxxIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/Drago

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad created this revision. brad added a reviewer: devnexen. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. As has been done for other OS's. Move the header path management to the driver. Also I noticed with ht

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

brad created this revision. brad added reviewers: mkuper, waltl. brad added a project: clang. Herald added a project: All. brad requested review of this revision. As has been done for other OS's. Move the header path management to the driver. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa2c701b5dc0: [Driver] move Haiku header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad updated this revision to Diff 549757. brad added a comment. Removed: /boot/system/develop/headers/os/arch Added: /boot/system/develop/headers/gnu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157767/new/ https://reviews.llvm.org/D157767 File

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad created this revision. brad added a reviewer: nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Here is a first cut at moving the Haiku header search path management to the driver as has be

[PATCH] D154902: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1f8fd548f1: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D154902: [Driver] Default ToolChain::IsIntegratedAssemblerDefault to true

brad added a comment. In D154902#4487195 , @MaskRay wrote: > `[Driver]` seems more specific than `[Clang]` You're right. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154902/new/ https://reviews.ll

[PATCH] D154902: [Clang] Default ToolChain::IsIntegratedAssemblerDefault to true

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, mstorsjo, jgravelle-google, sbc100, dschuff. Herald added a project: All. brad requested review of this revision. Herald added subscribers: wangpc, aheejin. Ha

[PATCH] D148490: [AIX] use system assembler for assembly files

brad added a comment. What is left for this to be reverted, in the quest to fully enable IAS for AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-co

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

brad added inline comments. Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55 HasDotTypeDotSizeDirective = false; - UseIntegratedAssembler = false; + UseIntegratedAssembler = true; ParseInlineAsmUsingAsmParser = true; Instead of setting the value to true you

[PATCH] D147365: [HIPSPV] Remove useIntegratedAs. NFC

brad created this revision. brad added reviewers: jhuber6, ronlieb. brad added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. useIntegratedAs() is enabled if IsIntegratedAssem

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd44371c00d87: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true (authored by brad). Repository: rG LLVM Github Monorepo C

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

brad updated this revision to Diff 509084. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147030/new/ https://reviews.llvm.org/D147030 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/integrated-as.c Index: clang/test/Driver/integra

[PATCH] D147030: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead. Invert the logic and have the defaul

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9827dc1185: [Driver][NetBSD] Simplify NetBSD version handling (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://review

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad updated this revision to Diff 508376. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/test/Driver/netbsd.c clang/test/Driver/netbsd.cpp Index:

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad updated this revision to Diff 508373. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/test/Driver/netbsd.c clang/test/Driver/netbsd.cpp Index:

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

brad created this revision. brad added a reviewer: fcambus. brad added a project: clang. Herald added subscribers: fedor.sergeev, krytarowski. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. NetBSD 6.x and older is ancient. Remov

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13a10e7ec90a: [Driver][FreeBSD] Simplify ARM handling (authored by brad). Changed prior to commit: https://reviews.llvm.org/D144823?vs=500553&id=5

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad added a comment. @emaste Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

brad added a comment. In D144232#4155966 , @adalava wrote: > I agree with D144321 , sorry for the late > reply. @pkubaj and @brad , thanks for pushing it. I think D144232 > can be aba

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad updated this revision to Diff 500553. brad added a comment. Missing header part of diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144823/new/ https://reviews.llvm.org/D144823 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Driver/To

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

brad created this revision. brad added reviewers: dim, emaste. brad added a project: clang. Herald added subscribers: hiraditya, kristof.beyls, krytarowski, arichardson. Herald added a project: All. brad requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald adde

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd4eb939cae: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD… (authored by brad). Repository: rG LLVM Github Monorepo C

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

brad added a comment. In D144778#4152443 , @dim wrote: > LGTM, are there no test cases which are affected by this? The stdc++ library test for FreeBSD 9 was removed in the previous diff and I don't see anything testing the header path. Repository: r

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

brad created this revision. brad added reviewers: dim, emaste. brad added a project: clang. Herald added subscribers: krytarowski, arichardson. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. With the last diff as I was simplifying some bits

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2c0fd96757: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a… (authored by brad). Repository: rG LLVM Github Monorepo

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d585c9dd07d: [PowerPC] Use member function to determine PowerPC Secure PLT (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499222. brad added a comment. rename function and clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

brad updated this revision to Diff 499055. brad edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144341/new/ https://reviews.llvm.org/D144341 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChains/F

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/include/llvm/TargetParser/Triple.h llvm/lib/Target/Power

  1   2   3   >