[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king added a comment. Thanks rsmith! Since I do not have commit privileges, can you land this for me, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141441/new/ https://reviews.llvm.org/D141441

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king updated this revision to Diff 488021. brad.king edited the summary of this revision. brad.king added a comment. Clarify commit message Revise the message to clarify the changes are for implicitly generated members. Also link to the corresponding issue with a full URL. Repository: r

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king created this revision. Herald added a subscriber: arphaman. Herald added a project: All. brad.king requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the change from commit 15f3cd6bfc67

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

brad.king accepted this revision. brad.king added a comment. This revision is now accepted and ready to land. LGTM. After applying this patch locally on top of the release/15.x branch, CastXML builds again. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

brad.king abandoned this revision. brad.king added a comment. @rsmith thanks. > If a node is not marked invalid, that does not imply the corresponding source > code is valid. Okay, that clears up my understanding. > hook into the start and end of creating a function (so you can install your >

[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

brad.king updated this revision to Diff 113561. brad.king edited the summary of this revision. brad.king added a comment. Herald added a subscriber: mgorny. Updated diff to add a test case. https://reviews.llvm.org/D37381 Files: lib/Sema/SemaDeclCXX.cpp unittests/Sema/CMakeLists.txt unitt

[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

brad.king added a comment. > Tests? `make check` didn't regress from this. This behavior difference is not observable from within Clang itself, only in external applications that use SuppressAllDiagnostics while forcing definition of implicit members. Adding a test will require reproducing a

[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

brad.king updated this revision to Diff 113544. brad.king added a comment. Updated diff with full context. https://reviews.llvm.org/D37381 Files: lib/Sema/SemaDeclCXX.cpp Index: lib/Sema/SemaDeclCXX.cpp === --- lib/Sema/SemaDecl

[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

brad.king created this revision. In commit r303930 (Switch from using a DiagnosticTrap and a note..., 2017-05-25) use of DiagnosticErrorTrap was removed because it was no longer needed to detect whether to add a diagnostic note. However, the trap was also necessary to correctly detect and mark in