[PATCH] D120254: [OpenCL] Align subgroup builtin guards

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif --

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status

azabaznov accepted this revision. azabaznov added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119719/new/ https://reviews.llvm.org/D119719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D119719: [Docs][OpenCL] Update OpenCL 3.0 status on release 14

azabaznov added inline comments. Comment at: clang/docs/OpenCLSupport.rst:395 ++--+-+-+--+--

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb1a33bec7c: [OpenCL] Adjust diagnostic for subgroup support. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://re

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov updated this revision to Diff 407856. azabaznov added a comment. Use existing diagnostics; add the comment that device can support extension but not the feature. Will follow up if we need explicit mention in the language spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4bd70f769: [OpenCL] Add support of language builtins for OpenCL C 3.0 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. > There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we > need this check to preserve the existing behavior indeed. Thanks. The other test is `SemaOpenCL/clang-builtin-version.cl`. > But it might be worth asking someone outside of the OpenCL co

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 407823. azabaznov added a comment. Rename language mode for device side enqueue builtins; add the comment that device side enqueue builtins are not supported until OpenCL 2.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. @Anastasia @svenvh ping. Just a kind reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 ___ cfe-commits mailing list cfe-commi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov marked 4 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 406434. azabaznov added a comment. Check only against specific language option, remove unused LanguageIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: c

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov added a comment. It seems hard to find a direct mention in the spec, but in the API spec: //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device supports independent forward progress of sub-groups, CL_FALSE otherwise. This query must return CL_TRUE for devices t

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL C 3.0 __opencl_c_subgroups feature is slight

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 405921. azabaznov added a comment. Reimplement with checking language options only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Bas

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 404511. azabaznov added a comment. Remove no longer required comment in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Basic

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenCL

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5de66c4c50b: [OpenCL] Add support of __opencl_c_device_enqueue feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:2 // RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL1.2 -// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL3.0 -cl-ext=-__o

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 402873. azabaznov added a comment. Add expected-no-diagnostics, fix misprint in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 Files: clang/include/clang/B

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 399269. azabaznov added a comment. Rebase, remove extra 'verify' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values Anastasia wrote: > Anastasia wrote: > > I can't remember if we have d

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov marked 3 inline comments as done. azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/invalid-device-enqueue-types-cl3.0.cl:5 +void f() { + clk_event_t e; + queue_t q; Anastasia wrote: > I know that many test have prefix "invalid" but I

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov updated this revision to Diff 395390. azabaznov added a comment. Simplified running lines in tests, use 'verify' when validating features, simplify condition in Sema Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://revie

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov abandoned this revision. azabaznov added a comment. Now program scope global variables are required by device enqueue in the spec, new patch for device enqueue support: https://reviews.llvm.org/D115640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of __opencl_c_generic

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto &OpenCLFeaturesMap = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > Anastasia wrote: > > What test case covers this change? It feels

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. Herald added a subscriber: Naghasan. > How about we clarify with Khronos whether it would be sufficient to add a > restriction like: > >> Program scope blocks are only supported when program scope variables feature >> is supported. That's sounds good to me. Especially

[PATCH] D108392: [OpenCL] Fix parsing of opencl-c.h in CL 3.0 with device-scope atomics enabled

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:114 +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_device, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTIO

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. @Anastasia, @yaxunl, do you think it's possible to refactor code generation for blocks such that block literal for global blocks (with no captures) would be emitted in constant address space? Now it's emitted in global address space (for example @__block_literal_globa

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, yaxunl, svenvh. Herald added a subscriber: ldrumm. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of __opencl_c_generic_address_

[PATCH] D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment.

azabaznov created this revision. azabaznov added reviewers: aaron.ballman, Anastasia, svenvh. Herald added subscribers: dexonsmith, kerbowa, sunfish, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. azabaznov requested review of this revision. Herald added subscribers: cfe-

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109320/new/ https://reviews.llvm.org/D109320 ___ cfe-commits mailing lis

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

azabaznov added a comment. Yeah, this looks good. Thanks! Please notify when this is ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/ https://reviews.llvm.org/D107318 ___ cfe-comm

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e124ff25681: [OpenCL] Replace test for pipe struct to test it with fixed triple (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10717

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

azabaznov updated this revision to Diff 363155. azabaznov added a comment. Restore original test name which was changed in D106748 , use check-prefixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107176/new/ htt

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

azabaznov created this revision. azabaznov added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rGacc58504952f: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107154/new/ htt

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added a comment. > We might need to fix the target triple in > clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl to avoid surprises with testing > but it has better coverage if we don't though... Yeah, I am not sure now though. It's awful because testing is not deterministic as we have di

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added a comment. @airlied, can you please fix that to something like here https://godbolt.org/z/3Kbso8ca3? What currently we do have with your patch is that generic address space overload is always selected, but more strict overloading always exist in OpenCL C 3.0 (https://godbolt.org

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 363044. azabaznov added a comment. Fix doubling run lines, misprint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107154/new/ https://reviews.llvm.org/D107154 Files: clang/include/clang/Basic/LangOptions.d

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, dexonsmith, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'pipe' keyword is introduced in OpenCL C 2.0: so

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added a comment. Reverted it due too suspicious failing: error: 'error' diagnostics expected but not seen: File /home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl Line 8: type '__global write_only pipe int ({{(void)?}})' can only b

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13303 #endif +#elif __OPENCL_C_VERSION__ >= CL_VERSION_3_0 +void __ovld atomic_init(volatile __global atomic_int *object, int value); Sorry, I overlooked that. Not //elif//, just //if// as

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362955. azabaznov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106748/new/ https://reviews.llvm.org/D106748 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Basic/OpenC

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16a4fcbe510: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13304 +#else +void __ovld atomic_init(volatile __global atomic_int *object, int value); +void __ovld atomic_init(volatile __local atomic_int *object, int value); These new atomics with glob

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov updated this revision to Diff 362018. azabaznov added a comment. Herald added a subscriber: dexonsmith. Preserve existing diagnostic with `err_opencl_unknown_type_specifier`, fix comments for language option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154 "'%2' %select{type qualifier|storage class specifier}3">; +def err_opencl_type_specifier_requires : Error< + "%select{type qualifier|storage class specifier}0 '%1' requires " -

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'pipe' keyword is introduced in OpenCL C 2.0: so do checks fo

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov updated this revision to Diff 361155. azabaznov added a comment. Unify with `err_opencl_requires_extension`. Infrastructure for getting aliased extensions seems to messy and doesn't seem worth it yet since there are only two cases of such functionality (fp64 and 3d image writes) :( R

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

azabaznov added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK ---

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

azabaznov added a comment. You also need to guard //memory_order_seq_cst// enum entry. Note that //memory_order_acq_rel// is always defined as it can be used in //atomic_work_item_fence()// built-in function, AFAIR in all other cases if //memory_order_acq_rel// is used without //__opencl_c_atom

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov updated this revision to Diff 359734. azabaznov added a comment. Change diagnostic output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106260/new/ https://reviews.llvm.org/D106260 Files: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1732-1734 +// __opencl_c_3d_image_writes feature. OpenCL C v3.0 API s4.2 - For devices +// that support OpenCL 3.0, cl_khr_3d_image_writes must be returned when and +// only when the optional fe

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eb59e1d0ea: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro (authored by azabaznov). Repository: rG LLVM Github

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 358909. azabaznov added a comment. Restructured test a little Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOptions.h c

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) || defined(__ope

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03d8fed34951: [OpenCL] Add verbosity when checking support of read_write images (authored by azabaznov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

azabaznov updated this revision to Diff 358265. azabaznov added a comment. Add comment for C++ for OpenCL, add variable to check support for OpenCL C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892 Files:

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412 +!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", + S.getLangOpts( || DeclTy->isPipeType()) { ---

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

azabaznov created this revision. azabaznov added reviewers: Anastasia, thakis. Herald added a reviewer: aaron.ballman. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGab76101f40f8: [OpenCL] Add support of __opencl_c_read_write_images feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10491

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 358236. azabaznov added a comment. Update test after generic AS was merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCL

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG78463ebde2f8: [OpenCL] Add support of __opencl_c_generic_address_space feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov updated this revision to Diff 355890. azabaznov added a comment. Fixed naming of new methods, fixed comments, removed redundant comments from source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://reviews.llvm.org/

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 355884. azabaznov added a comment. Fixed latest comment about checking for `== 300`. Btw, there already exists a few places where `>= 300` is checked. Should fix them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov updated this revision to Diff 355873. azabaznov added a comment. Added FIXME. Alternatively, we could add this language option only in `::adjust` if there is still a worry about multiple places of definitions. Btw, there will some more language options which dependent on target setting

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov updated this revision to Diff 355853. azabaznov added a comment. Addressed latest review comments, also refactored the patch by putting diagnostics into OpenCLOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://revi

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGa42739055835: [OpenCL] Add support of __opencl_c_images feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ htt

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 352723. azabaznov added a comment. Restructured test, added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOption

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov updated this revision to Diff 352681. azabaznov added a comment. Set SPIR target for added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 Files: clang/lib/Sema/SemaType.cpp clang/test/

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Thanks for working on this! That's cool, I managed to reproduce something similar to https://reviews.llvm.org/D99577. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s Anastasia wrote: > svenvh wro

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

azabaznov added a comment. In D97869#2807654 , @svenvh wrote: > In D97869#2807627 , @azabaznov wrote: > >> @svenvh, are you going to add header-like output emitting? > > Yes, I can add that if there is interest. I

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

azabaznov added a comment. @svenvh, are you going to add header-like output emitting? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov added a comment. In D102853#2773890 , @Anastasia wrote: > LGTM! Although I think it would be better if we set `__IMAGE_SUPPORT__` > conditionally also for earlier OpenCL versions. It has always been defined for SPIR target only. Should we wait

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:22 +extern generic float g_generic_extern_var; +#ifndef __opencl_c_program_scope_global_variables +// expected-error@-17 {{program scope variable must reside in constant address space}} --

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mono

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826905787ae4: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/CodeGenOpenCL/printf.cl:9 -#ifdef cl_khr_fp64 +#if defined(cl_khr_fp64) || defined(__opencl_c_fp64) typedef __attribute__((ext_vector_type(2))) double double2;

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346380. azabaznov added a comment. Drop one more formatting change from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files: clang/docs/OpenCLSupport.rst

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346379. azabaznov added a comment. Drop formatting changes from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files: clang/docs/OpenCLSupport.rst clang

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 345846. azabaznov edited the summary of this revision. azabaznov added a comment. Rebase after https://reviews.llvm.org/D100976; addressed review comments and updated docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:306 +// Set conditionally to provide correct diagnostics for 'double' type +llvm::StringRef FP64Feature( +getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64"); ---

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if 'cl_k

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 343417. azabaznov added a comment. Rebased to use `::validateOpenCLTarget`. Decided to use explicit simulatneous extensions/feature disabling in command line due to API spec limitations: clGetDeviceInfo: Will not describe support for the cl_khr_3d_image_wr

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me in general. See a comment. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires

  1   2   3   >