https://github.com/TIFitis closed
https://github.com/llvm/llvm-project/pull/124746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 610953fa4f0b6b93549bdaf1ac6e317a34551f93 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/8] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/124746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis closed
https://github.com/llvm/llvm-project/pull/110001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/110001
>From 17ae5d768dc5ee113c4e859273706cb8e11f46e9 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Wed, 25 Sep 2024 16:06:36 +0100
Subject: [PATCH 1/3] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from
Clan
@@ -9041,257 +9041,65 @@ void CGOpenMPRuntime::emitUserDefinedMapper(const
OMPDeclareMapperDecl *D,
return;
ASTContext &C = CGM.getContext();
QualType Ty = D->getType();
- QualType PtrTy = C.getPointerType(Ty).withRestrict();
- QualType Int64Ty = C.getIntTypeForBitwi
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/110001
>From a1571146327672558c765248d5c5d972bfa24775 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Wed, 25 Sep 2024 16:06:36 +0100
Subject: [PATCH 1/2] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from
Clan
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/110001
>From 387ac88d84d7fd56d3e36b6703e6c08d2dc908fc Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Wed, 25 Sep 2024 16:06:36 +0100
Subject: [PATCH 1/2] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from
Clan
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/110001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2801,6 +2801,67 @@ class OpenMPIRBuilder {
using GenMapInfoCallbackTy =
function_ref;
+private:
+ /// Emit the array initialization or deletion portion for user-defined mapper
+ /// code generation. First, it evaluates whether an array section is mapped
+ /// an
TIFitis wrote:
@jdoerfert @jsjodin Polite request for review :)
https://github.com/llvm/llvm-project/pull/110001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@jdoerfert @jsjodin Polite request for review :)
https://github.com/llvm/llvm-project/pull/110001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/110001
This patch migrates the OpenMP UserDefinedMapper codegen from Clang to the
OpenMPIRBuilder. I will be adding further patches in the near future so that
OpenMP dialect in MLIR can make use of these.
>From 387ac
https://github.com/TIFitis approved this pull request.
Thanks for the fix. LGTM.
I've also added some changes in #100364 which should fix some other places
where debug info was being incorrectly propagated.
https://github.com/llvm/llvm-project/pull/100358
__
https://github.com/TIFitis closed
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@jdoerfert Kind reminder for review. Thanks.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
Ping for review 😄
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -607,15 +621,17 @@ class OpenMPIRBuilder {
/// Generator for '#omp barrier'
///
/// \param Loc The location where the barrier directive was encountered.
- /// \param DK The kind of directive that caused the barrier.
+ /// \param Kind The kind of directive that caused
TIFitis wrote:
> Not super familiar with the work here, but could we maybe split it as - one
> patch for OpenMPIRBuilder changes with tests in OpenMPIRBuilderTest.cpp and
> then second patch for the clang changes to use those OpenMPIRBuilder changes?
> Would the CI tests cause issues?
Only th
TIFitis wrote:
> This patch is huge, and just skimming over it shows various places that could
> be split off, and others that should not make it to the review stage
> (commented out code). Please update.
Hi, thanks for talking the time out to review the patch.
I've addressed the comments you
@@ -99,14 +100,20 @@ class OpenMPIRBuilderConfig {
/// expanded.
std::optional IsGPU;
- // Flag for specifying if offloading is mandatory.
+ /// Flag for specifying if LLVMUsed information should be emitted.
+ std::optional EmitLLVMUsed;
TIFitis wrote:
@@ -607,15 +621,17 @@ class OpenMPIRBuilder {
/// Generator for '#omp barrier'
///
/// \param Loc The location where the barrier directive was encountered.
- /// \param DK The kind of directive that caused the barrier.
+ /// \param Kind The kind of directive that caused
@@ -145,6 +145,8 @@ static bool
isValidWorkshareLoopScheduleType(OMPScheduleType SchedType) {
}
#endif
+Function *GLOBAL_ReductionFunc = nullptr;
TIFitis wrote:
We don't need this for now, I've removed it.
https://github.com/llvm/llvm-project/pull/80343
___
@@ -2096,15 +2102,1408 @@ OpenMPIRBuilder::createSection(const
LocationDescription &Loc,
/*IsCancellable*/ true);
}
-/// Create a function with a unique name and a "void (i8*, i8*)" signature in
-/// the given module and return it.
-Function *get
TIFitis wrote:
@jsjodin @jdoerfert Hi, this patch has been sitting for a while now. Would be
great to get it reviewed and accepted. Thanks.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
> I don't remember exactly the test (added them more than 5 years ago), but
> both UDR and non-trivial constructors should be supported. I just remember
> that there were some limitations for UDR for NVPTX, like trivial UDR
> operations to use NVPTX fast builtins.
As long we ha
TIFitis wrote:
> Some comments inlined.
I've addressed these in the latest commit.
> Do we support non trivial constructors for reduction variables? Similarly,
> did we support user defined reductions? If either questions is answered with
> yes, do we keep that support?
>
> We might need to
@@ -0,0 +1,1071 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex
"__omp_offloading_[0-9a-z]+_[0-9a-z]+" "reduction_size[.].+[.]"
"pl_cond[.].+[.|,]" --prefix-filechec
TIFitis wrote:
@jdoerfert @jsjodin polite ping for review.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@alexey-bataev I've added the test clang/test/OpenMP/reduction_complex.c to
this PR. I tried to add the checks based on the other similar tests in the
directory, let me know if it needs any changes.
https://github.com/llvm/llvm-project/pull/80343
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@alexey-bataev I'm facing issues adding the test to Clang tests as it uses the
complex.h header files. From what I can tell header files don't seem to be
supported. Is there any way to add the test you provided to the Clang tests or
a different one which can still check for the
TIFitis wrote:
@jsjodin @jdoerfert I have now added the missing support for complex variable
reductions. Please let me know if this patch requires any other changes.
Thanks.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
TIFitis wrote:
Thanks @alexey-bataev for the test. It does hit the complex scenario.
I'll close this PR and add that test in another PR.
https://github.com/llvm/llvm-project/pull/82497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/TIFitis closed
https://github.com/llvm/llvm-project/pull/82497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/82497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/82497
This patch removes the complex reduction variables codegen. There are currently
no tests for this, and from playing around with some complex reduction variable
test cases the code seems unreachable.
The PR #803
TIFitis wrote:
Ping for review :)
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2051,36 +2057,1424 @@ OpenMPIRBuilder::createSection(const
LocationDescription &Loc,
/*IsCancellable*/ true);
}
-/// Create a function with a unique name and a "void (i8*, i8*)" signature in
-/// the given module and return it.
-Function *get
TIFitis wrote:
With the latest changes the build bots are all clean now. Let me know if there
are any further changes required for this patch to go through.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists
TIFitis wrote:
Yup, code generated is identical, except for the align issue I've highlighted
and some cast instructions being moved around. Also no TBAA Info.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lis
@@ -2042,35 +2057,1378 @@ OpenMPIRBuilder::createSection(const
LocationDescription &Loc,
/*IsCancellable*/ true);
}
-/// Create a function with a unique name and a "void (i8*, i8*)" signature in
-/// the given module and return it.
-Function *get
@@ -2719,10 +4051,24 @@ getKmpcForStaticLoopForType(Type *Ty, OpenMPIRBuilder
*OMPBuilder,
static void createTargetLoopWorkshareCall(
OpenMPIRBuilder *OMPBuilder, WorksharingLoopType LoopType,
BasicBlock *InsertBlock, Value *Ident, Value *LoopBodyArg,
-Type *Parall
TIFitis wrote:
> There is some code that is related to Flang/MLIR that shouldn't be in the
> patch. e.g. ReductionInfoManager is not used anywhere. I am currently working
> on a patch that refactors this code a bit and how it is used in the MLIR
> lowering.
Thanks for pointing this out, I've
TIFitis wrote:
@jsjodin This PR only has the migration work. Flang/MLIR is left unchanged
other than the few necessary changes.
Once this patch is merged, I'll put up a PR for having MLIR use these additions.
https://github.com/llvm/llvm-project/pull/80343
_
@@ -36,14 +36,14 @@ void test() {
// CHECK1-NEXT:[[DYN_PTR_ADDR:%.*]] = alloca ptr, align 8
// CHECK1-NEXT:[[DOTZERO_ADDR:%.*]] = alloca i32, align 4
// CHECK1-NEXT:[[DOTTHREADID_TEMP_:%.*]] = alloca i32, align 4
-// CHECK1-NEXT:store ptr [[DYN_PTR]], ptr [[DYN_
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2953,7 +2953,7 @@ int bar(int n){
// CHECK3-NEXT:[[TMP8:%.*]] = getelementptr inbounds
[[STRUCT__GLOBALIZED_LOCALS_TY_0:%.*]], ptr [[TMP4]], i32 [[TMP5]]
// CHECK3-NEXT:[[C:%.*]] = getelementptr inbounds
[[STRUCT__GLOBALIZED_LOCALS_TY_0]], ptr [[TMP8]], i32 0, i32
https://github.com/TIFitis approved this pull request.
Thanks for the fix and also adding a test🙂
LGTM 👍🏽
https://github.com/llvm/llvm-project/pull/70268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
Author: Akash Banerjee
Date: 2023-08-16T16:35:28+01:00
New Revision: 5d9ccd7a96930351519ccbe5f85b127faa0dda9a
URL:
https://github.com/llvm/llvm-project/commit/5d9ccd7a96930351519ccbe5f85b127faa0dda9a
DIFF:
https://github.com/llvm/llvm-project/commit/5d9ccd7a96930351519ccbe5f85b127faa0dda9a.diff
Author: Akash Banerjee
Date: 2023-07-12T12:03:28+01:00
New Revision: 227012cbd71f7f55c9f28f561a069628a964a97a
URL:
https://github.com/llvm/llvm-project/commit/227012cbd71f7f55c9f28f561a069628a964a97a
DIFF:
https://github.com/llvm/llvm-project/commit/227012cbd71f7f55c9f28f561a069628a964a97a.diff
Author: Akash Banerjee
Date: 2023-07-05T14:56:45+01:00
New Revision: 07630da36a31596594a1ba3b9f000dc57d5382f3
URL:
https://github.com/llvm/llvm-project/commit/07630da36a31596594a1ba3b9f000dc57d5382f3
DIFF:
https://github.com/llvm/llvm-project/commit/07630da36a31596594a1ba3b9f000dc57d5382f3.diff
Author: Akash Banerjee
Date: 2023-07-05T14:03:54+01:00
New Revision: 4a49226537abafc9b372ba8ef61d14a817a5226a
URL:
https://github.com/llvm/llvm-project/commit/4a49226537abafc9b372ba8ef61d14a817a5226a
DIFF:
https://github.com/llvm/llvm-project/commit/4a49226537abafc9b372ba8ef61d14a817a5226a.diff
Author: Akash Banerjee
Date: 2023-06-30T16:03:57+01:00
New Revision: a5ea6760674762cb597cf328dc467f1296633da0
URL:
https://github.com/llvm/llvm-project/commit/a5ea6760674762cb597cf328dc467f1296633da0
DIFF:
https://github.com/llvm/llvm-project/commit/a5ea6760674762cb597cf328dc467f1296633da0.diff
Author: Akash Banerjee
Date: 2023-06-30T15:12:28+01:00
New Revision: 0d8d718171192301f2beb10bd08ce62e70281a5e
URL:
https://github.com/llvm/llvm-project/commit/0d8d718171192301f2beb10bd08ce62e70281a5e
DIFF:
https://github.com/llvm/llvm-project/commit/0d8d718171192301f2beb10bd08ce62e70281a5e.diff
Author: Akash Banerjee
Date: 2023-06-12T15:43:09+01:00
New Revision: 3401a5f7584a2f12a90a7538aee2ae37038c82a9
URL:
https://github.com/llvm/llvm-project/commit/3401a5f7584a2f12a90a7538aee2ae37038c82a9
DIFF:
https://github.com/llvm/llvm-project/commit/3401a5f7584a2f12a90a7538aee2ae37038c82a9.diff
Author: Akash Banerjee
Date: 2023-05-04T16:51:06+01:00
New Revision: 35309db7dcefde20180e924df303f65a14d97d68
URL:
https://github.com/llvm/llvm-project/commit/35309db7dcefde20180e924df303f65a14d97d68
DIFF:
https://github.com/llvm/llvm-project/commit/35309db7dcefde20180e924df303f65a14d97d68.diff
Author: Akash Banerjee
Date: 2023-03-20T18:48:21Z
New Revision: 2d373e4dc7e97b0b2d7022d8d04e64834204187c
URL:
https://github.com/llvm/llvm-project/commit/2d373e4dc7e97b0b2d7022d8d04e64834204187c
DIFF:
https://github.com/llvm/llvm-project/commit/2d373e4dc7e97b0b2d7022d8d04e64834204187c.diff
LOG
Author: Akash Banerjee
Date: 2023-01-08T16:45:43Z
New Revision: 310eea1c78e3e7aac7c016ab9bdf00d04f354645
URL:
https://github.com/llvm/llvm-project/commit/310eea1c78e3e7aac7c016ab9bdf00d04f354645
DIFF:
https://github.com/llvm/llvm-project/commit/310eea1c78e3e7aac7c016ab9bdf00d04f354645.diff
LOG
Author: Akash Banerjee
Date: 2022-11-14T17:18:10Z
New Revision: 87f652d31f6dcb493e4e3290d694e52c092cecb1
URL:
https://github.com/llvm/llvm-project/commit/87f652d31f6dcb493e4e3290d694e52c092cecb1
DIFF:
https://github.com/llvm/llvm-project/commit/87f652d31f6dcb493e4e3290d694e52c092cecb1.diff
LOG
Author: Akash Banerjee
Date: 2022-11-02T18:54:25Z
New Revision: a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc
URL:
https://github.com/llvm/llvm-project/commit/a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc
DIFF:
https://github.com/llvm/llvm-project/commit/a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc.diff
LOG
64 matches
Mail list logo
