================ @@ -607,15 +621,17 @@ class OpenMPIRBuilder { /// Generator for '#omp barrier' /// /// \param Loc The location where the barrier directive was encountered. - /// \param DK The kind of directive that caused the barrier. + /// \param Kind The kind of directive that caused the barrier. /// \param ForceSimpleCall Flag to force a simple (=non-cancellation) barrier. /// \param CheckCancelFlag Flag to indicate a cancel barrier return value /// should be checked and acted upon. + /// \param ThreadID Optional parameter to pass in any existing ThreadID value. /// /// \returns The insertion point after the barrier. - InsertPointTy createBarrier(const LocationDescription &Loc, omp::Directive DK, - bool ForceSimpleCall = false, - bool CheckCancelFlag = true); + InsertPointTy createBarrier(const LocationDescription &Loc, + omp::Directive Kind, bool ForceSimpleCall = false, + bool CheckCancelFlag = true, + Value *ThreadID = nullptr); ---------------- TIFitis wrote:
Thanks for clearing this up. I've updated the PR with the changes. I couldn't do it as a pre-commit as it relies on changes from this PR to use the OpenMPIRBuilder createBarrier func and the changes aren't trivially portable. However, it has only required updating 5 clang tests and the differences are minimal. Thanks for the the hard work reviewing this patch so far :) https://github.com/llvm/llvm-project/pull/80343 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits