[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. Fixed it in https://reviews.llvm.org/D138266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. This introduced a dependency cycle: .-> @llvm-project//llvm:Analysis (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | @llvm-project//llvm:ProfileData (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | | @llvm-project//llvm:Symboliz

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

akuegel added a comment. It seems this change triggers a warning: https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 llvm-project/llvm/lib/Transforms/Utils/CodeExtractor.cpp:901:15: error: enumeration value 'PresplitCoroutine' not handled in swit

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcc344d262a2e: [clang] Add static_cast to fix Bazel build. (authored by akuegel). Repository: rG LLVM Github Monorepo C

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

akuegel created this revision. Herald added a project: All. akuegel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124995 Files: clang/lib/ExtractAPI/ExtractAPIConsumer.cp

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

akuegel added a comment. Yes, I believe the issue with the circular dependency was already fixed by my latest commit. Sorry for first committing the wrong fix (just removing the headers without checking that they were needed to pull in raw_ostream header transitively). So if you apply my fix, y

[PATCH] D51650: Implement target_clones multiversioning

akuegel added a comment. Since it is not clear whether the semantic change was intended, I think it makes sense to revert the patch for now. If it is intended, it might be good to mention it in the change description, so that people are warned. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

akuegel added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:381 + (IsNolintBegin ? "END" : "BEGIN") + "' comment"; + Error.Message = tooling::DiagnosticMessage(Message.str(), SM, Loc); return Error;

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

akuegel added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:15 +#include "llvm/ADT/StringRef.h" +#include "llvm/Option/ArgList.h" +#include "llvm/Support/Error.h" Would it be possible to avoid the usage of ArgList in a target that belongs

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

akuegel added a comment. It seems this patch caused a test failure in MLIR: test/Target/LLVMIR/llvm-intrinsics.mlir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107349/new/ https://reviews.llvm.org/D107349

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

akuegel added a comment. Already landed as https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022, I will close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760 __

[PATCH] D107760: [lldb] Fix warning -Wnon-virtual-dtor.

akuegel created this revision. akuegel added a reviewer: bkramer. akuegel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When making the emit function virtual, the destructor needs to become virtual as well. Repository: rG LLVM Github

[PATCH] D76272: Fix memtag test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5156e38eb1d3: Fix memtag test. (authored by akuegel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/ https://reviews.llvm.org/D76272 Files: clan

[PATCH] D76272: Fix memtag test.

akuegel created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akuegel added a reviewer: bkramer. bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds