[PATCH] D107760: [lldb] Fix warning -Wnon-virtual-dtor.

[Adrian Kuegel via Phabricator via cfe-commits]

akuegel created this revision.
akuegel added a reviewer: bkramer.
akuegel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

When making the emit function virtual, the destructor needs to become
virtual as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107760

Files:
  clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp


Index: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
===================================================================
--- clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
+++ clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
@@ -238,6 +238,7 @@
 public:
   OpenCLBuiltinFileEmitterBase(RecordKeeper &Records, raw_ostream &OS)
       : Records(Records), OS(OS) {}
+  virtual ~OpenCLBuiltinFileEmitterBase() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
@@ -307,6 +308,7 @@
 public:
   OpenCLBuiltinTestEmitter(RecordKeeper &Records, raw_ostream &OS)
       : OpenCLBuiltinFileEmitterBase(Records, OS) {}
+  virtual ~OpenCLBuiltinTestEmitter() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.



Index: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
===================================================================
--- clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
+++ clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
@@ -238,6 +238,7 @@
 public:
   OpenCLBuiltinFileEmitterBase(RecordKeeper &Records, raw_ostream &OS)
       : Records(Records), OS(OS) {}
+  virtual ~OpenCLBuiltinFileEmitterBase() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
@@ -307,6 +308,7 @@
 public:
   OpenCLBuiltinTestEmitter(RecordKeeper &Records, raw_ostream &OS)
       : OpenCLBuiltinFileEmitterBase(Records, OS) {}
+  virtual ~OpenCLBuiltinTestEmitter() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits