[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

adamcz added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358 +// Returns^ +const char *findPathInURI(const char *S) { + // Skip over scheme. Is there a reason why you're doing this with manual manipulation of C-strings instea

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:6960 +if (ParamType.isNull()) + return ExprError(); // CheckNonTypeTemplateParameterType will produce a diagnost

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:898 +if (isCancelled()) { + log("ASTWorker skipping update {0} for file {1}", Inputs.Version, + FileName); I'd add something like "due to cancellation". I know yo

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b2fed3ab419: [clangd] Upgrade vlog() to log() for preamble build stats (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:555 if (BuiltPreamble) { -vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds", +log("Built preamble of size {0} for file {1} version {2} in {3} seconds", Bui

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is v

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab3cfd013cf: [clang] Do not crash on "requires" after a fatal error occurred. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz added inline comments. Comment at: clang/test/SemaCXX/concept-fatal-error.cpp:8 + // We test that we do not crash in such cases (#55401) + int i = requires { { i } f } // expected-error {{expected ';' at end of declaration list}} + ilya-biryukov wrote:

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz updated this revision to Diff 444315. adamcz added a comment. improved the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new/ https://reviews.llvm.org/D129499 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/SemaCXX/concept-

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz created this revision. adamcz added a reviewer: ilya-biryukov. Herald added a project: All. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code would assume that SubstExpr() cannot fail on concept specialization. This is

[PATCH] D127749: [clangd] Wire up compilation for style blocks

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Wait, what? How? Whaaat? How did that happen? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127749/new/ https://reviews.llvm.org/D12774

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad46aaede6e4: [clangd] Add beforeExecute() callback to FeatureModules. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

adamcz updated this revision to Diff 424215. adamcz marked 5 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124176/new/ https://reviews.llvm.org/D124176 Files: clang-tools

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:373 + } + llvm::StringRef filePath() const { return File->getFilePath(); } + llvm::StringRef memoryContents() co

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It runs i

[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:500 + if (Stats != nullptr) { +Stats->TotalBuildTime = PreambleTimer.getTime(); This is a significant change. You are now exporting this information for failed preamble builds

[PATCH] D122894: [clangd] Record IO precentage for first preamble build of the instance

adamcz added a comment. Thanks, I was just about to fix that! Comment at: clang-tools-extra/clangd/TUScheduler.cpp:115 bool IsFirstPreamble) { - static llvm::once_flag OnceFlag; - llvm::call_once(OnceFlag, [&] { + auto RecordWithLabel = [&Stats](llv

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e459126185f: [clang] Do not crash on arrow operator on dependent type. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. Thanks for all the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 418219. adamcz marked an inline comment as done. adamcz added a comment. added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 Files: clang/lib/Sema/TreeTr

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. In D121824#3399208 , @sammccall wrote: > I reduced something very similar recently as > https://github.com/clangd/clangd/issues/1073 > > This patch does not fix it, but looks closely related, want to take a look? Very similar. My

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 417331. adamcz added a comment. Reverted to previous version + new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 Files: clang/lib/Sema/TreeTransform.h clang

[PATCH] D122102: [clangd] Introduce "add subclass" tweak

adamcz added a comment. Thanks, this looks really good! I always wanted a code action like this. I always envisioned this as a code action on a class to implement missing virtual methods though. The idea would be: class Foo : public B^ar { }; expands into: class Foo : public Bar { int baz

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6009d0d5801d: [clangd] Track time spent in filesystem ops during preamble builds (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 417006. adamcz marked an inline comment as done. adamcz added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tools-extra/clangd

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added inline comments. Comment at: clang-tools-extra/clangd/FS.h:91 +IntrusiveRefCntPtr +getTimeTrackingFS(std::shared_ptr Timer, + IntrusiveRefCntPtr FS); kadircet wrote: > adamcz wrote: > > kadircet wrote: > > > kadircet wrote: > > > > i

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 416964. adamcz marked 3 inline comments as done. adamcz added a comment. more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tools-extr

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. Thanks! I updated the change. Let me know if this is what you had in mind. I kept the original test too, can't hurt right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 416561. adamcz added a comment. changed to marking VarDecl as invalid if it's ref type and initializer is invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 File

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added a comment. In D121712#3383944 , @Trass3r wrote: > Hmm just a few curious questions from the sidelines. > Why a "custom system" instead of something -ftime-trace based? I'm not sure if I understand. -ftime-trace is a one-off. I want to monito

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 415919. adamcz marked 12 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tool

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added a project: All. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121824 Files: clang/lib/S

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extr

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f4ea36bfe4c: [clang] Improve laziness of resolving module map headers. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang has support for lazy headers in module maps - if size and/or modtime and provided in the cppmap file, headers are

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55a79318c60d: [clang][clangd] Improve signature help for variadic functions. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Added a slightly awkward clang (not clangd) test. The output is suboptimial, because it's not clangd, but it shows things work as they should. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929 +// +// This only matters for variad

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 388167. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments, added new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 File

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for con

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Sorry for trouble, I will revert this for now. It's only the test that's causing the problem, the fix is fine, as far as I can tell. Still, better revert the whole thing for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG581a6a8118f5: [clang] Fix armv7-quick build by hardcoding -triple=

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test was added in 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2b1bdb4c8a: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. The call to getTypeSizeInChars() is replaced wi

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10617 +// copying the data, which is wasteful. +for (const unsigned N : {1u, FinalSize}) { + unsigned OldElts = Value->getArrayInitializedElts(); kadircet wrote: > maybe unroll

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz updated this revision to Diff 385102. adamcz marked an inline comment as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.org/D113120 Files: clang/lib/AST/ExprCon

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before). Comment at: clang/lib/Sema/SemaOverload.cpp:6460 // l

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 385071. adamcz added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG97fbc975fab1: [clangd] Find definition of ClassTemplate without going through index. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1130

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you thi

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this commit, on code like: struct S { ... }; S arr[1000]; while checking if arr is constexpr, clang wou

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I noticed that, while go-to-def works

[PATCH] D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112628 Files: clan

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2174524116a8: [clangd] AddUsing: Fix support for template specializations. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8f4a0118914: [clangd] Fix a hover crash on templated spaceship operator. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ ht

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz updated this revision to Diff 382335. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz removed a reviewer: usaxena95. adamcz added a comment. Thanks Kadir! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 ___ cfe-commits mailing list cfe-com

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz updated this revision to Diff 382326. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ https://reviews.llvm.org/D112527 Files: clang-tools-extra/cla

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Before this change, we would add "using std::vector" instead of

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, yaxunl. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We make assumption that: getDe

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e88ac3: [clangd] Add code completion of param name on /* inside function calls. (authored by adamcz). Repository: rG LLVM Github Monorepo C

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1963 +auto OffsetBeforeComment = *Offset - 2; +return codeCompleteComment(FileName, OffsetBeforeComment, Preamble, + ParseInput); kadircet wr

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 380636. adamcz marked an inline comment as done. adamcz added a comment. final review comment (dropped Preamble check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Fix LGTM As for the test, I suggest putting it in clang/test/AST/, maybe in ast-dump-constant-expr? You can write a CHECK-NEXT: thingy to verify that consteval is preserved. The test already

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfba563e92b64: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/n

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz updated this revision to Diff 379335. adamcz marked an inline comment as done. adamcz added a comment. removed unnecessary Flags.clear() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648 Files: cla

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1145 + CodeCompletionTUInfo CCTUInfo; + std::vector &ParamNames; + // For de-duplication only. StringRefs based on strings in ParamNames. kadircet wrote: > nit: Why not directl

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 379070. adamcz marked 3 inline comments as done. adamcz added a comment. next round of review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-t

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz added a comment. Hi Nathan Would you mind reviewing this change? It's related to your https://reviews.llvm.org/D85503 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz created this revision. adamcz added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously we would call getAs

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1148 + std::set ParamNamesSeen; +}; // SignatureHelpCollector + kadircet wrote: > change the ending comment (well, I'd actually drop it completely) Oops, too much copy/paste. We

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 377891. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-tools

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This covers both C-st

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For example, if you have: void foo(int bar); foo(/*^ it s

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08128fe7059e: [clang] Make member var invalid when static initializer is invalid. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2987 +if (ThisDecl) + ThisDecl->setInvalidDecl(); SkipUntil(tok::comma, StopAtSemi | StopBeforeMatch); hokein wrote: > it seems to me calling `Sema::ActOnInitiali

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 363495. adamcz added a comment. ActOnInializerError instead of SetInvalidDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added a comment. OK, I think we've got it now :-) I kept the original crash test in the change, but I'm not sure if it's appropriate anymore. Let me know if you think I should remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 357511. adamcz added a comment. Fix a more generic case of invalid static initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDec

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/test/SemaCXX/cxx11-crashes.cpp:117 + // The missing expression makes A undeduced. + static constexpr auto A = ; // expected-error {{expected expression}} + Foo::type B; // The type of B is also undeduced (wrapped in Elaborated

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 356925. adamcz added a comment. changed to marking field type as invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undeduced fields in a valid record cause crashes when trying to obtain the size and/or layout of the record. Repository:

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG49eba8bf1780: [clang] Do not crash when ArgTy is null in CheckArgAlignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ h

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 351155. adamcz added a comment. updated after the CXXDefaultArgExpr containsErrors() change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/Se

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa95937452f23: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr (authored by adamcz). Repository: rG LLVM Github Monorepo CHA

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added a comment. Thanks Haojian! I sent out https://reviews.llvm.org/D103982 for the CXXDefaultArgExpr. I'll update this change after I submit that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change, CXXDefaultArgExpr would always have ExprDependence::None. This can lead to issues when, for example, t

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added reviewers: kadircet, hokein. adamcz added a comment. FYI The ArgTy.isNull() check is sufficient to fix this. The Arg->containsErrors() is not - it's false in this case, since it seems CXXDefaultArgExpr with RecoveryExpr inside seems to not contains errors, according to containsErro

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350629. adamcz added a comment. Added some containsErrors() calls, not sure if that's the right thing to do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: cl

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350613. adamcz added a comment. update commit description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz updated this revision to Diff 350612. adamcz added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103825 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/recovery-exp

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No repro case just yet. I only observed a crash like this and noticed ArgTy-Value = 0 in coredump. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D103472: [clang] Fix a crash during code completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721476e6b211: [clang] Fix a crash during code completion (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGeba3ee04d450: [clangd] Run code completion on each token coverd by --check-lines (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/n

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz updated this revision to Diff 349878. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/new/ https://reviews.llvm.org/D103538 Files: clang-tools-extra/clangd/tool/Check.cpp clang-tools-extra/cl

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz marked an inline comment as done. adamcz added a comment. I didn't put much thought into where --check-lines goes. It's an interesting thought. I think having all the flags in one place is more valuable than trying to split them in some way. We contain all flags in the same place, close

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In --check mode we do not run code completion because it is too

  1   2   3   4   >