[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 495925. abidmalikwaterloo added a comment. Rebase the patch to origin/main with all updates. Made changes to make it buildable using the new changes. (WIP). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#4081228 , @kiranchandramohan wrote: > Since the plan is to switch to the Canonical Style operation, maybe this can > wait till the `omp.canonical_loop` changes are in? Ok..make sense Repository: rG LLVM

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 486732. abidmalikwaterloo added a comment. Added a pretty test for omp.distrubute in ops.mlir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 Files: mlir/

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 5 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:124 +// CHECK-LABEL: omp_DistributeOp +func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref, %chunk_var

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 483422. abidmalikwaterloo marked 8 inline comments as done and an inline comment as not done. abidmalikwaterloo added a comment. Clean the formatting comments. The patch is out of attention for a while. Still need to work on the context selector pa

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 480159. abidmalikwaterloo marked 3 inline comments as done. abidmalikwaterloo added a comment. Update the patch based on the feedback and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3917238 , @kiranchandramohan wrote: > Patch probably needs a rebase. A few more minor things to fix. Looks mostly > ready. With which branch should I rebase? I have taken care rest of the comments. Thanks

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 473706. abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. corrected the syntex of the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://review

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp", "Sim

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Ping! Does this need any further change? Seems okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits m

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Seems that everything has been taken care of. It was accidentally out of my radar (do not know why). I will go through it once again and update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https:

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 461661. abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. Updated the PrintStmt.cpp according to the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/n

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. I will work on the patch in parts. I am planning to submit taking care of comments except for comments for SemaOpenMP and code generation. Comment at: clang/lib/AST/OpenMPClause.cpp:1679 +

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3723940 , @clementval wrote: > In D105255#3723865 , > @abidmalikwaterloo wrote: > >> [MLIR][OpenMP] Added target data, exit data, and enter data operation >> defini

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 452743. abidmalikwaterloo added a comment. [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3707533 , @clementval wrote: > In D105255#3707495 , @raghavendhra > wrote: > >> In D105255#3707088 , >> @abidmalikwaterloo

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3706602 , @raghavendhra wrote: > @abidmalikwaterloo Can you please check your last patch pushed for review? > https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can > not apply your patc

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. I just updated the patch. Something went wrong. I used arc `diff --update ` for uploading. However, it seems it is not comparing the last submitted patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 448086. abidmalikwaterloo added a comment. Added assembly format changed the type of mape_type_modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255 File

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:3144 +for (const OMPTraitSelector &Selector : Set.Selectors) { + if (Selector.Kind == llvm::omp::TraitSelector::user_con

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10852 +def err_omp_misplaced_default_clause : Error< + "misplaced default clause! Only one default clause is allowed in" + "

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Ping! Comment at: clang/lib/AST/OpenMPClause.cpp:1614-1617 + if (Node->getTI().Sets.size() == 0) { +OS << "default("; +return; + } ABataev wrote: > Is this correct? Just `default(` is expected to be printed? This fun

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3643428 , @clementval wrote: > Why not adding the assembly format directly for these operations like your > patch D105584 ? OK, I will do it! Repository: rG LLVM Github

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 443708. abidmalikwaterloo added a comment. Update ops.mlir test cases. llvm-lit is working and all tests are passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 442661. abidmalikwaterloo marked 14 inline comments as done. abidmalikwaterloo added a comment. Updated and clean the code based on the comments from the reviewer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 442343. abidmalikwaterloo added a comment. Removed unrelated changes in CMakefile.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 Files: mlir/include/

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added a comment. update the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cf

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 442321. abidmalikwaterloo marked 11 inline comments as done. abidmalikwaterloo added a comment. Herald added a subscriber: anlunx. Updated DistributeOp::verify as per reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wr

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 441105. abidmalikwaterloo added a comment. Update the patch for assembly format. Change the WSLoopControl to LoopControl. Added DistributeOp to parent of Yield OP. Added one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3618040 , @abidmalikwaterloo wrote: > In D105584#3617666 , @clementval > wrote: > >> In D105584#3617456 , >> @abidmalikwat

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3617666 , @clementval wrote: > In D105584#3617456 , > @abidmalikwaterloo wrote: > >> // CHECK-LABEL: omp_DistributeOp >> func.func @omp_DistributeOp(%lb : index,

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. // CHECK-LABEL: omp_DistributeOp func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref, %chunk_var : i32) -> () { // CHECK: omp.wsloop collapse(2) "omp.DistributeOp" (%lb, %ub, %step) ({ ^bb0(%iv: index):

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > abidmalikwaterloo wrote: > > shraiysh wrote: > > > abidmali

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 436616. abidmalikwaterloo added a comment. Revised the patcg according to the reviews of the reviewers. clean the code and add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ h

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:661 + +The $map_type_modifier vector specifies the modifier for each map type +operand abidmalikwaterlo

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:6 +=== +>>> [Testing] TestAST, a helper for writing straight-line AST tests # Not add_clang_library: this is not part of clang's publ

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Should I update the patch? I am waiting for quick feedback on the concept of handling conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 __

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added inline comments. Herald added a subscriber: bzcheeseman. Comment at: clang/lib/Testing/CMakeLists.txt:33 + clangBasic + clangFrontend ) Are these okay? In D105584 these were not Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked an inline comment as done. abidmalikwaterloo added inline comments. Herald added a subscriber: bzcheeseman. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > abidmalikwaterloo w

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:488-490 +`private_var`, `firstprivate_var`, and `lastprivate_var` arguments are +variadic list of operands that specify

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend shraiysh wrote: > unrelated change? When I rebase, these changes were highlighted in the main branch which was missing in the pa

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 429235. abidmalikwaterloo edited the summary of this revision. abidmalikwaterloo added a comment. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Rebase the patch and clean some formatting as needed Repository: rG LL

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 428955. abidmalikwaterloo added a comment. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Added the assembly format, dist_schedule parser support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D124040: Basic Support for otherwise clause

abidmalikwaterloo created this revision. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The patch provides otherwise support in

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 423305. abidmalikwaterloo added a comment. Cleaned the code and added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 Files: clang/include/clang/AS

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. The last update removed all previous updates. Can you point me to the correct way to do it? I did the following : arc patch D122255 "did something/cleaning" git commit -a --amend arc diff Repository: rG LLVM Github Monorepo

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422512. abidmalikwaterloo added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 Files: clang/test/OpenMP/metadirective_ast_print2.c

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 422509. abidmalikwaterloo added a comment. I update it but it created a new patch D123598 . I marked it Abandon. Not sure how to delete it. I am submitting it again after cleaning the codes and adding some basic tes

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo updated this revision to Diff 422504. abidmalikwaterloo added a comment. I submitted update but it created a new patch D123598 . I marked it abandon and submitting it again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. There should be an update to D122255 . It should not create the new one.D123598 ---> I did the following : arc patch D122255 "did something/cleaning" git comm

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo added a comment. It. should update D122255 . It should not create the new one. ---> I used the following arc patch D122255 "did something" git commit -a arc diff > Repository: rG LLVM Github Monorepo

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LL

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Are you going to work on it? Just confirming. I am working on D122255 . The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification. Corre

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. would it make sense to submit separate patches for when (OMPC_when) and otherwise (OMPC_otherwise) clauses? The D120573 also has OMPC_when support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); ggeorgakoudis wrote: > abidmalikwaterlo

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); Why a

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); This approach is valid for static condi

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Is it okay if I can put comments on the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 ___ cfe-commits mailing list c

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Does anyone implement/take care of the "otherwise" clause? If I am correct, OpenMP 5.2 supports otherwise instead of the default for meta directive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120573/new/ https

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LL