abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments.
================ Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:661 + + The $map_type_modifier vector specifies the modifier for each map type + operand ---------------- abidmalikwaterloo wrote: > shraiysh wrote: > > It is not clear which element in this list corresponds to which map type. > > It would be nice if we could either document that here, or have separate > > operands for each map type. (same for other two constructs too) > I feel keeping it in vector makes more sense. I will document it here. As per > OpenMP Specifications: > The map-type can be **to, from, tofrom, or alloc**. Correction: map_type_modifier can be "always, close, and mapper" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
