https://github.com/teresajohnson approved this pull request.
https://github.com/llvm/llvm-project/pull/135728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teresajohnson wrote:
> > I was mostly thinking that detecting and erroring at LTO time would result
> > in a clearer error (like at the start of LTO::addModule, where it is
> > looking for partially split LTO units, which we do by adding the module
> > flag to the index flags).
>
> I don't th
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/135552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/135728
>From 4ddc4d6fcd938b66cce586c18a9e165c6d065121 Mon Sep 17 00:00:00 2001
From: Peter Collingbourne
Date: Mon, 14 Apr 2025 19:04:00 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
pcc wrote:
> Could that be addressed by only allowing this flag under LTO?
`-fsanitize=address -flto=thin` would have the same issue (if there is indeed
an issue, which I think there probably isn't).
> Probably at least add a note to the new documentation for the option that it
> will result
https://github.com/bcardosolopes approved this pull request.
LGTM, pending if Andy has any other followup
https://github.com/llvm/llvm-project/pull/135552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/AmrDeveloper closed
https://github.com/llvm/llvm-project/pull/135493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amr Hesham
Date: 2025-04-15T19:52:26+02:00
New Revision: 30d13e359190f7a0e2122292ec4a4fc1a6c71acc
URL:
https://github.com/llvm/llvm-project/commit/30d13e359190f7a0e2122292ec4a4fc1a6c71acc
DIFF:
https://github.com/llvm/llvm-project/commit/30d13e359190f7a0e2122292ec4a4fc1a6c71acc.diff
LO
https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/135493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/m1kit updated
https://github.com/llvm/llvm-project/pull/135787
>From 15631133faed63a1c4bf7b3c9076629985e48bf9 Mon Sep 17 00:00:00 2001
From: mikit <37488201+m1...@users.noreply.github.com>
Date: Tue, 15 Apr 2025 22:32:24 +0900
Subject: [PATCH 1/2] [CodeGen] Fix new-delete-type
@@ -108,6 +108,32 @@ DependencyScanningFilesystemSharedCache::getShardForUID(
return CacheShards[Hash % NumShards];
}
+void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths(
+llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const {
+ /
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Nicolas van Kempen (nicovank)
Changes
`check_clang_tidy` now matches full lines only, so `{{^}}` clauses are no
longer necessary.
I am splitting those changes over multiple PRs to make review easier. Numbering
them but the a
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/135826
`check_clang_tidy` now matches full lines only, so `{{^}}` clauses are no
longer necessary.
I am splitting those changes over multiple PRs to make review easier. Numbering
them but the actual order doesn't m
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/135809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
asudarsa wrote:
Addressed in c0bc6890a68b7b
@@ -143,6 +143,32 @@ if (LLVM_ENABLE_SPHINX)
gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs
../include/clang/Basic/Diagnostic.td "${docs_targets}")
gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs
../include/clang/Driver/ClangOptionDocs.td
@@ -0,0 +1,89 @@
+//==-- ABIArgInfo.h - Abstract info regarding ABI-specific arguments
---==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
Pass a reference to `StableDirs` when creating ModuleDepCollector. This avoids
needing to create one from the same ScanInstance for each call to
`handleTopLevelModule` & reduces the amount of potential d
@@ -271,3 +271,33 @@ void operators() {
if (to_int_int) {} // expected-error {{attempt to use a deleted function:
deleted (TO, operator bool)}}
static_cast(to_int_int); // expected-error {{static_cast from 'TO' to 'bool' uses deleted function: deleted (TO, operator bool)}}
https://github.com/steakhal commented:
Thank you for proposing this. It looks really good already.
The code looks nice and dense, and the output also looks wonderful.
I had some design questions and a few remarks on the testing and error handling.
Good job.
https://github.com/llvm/llvm-project/
Author: Michael Park
Date: 2025-04-13T22:29:27-07:00
New Revision: 63e2963f4a24cb9365d1224e69f64bf643171023
URL:
https://github.com/llvm/llvm-project/commit/63e2963f4a24cb9365d1224e69f64bf643171023
DIFF:
https://github.com/llvm/llvm-project/commit/63e2963f4a24cb9365d1224e69f64bf643171023.diff
@@ -0,0 +1,160 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// REQUIRES: aarch64-registered-target
+// RUN: %clang_cc1 -triple aarch64 -target-feature +sme-f8f32 -target-feature
+sme-f8f16 -target-feature +sme-mop4 -tar
pdimov wrote:
The above was a 64 bit build, in 32 bit the warning is
```
1>testbed2022.cpp(8,15): warning : cast from 'FARPROC' (aka 'int (*)()
__attribute__((stdcall))') to 'PGNSI' (aka 'void (*)(_SYSTEM_INFO *)
__attribute__((stdcall))') converts to incompatible function type
[-Wcast-functio
zmodem wrote:
Thanks! I'll go ahead and push the button. Hope you feel better soon!
https://github.com/llvm/llvm-project/pull/135611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1206,82 +1198,70 @@
createCompilerInstanceForModuleCompileImpl(CompilerInstance &ImportingInstance,
DiagnosticOptions &DiagOpts = Invocation->getDiagnosticOpts();
DiagOpts.VerifyDiagnostics = 0;
- assert(ImportingInstance.getInvocation().getModuleHash() ==
-
https://github.com/qiongsiwu edited
https://github.com/llvm/llvm-project/pull/135703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,6 +108,32 @@ DependencyScanningFilesystemSharedCache::getShardForUID(
return CacheShards[Hash % NumShards];
}
+void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths(
+llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const {
+ /
@@ -108,6 +108,32 @@ DependencyScanningFilesystemSharedCache::getShardForUID(
return CacheShards[Hash % NumShards];
}
+void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths(
qiongsiwu wrote:
Yes good catch! This should have a lock.
@@ -108,6 +108,32 @@ DependencyScanningFilesystemSharedCache::getShardForUID(
return CacheShards[Hash % NumShards];
}
+void DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths(
+llvm::raw_ostream &OS, llvm::vfs::FileSystem &UnderlyingFS) const {
+ /
https://github.com/qiongsiwu updated
https://github.com/llvm/llvm-project/pull/135703
>From d4b1210c16b4fccc6faa9445bee457a1e330a025 Mon Sep 17 00:00:00 2001
From: Qiongsi Wu
Date: Mon, 14 Apr 2025 16:49:07 -0700
Subject: [PATCH 1/2] Initial commit.
---
.../DependencyScanningFilesystem.h
https://github.com/ShashwathiNavada updated
https://github.com/llvm/llvm-project/pull/125643
>From 0aebcd7119fbcd51154c5d9706752e8ff3f041bc Mon Sep 17 00:00:00 2001
From: ShashwathiNavada
Date: Tue, 4 Feb 2025 00:16:09 -0600
Subject: [PATCH 1/7] Adding diagnostics for unsupported option
---
c
https://github.com/hstk30-hw edited
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1302,6 +1302,7 @@ ItaniumRecordLayoutBuilder::LayoutBase(const
BaseSubobjectInfo *Base) {
setSize(std::max(getSize(), Offset + Layout.getSize()));
// Remember max struct/class alignment.
+ UnadjustedAlignment = std::max(UnadjustedAlignment, PreferredBaseAlign);
---
AaronBallman wrote:
> > What if we add unsigned clang_getCStringLength(CXString); which gets the
> > length but not the contents? Do we need to package pointer and size
> > together?
>
> Where do we store the length, if we can't add a new field to `CXString`, and
> we can't use `private_flags
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
+ OFK_FIRST = OFK_OpenMP,
asudarsa wrote:
@@ -923,10 +923,9 @@ Expected> linkAndWrapDeviceFiles(
});
auto LinkerArgs = getLinkerArgs(Input, BaseArgs);
-DenseSet ActiveOffloadKinds;
+uint16_t ActiveOffloadKindMask = 0u;
asudarsa wrote:
I think it is a good optimization to have (16-
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,Theo
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/16064
Here is the relevant piece of the
@@ -1302,6 +1302,7 @@ ItaniumRecordLayoutBuilder::LayoutBase(const
BaseSubobjectInfo *Base) {
setSize(std::max(getSize(), Offset + Layout.getSize()));
// Remember max struct/class alignment.
+ UnadjustedAlignment = std::max(UnadjustedAlignment, PreferredBaseAlign);
---
mariusdr wrote:
> LGTM - sorry for the delayed response.
>
> Will you need me to merge that for you (once the merge conflict is resolved)?
Yes, thanks!
https://github.com/llvm/llvm-project/pull/133574
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/mariusdr updated
https://github.com/llvm/llvm-project/pull/133574
>From bcf038103c717edfdcf633ac8f3f6f1f306d927a Mon Sep 17 00:00:00 2001
From: marius doerner
Date: Sat, 29 Mar 2025 09:21:20 +0100
Subject: [PATCH 1/3] [clang] Clear `NeedsCleaning` flag after
`ExpandBuiltinMa
https://github.com/ahatanak closed
https://github.com/llvm/llvm-project/pull/134951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Akira Hatanaka
Date: 2025-04-15T10:12:18-07:00
New Revision: 3192ecfa89a48b5f56ff36956abe7e84327ced5d
URL:
https://github.com/llvm/llvm-project/commit/3192ecfa89a48b5f56ff36956abe7e84327ced5d
DIFF:
https://github.com/llvm/llvm-project/commit/3192ecfa89a48b5f56ff36956abe7e84327ced5d.diff
https://github.com/cor3ntin approved this pull request.
lgtm, but make sure to address Matheus's comments
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
teresajohnson wrote:
> > I assume this will give a duplicate symbol linker error if used
> > inappropriately? Any chance of more subtle bugs?
>
> As far as LTO is concerned I think it can only result in a duplicate symbol
> error as the resulting symbols will have external strong linkage. Ther
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,
=?utf-8?q?Th=C3=A9o?= De Magalhaes ,Theo
https://github.com/cor3ntin reopened
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -743,6 +759,13 @@ class Sema;
Standard.setAllToTypes(T);
}
+/// A conversion sequence is perfect if
+/// it is an identity conversion and
erichkeane wrote:
your formatting of this comment is a little weird re-newlines.
https://github.com
@@ -979,6 +1002,22 @@ class Sema;
return false;
}
+// An overload is a perfect match if the conversion
+// sequences for each argument are perfect.
+bool isPerfectMatch(const ASTContext &Ctx) const {
+ if (!Viable)
+return false;
+ for (
https://github.com/erichkeane approved this pull request.
I have a handful of comments that are all nits/minor enough I trust you on, but
overall this looks fine.
Lets ship it!
https://github.com/llvm/llvm-project/pull/133426
___
cfe-commits mailing
@@ -1117,16 +1217,27 @@ class Sema;
SmallVector Candidates;
llvm::SmallPtrSet Functions;
-// Allocator for ConversionSequenceLists. We store the first few of these
+DeferredTemplateOverloadCandidate *FirstDeferredCandidate;
erichkeane wrote:
`
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Do you need to invoke the destructor?
https://github.com/llvm/llvm-project/pull/135787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fangyi-zhou wrote:
Sorry I've been a bit busy with other things, just had some time to address the
review comments. Please let me know if anything else needs changing
https://github.com/llvm/llvm-project/pull/128251
___
cfe-commits mailing list
cfe-co
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/134807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/135704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Cyndy Ishida
Date: 2025-04-15T09:59:23-07:00
New Revision: 40050888a11a92a2fbf4da5dda5956ca9ecb6b55
URL:
https://github.com/llvm/llvm-project/commit/40050888a11a92a2fbf4da5dda5956ca9ecb6b55
DIFF:
https://github.com/llvm/llvm-project/commit/40050888a11a92a2fbf4da5dda5956ca9ecb6b55.diff
@@ -1302,6 +1302,7 @@ ItaniumRecordLayoutBuilder::LayoutBase(const
BaseSubobjectInfo *Base) {
setSize(std::max(getSize(), Offset + Layout.getSize()));
// Remember max struct/class alignment.
+ UnadjustedAlignment = std::max(UnadjustedAlignment, PreferredBaseAlign);
---
xTachyon wrote:
> What if we add unsigned clang_getCStringLength(CXString); which gets the
> length but not the contents? Do we need to package pointer and size together?
Where do we store the length, if we can't add a new field to `CXString`, and we
can't use `private_flags` to store it?
htt
@@ -466,6 +467,29 @@ class FullSourceLoc : public SourceLocation {
}
};
+/// A simple pair of identifier info and location.
+class IdentifierLoc {
+ SourceLocation Loc;
+ IdentifierInfo *II = nullptr;
+
+public:
+ IdentifierLoc() = default;
+ IdentifierLoc(SourceLocation
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov commented:
Thanks, I like the idea!
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> Yes please. :-) And thanks very much.
You're welcome, thanks for bringing the issue up and sticking with me until I
understood it. :-D I've posted https://github.com/llvm/llvm-project/pull/135798
to backport to 20.x
https://github.com/llvm/llvm-project/pull/86131
___
AaronBallman wrote:
> `CXString::private_flags` only has 2 bits used. Could we use the rest for the
> size? Would it be enough?
I'd be a bit uncomfortable with that. It would work, but it means we're never
able to add any new private flags in the future.
> There's also the possibility to not
https://github.com/erichkeane approved this pull request.
I REALLY like this. I THINK this ends up being pretty trivial implementation
for most of the files, and did a quick overlook on it, but please let another
person or two do the scroll through to mkae sure I didnt miss anything.
https://
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Jan Svoboda (jansvoboda11)
Changes
This PR introduces new single-module preprocessing mode. It is very similar to
single-file-parse mode, but has the following differences:
* Single-file mode skips over all inclusion directives, wh
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
This PR introduces new single-module preprocessing mode. It is very similar to
single-file-parse mode, but has the following differences:
* Single-file mode skips over all inclusion directives, while the
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/135813
This PR introduces new single-module preprocessing mode. It is very similar to
single-file-parse mode, but has the following differences:
* Single-file mode skips over all inclusion directives, while the si
pdimov wrote:
Yes please. :-) And thanks very much.
https://github.com/llvm/llvm-project/pull/86131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/135808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
Done. Thank you for your contribution!
https://github.com/llvm/llvm-project/pull/135420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
+ OFK_FIRST = OFK_OpenMP,
jhuber6 wrote:
W
@@ -32,10 +32,12 @@ namespace object {
/// The producer of the associated offloading image.
enum OffloadKind : uint16_t {
OFK_None = 0,
- OFK_OpenMP,
- OFK_Cuda,
- OFK_HIP,
- OFK_LAST,
+ OFK_OpenMP = (1 << 1),
jhuber6 wrote:
This is 2, not 1.
https://g
@@ -923,10 +923,9 @@ Expected> linkAndWrapDeviceFiles(
});
auto LinkerArgs = getLinkerArgs(Input, BaseArgs);
-DenseSet ActiveOffloadKinds;
+uint16_t ActiveOffloadKindMask = 0u;
jhuber6 wrote:
This code doesn't need to be modified, but I gu
AaronBallman wrote:
> > ping, is this still a problem?
>
> yes, this is still happening. but I am currently lacking cycles to dig deeper
> into expression evaluation to see if this is the right fix given the
> reproducer. @VitaNuo was to take a look with some limited capacity, but I
> think s
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics
- Now correctly diagnose a tentative definition of an array with static
storage duration in pedantic mode in C. (#GH50661)
+- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns
when the divisor i
MillePlateaux wrote:
@erichkeane @AaronBallman This is my first time participating in an open source
project. I would like to ask if you have the same opinion so far. I have
revised many versions over and over again. I just hope that the requirements
can be clarified.
https://github.com/llvm/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Finding operator delete[] is still problematic, without it the extension is a
security hazard, so reverting until the problem with operator delete[] is
figured out.
---
Patch is 86.63 KiB, trunc
https://github.com/CarolineConcatto approved this pull request.
The patch looks good to me
https://github.com/llvm/llvm-project/pull/130127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Djordje Todorovic (djtodoro)
Changes
The right name was used in riscv-toolchain-conventions docs.
---
Full diff: https://github.com/llvm/llvm-project/pull/135647.diff
15 Files Affected:
- (modified) clang/test/Driver/print-supported-ext
@@ -717,6 +717,12 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr
&MTA) {
return false;
}
+ if (const FunctionDecl *CalleeDecl = CE->getDirectCallee();
+ CalleeDecl && CalleeDecl->hasAttr()) {
+Diag(St->getBeginLoc(), diag::err_musttail_mismatch) <<
ojhunt wrote:
It's even more dumb, but I have this fixed and am writing tests
https://github.com/llvm/llvm-project/pull/113510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I think this looks fine but I'd like @Bigcheese @erichkeane @AaronBallman to
look at it too.
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/e-kud approved this pull request.
LGTM. For the particular arches, `vaes`, `vpclmulqdq` are inherited from
`ICLAdditionalFeatures`. So we shouldn't miss them in the future.
https://github.com/llvm/llvm-project/pull/135489
___
cfe-co
https://github.com/phoebewang closed
https://github.com/llvm/llvm-project/pull/135489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -29,13 +32,29 @@ CIRGenCallee
CIRGenCallee::prepareConcreteCallee(CIRGenFunction &cgf) const {
return *this;
}
-static const CIRGenFunctionInfo &arrangeFreeFunctionLikeCall(CIRGenTypes &cgt)
{
+static const CIRGenFunctionInfo &
+arrangeFreeFunctionLikeCall(CIRGenTypes &
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/135511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hstk30-hw edited
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/135372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7132,7 +7118,7 @@ ExprResult SemaOpenMP::ActOnOpenMPCall(ExprResult Call,
Scope *Scope,
if (!CalleeFnDecl)
return Call;
- if (getLangOpts().OpenMP >= 51 && getLangOpts().OpenMP < 60 &&
+ if (getLangOpts().OpenMP >= 50 && getLangOpts().OpenMP <= 60 &&
-
asudarsa wrote:
Hi @jhuber6
Thanks so much for feedback so far. I have added a separate PR
(https://github.com/llvm/llvm-project/pull/135809) for improving OffloadKind
implementation. Kindly take a look.
Thanks
https://github.com/llvm/llvm-project/pull/135683
___
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Arvind Sudarsanam (asudarsa)
Changes
Following are the changes:
1. Make OffloadKind enum values to be powers of two so we can use them like a
bitfield
2. Include OFK_SYCL enum value
3. Modify ActiveOffloadKinds support in clang-linker-wra
https://github.com/asudarsa created
https://github.com/llvm/llvm-project/pull/135809
Following are the changes:
1. Make OffloadKind enum values to be powers of two so we can use them like a
bitfield
2. Include OFK_SYCL enum value
3. Modify ActiveOffloadKinds support in clang-linker-wrapper to
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: None (yronglin)
Changes
Currently we have many similiar data structures like:
- `std::pair`.
- Element type of `ModuleIdPath`.
- `IdentifierLocPair`.
- `IdentifierLoc`
https://github.com/jeremyd2019 edited
https://github.com/llvm/llvm-project/pull/135701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hstk30-hw edited
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ShashwathiNavada updated
https://github.com/llvm/llvm-project/pull/125643
>From 0aebcd7119fbcd51154c5d9706752e8ff3f041bc Mon Sep 17 00:00:00 2001
From: ShashwathiNavada
Date: Tue, 4 Feb 2025 00:16:09 -0600
Subject: [PATCH 1/7] Adding diagnostics for unsupported option
---
c
@@ -3107,6 +3107,26 @@ let TargetPrefix = "aarch64" in {
}
}
+ class SME_OuterProduct_TMOP_Intrinsic
+ : DefaultAttrsIntrinsic<[],
+ [llvm_i32_ty,
+ llvm_anyvector_ty,
+ LLVMMatchType<0>,
+ LLVMMatchType<0>,
+ llvm_nxv16i8
https://github.com/erichkeane commented:
Overall I don't mind the patch. The special attribute here is...
frustrating/concerning/etc, and I'd rather we just mark the attribute as
'invalid' in some way so that we can diagnose it instead.
https://github.com/llvm/llvm-project/pull/133699
___
1 - 100 of 153704 matches
Mail list logo
