[clang] [CIR] Update ComplexRealOp to work on scalar type (PR #161080)

2025-09-28 Thread Henrich Lauko via cfe-commits
@@ -148,9 +148,10 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { } mlir::Value createComplexReal(mlir::Location loc, mlir::Value operand) { -auto operandTy = mlir::cast(operand.getType()); -return cir::ComplexRealOp::create(*this, loc, operandTy.getElementTyp

[clang] [alpha.webkit.UnretainedCallArgsChecker] Treat NSStringFromSelector and alike as trivial and returns a retained value (PR #161135)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes Treat NSStringFromSelector, NSSelectorFromString, NSStringFromClass, NSClassFromString, NSStringFromProtocol, and NSProtocolFromString as trivial, and treat their return values as a safe pointer origin since t

[clang] [alpha.webkit.UnretainedCallArgsChecker] Treat NSStringFromSelector and alike as trivial and returns a retained value (PR #161135)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes Treat NSStringFromSelector, NSSelectorFromString, NSStringFromClass, NSClassFromString, NSStringFromProtocol, and NSProtocolFromString as trivial, and treat their return values as a safe poin

[clang] [Clang] Avoid null deref in lambda attribute compat warning (PR #161096)

2025-09-28 Thread Corentin Jabot via cfe-commits
@@ -1147,7 +1147,7 @@ def ext_lambda_missing_parens : ExtWarn< "lambda without a parameter clause is a C++23 extension">, InGroup; def warn_cxx20_compat_decl_attrs_on_lambda : Warning< - "%select{an attribute specifier sequence|%1}0 in this position " + "%select{an attrib

[clang] [clang] treat deduced-as-dependent as undeduced for constant template parameters (PR #161099)

2025-09-28 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. Impressingly/confusingly, this does solve our issues. Thanks for the quick fix https://github.com/llvm/llvm-project/pull/161099 ___ cfe-commits mailing list [email protected] https://list

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation directive and "looprange" clause (PR #139293)

2025-09-28 Thread via cfe-commits
github-actions[bot] wrote: @eZWALT Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - Allow AVX/AVX512 IFMA madd52 intrinsics to be used in constexpr (PR #161056)

2025-09-28 Thread NagaChaitanya Vellanki via cfe-commits
https://github.com/chaitanyav updated https://github.com/llvm/llvm-project/pull/161056 >From 1920f6dde19da9e27a9a035f5c57a5a325aa33a7 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Sun, 28 Sep 2025 00:29:57 -0700 Subject: [PATCH] [X86][Clang] VectorExprEvaluator::VisitCallExpr / I

[libunwind] [libunwind][test] Add check for objcopy to improve test compatibility (PR #161112)

2025-09-28 Thread Wu Yingcong via cfe-commits
https://github.com/yingcong-wu created https://github.com/llvm/llvm-project/pull/161112 Previous, we only use `objcopy`, which is not available for some of the build configs. With this patch, we not only try to use `objcopy`, but also try to use `llvm-objcopy` if available. >From a56a073ea90f

[clang] [clang][modules] Ensure -nostdlib causes no manifest to be reported (PR #161110)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) Changes When -nostdlib is specified, Clang should not report any library‑provided module manifest, even if a manifest for the default standard library is present. --- Full diff: https://github.com/llvm/llvm

[clang] [clang-scan-deps] Remove const from ModuleDeps loop to enable move. (PR #161109)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) Changes This changes the iteration from const to non-const so that std::move results in a true move rather than a copy. --- Full diff: https://github.com/llvm/llvm-project/pull/161109.diff 1 Files Affecte

[clang] [ARM][clang] Add some build attributes support (PR #161106)

2025-09-28 Thread via cfe-commits
https://github.com/paperchalice updated https://github.com/llvm/llvm-project/pull/161106 >From 4627b4732d900e8b85f4ba27ecd64fc0d2fdabe4 Mon Sep 17 00:00:00 2001 From: PaperChalice Date: Sat, 27 Sep 2025 17:30:14 +0800 Subject: [PATCH] [ARM][clang] Add some build attributes support --- clang/l

[clang] [Clang] Avoid null deref in lambda attribute compat warning (PR #161096)

2025-09-28 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/161096 >From 621aedbabfb03991b1f5a4981ab2c2191187bed1 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 28 Sep 2025 23:45:51 +0300 Subject: [PATCH] [Clang] Avoid null deref in lambda attribute compat warn

[clang] [clang][modules-driver] Add dependency scan and dependency graph (PR #152770)

2025-09-28 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth ready_for_review https://github.com/llvm/llvm-project/pull/152770 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Remove const from ModuleDeps loop to enable move. (PR #161109)

2025-09-28 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth created https://github.com/llvm/llvm-project/pull/161109 This changes the iteration from const to non-const so that std::move results in a true move rather than a copy. >From 73cbb1d0c982dddbd92f63b6dff295a98baf5ddb Mon Sep 17 00:00:00 2001 From: Naveen Seth Hani

[clang-tools-extra] [clangd] Fix off-by-one error in CommandMangler (PR #160029)

2025-09-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Review ping https://github.com/llvm/llvm-project/pull/160029 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules-driver] Add dependency scan and dependency graph (PR #152770)

2025-09-28 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/152770 >From 8e126e911485aeaa07f11b795d07ab408a0f931a Mon Sep 17 00:00:00 2001 From: Naveen Seth Hanig Date: Mon, 29 Sep 2025 00:53:21 +0200 Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen

[clang] [Clang] Avoid null deref in lambda attribute compat warning (PR #161096)

2025-09-28 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/161096 >From cb5b1831921092d5dcf96f452f6dee367bfb18a1 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Sun, 28 Sep 2025 23:45:51 +0300 Subject: [PATCH] [Clang] Avoid null deref in lambda attribute compat warn

[clang-tools-extra] [clang-tidy] Add IgnoredRegex to 'bugprone-suspicious-include' (PR #160958)

2025-09-28 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/160958 From 47fcb11c78f88f4318253c2a78daccbb413d6df2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Fri, 26 Sep 2025 23:24:56 +0200 Subject: [PATCH 1/4] [clang-tidy] Add IgnoredR

[clang] [CIR] Add limited support for array new (PR #161095)

2025-09-28 Thread via cfe-commits
jiang1997 wrote: I'm not sure if the granularity of the current changes is appropriate. Do you have any suggestions, @andykaylor? https://github.com/llvm/llvm-project/pull/161095 ___ cfe-commits mailing list [email protected] https://lists.ll

[clang] [Clang] Avoid null deref in lambda attribute compat warning (PR #161096)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #161070 --- This PR addresses the issue in `warn_cxx20_compat_decl_attrs_on_lambda` by using `%0`=_attribute name_ and `%1`=_selector_, which prevents a null `IdentifierInfo*`. https://github.com

[clang] [clang-format][NFC] Introduce isNotOneOf (PR #161021)

2025-09-28 Thread Björn Schäpers via cfe-commits
@@ -1877,8 +1880,9 @@ struct AdditionalKeywords { // In Verilog the colon in a default label is optional. return Tok.is(TT_CaseLabelColon) || (Tok.is(tok::kw_default) && -!(Next && Next->isOneOf(tok::colon, tok::semi, kw_clocking, kw_iff, -

[clang-tools-extra] [llvm] [GitHub][WIP] Run clang-format inside ci-container (PR #160193)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/160193 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Set the feature testing macro to 1 (PR #161034)

2025-09-28 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: This seems like a reasonable compromise to me. https://github.com/llvm/llvm-project/pull/161034 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Make a few `std::string`s into `StringRef`s (PR #160961)

2025-09-28 Thread Carlos Galvez via cfe-commits
@@ -33,8 +33,8 @@ class ExceptionEscapeCheck : public ClangTidyCheck { void check(const ast_matchers::MatchFinder::MatchResult &Result) override; private: - std::string RawFunctionsThatShouldNotThrow; - std::string RawIgnoredExceptions; + StringRef RawFunctionsThatShouldN

[clang-tools-extra] [clang-tidy][NFC] Make a few `std::string`s into `StringRef`s (PR #160961)

2025-09-28 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/160961 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Deprecate one form of support::endian::byte_swap (NFC) (PR #161045)

2025-09-28 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/161045 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9a5671e - [Support] Deprecate one form of support::endian::byte_swap (NFC) (#161045)

2025-09-28 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-09-28T10:27:29-07:00 New Revision: 9a5671efac31d91e3479c6ae6a0af6196100beb3 URL: https://github.com/llvm/llvm-project/commit/9a5671efac31d91e3479c6ae6a0af6196100beb3 DIFF: https://github.com/llvm/llvm-project/commit/9a5671efac31d91e3479c6ae6a0af6196100beb3.diff L

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread Victor Chernyakin via cfe-commits
localspook wrote: For code that compiles as C23 but doesn't want to use C23 features to stay compatible with earlier versions, clang provides the [`-Wpre-c23-compat`](https://clang.llvm.org/docs/DiagnosticsReference.html#wpre-c23-compat) warning. However, it seems that warning [doesn't cover y

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: > I wonder if we should extend that warning? Sounds reasonable to me! https://github.com/llvm/llvm-project/pull/161023 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [Clang] only convert dependency filename to native form when MS-compatible (PR #160903)

2025-09-28 Thread Ruoyu Zhong via cfe-commits
https://github.com/ZhongRuoyu updated https://github.com/llvm/llvm-project/pull/160903 >From a9e571852a11ca7812bbb243462d060061779598 Mon Sep 17 00:00:00 2001 From: Ruoyu Zhong Date: Fri, 26 Sep 2025 23:17:32 +0800 Subject: [PATCH 1/2] [Clang] only convert dependency filename to native form wh

[clang] 8f905c3 - [clang][DebugInfo][test] Adjust structured-binding.cpp expected IR names (#160300)

2025-09-28 Thread via cfe-commits
Author: Michael Buch Date: 2025-09-23T14:10:46Z New Revision: 8f905c3e6f022ec6255d1e537eedcdbc029bf99d URL: https://github.com/llvm/llvm-project/commit/8f905c3e6f022ec6255d1e537eedcdbc029bf99d DIFF: https://github.com/llvm/llvm-project/commit/8f905c3e6f022ec6255d1e537eedcdbc029bf99d.diff LOG:

[clang-tools-extra] [clang-tidy] Add new check `modernize-use-structured-binding` (PR #158462)

2025-09-28 Thread via cfe-commits
flovent wrote: ping. And any opinions for https://github.com/llvm/llvm-project/pull/158462#issuecomment-3319449440? https://github.com/llvm/llvm-project/pull/158462 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-b

[clang] [llvm] [OpenMP] Adds omp_target_is_accessible routine (PR #138294)

2025-09-28 Thread Shilei Tian via cfe-commits
@@ -3027,6 +3027,29 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy { return ((IsAPU || OMPX_ApuMaps) && IsXnackEnabled); } + bool isAccessiblePtrImpl(const void *Ptr, size_t Size) override { +hsa_amd_pointer_info_t Info; +Info.size = size

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/161023 >From 51cf252c590d15c7be2ea5a25e7e86ea5e6772c8 Mon Sep 17 00:00:00 2001 From: isuckatcs <[email protected]> Date: Sat, 27 Sep 2025 22:32:15 +0200 Subject: [PATCH 1/2] [clang-tidy] Port

[clang-tools-extra] [llvm] [GitHub][WIP] Run clang-format inside ci-container (PR #160193)

2025-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD llvm/utils/git/code-lint-helper.py `` :warning: The reproductio

[clang] [CIR] Upstream `AddressSpace` support for `PointerType` (PR #161028)

2025-09-28 Thread David Rivera via cfe-commits
@@ -226,31 +228,57 @@ def CIR_PointerType : CIR_Type<"Pointer", "ptr", [ ]> { let summary = "CIR pointer type"; let description = [{ -The `!cir.ptr` type represents C and C++ pointer types and C++ reference -types, other than pointers-to-members. The `pointee` type

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/161023 >From 51cf252c590d15c7be2ea5a25e7e86ea5e6772c8 Mon Sep 17 00:00:00 2001 From: isuckatcs <[email protected]> Date: Sat, 27 Sep 2025 22:32:15 +0200 Subject: [PATCH 1/2] [clang-tidy] Port

[clang] [clang] Accept empty enum in MSVC compatible C (PR #159981)

2025-09-28 Thread via cfe-commits
https://github.com/yicuixi updated https://github.com/llvm/llvm-project/pull/159981 >From 77fc06c7147e8eec1712f2c8babdb6fd8a48dd94 Mon Sep 17 00:00:00 2001 From: yicuixi Date: Sun, 21 Sep 2025 22:22:28 +0800 Subject: [PATCH 1/4] [clang] Accept empty enum in MSVC compatible C Signed-off-by: yic

[clang] [llvm] [Support] Deprecate one form of support::endian::byte_swap (NFC) (PR #161045)

2025-09-28 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/161045 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Make -funwind-tables the default for SystemZ. (PR #139764)

2025-09-28 Thread via cfe-commits
https://github.com/anoopkg6 updated https://github.com/llvm/llvm-project/pull/139764 >From e0b15d83e04aebc8f7198af085c6fbe35f5ca7d4 Mon Sep 17 00:00:00 2001 From: anoopkg6 Date: Tue, 13 May 2025 18:33:15 +0200 Subject: [PATCH 1/3] Make -funwind-tables the default for SystemZ. --- clang/lib/Dr

[clang] [clang-tools-extra] [clang-tidy] Fix false positives about references in `misc-const-correctness` (PR #160971)

2025-09-28 Thread via cfe-commits
https://github.com/flovent edited https://github.com/llvm/llvm-project/pull/160971 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] Fix false positives about references in `misc-const-correctness` (PR #160971)

2025-09-28 Thread via cfe-commits
@@ -309,6 +309,10 @@ Changes in existing checks - ``for`` loops are supported. +- Improved :doc:`misc-const-correctness + ` check to avoid false + positives when pointers is tranferred to non-const references. flovent wrote: For the second function in li

[clang] [llvm] [Support] Deprecate one form of support::endian::byte_swap (NFC) (PR #161045)

2025-09-28 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/161045 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -0,0 +1,58 @@ +//===--- AvoidUnprototypedFunctionsCheck.cpp - clang-tidy -===// isuckatcs wrote: Seems like I used an outdated `add_new_check.py`. 😅 https://github.com/llvm/llvm-project/pull/161023 ___

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/161023 >From 51cf252c590d15c7be2ea5a25e7e86ea5e6772c8 Mon Sep 17 00:00:00 2001 From: isuckatcs <[email protected]> Date: Sat, 27 Sep 2025 22:32:15 +0200 Subject: [PATCH 1/2] [clang-tidy] Port

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -0,0 +1,73 @@ +.. title:: clang-tidy - portability-avoid-unprototyped-functions + +portability-avoid-unprototyped-functions + + +Checks if unprototyped function types are used in the source code. + +For example: + +.. code-block:: c + +

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -208,6 +208,11 @@ New checks Detect redundant parentheses. +- New :doc:`portability-avoid-unprototyped-functions EugeneZelenko wrote: Please keep alphabetical order (by check name) in this section. https://github.com/llvm/llvm-project/pull/161023 _

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -581,7 +582,38 @@ runClangTidy(clang::tidy::ClangTidyContext &Context, return AdjustedArgs; }; + // Add extra arguments passed by clang-diagnostic-* checks. + ArgumentsAdjuster ClangDiagnosticArgumentsInserter = + [&Context](const CommandLineArguments &

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -0,0 +1,58 @@ +//===--- AvoidUnprototypedFunctionsCheck.cpp - clang-tidy -===// EugeneZelenko wrote: ```suggestion //===--===// ``` https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -0,0 +1,33 @@ +//===--- AvoidUnprototypedFunctionsCheck.h - clang-tidy -*- C++ -*-===// EugeneZelenko wrote: ```suggestion //===--===// ``` https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -581,7 +582,38 @@ runClangTidy(clang::tidy::ClangTidyContext &Context, return AdjustedArgs; }; + // Add extra arguments passed by clang-diagnostic-* checks. EugeneZelenko wrote: Does it really relate to check? https://github.com/llvm/llvm-p

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
@@ -0,0 +1,33 @@ +//===--- AvoidUnprototypedFunctionsCheck.h - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy][NFC] Make a few `std::string`s into `StringRef`s (PR #160961)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. https://github.com/llvm/llvm-project/pull/160961 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/161023 >From 51cf252c590d15c7be2ea5a25e7e86ea5e6772c8 Mon Sep 17 00:00:00 2001 From: isuckatcs <[email protected]> Date: Sat, 27 Sep 2025 22:32:15 +0200 Subject: [PATCH 1/2] [clang-tidy] Port

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
isuckatcs wrote: > IIUC the clang-diagnostic-strict-prototypes check on its own doesn't enable > the warning, but what if it did? I quickly implemented this idea. WDYT? > [-Wpre-c23-compat](https://clang.llvm.org/docs/DiagnosticsReference.html#wpre-c23-compat) > warning. [...] (it seems to on

[clang-tools-extra] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` (PR #161064)

2025-09-28 Thread via cfe-commits
@@ -35,7 +35,7 @@ class SignedCharMisuseCheck : public ClangTidyCheck { const ast_matchers::internal::Matcher &IntegerType, const std::string &CastBindName) const; - const StringRef CharTypdefsToIgnoreList; + const StringRef CharTypedefsToIgnoreList;

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code linter clang-tidy found issues in your code. :warning: You can test this locally with the following command: ```bash git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/portability/AvoidUnprototypedFunctionsCheck.cpp clang-too

[clang-tools-extra] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` (PR #161064)

2025-09-28 Thread via cfe-commits
@@ -58,8 +58,11 @@ Potentially Breaking Changes :doc:`bugprone-easily-swappable-parameters ` from ``NamePrefixSuffixSilenceDissimilarityTreshold`` to - ``NamePrefixSuffixSilenceDissimilarityThreshold``, - correcting a spelling mistake. + ``NamePrefixSuffixSilenceDissim

[clang-tools-extra] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` (PR #161064)

2025-09-28 Thread via cfe-commits
@@ -58,8 +58,11 @@ Potentially Breaking Changes :doc:`bugprone-easily-swappable-parameters ` from ``NamePrefixSuffixSilenceDissimilarityTreshold`` to - ``NamePrefixSuffixSilenceDissimilarityThreshold``, - correcting a spelling mistake. + ``NamePrefixSuffixSilenceDissim

[clang] [CIR] Update ComplexRealOp to work on scalar type (PR #161080)

2025-09-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/161080 Update cir::CreateRealOp to make it visible on scalars Issue #160568 >From 48b11b37327d9f46f1630738a186e971c236acdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CAmr?= Date: Sun, 28 Sep 2025 14:47:13

[clang] [X86][Clang] Allow SSE/AVX COMI/UCOMI/CMPS/CMPP fp comparison intrinsics to be used in constexpr (PR #160876)

2025-09-28 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/160876 >From dc9c318af379bc8328c69ee7d14787e99e906816 Mon Sep 17 00:00:00 2001 From: mtx Date: Sat, 27 Sep 2025 18:15:20 +0800 Subject: [PATCH 1/5] [X86][Clang] Support `__builtin_ia32_(u)comi(sd)` --- clang/include/cl

[clang] [AST] Give `CharUnits::operator%` a consistent type. NFC (PR #160781)

2025-09-28 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM once the code is clang-format'ed https://github.com/llvm/llvm-project/pull/160781 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [llvm] [GitHub][WIP] Run clang-format inside ci-container (PR #160193)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/160193 >From f4e3ea586cf6b8284d57728ec4da022a168e5890 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 27 Sep 2025 23:46:58 +0300 Subject: [PATCH 1/9] deleteme: violate clang-format to run job --- clang-too

[clang] [llvm] Reland "[AArch64] Decouple feature dependency expansion. (#94279)" (PR #95519)

2025-09-28 Thread via cfe-commits
XiaShark wrote: > Hello, I noticed an issue after this PR: if both `-march` and `-mcpu` are > specified in the command line parameters, the features in `-mcpu` are lost. > See https://godbolt.org/z/hPq1z9rvn. Is this expected behavior? After re-adding `initFeatureMap`, the issue was resolved.

[clang-tools-extra] [llvm] [GitHub][WIP] Run clang-format inside ci-container (PR #160193)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/160193 >From f4e3ea586cf6b8284d57728ec4da022a168e5890 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 27 Sep 2025 23:46:58 +0300 Subject: [PATCH 1/7] deleteme: violate clang-format to run job --- clang-too

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
isuckatcs wrote: > So if you have config like this > > ```yaml > # .clang-tidy > Checks: clang-diagnostic-strict-prototypes > ExtraArgs: ["-Wstrict-prototypes", "-W...", ...] > ``` IIUC the `clang-diagnostic-strict-prototypes` check on its own doesn't enable the warning, but what if it did? I

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread via cfe-commits
isuckatcs wrote: > You can probably also add the -Wstrict-prototypes to the ExtraArgs field in > the .clang-tidy file. This still leaves us with the other problem. `-Wstrict-prototypes` doesn't emit anything with `-std=c23`, but for portability reasons we should still require the user to writ

[clang-tools-extra] [llvm] [GitHub] Bump clang-tidy version to 21th in CI (PR #160193)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/160193 >From f4e3ea586cf6b8284d57728ec4da022a168e5890 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 27 Sep 2025 23:46:58 +0300 Subject: [PATCH 1/5] deleteme: violate clang-format to run job --- clang-too

[clang-tools-extra] [llvm] [GitHub][WIP] Run clang-format inside ci-container (PR #160193)

2025-09-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/160193 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream `AddressSpace` support for `PointerType` (PR #161028)

2025-09-28 Thread Henrich Lauko via cfe-commits
@@ -35,4 +35,28 @@ class CIR_DefaultValuedEnumParameter let defaultValue = value; } +def CIR_AddressSpace xlauko wrote: fix format to mirror incubator https://github.com/llvm/llvm-project/pull/161028 ___ cfe-comm

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread Victor Chernyakin via cfe-commits
localspook wrote: Hold up — this wasn't obvious to me (I guess because I've never used `ExtraArgs` in the config file), but this is genuinely a pretty convenient solution! Expose a clang warning as a clang-tidy check, all without messing with the build system. I think we should document it! h

[clang] ddfbfd6 - [NFC][clang] Move simplifyConstraint to TargetInfo.cpp (#154905)

2025-09-28 Thread via cfe-commits
Author: Iris Shi Date: 2025-09-28T10:07:27+02:00 New Revision: ddfbfd6b580c6d0ac89fc826f795cb67d051c101 URL: https://github.com/llvm/llvm-project/commit/ddfbfd6b580c6d0ac89fc826f795cb67d051c101 DIFF: https://github.com/llvm/llvm-project/commit/ddfbfd6b580c6d0ac89fc826f795cb67d051c101.diff LOG:

[clang-tools-extra] [clang-tidy] Portability Avoid Unprototyped Functions Check (PR #161023)

2025-09-28 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: You can probably also add the -Wstrict-prototypes to the ExtraArgs field in the .clang-tidy file. https://github.com/llvm/llvm-project/pull/161023 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-

[clang] [NFC][clang] Move simplifyConstraint to TargetInfo.cpp (PR #154905)

2025-09-28 Thread Iris Shi via cfe-commits
https://github.com/el-ev closed https://github.com/llvm/llvm-project/pull/154905 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream `AddressSpace` support for `PointerType` (PR #161028)

2025-09-28 Thread Henrich Lauko via cfe-commits
@@ -226,31 +228,57 @@ def CIR_PointerType : CIR_Type<"Pointer", "ptr", [ ]> { let summary = "CIR pointer type"; let description = [{ -The `!cir.ptr` type represents C and C++ pointer types and C++ reference -types, other than pointers-to-members. The `pointee` type

[clang] [clang][DebugInfo][test] Adjust structured-binding.cpp expected IR names (PR #160300)

2025-09-28 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/160300 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream `AddressSpace` support for `PointerType` (PR #161028)

2025-09-28 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/161028 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream `AddressSpace` support for `PointerType` (PR #161028)

2025-09-28 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko commented: I was chainging addresspace recently in https://github.com/llvm/clangir/pull/1923 fix it accordingly please. https://github.com/llvm/llvm-project/pull/161028 ___ cfe-commits mailing list [email protected]

[clang-tools-extra] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` (PR #161064)

2025-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) Changes Following the example of #158282. --- Full diff: https://github.com/llvm/llvm-project/pull/161064.diff 5 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseChec

[clang-tools-extra] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` (PR #161064)

2025-09-28 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook created https://github.com/llvm/llvm-project/pull/161064 Following the example of #158282. >From 1a0c393d76580488c8a768cfea21214d6c37692a Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sun, 28 Sep 2025 01:51:18 -0700 Subject: [PATCH] [clang-tidy] Fix typoe

[clang] [llvm] Reland "[AArch64] Decouple feature dependency expansion. (#94279)" (PR #95519)

2025-09-28 Thread via cfe-commits
XiaShark wrote: Hello, I noticed an issue after this PR: if both `-march` and `-mcpu` are specified in the command line parameters, the features in `-mcpu` are lost. See https://godbolt.org/z/hPq1z9rvn. Is this expected behavior? https://github.com/llvm/llvm-project/pull/95519

[clang] [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - Allow AVX/AVX512 IFMA madd52 intrinsics to be used in constexpr (PR #161056)

2025-09-28 Thread NagaChaitanya Vellanki via cfe-commits
https://github.com/chaitanyav updated https://github.com/llvm/llvm-project/pull/161056 >From 4b022cd6ccdd6adb1ed898dc0436f6c4dba1f442 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Sun, 28 Sep 2025 00:29:57 -0700 Subject: [PATCH] [X86][Clang] VectorExprEvaluator::VisitCallExpr / I

[clang] [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - Allow AVX/AVX512 IFMA madd52 intrinsics to be used in constexpr (PR #161056)

2025-09-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/lib/AST/ByteCode/InterpBuiltin.cpp clang

[clang] [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - Allow AVX/AVX512 IFMA madd52 intrinsics to be used in constexpr (PR #161056)

2025-09-28 Thread NagaChaitanya Vellanki via cfe-commits
https://github.com/chaitanyav created https://github.com/llvm/llvm-project/pull/161056 Resolves #160498 >From 33d313bac475fc3aa558be8657b7373a2c724342 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Sun, 28 Sep 2025 00:29:57 -0700 Subject: [PATCH] [X86][Clang] VectorExprEvaluator::

[clang-tools-extra] [clang-tidy] Fix `modernize-use-nullptr` crash on 32-bit Windows (PR #160023)

2025-09-28 Thread Victor Chernyakin via cfe-commits
localspook wrote: Failure looks unrelated https://github.com/llvm/llvm-project/pull/160023 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix `modernize-use-nullptr` crash on 32-bit Windows (PR #160023)

2025-09-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot3` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/15398 Here is the rel

[clang-tools-extra] [clang-tidy] Fix `modernize-use-nullptr` crash on 32-bit Windows (PR #160023)

2025-09-28 Thread Victor Chernyakin via cfe-commits
localspook wrote: Fair enough, merging https://github.com/llvm/llvm-project/pull/160023 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Enable 'readability-named-parameter' check (PR #158774)

2025-09-28 Thread Davide Cunial via cfe-commits
capitan-davide wrote: Ok, based on the discussion, I am closing this PR https://github.com/llvm/llvm-project/pull/158774 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits