[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/149739 >From cb439cc703699279f690d6a4d0497a60ebfa4c08 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Mon, 21 Jul 2025 00:06:26 +0300 Subject: [PATCH 1/2] [clang-tidy] Add parallel execution by default in 'run-cl

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -12251,6 +12264,9 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, if (NewFD->hasAttr()) SYCL().CheckSYCLEntryPointFunctionDecl(NewFD); + if (NewFD->hasAttr()) +SYCL().CheckSYCLExternalFunctionDecl(NewFD); erichkeane wrote:

[clang-tools-extra] [clang-doc] integrate JSON as the source for Mustache templates (PR #149589)

2025-07-23 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/149589 >From 7ecaad5127246bce4a836d2bbf419f062d170b85 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Fri, 18 Jul 2025 13:59:44 -0700 Subject: [PATCH] [clang-doc] integrate JSON as the source for Mustache templates

[clang] [clang][test] Specify value of `-fopenmp=libomp` for test. (PR #150301)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jordan Rupprecht (rupprecht) Changes `libomp` is the default value when unconfigured in cmake, but llvm can be configured to have `libgomp` be the default instead. Explicitly specify this value so the test does not fail when it assumes li

[clang] [clang][test] Specify value of `-fopenmp=libomp` for test. (PR #150301)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jordan Rupprecht (rupprecht) Changes `libomp` is the default value when unconfigured in cmake, but llvm can be configured to have `libgomp` be the default instead. Explicitly specify this value so the test does not fail when it ass

[clang] [clang][test] Specify value of `-fopenmp=libomp` for test. (PR #150301)

2025-07-23 Thread Jordan Rupprecht via cfe-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/150301 `libomp` is the default value when unconfigured in cmake, but llvm can be configured to have `libgomp` be the default instead. Explicitly specify this value so the test does not fail when it assumes libomp is

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -12251,6 +12264,9 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, if (NewFD->hasAttr()) SYCL().CheckSYCLEntryPointFunctionDecl(NewFD); + if (NewFD->hasAttr()) +SYCL().CheckSYCLExternalFunctionDecl(NewFD); tahonermann wrote:

[clang-tools-extra] [clang-doc] integrate JSON as the source for Mustache templates (PR #149589)

2025-07-23 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/149589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] refactor JSON for better Mustache compatibility (PR #149588)

2025-07-23 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/149588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4db2f3a - [clang-doc] refactor JSON for better Mustache compatibility (#149588)

2025-07-23 Thread via cfe-commits
Author: Erick Velez Date: 2025-07-23T12:53:07-07:00 New Revision: 4db2f3ac89b1e62af4893b647d77f3ab1f390066 URL: https://github.com/llvm/llvm-project/commit/4db2f3ac89b1e62af4893b647d77f3ab1f390066 DIFF: https://github.com/llvm/llvm-project/commit/4db2f3ac89b1e62af4893b647d77f3ab1f390066.diff L

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/150290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4781305 - [clang-tidy] Ignore pure-virtual in portability-template... (#150290)

2025-07-23 Thread via cfe-commits
Author: Piotr Zegar Date: 2025-07-23T21:51:58+02:00 New Revision: 478130545bc41a8bb80304e5d931559a9d2b6171 URL: https://github.com/llvm/llvm-project/commit/478130545bc41a8bb80304e5d931559a9d2b6171 DIFF: https://github.com/llvm/llvm-project/commit/478130545bc41a8bb80304e5d931559a9d2b6171.diff L

[clang] [CIR] Implement CK_LValueToRValueBitCast for ComplexType (PR #150296)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds support for CK_LValueToRValueBitCast for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/150296.diff 2 Files Af

[clang] [CIR] Implement CK_LValueToRValueBitCast for ComplexType (PR #150296)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for CK_LValueToRValueBitCast for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/150296.diff 2 Files Affe

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/150290 >From 76f481c6471f71151855082360416078c14675ea Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 23 Jul 2025 19:11:28 + Subject: [PATCH 1/2] [clang-tidy] Ignore pure-virtual in portability-template...

[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: > Also I think `clang-tidy-diff.py` should refer to Clang-Tidy. Several places > are affected. Do you mean renaming `clang-tidy` -> `Clang-Tidy` in scripts output/docs? https://github.com/llvm/llvm-project/pull/149739 ___ cfe-commits

[clang-tools-extra] [clang-doc] refactor JSON for better Mustache compatibility (PR #149588)

2025-07-23 Thread Erick Velez via cfe-commits
evelez7 wrote: ### Merge activity * **Jul 23, 7:51 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/149588). https://github.com/llvm/llvm-project/pull/149588

[clang] [CIR] Implement CK_LValueToRValueBitCast for ComplexType (PR #150296)

2025-07-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/150296 This change adds support for CK_LValueToRValueBitCast for ComplexType https://github.com/llvm/llvm-project/issues/141365 >From 670aae7394804492de6c86b6068a650391de7004 Mon Sep 17 00:00:00 2001 From: AmrDev

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -12937,6 +12937,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr() && + !D->hasAttr()) erichkeane wrote: An additional thought after clicking 'start-review': P

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/150290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/150290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM with nit https://github.com/llvm/llvm-project/pull/150290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/150290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Baranov Victor via cfe-commits
@@ -171,3 +171,20 @@ struct NoInstantiation{ }; }; } // namespace PartialSpecializationNoInstantiation + +namespace PR139031 { vbvictor wrote: nit: IMO `PR-` or `GH-XXX` namespaces just bloat code without any benefits, `git blame` can do the job. And

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -12937,6 +12937,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr() && + !D->hasAttr()) tahonermann wrote: Your suggested change would not be correct because it

[clang] [clang-repl] Disable new test after #148701 (PR #150294)

2025-07-23 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/150294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Disable new test after #148701 (PR #150294)

2025-07-23 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/150294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Disable new test after #148701 (PR #150294)

2025-07-23 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/150294 >From ca713312086af52124108251bedded8aca4dd834 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Wed, 23 Jul 2025 19:27:50 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] [WebAssembly,clang] Add __builtin_wasm_test_function_pointer_signature (PR #150201)

2025-07-23 Thread Hood Chatham via cfe-commits
hoodmane wrote: My thought is that it returns the return value. If one of the signatures matches it sets `*success = 1` otherwise it sets `*success = 0`. It probably can be written in terms of `__builtin_wasm_test_function_pointer_signature` with C++ templates but lot of projects I contribute

[clang] [clang-repl] Disable new test after #148701 (PR #150294)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qinkun Bao (qinkunbao) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/150294.diff 1 Files Affected: - (modified) clang/test/Interpreter/pretty-print.c (+1-1) ``diff diff --git a/clang/test/Interpreter/prett

[clang] [clang-repl] Disable new test after #148701 (PR #150294)

2025-07-23 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao created https://github.com/llvm/llvm-project/pull/150294 None >From ca713312086af52124108251bedded8aca4dd834 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Wed, 23 Jul 2025 19:27:50 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [CIR] Upstream Support Init ComplexType from 1 size InitList (PR #150293)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for init ComplexType from InitList with 1 size https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/

[clang] [CIR] Upstream Support Init ComplexType from 1 size InitList (PR #150293)

2025-07-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/150293 This change adds support for init ComplexType from InitList with 1 size https://github.com/llvm/llvm-project/issues/141365 >From cdbeea744cf63c1223d9fc9bf994ab9dc5ad6dbf Mon Sep 17 00:00:00 2001 From: AmrD

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Baranov Victor via cfe-commits
@@ -96,3 +96,45 @@ Note in the LLVM alias, the default value is `false`. matched against only the type name (i.e. ``Type``). E.g. to suppress reports for ``std::array`` iterators use `std::array<.*>::(const_)?iterator` string. The default is an empty string. + +.. option:

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Baranov Victor via cfe-commits
@@ -114,6 +114,11 @@ Changes in existing checks ` check by adding detection for variables introduced by structured bindings. +- Improved :doc:`readability-qualified-auto + ` check by adding the option + `IgnoreAliasing`, that allows not looking at underlying types of typ

[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread via cfe-commits
@@ -93,6 +93,10 @@ Improvements to clang-query Improvements to clang-tidy -- +- The ``run-clang-tidy.py`` and ``clang-tidy-diff.py`` scripts now run checks in EugeneZelenko wrote: ```suggestion - The :program:`run-clang-tidy.py` and :

[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread via cfe-commits
https://github.com/EugeneZelenko commented: Also I think `clang-tidy-diff.py` should refer to Clang-Tidy. Several places are affected. https://github.com/llvm/llvm-project/pull/149739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/149739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Ignore pure virtual member functions in portability-template-virtual-member-function check. Those functions will be represented in vtable as __cxa_pure_virtual or something similar. Fixes #139031. ---

[clang-tools-extra] [clang-tidy] Ignore pure-virtual in portability-template... (PR #150290)

2025-07-23 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/150290 Ignore pure virtual member functions in portability-template-virtual-member-function check. Those functions will be represented in vtable as __cxa_pure_virtual or something similar. Fixes #139031. >From 76f4

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/150282 >From 0bb04ba187b4d4a343f2f6f949615a0d98fd046d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 23 Jul 2025 14:00:45 -0400 Subject: [PATCH 1/4] [C23] Handle type compatibility for enumerations better

[clang-tools-extra] [clang-tidy] Add parallel execution by default in 'run-clang-tidy' and 'clang-tidy-diff' (PR #149739)

2025-07-23 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/149739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/150282 >From 0bb04ba187b4d4a343f2f6f949615a0d98fd046d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 23 Jul 2025 14:00:45 -0400 Subject: [PATCH 1/3] [C23] Handle type compatibility for enumerations better

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Please update your branch with main and resolve the conflicts https://github.com/llvm/llvm-project/pull/147060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Julian Schmidt via cfe-commits
@@ -96,3 +96,45 @@ Note in the LLVM alias, the default value is `false`. matched against only the type name (i.e. ``Type``). E.g. to suppress reports for ``std::array`` iterators use `std::array<.*>::(const_)?iterator` string. The default is an empty string. + +.. option:

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] added `IgnoreAliasing` option to `readability-qualified-auto check` (PR #147060)

2025-07-23 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/147060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/150282 >From 0bb04ba187b4d4a343f2f6f949615a0d98fd046d Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 23 Jul 2025 14:00:45 -0400 Subject: [PATCH 1/2] [C23] Handle type compatibility for enumerations better

[clang] [WebAssembly,clang] Add __builtin_wasm_test_function_pointer_signature (PR #150201)

2025-07-23 Thread Sam Clegg via cfe-commits
sbc100 wrote: > I'd also like to add `__builtin_wasm_nontrapping_call(&success, func, a, b, > c)` which tries to call func with 3, 2, 1, and 0 arguments. Where would the return value go here? Would end up in &success? What happens if none of the signatures match? Could you write this in ter

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-23 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: https://github.com/5chmidti approved this pull request. LGTM https://github.com/ll

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-23 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: @@ -9,6 +9,8 @@ different from the number of data members inside th

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-23 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?Message-ID: In-Reply-To: https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/135831 _

[clang] [llvm] [Clang][OpenMP] Capture mapped pointers on `target` by reference. (PR #145454)

2025-07-23 Thread Abhinav Gaba via cfe-commits
abhinavgaba wrote: > Even for cases where both the pointer, pointee are mapped, the expectation is > for the pointer to still be captured by-ref. >Why? Because we don't know if the pointer/pointee were both already existing on the device, in which case, there should be no pointer-attachment fo

[clang] [llvm] Implement `preserve_none` for 32-bit x86 (PR #150106)

2025-07-23 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > Okay, this is just adding them to the existing CSR_*_NoneRegs, correct? Yes. > Makes sense. Where do you think the best place to do this is? I think similar sorts of diagnostics are in llvm/lib/Target/X86/X86ISelLoweringCall.cpp . (Grep for errorUnsupported.) > How ab

[clang-tools-extra] [clang-tidy] ExprSequence: Handle ternary operators. (PR #132913)

2025-07-23 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/132913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix false positives in `bugprone-signed-char-misuse` (PR #149790)

2025-07-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Bj=C3=B6rn?= Svensson , =?utf-8?q?Bj=C3=B6rn?= Svensson , =?utf-8?q?Bj=C3=B6rn?= Svensson Message-ID: In-Reply-To: https://github.com/PiotrZSL approved this pull request. LGTM, rebase and could be merged https://github.com/llvm/llvm-project/pull/149790 __

[clang] [clang][OpenMP] In 6.0, can omit length in array section (PR #148048)

2025-07-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/23950 Here is the relevant piece of the build log fo

[clang-tools-extra] [clang-tidy] Speed up `misc-header-include-cycle` (PR #148757)

2025-07-23 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/148757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6a98171 - [clang-tidy] Speed up `misc-header-include-cycle` (#148757)

2025-07-23 Thread via cfe-commits
Author: Victor Chernyakin Date: 2025-07-23T20:14:29+02:00 New Revision: 6a9817113838a3f87e803ac71aab46b3ccf24686 URL: https://github.com/llvm/llvm-project/commit/6a9817113838a3f87e803ac71aab46b3ccf24686 DIFF: https://github.com/llvm/llvm-project/commit/6a9817113838a3f87e803ac71aab46b3ccf24686.d

[clang] [clang] Add a CodeGen option to ignore compilation directories (PR #149897)

2025-07-23 Thread David Blaikie via cfe-commits
dwblaikie wrote: > @dwblaikie The other possible implementation is here: #150112 > > It is so different and I don't feel it is really better so I used a separate > PR. I guess the reason I feel it is not better because the entire system has > lots of holes in it that just doesn't work in some

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: There's no release note because this is covered by the existing one about N3037. Assuming this patch is landed in time, it would be cherry-picked to the 21.x branch (which also has the release note). If it's not cherry-picked, then I'll add a release note to the main branch

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes An enumeration is compatible with its underlying type, which means that code like the following should be accepted: struct A { int h; }; void func() { extern struct A x; enum E : int { e };

[clang] [C23] Handle type compatibility for enumerations better (PR #150282)

2025-07-23 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/150282 An enumeration is compatible with its underlying type, which means that code like the following should be accepted: struct A { int h; }; void func() { extern struct A x; enum E : int { e };

[clang] [llvm] [Clang][OpenMP] Capture mapped pointers on `target` by reference. (PR #145454)

2025-07-23 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > I have one big question - why do we need this? If pointer is mapped > > explicitly, it becomes an attached pointer, which cannot be modified in > > target region. How we capture/process it, byref or byval, does not matter, > > we can do whatever is better. So, why do w

[clang] [CIR] Upstream Unary Plus & Minus op for ComplexType (PR #150281)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for Unary Plus & Minus op for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/150281.diff 3 Files Affecte

[clang] [CIR] Upstream Unary Plus & Minus op for ComplexType (PR #150281)

2025-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds support for Unary Plus & Minus op for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/150281.diff 3 Files Affec

[clang] [CIR] Upstream Unary Plus & Minus op for ComplexType (PR #150281)

2025-07-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/150281 This change adds support for Unary Plus & Minus op for ComplexType https://github.com/llvm/llvm-project/issues/141365 >From 19a9d55e62b829de872c152c40f41a4459bc8c45 Mon Sep 17 00:00:00 2001 From: AmrDevelo

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Kajetan Puchalski via cfe-commits
@@ -3706,14 +3706,19 @@ def fopenmp_relocatable_target : Flag<["-"], "fopenmp-relocatable-target">, def fnoopenmp_relocatable_target : Flag<["-"], "fnoopenmp-relocatable-target">, Group, Flags<[NoArgumentUnused, HelpHidden]>, Visibility<[ClangOption, CC1Option]>; -def fope

[clang] [Sema] Fix -Wunreachable-code false negative when operands differ only by implicit casts (PR #149972)

2025-07-23 Thread M. Zeeshan Siddiqui via cfe-commits
https://github.com/codemzs edited https://github.com/llvm/llvm-project/pull/149972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Kajetan Puchalski via cfe-commits
@@ -952,6 +954,9 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA, << A->getSpelling() << A->getValue(); break; } + } else { +Args.AddLastArg(CmdArgs, options::OPT_fopenmp_simd, mrkajetanp wrote: Yes, that's correct. If

[clang] 45d99c2 - [clang][OpenMP] In 6.0, can omit length in array section (#148048)

2025-07-23 Thread via cfe-commits
Author: David Pagan Date: 2025-07-23T10:53:38-07:00 New Revision: 45d99c26c3513945a454e90b69d48257886f8284 URL: https://github.com/llvm/llvm-project/commit/45d99c26c3513945a454e90b69d48257886f8284 DIFF: https://github.com/llvm/llvm-project/commit/45d99c26c3513945a454e90b69d48257886f8284.diff L

[clang] [clang][OpenMP] In 6.0, can omit length in array section (PR #148048)

2025-07-23 Thread David Pagan via cfe-commits
https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/148048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -12937,6 +12937,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr() && + !D->hasAttr()) erichkeane wrote: I understood what you meant, and strongly disagree. Th

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -12937,6 +12937,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr() && + !D->hasAttr()) tahonermann wrote: I mentioned global variables are just one example; we

[clang] [Sema] Fix -Wunreachable-code false negative when operands differ only by implicit casts (PR #149972)

2025-07-23 Thread M. Zeeshan Siddiqui via cfe-commits
@@ -1160,8 +1160,11 @@ class CFGBuilder { return {}; // Check that it is the same variable on both sides. -if (!Expr::isSameComparisonOperand(DeclExpr1, DeclExpr2)) - return {}; +if (!Expr::isSameComparisonOperand(DeclExpr1, DeclExpr2)) { + if (!Exp

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,71 @@ +//===--- CIRGenCleanup.cpp - Bookkeeping and code emission for cleanups ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,100 @@ +//===-- EHScopeStack.h - Stack for cleanup CIR generation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,100 @@ +//===-- EHScopeStack.h - Stack for cleanup CIR generation ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -235,46 +247,93 @@ void CIRGenFunction::LexicalScope::cleanup() { (void)emitReturn(*returnLoc); } - mlir::Block *curBlock = builder.getBlock(); - if (isGlobalInit() && !curBlock) -return; - if (curBlock->mightHaveTerminator() && curBlock->getTerminator()) -

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,71 @@ +//===--- CIRGenCleanup.cpp - Bookkeeping and code emission for cleanups ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -369,6 +369,19 @@ void CIRGenFunction::emitImplicitAssignmentOperatorBody(FunctionArgList &args) { s->getStmtClassName()); } +void CIRGenFunction::destroyCXXObject(CIRGenFunction &cgf, Address addr, + QualType typ

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm, besides nits https://github.com/llvm/llvm-project/pull/149948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/149948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for normal cleanups (PR #149948)

2025-07-23 Thread Henrich Lauko via cfe-commits
@@ -369,6 +369,19 @@ void CIRGenFunction::emitImplicitAssignmentOperatorBody(FunctionArgList &args) { s->getStmtClassName()); } +void CIRGenFunction::destroyCXXObject(CIRGenFunction &cgf, Address addr, + QualType typ

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -1641,6 +1641,13 @@ def DeviceKernel : DeclOrTypeAttr { }]; } +def SYCLExternal : InheritableAttr { + let Spellings = [Clang<"sycl_external">]; erichkeane wrote: > Ok, I'm fine with dropping the GNU spelling. But in that case, we should also > change the

[clang] [CIR] Add support for array constructors (PR #149142)

2025-07-23 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/149142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -1641,6 +1641,13 @@ def DeviceKernel : DeclOrTypeAttr { }]; } +def SYCLExternal : InheritableAttr { + let Spellings = [Clang<"sycl_external">]; tahonermann wrote: Ok, I'm fine with dropping the GNU spelling. But in that case, we should also change the `s

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/150269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Tarun Prabhu via cfe-commits
@@ -952,6 +954,9 @@ void Flang::ConstructJob(Compilation &C, const JobAction &JA, << A->getSpelling() << A->getValue(); break; } + } else { +Args.AddLastArg(CmdArgs, options::OPT_fopenmp_simd, tarunprabhu wrote: If I understand this c

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu commented: Thanks. The frontend parts of it look fine. I haven't looked too closely at the core OpenMP changes. https://github.com/llvm/llvm-project/pull/150269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [flang] [flang][OpenMP] Add -f[no]-openmp-simd (PR #150269)

2025-07-23 Thread Tarun Prabhu via cfe-commits
@@ -3706,14 +3706,19 @@ def fopenmp_relocatable_target : Flag<["-"], "fopenmp-relocatable-target">, def fnoopenmp_relocatable_target : Flag<["-"], "fnoopenmp-relocatable-target">, Group, Flags<[NoArgumentUnused, HelpHidden]>, Visibility<[ClangOption, CC1Option]>; -def fope

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -12251,6 +12264,9 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, if (NewFD->hasAttr()) SYCL().CheckSYCLEntryPointFunctionDecl(NewFD); + if (NewFD->hasAttr()) +SYCL().CheckSYCLExternalFunctionDecl(NewFD); erichkeane wrote:

[clang-tools-extra] [clang-tidy] modernize-use-std-print, format: Fix checks with Abseil functions (PR #142312)

2025-07-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: Could you rebase from latest main? After ReleaseNotes were cleared, there are merge conflicts almost every PR..:( https://github.com/llvm/llvm-project/pull/142312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Erich Keane via cfe-commits
@@ -12937,6 +12937,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr() && + !D->hasAttr()) erichkeane wrote: Hmmm... this skips quite a bit which causes obvious dis

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -12251,6 +12264,9 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, if (NewFD->hasAttr()) SYCL().CheckSYCLEntryPointFunctionDecl(NewFD); + if (NewFD->hasAttr()) +SYCL().CheckSYCLExternalFunctionDecl(NewFD); tahonermann wrote:

[clang] [WebAssembly,clang] Add __builtin_wasm_test_function_pointer_signature (PR #150201)

2025-07-23 Thread Hood Chatham via cfe-commits
hoodmane wrote: I'd also like to add `__builtin_wasm_nontrapping_call(&success, func, a, b, c)` which tries to call func with 3, 2, 1, and 0 arguments. https://github.com/llvm/llvm-project/pull/150201 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-23 Thread Tom Honermann via cfe-commits
@@ -16275,6 +16297,13 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body, } } + if (FD && !FD->isInvalidDecl() && FD->hasAttr()) { +SYCLExternalAttr *SEAttr = FD->getAttr(); +if (FD->isDeletedAsWritten()) tahonermann wrote: Sindhu an

[clang-tools-extra] [clang-tidy] add modernize-use-constexpr check (PR #146553)

2025-07-23 Thread via cfe-commits
@@ -142,6 +142,11 @@ New checks Finds unscoped (non-class) ``enum`` declarations and suggests using ``enum class`` instead. +- New :doc:`modernize-use-constexpr EugeneZelenko wrote: Please rebase from `main`. https://github.com/llvm/llvm-project/pull/146

[clang] [llvm] Implement `preserve_none` for 32-bit x86 (PR #150106)

2025-07-23 Thread Brandt Bucher via cfe-commits
brandtbucher wrote: How about we add the base pointers to both clobber lists here and leave the nest parameter as a future improvement for another PR? The calling convention is ABI-unstable, so we can always tweak it later. https://github.com/llvm/llvm-project/pull/150106 _

[clang] [llvm] Implement `preserve_none` for 32-bit x86 (PR #150106)

2025-07-23 Thread Brandt Bucher via cfe-commits
brandtbucher wrote: Okay. Both of those concerns already apply to the existing 64-bit flavor, right? Would you prefer to see them addressed here, or in a dedicated follow-up? > For "nest", we can forbid combining it with the preserves_none calling > convention, probably, as long as we can dete

  1   2   3   4   >