dwblaikie wrote:

> @dwblaikie The other possible implementation is here: #150112
> 
> It is so different and I don't feel it is really better so I used a separate 
> PR. I guess the reason I feel it is not better because the entire system has 
> lots of holes in it that just doesn't work in some cases regardless if how it 
> is implemented, 

I worry that adding more distinct options is likely to complicate things 
further, though...

> * If -fdebug-compilation-dir is a relative path, the `DIFile` will just not 
> going to point to an absolute path and defeat the purpose.
> * The interaction with `-fdebug-prefix-map` is also weird and not correct in 
> many cases. In the other PR, I added this test case to show the remapped path 
> is simply wrong and cannot be recovered: 
> https://github.com/llvm/llvm-project/blob/2b68ec15d8a555196220dc29bd9cc31368241147/clang/test/CodeGen/debug-prefix-map.c#L59

Are these existing bugs, or bugs that occur with the alternative patch?



https://github.com/llvm/llvm-project/pull/149897
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to