[clang] [lld] [llvm] [Clang][AArch64] Remove redundant tune args to the backend (PR #146896)

2025-07-04 Thread Tomer Shafir via cfe-commits
https://github.com/tomershafir closed https://github.com/llvm/llvm-project/pull/146896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 65e11f6 - [Clang][AArch64] Remove redundant tune args to the backend (#146896)

2025-07-04 Thread via cfe-commits
Author: Tomer Shafir Date: 2025-07-05T09:36:13+03:00 New Revision: 65e11f600db346321fde400832c86a12e4ee5882 URL: https://github.com/llvm/llvm-project/commit/65e11f600db346321fde400832c86a12e4ee5882 DIFF: https://github.com/llvm/llvm-project/commit/65e11f600db346321fde400832c86a12e4ee5882.diff

[clang] [Clang][Sema] Do not perform error recovery for invalid member using-declaration in C++20+ mode (PR #147003)

2025-07-04 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis closed https://github.com/llvm/llvm-project/pull/147003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3d6f4fb - [Clang][Sema] Do not perform error recovery for invalid member using-declaration in C++20+ mode (#147003)

2025-07-04 Thread via cfe-commits
Author: Yanzuo Liu Date: 2025-07-05T14:30:28+08:00 New Revision: 3d6f4fb5f7acb1cecd8ee143627d2538781a6241 URL: https://github.com/llvm/llvm-project/commit/3d6f4fb5f7acb1cecd8ee143627d2538781a6241 DIFF: https://github.com/llvm/llvm-project/commit/3d6f4fb5f7acb1cecd8ee143627d2538781a6241.diff LO

[clang] [clang] Fix a typo in documentation (PR #147128)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/147128.diff 1 Files Affected: - (modified) clang/docs/DebuggingCoroutines.rst (+1-1) ``diff diff --git a/clang/docs/DebuggingCorou

[clang] [clang] Fix a typo in documentation (PR #147128)

2025-07-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/147128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Fix a typo in documentation (PR #147128)

2025-07-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/147128 None >From 2415ca3a80794508f5973475ab6d3ce26c1a8687 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 4 Jul 2025 21:45:19 -0700 Subject: [PATCH] [lldb] Fix a typo in documentation --- clang/docs/De

[clang] [Clang][Sema] Do not perform error recovery for invalid member using-declaration in C++20+ mode (PR #147003)

2025-07-04 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/147003 >From 32e2c12d44da29e20212bdeed3628d4c736191ad Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Fri, 4 Jul 2025 13:58:17 +0800 Subject: [PATCH] Do not perform error recovery for invalid member using-declaration in

[clang] [llvm] [LLVM] Add GNU make jobserver support (PR #145131)

2025-07-04 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/145131 >From 5b5953d2df2bf2aae652625d2a566bc923a8dbfe Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Tue, 17 Jun 2025 17:01:07 -0400 Subject: [PATCH] [Clang][Driver] Add jobserver support for --offload-jobs T

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread via cfe-commits
YexuanXiao wrote: The failed libc++ test with Android target is related to `has_unique_object_representations`, which I think is unrelated to this change. https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [llvm] [LLVM] Add GNU make jobserver support (PR #145131)

2025-07-04 Thread Yaxun Liu via cfe-commits
@@ -133,6 +140,85 @@ void StdThreadPool::processTasks(ThreadPoolTaskGroup *WaitingForGroup) { } } +/// Main loop for worker threads when using a jobserver. +/// This function uses a two-level queue; it first acquires a job slot from the +/// external jobserver, then retriev

[clang] [llvm] [LLVM] Add GNU make jobserver support (PR #145131)

2025-07-04 Thread Yaxun Liu via cfe-commits
@@ -79,7 +86,7 @@ void StdThreadPool::processTasks(ThreadPoolTaskGroup *WaitingForGroup) { // Yeah, we have a task, grab it and release the lock on the queue // We first need to signal that we are active before popping the queue - // in order for wait() to pr

[clang] [llvm] [LLVM] Add GNU make jobserver support (PR #145131)

2025-07-04 Thread Yaxun Liu via cfe-commits
@@ -133,6 +140,85 @@ void StdThreadPool::processTasks(ThreadPoolTaskGroup *WaitingForGroup) { } } +/// Main loop for worker threads when using a jobserver. +/// This function uses a two-level queue; it first acquires a job slot from the +/// external jobserver, then retriev

[clang] [llvm] [LLVM] Add GNU make jobserver support (PR #145131)

2025-07-04 Thread Yaxun Liu via cfe-commits
@@ -119,7 +130,25 @@ class ThreadPoolExecutor : public Executor { auto Task = std::move(WorkStack.back()); WorkStack.pop_back(); Lock.unlock(); - Task(); + + if (TheJobserver) { +JobSlot Slot = TheJobserver->tryAcquire(); +if (Slot.is

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread Matheus Izvekov via cfe-commits
@@ -3455,9 +3454,12 @@ void Sema::DeclareGlobalAllocationFunction(DeclarationName Name, if (Func->getNumParams() == Params.size()) { llvm::SmallVector FuncParams; for (auto *P : Func->parameters()) - FuncParams.push_back( - Context.g

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread Matheus Izvekov via cfe-commits
@@ -3455,9 +3454,12 @@ void Sema::DeclareGlobalAllocationFunction(DeclarationName Name, if (Func->getNumParams() == Params.size()) { llvm::SmallVector FuncParams; for (auto *P : Func->parameters()) - FuncParams.push_back( - Context.g

[clang] [Driver][RISCV] Fix incorrect compiler-rt path override in BareMetal toolchain after RISCVToolChain removal (PR #146849)

2025-07-04 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/146849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][RISCV] Fix incorrect compiler-rt path override in BareMetal toolchain after RISCVToolChain removal (PR #146849)

2025-07-04 Thread Petr Hosek via cfe-commits
@@ -206,6 +206,15 @@ std::string BareMetal::computeSysRoot() const { return computeClangRuntimesSysRoot(D, /*IncludeTriple*/ true); } +std::string BareMetal::getCompilerRTPath() const { + if (IsGCCInstallationValid || detectGCCToolchainAdjacent(getDriver())) { +SmallStr

[clang] [Driver] Use range-based for loops (NFC) (PR #146987)

2025-07-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 21fb7e6 - [Driver] Use range-based for loops (NFC) (#146987)

2025-07-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-07-04T18:38:21-07:00 New Revision: 21fb7e68ef05180e71e454fb4daecdcb75256a5e URL: https://github.com/llvm/llvm-project/commit/21fb7e68ef05180e71e454fb4daecdcb75256a5e DIFF: https://github.com/llvm/llvm-project/commit/21fb7e68ef05180e71e454fb4daecdcb75256a5e.diff L

[clang] [Index] Remove an unnecessary cast (NFC) (PR #146944)

2025-07-04 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add2c58 - [Index] Remove an unnecessary cast (NFC) (#146944)

2025-07-04 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-07-04T18:38:13-07:00 New Revision: add2c58e6560697262a77c0014e7f825f5935fc9 URL: https://github.com/llvm/llvm-project/commit/add2c58e6560697262a77c0014e7f825f5935fc9 DIFF: https://github.com/llvm/llvm-project/commit/add2c58e6560697262a77c0014e7f825f5935fc9.diff L

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-04 Thread Tomohiro Kashiwada via cfe-commits
kikairoya wrote: `git clang-format` makes reformat below, should it be applied? ```diff diff --git a/clang/include/clang-c/Platform.h b/clang/include/clang-c/Platform.h index 8d341ddd6f8e..1c28ccf81981 100644 --- a/clang/include/clang-c/Platform.h +++ b/clang/include/clang-c/Platform.h @@ -23,13

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-04 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h -- clang/include/clang-c/Platform.h `` View t

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-04 Thread Tomohiro Kashiwada via cfe-commits
kikairoya wrote: Before merge this, requires https://github.com/llvm/llvm-project/pull/147108 https://github.com/llvm/llvm-project/pull/147122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes This is needed for Cygwin build without `-DLLVM_LINK_LLVM_DYLIB=ON`, otherwise causes a linker error 'export ordinal too large'. --- Full diff: https://github.com/llvm/llvm-project/pull/147122.diff

[clang] [libclang][Cygwin] Use __declspec(dllexport) for libclang on Cygwin (PR #147122)

2025-07-04 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/147122 This is needed for Cygwin build without `-DLLVM_LINK_LLVM_DYLIB=ON`, otherwise causes a linker error 'export ordinal too large'. >From 4406a457b7cf3713dc9bea67bd7b68ecb61966bd Mon Sep 17 00:00:00 2001 From: k

[clang] [clang][diagnostics] Refactor "warn_doc_api_container_decl_mismatch" to use enum_select (PR #146433)

2025-07-04 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Can we merge this with private email address? https://github.com/llvm/llvm-project/pull/146433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread Bogdan Vetrenko via cfe-commits
https://github.com/bv2k4 edited https://github.com/llvm/llvm-project/pull/147119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add alignment attr & propagate alignment through make.buffer.rsrc inst (PR #145278)

2025-07-04 Thread Shilei Tian via cfe-commits
@@ -85,7 +85,7 @@ __amdgpu_buffer_rsrc_t test_amdgcn_make_buffer_p0_nullptr(short stride, int num, // CHECK-LABEL: @test_amdgcn_make_buffer_p1_nullptr( // CHECK-NEXT: entry: -// CHECK-NEXT:[[TMP0:%.*]] = tail call ptr addrspace(8) @llvm.amdgcn.make.buffer.rsrc.p8.p1(ptr

[clang] [Index] Remove an unnecessary cast (NFC) (PR #146944)

2025-07-04 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/146944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Use range-based for loops (NFC) (PR #146987)

2025-07-04 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/146987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules-driver] Add scanner to detect C++20 module presence (PR #145220)

2025-07-04 Thread Naveen Seth Hanig via cfe-commits
naveen-seth wrote: Done. For the regression test, I've updated it to use `--allow-empty` instead of forcing output using `clang -v` (+formatting & removed duplicate flags). Thank you for the reviews. https://github.com/llvm/llvm-project/pull/145220 _

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread Bogdan Vetrenko via cfe-commits
https://github.com/bv2k4 updated https://github.com/llvm/llvm-project/pull/147119 >From 9d8f8dcaacadac7d038da4cc6c72f1bbaceab7c0 Mon Sep 17 00:00:00 2001 From: Bogdan Vetrenko Date: Sat, 5 Jul 2025 01:53:01 +0300 Subject: [PATCH] [clang][NFC] Use switch in LoopHintAttr::getValueString --- cla

[clang] [clang][modules-driver] Add scanner to detect C++20 module presence (PR #145220)

2025-07-04 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/145220 >From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001 From: Naveen Seth Hanig Date: Fri, 13 Jun 2025 09:19:21 +0200 Subject: [PATCH 1/7] [clang][modules-driver] Add scanner to detect C++20

[clang] [llvm] [WPD]: Apply speculative WPD in non-lto mode. (PR #145031)

2025-07-04 Thread Hassnaa Hamdi via cfe-commits
hassnaaHamdi wrote: hola! @teresajohnson @pcc https://github.com/llvm/llvm-project/pull/145031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Avoid printing overly large integer/_BitInt numbers in static assertion failure diagnostics #71675 (PR #145053)

2025-07-04 Thread via cfe-commits
https://github.com/maramatias updated https://github.com/llvm/llvm-project/pull/145053 >From f58ea201585cb1b0128f97b9edb07f35621d81b0 Mon Sep 17 00:00:00 2001 From: Mara Matias Date: Wed, 18 Jun 2025 09:06:10 -0700 Subject: [PATCH 1/2] [clang] Avoid printing overly large integer/_BitInt number

[clang] [clang][diagnostics] Refactor "warn_doc_container_decl_mismatch" to use enum_select (PR #147120)

2025-07-04 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Developer Policy](https://llvm.org/docs/DeveloperPol

[clang] [clang][diagnostics] Refactor "warn_doc_container_decl_mismatch" to use enum_select (PR #147120)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ayokunle Amodu (ayokunle321) Changes Related: https://github.com/llvm/llvm-project/issues/123121 This patch refactors the `warn_doc_container_decl_mismatch` diagnostic to use `enum_select` instead of `select`. This gets rid of magic numbe

[clang] [clang][diagnostics] Refactor "warn_doc_container_decl_mismatch" to use enum_select (PR #147120)

2025-07-04 Thread Ayokunle Amodu via cfe-commits
https://github.com/ayokunle321 created https://github.com/llvm/llvm-project/pull/147120 Related: https://github.com/llvm/llvm-project/issues/123121 This patch refactors the `warn_doc_container_decl_mismatch` diagnostic to use `enum_select` instead of `select`. This gets rid of magic numbers an

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread Matheus Izvekov via cfe-commits
@@ -3397,7 +3397,8 @@ void Sema::DeclareGlobalNewDelete() { GlobalNewDeleteDeclared = true; QualType VoidPtr = Context.getPointerType(Context.VoidTy); - QualType SizeT = Context.getSizeType(); + // FIXME: Why is 'Canonical'SizeType needed here? + QualType SizeT = Contex

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread Bogdan Vetrenko via cfe-commits
https://github.com/bv2k4 updated https://github.com/llvm/llvm-project/pull/147119 >From ca25a88e68423559798d75b85be70e00a42313b4 Mon Sep 17 00:00:00 2001 From: Bogdan Vetrenko Date: Sat, 5 Jul 2025 01:53:01 +0300 Subject: [PATCH] [clang][NFC] Use switch in LoopHintAttr::getValueString --- cla

[clang] [clang-tools-extra] [libcxx] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-04 Thread via cfe-commits
@@ -3397,7 +3397,8 @@ void Sema::DeclareGlobalNewDelete() { GlobalNewDeleteDeclared = true; QualType VoidPtr = Context.getPointerType(Context.VoidTy); - QualType SizeT = Context.getSizeType(); + // FIXME: Why is 'Canonical'SizeType needed here? + QualType SizeT = Contex

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bogdan Vetrenko (bv2k4) Changes Replace if-else chain with switch over enum. --- Full diff: https://github.com/llvm/llvm-project/pull/147119.diff 1 Files Affected: - (modified) clang/lib/AST/AttrImpl.cpp (+25-12) ``diff diff

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][NFC] Use switch in LoopHintAttr::getValueString (PR #147119)

2025-07-04 Thread Bogdan Vetrenko via cfe-commits
https://github.com/bv2k4 created https://github.com/llvm/llvm-project/pull/147119 Replace if-else chain with switch over enum. >From ca25a88e68423559798d75b85be70e00a42313b4 Mon Sep 17 00:00:00 2001 From: Bogdan Vetrenko Date: Sat, 5 Jul 2025 01:53:01 +0300 Subject: [PATCH] [clang][NFC] Use sw

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-04 Thread Baranov Victor via cfe-commits
vbvictor wrote: > I'm planning for an autofix of float and double since it's unambiguous what > those types should be. For int types, maybe I'll give 3 options for an autofix: Fixed (int32_t) Fast (int_fast32_t) Least (int_least32_t) You could make a universal option to configure autofixes. Mak

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-04 Thread JJ Marr via cfe-commits
jj-marr wrote: > Check makes sense to me! As a first iteration it's fine without autofix but I > can imagine it will be hard for a codebase to enable this check given the > large amount of things to fix. Maybe users can specify a mapping of wanted > types via an option? I'm planning for an au

[clang] [flang] [Clang] Introduce `--offload-targets` for `-fopenmp-targets` (PR #146594)

2025-07-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/146594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6db02dc - [Clang] Introduce `--offload-targets` for `-fopenmp-targets` (#146594)

2025-07-04 Thread via cfe-commits
Author: Joseph Huber Date: 2025-07-04T16:20:53-05:00 New Revision: 6db02dc4311b3ee52ec6e7e5e5cafb2600e7b30f URL: https://github.com/llvm/llvm-project/commit/6db02dc4311b3ee52ec6e7e5e5cafb2600e7b30f DIFF: https://github.com/llvm/llvm-project/commit/6db02dc4311b3ee52ec6e7e5e5cafb2600e7b30f.diff

[clang] [libclang] Add missing dllexport annotation (PR #147108)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tomohiro Kashiwada (kikairoya) Changes All other declarations of clang-c already have CINDEX_LINKAGE. --- Full diff: https://github.com/llvm/llvm-project/pull/147108.diff 1 Files Affected: - (modified) clang/include/clang-c/FatalErrorHa

[clang] [libclang] Add missing dllexport annotation (PR #147108)

2025-07-04 Thread Tomohiro Kashiwada via cfe-commits
https://github.com/kikairoya created https://github.com/llvm/llvm-project/pull/147108 All other declarations of clang-c already have CINDEX_LINKAGE. >From 53359252688692f2b0e25f529335848db94cc166 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Sat, 28 Jun 2025 11:50:14 +0900 Subject: [PATCH] [l

[clang] Reland "[Modules] Record whether VarDecl initializers contain side effects" (PR #145447)

2025-07-04 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > > You don't happen to be using the new constant interpreter? > > Not sure what you mean by this. We're using the unmodified compiler and > testing its correctness on google internal code. Then you're likely not. I was just making sure, because the constant evaluation takes a

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-04 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > > Have you looked at google-runtime-int? It should be doing the same thing > > (maybe small differences) > > I haven't before now. I still think a new check is necessary. > > `google-runtime-int` isn't as strict because it is coupled to the Google > coding guidelines. That

[clang] Reland "[Modules] Record whether VarDecl initializers contain side effects" (PR #145447)

2025-07-04 Thread via cfe-commits
bgra8 wrote: > Do you have a reproducer you can share? Working to get a smaller repro. But this only reproduces for builds with modules enabled so it will take some time. > Does the type that's being casted to RecordType have RecordType as the > canonical type, or is it completely off? The

[clang-tools-extra] [clang-tidy] Add new check: `modernize-use-concise-preprocessor-directives` (PR #146830)

2025-07-04 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: +1 to moving to `readability`. What's the behavior when you have: ```cpp #if defined(foo) && defined(bar) ``` ? I don't believe I saw a test for this use case. As a user I would probably prefer to keep it as is instead of having one `ifdef` and one `if defined`. Perhaps

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-04 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Check makes sense to me! As a first iteration it's fine without autofix but I can imagine it will be hard for a codebase to enable this check given the large amount of things to fix. Maybe users can specify a mapping of wanted types via an option? https://github.com/llvm/

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147106)

2025-07-04 Thread Lei Huang via cfe-commits
https://github.com/lei137 updated https://github.com/llvm/llvm-project/pull/147106 >From 36d2b8fc61ab67b8d8010e8b33e3e871f8e1c4f2 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 4 Jul 2025 14:53:15 -0500 Subject: [PATCH 1/4] define new alias for accumulate builtins --- clang/include/clang

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/147074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/147074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Speedup getFileIDLocal with a separate offset table. (PR #146604)

2025-07-04 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/146604 >From 7b06dabcc8fafee1e9ff3261264c36a44cb7b0a3 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 1 Jul 2025 22:04:51 +0200 Subject: [PATCH] [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

[clang] [clang][diagnostics] Refactor "warn_doc_api_container_decl_mismatch" to use enum_select (PR #146433)

2025-07-04 Thread Ayokunle Amodu via cfe-commits
ayokunle321 wrote: > thanks. will you need us to merge that for you? Yes please https://github.com/llvm/llvm-project/pull/146433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][diagnostics] Refactor "warn_doc_api_container_decl_mismatch" to use enum_select (PR #146433)

2025-07-04 Thread Ayokunle Amodu via cfe-commits
ayokunle321 wrote: > cor3ntin Yes please https://github.com/llvm/llvm-project/pull/146433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] SourceManager: Cache offsets for LastFileIDLookup to speed up getFileID (PR #146782)

2025-07-04 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/146782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e2510b1 - [clang] SourceManager: Cache offsets for LastFileIDLookup to speed up getFileID (#146782)

2025-07-04 Thread via cfe-commits
Author: Haojian Wu Date: 2025-07-04T22:11:59+02:00 New Revision: e2510b189dae1a18c1e84ea69c99ff417950e03a URL: https://github.com/llvm/llvm-project/commit/e2510b189dae1a18c1e84ea69c99ff417950e03a DIFF: https://github.com/llvm/llvm-project/commit/e2510b189dae1a18c1e84ea69c99ff417950e03a.diff LO

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-04 Thread JJ Marr via cfe-commits
jj-marr wrote: > Have you looked at google-runtime-int? It should be doing the same thing > (maybe small differences) I haven't before now. I still think a new check is necessary. `google-runtime-int` isn't as strict because it is coupled to the Google coding guidelines. That means it doesn'

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147106)

2025-07-04 Thread Lei Huang via cfe-commits
https://github.com/lei137 updated https://github.com/llvm/llvm-project/pull/147106 >From 36d2b8fc61ab67b8d8010e8b33e3e871f8e1c4f2 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 4 Jul 2025 14:53:15 -0500 Subject: [PATCH 1/2] define new alias for accumulate builtins --- clang/include/clang

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147106)

2025-07-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc Author: Lei Huang (lei137) Changes Initial clean up in prep for adding more accumulate builtins to clang. --- Full diff: https://github.com/llvm/llvm-project/pull/147106.diff 1 Files Affected: - (modified) clang/include/clang/Basic/Bu

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147106)

2025-07-04 Thread Lei Huang via cfe-commits
https://github.com/lei137 created https://github.com/llvm/llvm-project/pull/147106 Initial clean up in prep for adding more accumulate builtins to clang. >From 36d2b8fc61ab67b8d8010e8b33e3e871f8e1c4f2 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 4 Jul 2025 14:53:15 -0500 Subject: [PATCH

[clang] [clang] Remove source range from CXXOperatorCallExpr (PR #147028)

2025-07-04 Thread Haojian Wu via cfe-commits
@@ -158,9 +158,9 @@ class CXXOperatorCallExpr final : public CallExpr { : getOperatorLoc(); } - SourceLocation getBeginLoc() const { return Range.getBegin(); } - SourceLocation getEndLoc() const { return Range.getEnd(); } - SourceRange getSourceRange() cons

[clang] [llvm] [DirectX] Validate registers are bound to root signature (PR #146785)

2025-07-04 Thread via cfe-commits
https://github.com/joaosaffran edited https://github.com/llvm/llvm-project/pull/146785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][diagnostics] Refactor "warn_doc_api_container_decl_mismatch" to use enum_select (PR #146433)

2025-07-04 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. thanks. will you need us to merge that for you? https://github.com/llvm/llvm-project/pull/146433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[libunwind] [libunwind] Add CMake option to enable execute-only code generation on AArch64 (PR #140554)

2025-07-04 Thread Fangrui Song via cfe-commits
=?utf-8?q?Csanád_Hajdú?= , =?utf-8?q?Csanád_Hajdú?= Message-ID: In-Reply-To: @@ -16,6 +16,8 @@ #if defined(_AIX) .toc +#elif defined(__aarch64__) && defined(__ELF__) && defined(_LIBUNWIND_EXECUTE_ONLY_CODE) MaskRay wrote: `defined(__ELF__)` seems unnece

[clang] [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (PR #146891)

2025-07-04 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/146891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][OpenMP] Add tests for mapping pointers and their dereferences. (PR #146934)

2025-07-04 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/146934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [win][clang] Do not inject static_assert macro definition (PR #147030)

2025-07-04 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/147030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor requested changes to this pull request. https://github.com/llvm/llvm-project/pull/147074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
@@ -38,3 +38,10 @@ Options #define IS_SIGNED(T) std::is_signed::value Defaults to `false`. + +Limitations +--- + +Does not currently diagnose uses of ``std::chrono::is_clock``, +``std::chrono::treat_as_floating_point``, ``std::tuple_element``, +or ``std::variant

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
@@ -130,6 +155,10 @@ static const llvm::StringSet<> TypeTraits = { "result_of", "invoke_result", "type_identity", +"compare_three_way_result", +"common_comparison_category", vbvictor wrote: This also has variadic templates https://github.c

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Victor Chernyakin via cfe-commits
@@ -130,6 +149,12 @@ static const llvm::StringSet<> TypeTraits = { "result_of", "invoke_result", "type_identity", +"tuple_element", localspook wrote: Done https://github.com/llvm/llvm-project/pull/147074 ___

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/147074 >From 7ad6f7b8663980183e8bb8e79843942870e36267 Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Fri, 4 Jul 2025 07:42:54 -0700 Subject: [PATCH 1/5] [clang-tidy] Teach `modernize-type-traits` about more

[clang] Reland "[Modules] Record whether VarDecl initializers contain side effects" (PR #145447)

2025-07-04 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > I patched #146468 after this change, rebuilt the compiler and reproduced the > same crash. So I guess that patch does not fix the issue I see here. Does > #146468 depend on some other change? It does not. Do you have a reproducer you can share? Does the type that's being cas

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2025-07-04 Thread Julian Schmidt via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang] [ASTMatchers][NFC] improve 'isInteger' docs to show matching of unsigned (PR #147012)

2025-07-04 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-01` while building `clang` at step 7 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/207/builds/33

[clang-tools-extra] [clang-tidy] Add new check: `modernize-use-concise-preprocessor-directives` (PR #146830)

2025-07-04 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,107 @@ +//===--- UseConcisePreprocessorDirectivesCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [ASTMatchers][NFC] improve 'isInteger' docs to show matching of unsigned (PR #147012)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/147012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 833839b - [ASTMatchers][NFC] improve 'isInteger' docs to show matching of unsigned (#147012)

2025-07-04 Thread via cfe-commits
Author: Baranov Victor Date: 2025-07-04T21:18:32+03:00 New Revision: 833839ba65fddf2aea2d8f4687c0497eff5cd180 URL: https://github.com/llvm/llvm-project/commit/833839ba65fddf2aea2d8f4687c0497eff5cd180 DIFF: https://github.com/llvm/llvm-project/commit/833839ba65fddf2aea2d8f4687c0497eff5cd180.diff

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/147074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
@@ -130,6 +149,12 @@ static const llvm::StringSet<> TypeTraits = { "result_of", "invoke_result", "type_identity", +"tuple_element", vbvictor wrote: I'd also suggest adding "Limitation" section in check docs. Search in docs directory for refere

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Victor Chernyakin via cfe-commits
localspook wrote: I've changed the tests to use `-std=c++17-or-later`, but I don't think we need to add tests for the new traits because they wouldn't exercise any new codepaths. It's not like we only match on `compare_three_way_result_t` if compiling in C++20, no, we match on all traits in al

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Baranov Victor via cfe-commits
@@ -130,6 +149,12 @@ static const llvm::StringSet<> TypeTraits = { "result_of", "invoke_result", "type_identity", +"tuple_element", vbvictor wrote: Please remove other recursive traits as well, `variant_alternative` is also one of them. https

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-04 Thread Victor Chernyakin via cfe-commits
@@ -130,6 +149,12 @@ static const llvm::StringSet<> TypeTraits = { "result_of", "invoke_result", "type_identity", +"tuple_element", localspook wrote: Good catch -- recursive traits are indeed problematic, the check fires on the recursive use i

[clang-tools-extra] [clang-tidy] Make `bugprone-unhandled-self-assignment` check more general (PR #147066)

2025-07-04 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/147066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2025-07-04 Thread Louis Dionne via cfe-commits
ldionne wrote: CC @philnik777 in case you want to take a look as well https://github.com/llvm/llvm-project/pull/78707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2025-07-04 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,65 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [libcxx] [clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2025-07-04 Thread Louis Dionne via cfe-commits
@@ -411,7 +412,33 @@ static void emitAtomicCmpXchg(CodeGenFunction &CGF, AtomicExpr *E, bool IsWeak, CGF.Builder.SetInsertPoint(StoreExpectedBB); // Update the memory at Expected with Old's value. - CGF.Builder.CreateStore(Old, Val1); +llvm::Type *ExpectedType = Expected

[clang] [libcxx] [clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2025-07-04 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,65 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [libcxx] [clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2025-07-04 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,65 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

  1   2   3   4   >