[clang] [clang][bytecode] Diagnose delete of non-heap-allocated blocks (PR #137475)

2025-04-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/137475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 031101c - [clang][bytecode] Diagnose delete of non-heap-allocated blocks (#137475)

2025-04-26 Thread via cfe-commits
Author: Timm Baeder Date: 2025-04-27T08:57:57+02:00 New Revision: 031101c66f152a1885ece1d7620071cb049edf51 URL: https://github.com/llvm/llvm-project/commit/031101c66f152a1885ece1d7620071cb049edf51 DIFF: https://github.com/llvm/llvm-project/commit/031101c66f152a1885ece1d7620071cb049edf51.diff L

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-04-26 Thread via cfe-commits
@@ -0,0 +1,748 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [ARM] Adding diagnostics for mcmodel=tiny when used in invalid targets (PR #125643)

2025-04-26 Thread via cfe-commits
https://github.com/ShashwathiNavada updated https://github.com/llvm/llvm-project/pull/125643 >From 0aebcd7119fbcd51154c5d9706752e8ff3f041bc Mon Sep 17 00:00:00 2001 From: ShashwathiNavada Date: Tue, 4 Feb 2025 00:16:09 -0600 Subject: [PATCH 1/9] Adding diagnostics for unsupported option --- c

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-04-26 Thread via cfe-commits
@@ -0,0 +1,77 @@ +//===--- ConflictingGlobalAccesses.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Added Conflicting Global Accesses checker (PR #130421)

2025-04-26 Thread via cfe-commits
@@ -0,0 +1,77 @@ +//===--- ConflictingGlobalAccesses.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-26 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/136842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX512FP16] Decouple AVX512VL and AVX512DQ from AVX512FP16 (PR #137450)

2025-04-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang,llvm` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16729 Here is the relevant piece o

[clang] [llvm] [X86][AVX512FP16] Decouple AVX512VL and AVX512DQ from AVX512FP16 (PR #137450)

2025-04-26 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/137450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WIP] Correct lowering of `fp128` intrinsics (PR #76558)

2025-04-26 Thread Trevor Gross via cfe-commits
https://github.com/tgross35 updated https://github.com/llvm/llvm-project/pull/76558 >From dafb3a378876db6b3bf505b425b386fd8f79c918 Mon Sep 17 00:00:00 2001 From: Trevor Gross Date: Fri, 11 Aug 2023 22:16:01 -0400 Subject: [PATCH 1/3] [IR] Add a test for `f128` libcall lowering (NFC) `f128` int

[clang] [llvm] [WIP] Correct lowering of `fp128` intrinsics (PR #76558)

2025-04-26 Thread Trevor Gross via cfe-commits
https://github.com/tgross35 updated https://github.com/llvm/llvm-project/pull/76558 >From 9089a966f2107a2dfcad86fec746e9f2bd8a105b Mon Sep 17 00:00:00 2001 From: Trevor Gross Date: Fri, 11 Aug 2023 22:16:01 -0400 Subject: [PATCH 1/5] [IR] Add a test for `f128` libcall lowering (NFC) `f128` int

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/4224 Here is the relevan

[clang] 6c33735 - [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (#136842)

2025-04-26 Thread via cfe-commits
Author: Pengcheng Wang Date: 2025-04-27T11:12:47+08:00 New Revision: 6c3373534305a2ce23dd939344dd0a387a09fe88 URL: https://github.com/llvm/llvm-project/commit/6c3373534305a2ce23dd939344dd0a387a09fe88 DIFF: https://github.com/llvm/llvm-project/commit/6c3373534305a2ce23dd939344dd0a387a09fe88.diff

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-26 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#137490 https://github.com/llvm/llvm-project/pull/136842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Allow `Zicsr`/`Zifencei` to duplicate with `g` (PR #136842)

2025-04-26 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: /cherry-pick 6c3373534305a2ce23dd939344dd0a387a09fe88 https://github.com/llvm/llvm-project/pull/136842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX512FP16] Decouple AVX512VL and AVX512DQ from AVX512FP16 (PR #137450)

2025-04-26 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. https://github.com/llvm/llvm-project/pull/137450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-04-26 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,75 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -global-isel=0 -mtriple=amdgcn -mcpu=gfx950 < %s | FileCheck -check-prefixes=GFX950,GFX950-SDAG %s +; RUN: llc -global-isel=1 -mtriple=amdgcn -mcpu=g

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-04-26 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/137425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-04-26 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/137425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-04-26 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,144 @@ +//===-- TargetVerifier.cpp - LLVM IR Target Verifier *- C++ -*-===// + +/ Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +/ See https://llvm.org/LICENSE.txt for license information. +/ SPDX-License

[clang] d403c70 - [clang-format] Annotate tok::star in a*b*c as BinaryOperator (#137433)

2025-04-26 Thread via cfe-commits
Author: Owen Pan Date: 2025-04-26T12:55:00-07:00 New Revision: d403c70ff31830bf5311be11b51363ae98d06068 URL: https://github.com/llvm/llvm-project/commit/d403c70ff31830bf5311be11b51363ae98d06068 DIFF: https://github.com/llvm/llvm-project/commit/d403c70ff31830bf5311be11b51363ae98d06068.diff LOG:

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-04-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/134196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit checkers] Treat std::bit_cast as a pointer conversion (PR #137476)

2025-04-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/137476 WebKit repalced its use of WTF::bitwise_cast with std::bit_cast. Add the support for recognizing it as a pointer conversion. >From c76e86105b5ba03cc2a3c8399670b2b38eb8e6ea Mon Sep 17 00:00:00 2001 From: Ryosuke N

[clang] [clang][bytecode] Diagnose delete of non-heap-allocated blocks (PR #137475)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes With std::allocator::deallocate() calls --- Full diff: https://github.com/llvm/llvm-project/pull/137475.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+7) - (modified) clang

[clang] [clang][bytecode] Diagnose delete of non-heap-allocated blocks (PR #137475)

2025-04-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/137475 With std::allocator::deallocate() calls >From bdada63879bdd12603273167a291eaa4c0971dc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 26 Apr 2025 22:57:55 +0200 Subject: [PATCH] [clang

[clang] Support pack expansion for Clang Thread Safety attributes (PR #137477)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Puchert (aaronpuchert) Changes Support for attribute parameter packs was added some time ago in commit ead1690d31f815c00fdd2bc23db4766191bbeabc. But template substitution didn't expand the packs yet. For now expansion can only happe

[clang] Support pack expansion for Clang Thread Safety attributes (PR #137477)

2025-04-26 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert created https://github.com/llvm/llvm-project/pull/137477 Support for attribute parameter packs was added some time ago in commit ead1690d31f815c00fdd2bc23db4766191bbeabc. But template substitution didn't expand the packs yet. For now expansion can only happen wi

[clang] [WebKit checkers] Treat std::bit_cast as a pointer conversion (PR #137476)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes WebKit repalced its use of WTF::bitwise_cast with std::bit_cast. Add the support for recognizing it as a pointer conversion. --- Full diff: https://github.com/llvm/

[clang] [clang] Fix and test triviality of __ptrauth types (PR #137474)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (halbi2) Changes Address-discriminated __ptrauth types do not have unique object representations so they are not trivially comparable. Test all other trivialities too even though they are not incorrect. Fixes #137473 --- Full diff:

[clang] [clang] Fix and test triviality of __ptrauth types (PR #137474)

2025-04-26 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Fix and test triviality of __ptrauth types (PR #137474)

2025-04-26 Thread via cfe-commits
https://github.com/halbi2 created https://github.com/llvm/llvm-project/pull/137474 Address-discriminated __ptrauth types do not have unique object representations so they are not trivially comparable. Test all other trivialities too even though they are not incorrect. Fixes #137473 >From 33c

[clang] [Clang] Make enums trivially equality comparable (PR #133587)

2025-04-26 Thread via cfe-commits
halbi2 wrote: @philnik777 Is anything else blocking this patch to fix #132672? Could you just change the commit message to what @shafik suggested and merge it please? > [clang] Make enums trivially equality comparable > > std::equal(std::byte) currently has sub-optimal codegen due to enum types

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-04-26 Thread via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?Message-ID: In-Reply-To: https://github.com/tigbr updated https://github.com/llvm/llvm-project/pull/135831 >From 525459a04dd6e7d0079095ac531c7cd712

[clang] [clang-format] Correctly handle C# new modifier (PR #137430)

2025-04-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/137430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate tok::star in a*b*c as BinaryOperator (PR #137433)

2025-04-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/137433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae07f48 - [clang-format] Correctly handle C# new modifier (#137430)

2025-04-26 Thread via cfe-commits
Author: Owen Pan Date: 2025-04-26T12:54:38-07:00 New Revision: ae07f48913faa44ea050e4e0602d0aa62449d942 URL: https://github.com/llvm/llvm-project/commit/ae07f48913faa44ea050e4e0602d0aa62449d942 DIFF: https://github.com/llvm/llvm-project/commit/ae07f48913faa44ea050e4e0602d0aa62449d942.diff LOG:

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -114,31 +112,39 @@ class FactEntry : public CapabilityExpr { }; private: - const FactEntryKind Kind : 8; + const FactEntryKind Kind : 4; /// Exclusive or shared. - LockKind LKind : 8; + const LockKind LKind : 4; + + /// How it was acquired. + const SourceKind S

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -168,6 +197,8 @@ class FactManager { public: FactID newFact(std::unique_ptr Entry) { Facts.push_back(std::move(Entry)); +assert(Facts.size() - 1 <= std::numeric_limits::max() && aaronpuchert wrote: ```suggestion assert(Facts.size() - 1 <= std:

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -235,6 +266,20 @@ class FactSet { return false; } + std::optional replaceLock(FactManager &FM, iterator It, +std::unique_ptr Entry) { +if (It == end()) + return std::nullopt; +FactID F = FM.newFact(std::move(Entry)); +

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert commented: Two more things come to mind: * Consider adding a check to `SemaDeclAttr.cpp` that the new attribute is always accompanied by `capability` or `lockable`. Although I wonder whether that's too early. I'm not sure if we can see the other attributes alread

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -114,31 +112,39 @@ class FactEntry : public CapabilityExpr { }; private: - const FactEntryKind Kind : 8; + const FactEntryKind Kind : 4; /// Exclusive or shared. - LockKind LKind : 8; + const LockKind LKind : 4; + + /// How it was acquired. + const SourceKind S

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -114,31 +112,39 @@ class FactEntry : public CapabilityExpr { }; private: - const FactEntryKind Kind : 8; + const FactEntryKind Kind : 4; /// Exclusive or shared. - LockKind LKind : 8; + const LockKind LKind : 4; + + /// How it was acquired. + const SourceKind S

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -388,7 +395,7 @@ class SExprBuilder { til::LiteralPtr *createVariable(const VarDecl *VD); // Create placeholder for this: we don't know the VarDecl on construction yet. - std::pair + std::pair aaronpuchert wrote: Nice idea, but I'm not sure if it's

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -271,26 +271,32 @@ class CFGWalker { // translateAttrExpr needs it, but that should be moved too. class CapabilityExpr { private: - /// The capability expression and whether it's negated. - llvm::PointerIntPair CapExpr; + /// The capability expression and flags. + llvm::

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -163,15 +184,15 @@ using FactID = unsigned short; /// the analysis of a single routine. class FactManager { private: - std::vector> Facts; + std::vector> Facts; aaronpuchert wrote: The FactEntries themselves should never be replaced, they are immutable. W

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
@@ -81,26 +81,25 @@ static bool isCalleeArrow(const Expr *E) { return ME ? ME->isArrow() : false; } -static StringRef ClassifyDiagnostic(const CapabilityAttr *A) { - return A->getName(); -} - -static StringRef ClassifyDiagnostic(QualType VDT) { +static CapabilityExpr makeCa

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-04-26 Thread Aaron Puchert via cfe-commits
https://github.com/aaronpuchert edited https://github.com/llvm/llvm-project/pull/137133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate tok::star in a*b*c as BinaryOperator (PR #137433)

2025-04-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/137433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly handle C# new modifier (PR #137430)

2025-04-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/137430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2025-04-26 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > Yes this is good to go Could you rebase it to apply to latest trunk please? I'm happy to go ahead and merge it then. https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/137465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ccdd55c - [clang] Fix unused variable warning in MS mangler from constant matrix patch

2025-04-26 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2025-04-26T09:17:56-07:00 New Revision: ccdd55c518277d749eff878ffcb5ca3de55c2a60 URL: https://github.com/llvm/llvm-project/commit/ccdd55c518277d749eff878ffcb5ca3de55c2a60 DIFF: https://github.com/llvm/llvm-project/commit/ccdd55c518277d749eff878ffcb5ca3de55c2a60.diff

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/137465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix an unused variable warning (PR #137466)

2025-04-26 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/137466 This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. >From 72690becb4274fb520e0bade5db2a7ef5cd66ab0 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 26 Apr 2025

[clang] [CIR][NFC] Fix an unused variable warning (PR #137466)

2025-04-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/137466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix an unused variable warning (PR #137466)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. --- Full diff: https://github.com/llvm/llvm-project/pull/137466.diff 2 Files Affected: - (modified) clang/lib/C

[clang] [CIR][NFC] Fix an unused variable warning (PR #137466)

2025-04-26 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper ready_for_review https://github.com/llvm/llvm-project/pull/137466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. https://github.com/llvm/llvm-project/pull/137465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko commented: lgtm, please backport this to incubator once merged https://github.com/llvm/llvm-project/pull/137465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Standardize the element type name --- Full diff: https://github.com/llvm/llvm-project/pull/137465.diff 6 Files Affected: - (modified) clang/include/clang/CIR/Dialect/IR/CIRTypes.td (+4-4) - (modified)

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes Standardize the element type name --- Full diff: https://github.com/llvm/llvm-project/pull/137465.diff 6 Files Affected: - (modified) clang/include/clang/CIR/Dialect/IR/CIRTypes.td (+4-4) - (modified

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper ready_for_review https://github.com/llvm/llvm-project/pull/137465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Standardize element type name between Array and Vector Types (PR #137465)

2025-04-26 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/137465 Standardize the element type name >From c9cca01b36db0d449905ebefe2f2c953ec2e5746 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 26 Apr 2025 18:54:05 +0200 Subject: [PATCH] [CIR] Standardize element

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/136810 >From 6fa07927f48cc820fe7babe6d85a32e8e6cc781b Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Wed, 23 Apr 2025 12:14:40 +0800 Subject: [PATCH] [CIR] Upstream cir.call with scalar arguments --- .../CIR/Dialect/B

[clang] [clang][NFC] Avoid a duplicate variable in SemaExprCXX.cpp (PR #137464)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/137464.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2-3) ``diff diff --git a/clang/lib/Sema/SemaExprC

[clang] [clang][NFC] Avoid a duplicate variable in SemaExprCXX.cpp (PR #137464)

2025-04-26 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/137464 None >From e6d3f185e8e5dffa65856391e4d709c167f96805 Mon Sep 17 00:00:00 2001 From: Mariya Podchishchaeva Date: Sat, 26 Apr 2025 18:28:44 +0200 Subject: [PATCH] [clang][NFC] Avoid a duplicate variable in SemaE

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2025-04-26 Thread Thomas Du Plessis via cfe-commits
tdupes wrote: Yes this is good to go https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot8` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/15098 Here is the relevant piece of the

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -17,3 +17,15 @@ int f4() { // CHECK-LABEL: cir.func @f4() -> !s32i // CHECK: %[[#x:]] = cir.call @f3() : () -> !s32i // CHECK-NEXT:cir.store %[[#x]], %{{.+}} : !s32i, !cir.ptr + +int f5(int a, int *b, bool c); +int f6() { + int b = 1; + return f5(2, &b, false);

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -32,7 +32,13 @@ void X8664ABIInfo::computeInfo(CIRGenFunctionInfo &funcInfo) const { // Top level CIR has unlimited arguments and return types. Lowering for ABI // specific concerns should happen during a lowering phase. Assume everything // is direct for now. - asse

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -68,20 +168,70 @@ static cir::CIRCallOpInterface emitCallLikeOp(CIRGenFunction &cgf, assert(builder.getInsertionBlock() && "expected valid basic block"); assert(!cir::MissingFeatures::opCallIndirect()); - return builder.createCallOp(callLoc, directFuncOp); + return b

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-26 Thread via cfe-commits
github-actions[bot] wrote: @Losy001 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] f5a30f1 - [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (#134930)

2025-04-26 Thread via cfe-commits
Author: Losy001 Date: 2025-04-26T09:04:12-07:00 New Revision: f5a30f111dc4ad6422863722eb708059a68a9d5c URL: https://github.com/llvm/llvm-project/commit/f5a30f111dc4ad6422863722eb708059a68a9d5c DIFF: https://github.com/llvm/llvm-project/commit/f5a30f111dc4ad6422863722eb708059a68a9d5c.diff LOG:

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-26 Thread Reid Kleckner via cfe-commits
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/134930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -1516,6 +1520,41 @@ class CIR_CallOpBase extra_traits = []> !listconcat(extra_traits, [DeclareOpInterfaceMethods, DeclareOpInterfaceMethods])> { + let extraClassDeclaration = [{ +/// Get the argument operands to the c

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -214,14 +214,15 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { //======// cir::CallOp createCallOp(mlir::Location loc, mlir::SymbolRefAttr callee, - mlir::Type returnTyp

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -152,3 +303,105 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, return ret; } + +void CIRGenFunction::emitCallArg(CallArgList &args, const clang::Expr *e, + clang::QualType argType) { + assert(argType->isReferenceTy

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -68,20 +168,70 @@ static cir::CIRCallOpInterface emitCallLikeOp(CIRGenFunction &cgf, assert(builder.getInsertionBlock() && "expected valid basic block"); assert(!cir::MissingFeatures::opCallIndirect()); - return builder.createCallOp(callLoc, directFuncOp); + return b

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -18,22 +18,118 @@ using namespace clang; using namespace clang::CIRGen; -CIRGenFunctionInfo *CIRGenFunctionInfo::create(CanQualType resultType) { - void *buffer = operator new(totalSizeToAlloc(1)); +CIRGenFunctionInfo * +CIRGenFunctionInfo::create(CanQualType resultType, +

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
@@ -1496,6 +1496,10 @@ def FuncOp : CIR_Op<"func", [ return getFunctionType().getReturnTypes(); } +// TODO(cir): this should be an operand attribute, but for now we just hard- +// wire this as a function. Will later add a $no_proto argument to this op. +

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-04-26 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/136810 >From 8f7b72f8dfe2e4fb32669a344f95be7ce04dae3d Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Wed, 23 Apr 2025 12:14:40 +0800 Subject: [PATCH] [CIR] Upstream cir.call with scalar arguments --- .../CIR/Dialect/B

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-26 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. Thanks; this has bugged me for a while now. https://github.com/llvm/llvm-project/pull/137411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-26 Thread Reid Kleckner via cfe-commits
rnk wrote: > I wonder if we can do this check statically instead. I'm not sure I follow, what do you mean by "statically" in this context? https://github.com/llvm/llvm-project/pull/137411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-26 Thread Reid Kleckner via cfe-commits
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/137411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7afbffb - [clang] Split out and disable tests that break relative rpaths (#137411)

2025-04-26 Thread via cfe-commits
Author: Reid Kleckner Date: 2025-04-26T08:29:08-07:00 New Revision: 7afbffb5c2e40edd6c2b3164f1dc4faf90d7d332 URL: https://github.com/llvm/llvm-project/commit/7afbffb5c2e40edd6c2b3164f1dc4faf90d7d332 DIFF: https://github.com/llvm/llvm-project/commit/7afbffb5c2e40edd6c2b3164f1dc4faf90d7d332.diff

[clang] e71c8ea - [Driver] Fix _XOPEN_SOURCE definition on Solaris (#137141)

2025-04-26 Thread via cfe-commits
Author: Rainer Orth Date: 2025-04-26T17:06:04+02:00 New Revision: e71c8ea3cc73c8f7b0382468f355a254166d3a72 URL: https://github.com/llvm/llvm-project/commit/e71c8ea3cc73c8f7b0382468f355a254166d3a72 DIFF: https://github.com/llvm/llvm-project/commit/e71c8ea3cc73c8f7b0382468f355a254166d3a72.diff L

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-26 Thread Rainer Orth via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-04-26 Thread Urvi Rav via cfe-commits
https://github.com/ravurvi20 updated https://github.com/llvm/llvm-project/pull/128640 >From 6ebd5991788608fbd104ea9c23230912044462d3 Mon Sep 17 00:00:00 2001 From: Urvi Rav Date: Tue, 25 Feb 2025 00:49:07 -0600 Subject: [PATCH 1/5] default clause replaced by otherwise clause for metadirective

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-04-26 Thread Urvi Rav via cfe-commits
https://github.com/ravurvi20 updated https://github.com/llvm/llvm-project/pull/128640 >From 6ebd5991788608fbd104ea9c23230912044462d3 Mon Sep 17 00:00:00 2001 From: Urvi Rav Date: Tue, 25 Feb 2025 00:49:07 -0600 Subject: [PATCH 1/5] default clause replaced by otherwise clause for metadirective

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-26 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/136488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d591630 - [CIR] Upstream initial support for fixed size VectorType (#136488)

2025-04-26 Thread via cfe-commits
Author: Amr Hesham Date: 2025-04-26T16:11:43+02:00 New Revision: d59163092dfa7ec94391121ffdcb7b9b0e58f3b4 URL: https://github.com/llvm/llvm-project/commit/d59163092dfa7ec94391121ffdcb7b9b0e58f3b4 DIFF: https://github.com/llvm/llvm-project/commit/d59163092dfa7ec94391121ffdcb7b9b0e58f3b4.diff LO

[clang] [clang] Split out and disable tests that break relative rpaths (PR #137411)

2025-04-26 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. I wonder if we can do this check statically instead. https://github.com/llvm/llvm-project/pull/137411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

2025-04-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. (I have limited internet access between April 20th and May 4th, and my response time may be delayed..) https://github.com/llvm/llvm-project/pull/137141 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang-repl] Delegate CodeGen related operations for PTU to IncrementalParser (PR #137458)

2025-04-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Anutosh Bhat (anutosh491) Changes Read discussion https://github.com/llvm/llvm-project/pull/136404#discussion_r2059149768 and the following comments for context --- Patch is 28.83 KiB, truncated to 20.00 KiB below, full version: https:

[clang] [clang-repl] Delegate CodeGen related operations for PTU to IncrementalParser (PR #137458)

2025-04-26 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 created https://github.com/llvm/llvm-project/pull/137458 Read discussion https://github.com/llvm/llvm-project/pull/136404#discussion_r2059149768 and the following comments for context >From 1d773dea825579e43485b99d57931c6fa19f1768 Mon Sep 17 00:00:00 2001 From: a

  1   2   >