llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) <details> <summary>Changes</summary> This fixes a warning where a variable assigned in 'if' statement wasn't referenced again. --- Full diff: https://github.com/llvm/llvm-project/pull/137466.diff 2 Files Affected: - (modified) clang/lib/CIR/CodeGen/CIRGenExpr.cpp (+3-3) - (modified) clang/lib/CIR/CodeGen/CIRGenModule.cpp (+1-1) ``````````diff diff --git a/clang/lib/CIR/CodeGen/CIRGenExpr.cpp b/clang/lib/CIR/CodeGen/CIRGenExpr.cpp index 0a518c0fd935d..ff14798b9d34c 100644 --- a/clang/lib/CIR/CodeGen/CIRGenExpr.cpp +++ b/clang/lib/CIR/CodeGen/CIRGenExpr.cpp @@ -311,7 +311,7 @@ LValue CIRGenFunction::emitLValueForField(LValue base, const FieldDecl *field) { assert(!cir::MissingFeatures::opTBAA()); Address addr = base.getAddress(); - if (auto *classDef = dyn_cast<CXXRecordDecl>(rec)) { + if (isa<CXXRecordDecl>(rec)) { cgm.errorNYI(field->getSourceRange(), "emitLValueForField: C++ class"); return LValue(); } @@ -701,7 +701,7 @@ CIRGenFunction::emitArraySubscriptExpr(const clang::ArraySubscriptExpr *e) { } LValue CIRGenFunction::emitMemberExpr(const MemberExpr *e) { - if (auto *vd = dyn_cast<VarDecl>(e->getMemberDecl())) { + if (isa<VarDecl>(e->getMemberDecl())) { cgm.errorNYI(e->getSourceRange(), "emitMemberExpr: VarDecl"); return LValue(); } @@ -734,7 +734,7 @@ LValue CIRGenFunction::emitMemberExpr(const MemberExpr *e) { return lv; } - if (const auto *fd = dyn_cast<FunctionDecl>(nd)) { + if (isa<FunctionDecl>(nd)) { cgm.errorNYI(e->getSourceRange(), "emitMemberExpr: FunctionDecl"); return LValue(); } diff --git a/clang/lib/CIR/CodeGen/CIRGenModule.cpp b/clang/lib/CIR/CodeGen/CIRGenModule.cpp index 8aa57d1dbf9b3..b9cc2da583009 100644 --- a/clang/lib/CIR/CodeGen/CIRGenModule.cpp +++ b/clang/lib/CIR/CodeGen/CIRGenModule.cpp @@ -366,7 +366,7 @@ void CIRGenModule::emitGlobalVarDefinition(const clang::VarDecl *vd, bool isTentative) { const QualType astTy = vd->getType(); const mlir::Type type = convertType(vd->getType()); - if (clang::IdentifierInfo *identifier = vd->getIdentifier()) { + if (vd->getIdentifier()) { StringRef name = getMangledName(GlobalDecl(vd)); auto varOp = builder.create<cir::GlobalOp>(getLoc(vd->getSourceRange()), name, type); `````````` </details> https://github.com/llvm/llvm-project/pull/137466 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
