[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
@@ -2305,7 +2335,45 @@ TEST(BlockEndHints, PointerToMemberFunction) { $ptrmem[[}]] } // suppress )cpp", - ExpectedHint{" // if", "ptrmem"}); + ExpectedHint{" // if ()", "ptrmem"}); +} + +TEST(BlockEndHints, MinLineLimit) { +

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: > > gcc doesn't seem to allow it? https://godbolt.org/z/4zh8TTPac > > avr-gcc allow value 64 for constraint 'I' in very special case, such as > #51513. I guess the test needs to be updated to be representative? > And my solution is loosen that check in the frontend, but le

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: YexuanXiao (YexuanXiao) Changes …erals be typedefs instead of built-in types Includeing the results of `sizeof`, `sizeof...`, `__datasizeof`, `__alignof`, `_Alignof`, `alignof`, `_Countof`, `size_t` literals, and signed `size_t` literals

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-20 Thread via cfe-commits
https://github.com/YexuanXiao created https://github.com/llvm/llvm-project/pull/136542 …erals be typedefs instead of built-in types Includeing the results of `sizeof`, `sizeof...`, `__datasizeof`, `__alignof`, `_Alignof`, `alignof`, `_Countof`, `size_t` literals, and signed `size_t` literals,

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Jianjian Guan via cfe-commits
https://github.com/jacquesguan approved this pull request. https://github.com/llvm/llvm-project/pull/136534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. https://github.com/llvm/llvm-project/pull/136534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] IncludeCleaner include not found error now contains path (PR #136237)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: @tongshengw Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang-tools-extra] [clangd] IncludeCleaner include not found error now contains path (PR #136237)

2025-04-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/136237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 8435de0 - [clangd] Print include spelling in IncludeCleaner error message (#136237)

2025-04-20 Thread via cfe-commits
Author: Tongsheng Wu Date: 2025-04-21T02:09:51-04:00 New Revision: 8435de0916d9df5a3a9dd9eeb44d5bf4aba87ba3 URL: https://github.com/llvm/llvm-project/commit/8435de0916d9df5a3a9dd9eeb44d5bf4aba87ba3 DIFF: https://github.com/llvm/llvm-project/commit/8435de0916d9df5a3a9dd9eeb44d5bf4aba87ba3.diff

[clang-tools-extra] [clangd] IncludeCleaner include not found error now contains path (PR #136237)

2025-04-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/136237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -22,10 +22,16 @@ namespace clang { namespace clangd { class ParsedAST; +struct InlayHintOptions { + // Minimum lines for BlockEnd inlay-hints to be shown HighCommander4 wrote: Let's make this comment a bit more specific: ``` // Minimum height of a code b

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -2305,7 +2335,45 @@ TEST(BlockEndHints, PointerToMemberFunction) { $ptrmem[[}]] } // suppress )cpp", - ExpectedHint{" // if", "ptrmem"}); + ExpectedHint{" // if ()", "ptrmem"}); +} + +TEST(BlockEndHints, MinLineLimit) { +

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -22,10 +22,16 @@ namespace clang { namespace clangd { class ParsedAST; +struct InlayHintOptions { + // Minimum lines for BlockEnd inlay-hints to be shown + int HintMinLineLimit{2}; HighCommander4 wrote: What we discussed in the original issue was that th

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -2305,7 +2335,45 @@ TEST(BlockEndHints, PointerToMemberFunction) { $ptrmem[[}]] } // suppress )cpp", - ExpectedHint{" // if", "ptrmem"}); + ExpectedHint{" // if ()", "ptrmem"}); +} + +TEST(BlockEndHints, MinLineLimit) { +

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks for picking up this patch! Looks fairly good, just a few comments: https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -36,9 +36,12 @@ namespace { using ::testing::ElementsAre; using ::testing::IsEmpty; -std::vector hintsOfKind(ParsedAST &AST, InlayHintKind Kind) { +constexpr InlayHintOptions DefaultInlayHintOpts{}; HighCommander4 wrote: nit: let's call this `DefaultInlayH

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread Nathan Ridge via cfe-commits
@@ -147,6 +149,9 @@ std::string summarizeExpr(const Expr *E) { } // Literals are just printed +std::string VisitCXXNullPtrLiteralExpr(const CXXNullPtrLiteralExpr *E) { + return "nullptr"; HighCommander4 wrote: Could you add a small test case

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
steakhal wrote: Ah, I see now your perspective. Yes, any PRs tagged with the CSA tag will hit our inboxes. https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Ben Shi via cfe-commits
benshi001 wrote: > gcc doesn't seem to allow it? https://godbolt.org/z/4zh8TTPac avr-gcc allow value 64 for constraint 'I' in very special case, such as https://github.com/avrdudes/avr-libc/issues/678. And my solution is loosen that check in the frontend, but let the AVR backend to deny the i

[clang] [clang-tools-extra] [clangd] Support operators new and delete in textDocument/references (PR #135620)

2025-04-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/135620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Yanzuo Liu via cfe-commits
zwuis wrote: > FYI we usually ping once a week. Oh, I see. IIUC `@ llvm/pr-subscribers-clang-static-analyzer-1` is also a ping, which I didn't know. https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: gcc doesn't seem to allow it? https://godbolt.org/z/4zh8TTPac https://github.com/llvm/llvm-project/pull/136534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Add `Custom` to `ShortFunctionStyle`; add new AllowShortFunctionsOnASingleLineOptions for granular setup (PR #134337)

2025-04-20 Thread via cfe-commits
@@ -5685,11 +5685,9 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, if (Right.is(tok::r_brace) && Left.is(tok::l_brace) && !Left.Children.empty()) { // Support AllowShortFunctionsOnASingleLine for JavaScript. - return Style.AllowShortF

[clang] [clang-format]: Add `Custom` to `ShortFunctionStyle`; add new AllowShortFunctionsOnASingleLineOptions for granular setup (PR #134337)

2025-04-20 Thread via cfe-commits
https://github.com/irymarchyk updated https://github.com/llvm/llvm-project/pull/134337 >From df25a8bbfd827085265c51a44bedbf38deebbab4 Mon Sep 17 00:00:00 2001 From: Ivan Rymarchyk <> Date: Sat, 29 Mar 2025 13:54:32 -0700 Subject: [PATCH 1/9] [clang-format]: Add `Custom` to `ShortFunctionStyle`;

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes Allow the value 64 to be round up to 0 for constraint 'I'. --- Full diff: https://github.com/llvm/llvm-project/pull/136534.diff 3 Files Affected: - (modified) clang/lib/Basic/Targets/AVR.h (+1-1) - (modified

[clang] [clang][AVR] Improve compatibility of inline assembly with avr-gcc (PR #136534)

2025-04-20 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/136534 Allow the value 64 to be round up to 0 for constraint 'I'. >From 1dcd2d91c37a4e6afc137ff0ad54d25777a1f4b1 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 21 Apr 2025 11:16:51 +0800 Subject: [PATCH] [clang][

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/136525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6274442 - [clangd] Call hash_combine_range with a range (NFC) (#136526)

2025-04-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-04-20T19:59:28-07:00 New Revision: 6274442f8c657597233b9691298df7b5cd743e66 URL: https://github.com/llvm/llvm-project/commit/6274442f8c657597233b9691298df7b5cd743e66 DIFF: https://github.com/llvm/llvm-project/commit/6274442f8c657597233b9691298df7b5cd743e66.diff L

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/136526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 02b55d2 - [AST] Call hash_combine_range with a range (NFC) (#136525)

2025-04-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-04-20T19:59:19-07:00 New Revision: 02b55d2b78d318dad331a66ddac81c7318b0b87a URL: https://github.com/llvm/llvm-project/commit/02b55d2b78d318dad331a66ddac81c7318b0b87a DIFF: https://github.com/llvm/llvm-project/commit/02b55d2b78d318dad331a66ddac81c7318b0b87a.diff L

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Store documentation when indexing standard library (PR #133681)

2025-04-20 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I was talking about a change like > [kadircet@ff0c31d](https://github.com/kadircet/llvm-project/commit/ff0c31d232b2aed9e95d69d16a9dfbb9babea711) Thanks for the more fleshed-out suggestion. As written, this would also have the following effects: 1. we no longer use `Sy

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-04-20 Thread Sirui Mu via cfe-commits
https://github.com/Lancern closed https://github.com/llvm/llvm-project/pull/123193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 27653bd - Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (#136515)

2025-04-20 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-04-20T18:42:09-07:00 New Revision: 27653bdc49161b6d0e785185384a5c96a55e9e24 URL: https://github.com/llvm/llvm-project/commit/27653bdc49161b6d0e785185384a5c96a55e9e24 DIFF: https://github.com/llvm/llvm-project/commit/27653bdc49161b6d0e785185384a5c96a55e9e24.diff L

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: @liliumShade Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] 0e3e0bf - [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (#123193)

2025-04-20 Thread via cfe-commits
Author: Chyaka Date: 2025-04-21T10:06:43+08:00 New Revision: 0e3e0bf42c25b280d8caa455c6ae7e4a04d3667a URL: https://github.com/llvm/llvm-project/commit/0e3e0bf42c25b280d8caa455c6ae7e4a04d3667a DIFF: https://github.com/llvm/llvm-project/commit/0e3e0bf42c25b280d8caa455c6ae7e4a04d3667a.diff LOG: [

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136526.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/SystemIncludeExtractor.cpp (+1-2) ``diff diff --gi

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136526.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/SystemIncludeExtractor.cpp (+1-2) ``diff diff --git a/clang-t

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136525.diff 1 Files Affected: - (modified) clang/lib/AST/ItaniumCXXABI.cpp (+1-1) ``diff diff --git a/clang/lib/AST/ItaniumCXXABI.

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/136526 None >From b5fba39de08101596f33dbec85f8541dbd7912de Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Apr 2025 15:11:09 -0700 Subject: [PATCH] [clangd] Call hash_combine_range with a range (NFC)

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/136525 None >From 237474372f11d744737d9890308e7f687a1953ed Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 20 Apr 2025 15:11:01 -0700 Subject: [PATCH] [AST] Call hash_combine_range with a range (NFC) ---

[clang] Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (PR #136515)

2025-04-20 Thread Oliver Hunt via cfe-commits
ojhunt wrote: This is a blind build fix, so I'll merge https://github.com/llvm/llvm-project/pull/136515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (PR #136515)

2025-04-20 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/136515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
https://github.com/MythreyaK edited https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] be48727 - [clang-tools-extra] Use llvm::unique (NFC) (#136514)

2025-04-20 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-04-20T18:30:05-07:00 New Revision: be48727b95bf9075e4290cc8938ab87db8b7410c URL: https://github.com/llvm/llvm-project/commit/be48727b95bf9075e4290cc8938ab87db8b7410c DIFF: https://github.com/llvm/llvm-project/commit/be48727b95bf9075e4290cc8938ab87db8b7410c.diff L

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/136514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
https://github.com/MythreyaK ready_for_review https://github.com/llvm/llvm-project/pull/136106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Mythreya (MythreyaK) Changes Previous iteration of this PR was [here](https://github.com/llvm/llvm-project/pull/72345). I retained their first commit as-is, rebased it, and added my changes based on the comments in the thread

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/136106 >From 64410e0c5bbdc3f631e2efecef475768d48ef233 Mon Sep 17 00:00:00 2001 From: daiyousei-qz Date: Tue, 14 Nov 2023 20:42:10 -0800 Subject: [PATCH 1/4] Improve BlockEnd presentation including: 1. Explicitly sta

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/136106 >From a0e3a33eda624bbebd436d6ac97a18348be39e7c Mon Sep 17 00:00:00 2001 From: daiyousei-qz Date: Tue, 14 Nov 2023 20:42:10 -0800 Subject: [PATCH 1/5] Improve BlockEnd presentation including: 1. Explicitly sta

[clang] [RawPtrRefMemberChecker] Member variable checker should allow T* in smart pointer classes (PR #136503)

2025-04-20 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/136503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RawPtrRefMemberChecker] Member varible checker should allow T* in smart pointer classes (PR #136503)

2025-04-20 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/136503 >From 01a0a5544010a605e828a28c04ba56d37658c6b0 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 20 Apr 2025 11:58:11 -0700 Subject: [PATCH] [RawPtrRefMemberChecker] Member variable checker should allow T* i

[clang-tools-extra] [clangd] Improve `BlockEnd` inlayhint presentation (PR #136106)

2025-04-20 Thread via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/136106 >From a0e3a33eda624bbebd436d6ac97a18348be39e7c Mon Sep 17 00:00:00 2001 From: daiyousei-qz Date: Tue, 14 Nov 2023 20:42:10 -0800 Subject: [PATCH 1/4] Improve BlockEnd presentation including: 1. Explicitly sta

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

2025-04-20 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Add `Custom` to `ShortFunctionStyle`; add new AllowShortFunctionsOnASingleLineOptions for granular setup (PR #134337)

2025-04-20 Thread Owen Pan via cfe-commits
@@ -5685,11 +5685,9 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, if (Right.is(tok::r_brace) && Left.is(tok::l_brace) && !Left.Children.empty()) { // Support AllowShortFunctionsOnASingleLine for JavaScript. - return Style.AllowShortF

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix addrspace of global constants (PR #134399)

2025-04-20 Thread Shangwu Yao via cfe-commits
ShangwuYao wrote: This test reproduces the issue above: ``` // RUN: %clang_cc1 -fcuda-is-device -triple spirv32 -o - -emit-llvm -x cuda %s | FileCheck %s // RUN: %clang_cc1 -fcuda-is-device -triple spirv64 -o - -emit-llvm -x cuda %s | FileCheck %s // CHECK: @.str = private unnamed_addr addr

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2025-04-20 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Waiting on review for https://github.com/llvm/llvm-project/pull/136515 https://github.com/llvm/llvm-project/pull/116785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][NFC] Use isa<> over dyn_cast (PR #136445)

2025-04-20 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/136445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][NFC] Remove else after return (PR #136443)

2025-04-20 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/136443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][NFC] Remove else after return (PR #136443)

2025-04-20 Thread Petr Hosek via cfe-commits
@@ -261,7 +261,7 @@ static bool isPublic(const clang::AccessSpecifier AS, const clang::Linkage Link) { if (AS == clang::AccessSpecifier::AS_private) return false; - else if ((Link == clang::Linkage::Module) || + if ((Link == clang::Linkage::Module)

[clang] Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (PR #136515)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes After landing #116760 we hit build failures due to existing fields storing FPEvalMethodKind not being wide enough. --- Full diff: https://github.com/llvm/llvm-project/pull/136515.diff 2 Files Affected: - (m

[clang] Ensure bit-fields storing FPEvalMethodKind are wide enough to do so (PR #136515)

2025-04-20 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/136515 After landing #116760 we hit build failures due to existing fields storing FPEvalMethodKind not being wide enough. >From 535e11400ea11461fa8e0cc98f9b481b045805c4 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date:

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136514.diff 3 Files Affected: - (modified) clang-tools-extra/clang-doc/Representation.cpp (+2-2) - (modified) clang-tools-extra/clang-i

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

2025-04-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/136514 None >From 0682a632e741dde6737e488daf8fbc01d6b2a58b Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 19 Apr 2025 20:36:04 -0700 Subject: [PATCH] [clang-tools-extra] Use llvm::unique (NFC) --- clan

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2025-04-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while building `clang` at step 12 "build-stage2-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/11082 H

[clang] [Clang] Consider preferred_type in bitfield warnings (#116760) (PR #116785)

2025-04-20 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/116785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ac1aa4 - [Clang] Consider preferred_type in bitfield warnings (#116760) (#116785)

2025-04-20 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-04-20T14:16:51-07:00 New Revision: 3ac1aa4c88d4fe40166209cad616f4ae867c20a2 URL: https://github.com/llvm/llvm-project/commit/3ac1aa4c88d4fe40166209cad616f4ae867c20a2 DIFF: https://github.com/llvm/llvm-project/commit/3ac1aa4c88d4fe40166209cad616f4ae867c20a2.diff L

[clang] [flang] Enable `-m32`, `-maix32` and `-maix64` for Flang on AIX. (PR #136202)

2025-04-20 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LG. https://github.com/llvm/llvm-project/pull/136202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RawPtrRefMemberChecker] Member varible checker should allow T* in smart pointer classes (PR #136503)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes This PR fixes member variable checker to allow the usage of T* in smart pointer classes. e.g. alpha.webkit.NoUncheckedPtrMemberChecker should allow T* to appear wit

[clang] [RawPtrRefMemberChecker] Member varible checker should allow T* in smart pointer classes (PR #136503)

2025-04-20 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/136503 This PR fixes member variable checker to allow the usage of T* in smart pointer classes. e.g. alpha.webkit.NoUncheckedPtrMemberChecker should allow T* to appear within RefPtr. >From 441e1d80180549ff17eb74e3749bc

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-20 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 842e591 - [clang-tidy][NFC] fix `clang-tidy` warnings in `clang-tools-extra/clang-tidy` directory (#136097)

2025-04-20 Thread via cfe-commits
Author: Baranov Victor Date: 2025-04-20T20:41:13+02:00 New Revision: 842e5915778a820c63cf38b75bec932a6ea8c18b URL: https://github.com/llvm/llvm-project/commit/842e5915778a820c63cf38b75bec932a6ea8c18b DIFF: https://github.com/llvm/llvm-project/commit/842e5915778a820c63cf38b75bec932a6ea8c18b.diff

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-20 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp requested changes to this pull request. Please add a unit test demonstrating that the related issue is fixed. https://github.com/llvm/llvm-project/pull/134774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-20 Thread Carlos Galvez via cfe-commits
@@ -182,6 +182,11 @@ Changes in existing checks ``constexpr`` and ``static``` values on member initialization and by detecting explicit casting of built-in types within member list initialization. +- Improved :doc:`modernize-use-designated-initializers + ` check by avoid

[clang-tools-extra] [clang-tidy] Avoid diagnosing std::array initializations for modernize-use-designated-initializers (PR #134774)

2025-04-20 Thread Carlos Galvez via cfe-commits
@@ -122,7 +122,10 @@ void UseDesignatedInitializersCheck::registerMatchers(MatchFinder *Finder) { Finder->addMatcher( initListExpr( hasType(cxxRecordDecl(RestrictToPODTypes ? isPOD() : isAggregate(), -unless(HasBaseWithFields))

[clang-tools-extra] [clang-tidy][NFC] fix `clang-tidy` warnings in `clang-tools-extra/clang-tidy` directory (PR #136097)

2025-04-20 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/136097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix `clang-tidy` warnings in `clang-tools-extra/clang-tidy` directory (PR #136097)

2025-04-20 Thread Carlos Galvez via cfe-commits
@@ -209,12 +209,14 @@ bool isQualificationConvertiblePointer(QualType From, QualType To, // cv-decomposition of T, that is, cv_1, cv_2, ... , cv_n, is called the // cv-qualification signature of T. - auto isValidP_i = [](QualType P) { + // NOLINTNEXTLINE (readability-id

[clang] [alpha.webkit.UncheckedCallArgsChecker] Checker fails to recognize CanMakeCheckedPtrBase (PR #136500)

2025-04-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes This PR fixes the bug that alpha.webkit.UncheckedCallArgsChecker did not recognize CanMakeCheckedPtrBase due to getAsCXXRecordDecl returning nullptr for it in hasPu

[clang] ea3eb8d - [clang][bytecode] Fix bos/bdos with non-zero offset applied (#136482)

2025-04-20 Thread via cfe-commits
Author: Timm Baeder Date: 2025-04-20T20:12:47+02:00 New Revision: ea3eb8d6258a018f118b5d41057ca333d1c8d4a0 URL: https://github.com/llvm/llvm-project/commit/ea3eb8d6258a018f118b5d41057ca333d1c8d4a0 DIFF: https://github.com/llvm/llvm-project/commit/ea3eb8d6258a018f118b5d41057ca333d1c8d4a0.diff L

[clang] [clang][bytecode] Fix bos/bdos with non-zero offset applied (PR #136482)

2025-04-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/136482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncheckedCallArgsChecker] Checker fails to recognize CanMakeCheckedPtrBase (PR #136500)

2025-04-20 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/136500 This PR fixes the bug that alpha.webkit.UncheckedCallArgsChecker did not recognize CanMakeCheckedPtrBase due to getAsCXXRecordDecl returning nullptr for it in hasPublicMethodInBase. Manually grab getTemplatedDecl

[clang] [llvm] Minimal support of floating-point operand bundles (PR #135658)

2025-04-20 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/135658 >From 287340535219cd5bc31de3a27cde1b279db0eb09 Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Mon, 14 Apr 2025 12:51:43 +0700 Subject: [PATCH 1/6] Minimal support of floating-point operand bundles This is a

[clang] [llvm] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-04-20 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj edited https://github.com/llvm/llvm-project/pull/135807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-04-20 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj updated https://github.com/llvm/llvm-project/pull/135807 >From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001 From: Ritanya B Bharadwaj Date: Sun, 6 Apr 2025 09:33:06 -0500 Subject: [PATCH 1/3] [OpenMP] Parsing Support of ThreadSets in T

[clang] [flang] Enable `-m32`, `-maix32` and `-maix64` for Flang on AIX. (PR #136202)

2025-04-20 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/136202 >From ca318afb810504d248c8bedeb13e2f742a446c37 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 17 Apr 2025 17:06:27 -0400 Subject: [PATCH 1/5] Enable -m32, -maix32 and -maix64 for Flang on AIX. --- c

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread via cfe-commits
github-actions[bot] wrote: @fangyi-zhou Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] 461168a - [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (#136041)

2025-04-20 Thread via cfe-commits
Author: Fangyi Zhou Date: 2025-04-20T17:32:42+02:00 New Revision: 461168a3d3bb1e75ff41d351a5cc506e103da5d6 URL: https://github.com/llvm/llvm-project/commit/461168a3d3bb1e75ff41d351a5cc506e103da5d6 DIFF: https://github.com/llvm/llvm-project/commit/461168a3d3bb1e75ff41d351a5cc506e103da5d6.diff L

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,19 @@ +// RUN: %clang_analyze_cc1 -std=c++20 -analyzer-checker=core -verify %s + +// expected-no-diagnostics + +template +struct overload : public F... +{ + using F::operator()...; +}; + +template +overload(F&&...) -> overload; + +int main() +{ + const auto l = overlo

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/136041 >From 5dc9d55eb04d94c01dba0364b51a509f975e542a Mon Sep 17 00:00:00 2001 From: Fangyi Zhou Date: Thu, 17 Apr 2025 23:02:37 +0100 Subject: [PATCH 1/2] [clang][analyzer] Handle CXXParenInitListExpr alongside Init

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM, thanks. FYI we usually ping once a week. https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add support for lambda-expression in `use-trailing-return-type` check (PR #135383)

2025-04-20 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping:) https://github.com/llvm/llvm-project/pull/135383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve `bugprone-exception-escape`: add stacktrace of escaped exception (PR #134375)

2025-04-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/134375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/16498 Her

[clang] [clang][Analyzer] Fix error path of builtin overflow (PR #136345)

2025-04-20 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/136345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 060f955 - [clang][analyzer] Fix error path of builtin overflow (#136345)

2025-04-20 Thread via cfe-commits
Author: Pavel Skripkin Date: 2025-04-20T16:14:41+02:00 New Revision: 060f9556a2f6ef4669f1c2cd8c4a4d76748a440f URL: https://github.com/llvm/llvm-project/commit/060f9556a2f6ef4669f1c2cd8c4a4d76748a440f DIFF: https://github.com/llvm/llvm-project/commit/060f9556a2f6ef4669f1c2cd8c4a4d76748a440f.diff

  1   2   >