Hana =?utf-8?q?Dusíková?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> That however runs into the problem that the constant evaluator needs to be
> able to diagnose any invalid constructs it runs into w/o crashing, and I’m
> not sure it’s currently set up for that given that
> CheckConstex
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-gcc-ubuntu-no-asserts` running on `doug-worker-6` while
building `clang-tools-extra` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/202
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/16338
Here is the relevant piece of the
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `ppc64-flang-aix` running
on `ppc64-flang-aix-test` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/201/builds/4199
Here is the relevant pie
shiltian wrote:
The target hook approach won't work here because `VerifierPass` is part of
`LLVMCore`, so it can't depend on target-specific components and doing so would
introduce a circular dependency.
Instead, I'm thinking of an alternative: make the target-dependent verifier run
after the
Author: Kazu Hirata
Date: 2025-04-19T20:33:53-07:00
New Revision: f2ec5e40d96d6ba8f99e419009b6547965905cfe
URL:
https://github.com/llvm/llvm-project/commit/f2ec5e40d96d6ba8f99e419009b6547965905cfe
DIFF:
https://github.com/llvm/llvm-project/commit/f2ec5e40d96d6ba8f99e419009b6547965905cfe.diff
L
Author: Kazu Hirata
Date: 2025-04-19T20:34:03-07:00
New Revision: 9bcb18db89c5a3b317c0de2a5e94f18044390c3f
URL:
https://github.com/llvm/llvm-project/commit/9bcb18db89c5a3b317c0de2a5e94f18044390c3f
DIFF:
https://github.com/llvm/llvm-project/commit/9bcb18db89c5a3b317c0de2a5e94f18044390c3f.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/136247
>From fe082622b38f5b4e00a5be7076523ad2adb104a4 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 17 Apr 2025 20:06:51 -0700
Subject: [PATCH 1/4] [clang][uefi] add arm, aarch64, x86, loongarch64, ris
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 01/10] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/9] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136470
None
>From 38b63cb444c5ac305f7df7967c7eb462d0122d15 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 19 Apr 2025 16:01:29 -0700
Subject: [PATCH] [clangd] Use llvm::unique (NFC)
---
clang-tools-ext
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/7] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
llvmbot wrote:
@llvm/pr-subscribers-clangd
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136470.diff
10 Files Affected:
- (modified) clang-tools-extra/clangd/IncludeFixer.cpp (+1-1)
- (modi
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136469.diff
10 Files Affected:
- (modified) clang/lib/AST/ASTContext.cpp (+1-1)
- (modified) clang/lib/AST/ItaniumMangle.cpp (+2-3)
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136469.diff
10 Files Affected:
- (modified) clang/lib/AST/ASTContext.cpp (+1-1)
- (modified) clang/lib/AST/ItaniumMangle.cpp (+2-3)
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136469
None
>From 020358d3a5bc5b9015c25073d3c4a256b83ebbfc Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 19 Apr 2025 16:00:09 -0700
Subject: [PATCH] [clang] Use llvm::unique (NFC)
---
clang/lib/AST/AS
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/7] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
zwuis wrote:
@Xazax-hun @steakhal Please take a look.
https://github.com/llvm/llvm-project/pull/136041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zwuis approved this pull request.
https://github.com/llvm/llvm-project/pull/136041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/6] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 210b6d80bcfbbcd216f98199df386280724561e2 Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/5] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/136202
>From ca318afb810504d248c8bedeb13e2f742a446c37 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 17 Apr 2025 17:06:27 -0400
Subject: [PATCH 1/4] Enable -m32, -maix32 and -maix64 for Flang on AIX.
---
c
@@ -733,11 +733,16 @@ static llvm::Triple computeTargetTriple(const Driver &D,
Target.setEnvironment(llvm::Triple::GNUX32);
} else if (A->getOption().matches(options::OPT_m32) ||
A->getOption().matches(options::OPT_maix32)) {
- AT = Target.get32B
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136461
- **[clang] Use llvm::unique (NFC)**
- **[clangd] Use llvm::unique (NFC)**
- **[PBQP] Use llvm::interleaved (NFC)**
>From 6ed4f9e0ef30ae38042cba6a9a5390cf72f39ef7 Mon Sep 17 00:00:00 2001
From: Kazu Hira
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Kazu Hirata (kazutakahirata)
Changes
- **[clang] Use llvm::unique (NFC)**
- **[clangd] Use llvm::unique (NFC)**
- **[PBQP] Use llvm::interleaved (NFC)**
---
Full diff: https://github.com/llvm/llvm-project/pull/136461.diff
21 File
https://github.com/jofrn updated
https://github.com/llvm/llvm-project/pull/123609
>From 7b8cde7a99dddcca04921a5e15dc7f1e4793928b Mon Sep 17 00:00:00 2001
From: jofernau
Date: Mon, 20 Jan 2025 04:51:26 -0800
Subject: [PATCH 1/5] [TargetVerifier][AMDGPU] Add TargetVerifier.
This pass verifies th
kazutakahirata wrote:
Oops. I didn't meant to upload multiple patches in one PR.
https://github.com/llvm/llvm-project/pull/136461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangd
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
- **[clang] Use llvm::unique (NFC)**
- **[clangd] Use llvm::unique (NFC)**
- **[PBQP] Use llvm::interleaved (NFC)**
---
Full diff: https://github.com/llvm/llvm-project/pull/
https://github.com/hanickadot updated
https://github.com/llvm/llvm-project/pull/136436
From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?=
Date: Sun, 20 Apr 2025 00:24:46 +0200
Subject: [PATCH 1/2] [clang] add -fimplicit-constexpr
https://github.com/hanickadot updated
https://github.com/llvm/llvm-project/pull/136436
From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?=
Date: Sun, 20 Apr 2025 00:24:46 +0200
Subject: [PATCH 1/2] [clang] add -fimplicit-constexpr
@@ -10163,6 +10163,16 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D,
DeclContext *DC,
}
ConstexprSpecKind ConstexprKind = D.getDeclSpec().getConstexprSpecifier();
+
+// Clang's option -fimplicit-constexpr will make functions without
constexpr
+// o
@@ -6612,6 +6612,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
Args.AddLastArg(CmdArgs, options::OPT_fconstexpr_depth_EQ);
Args.AddLastArg(CmdArgs, options::OPT_fconstexpr_steps_EQ);
+ Args.AddLastArg(CmdArgs, options::OPT_fimplicit_constexpr);
-
@@ -0,0 +1,51 @@
+// RUN: %clang_cc1 -verify=normal,both -std=c++23 %s
+// RUN: %clang_cc1 -verify=implicit,both -fimplicit-constexpr -std=c++23 %s
hanickadot wrote:
new test added for earlier standards too
https://github.com/llvm/llvm-project/pull/136436
__
https://github.com/hanickadot updated
https://github.com/llvm/llvm-project/pull/136436
From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?=
Date: Sun, 20 Apr 2025 00:24:46 +0200
Subject: [PATCH] [clang] add -fimplicit-constexpr fla
mstorsjo wrote:
With https://martin.st/temp/abs-preproc.cpp as input, I run `clang -target
i686-w64-mingw32 abs-preproc.cpp -fsanitize=signed-integer-overflow -w -O3 -S
-emit-llvm -o abs-out.ll`, and I get the following diff of the output IR after
this change:
```diff
--- abs-good.ll 2025-04-2
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-ppc64le-linux-test-suite` running on `ppc64le-clang-test-suite` while
building `clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/95/builds/122
Author: Kazu Hirata
Date: 2025-04-19T13:35:18-07:00
New Revision: 94733492b720c2e65a8fe9bd2179a35a7b7d9916
URL:
https://github.com/llvm/llvm-project/commit/94733492b720c2e65a8fe9bd2179a35a7b7d9916
DIFF:
https://github.com/llvm/llvm-project/commit/94733492b720c2e65a8fe9bd2179a35a7b7d9916.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/136234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136451.diff
6 Files Affected:
- (modified) clang/lib/Analysis/CFG.cpp (+1-2)
- (modified) clang/lib/Basic/Module.cpp (+1-2)
- (modified) cl
Losy001 wrote:
I finally got around to add tests.
https://github.com/llvm/llvm-project/pull/134930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Losy001 updated
https://github.com/llvm/llvm-project/pull/134930
>From 4a3b446a8081636219c704d0a2bbba5af567f5ca Mon Sep 17 00:00:00 2001
From: Losy001 <64610343+losy...@users.noreply.github.com>
Date: Tue, 8 Apr 2025 22:41:03 +0200
Subject: [PATCH 1/2] Implement mangling for m
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136451.diff
6 Files Affected:
- (modified) clang/lib/Analysis/CFG.cpp (+1-2)
- (modified) clang/lib/Basic/Module.cpp (+1-2)
- (modif
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136451.diff
6 Files Affected:
- (modified) clang/lib/Analysis/CFG.cpp (+1-2)
- (modified) clang/lib/Basic/Module.cpp (+1-2)
- (mod
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136451
None
>From 5b2111f61f21732f7271d0619ea4a2fb79f9c000 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 19 Apr 2025 11:51:09 -0700
Subject: [PATCH] [clang] Use llvm::SmallVector::pop_back_val (NFC)
--
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2025-04-19T12:21:14-07:00
New Revision: c2d6c7cea7d857f7a9268703e30a7d1ffed7d64b
URL:
https://github.com/llvm/llvm-project/commit/c2d6c7cea7d857f7a9268703e30a7d1ffed7d64b
DIFF:
https://github.com/llvm/llvm-project/commit/c2d6c7cea7d857f7a9268703e30a7d1ffed7d64b.diff
L
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
mgorny wrote:
https://github.com/llvm/llvm-project/pull/136442
https://github.com/llvm/llvm-project/pull/126143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
@llvm/pr-subscribers-clang-format
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136448.diff
18 Files Affected:
- (modified) clang/lib/AST/ByteCode/State.cpp (+2-4)
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136448.diff
18 Files Affected:
- (modified) clang/lib/AST/ByteCode/State.cpp (+2-4)
- (modified) clang/lib/AST/ExprConstant.cpp (+2-4
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136448.diff
18 Files Affected:
- (modified) clang/lib/AST/ByteCode/State.cpp (+2-4)
- (modified) clang/lib/AST/ExprConstant.cpp (+2-
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136448
None
>From a4cd577388a8faca002be6051fd4710af9311838 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 19 Apr 2025 09:17:08 -0700
Subject: [PATCH] [clang] Use llvm::append_range (NFC)
---
clang/lib/
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/136444
In quite a few places we were not following the project naming
conventions. This patch applies clang-tidy fixes, and updates
some additional names to follow more typical project wide patterns.
>From 437a8def36b7
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang-tools-extra/clang-doc/Serialize.cpp
``
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136445.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-doc/Serialize.cpp (+2-2)
``diff
diff --git a/clang-tools-ex
ilovepi wrote:
* **#136445** https://app.graphite.dev/github/pr/llvm/llvm-project/136445?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1364
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/136445
None
>From bb22253f93023fa2accd950fed8221caabeddae6 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Sat, 19 Apr 2025 10:49:22 -0700
Subject: [PATCH] [clang-doc][NFC] Use isa<> over dyn_cast
---
clang-tools-ex
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
In quite a few places we were not following the project naming
conventions. This patch applies clang-tidy fixes, and updates
some additional names to follow more typical project wide patterns.
---
ilovepi wrote:
* **#136444** https://app.graphite.dev/github/pr/llvm/llvm-project/136444?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1364
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Paul Kirth (ilovepi)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136443.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-doc/Serialize.cpp (+1-1)
``diff
diff --git a/clang-tools-ex
ilovepi wrote:
* **#136443** https://app.graphite.dev/github/pr/llvm/llvm-project/136443?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1364
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/136443
None
>From e8723eec4f6f1f00ea5a0ba5b2328b0c1a2ebfb4 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Sat, 19 Apr 2025 11:11:40 -0700
Subject: [PATCH] [clang-doc][NFC] Remove else after return
---
clang-tools-e
mgorny wrote:
Yeah, I can do that. I suppose a separate build would be cleaner in the long
run — and hopefully it will let us build the CPU part cleanly with GCC xP.
https://github.com/llvm/llvm-project/pull/126143
___
cfe-commits mailing list
cfe-com
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
@@ -451,13 +451,44 @@ const char *const Runtimes = R"(
)";
llvm::Expected>
-Interpreter::create(std::unique_ptr CI) {
+Interpreter::create(std::unique_ptr CI,
+std::unique_ptr DeviceCI) {
llvm::Error Err = llvm::Error::success();
auto Interp =
Author: Kazu Hirata
Date: 2025-04-19T10:37:25-07:00
New Revision: 0ed1c9862df408d3df171762bd8fa0dafbe1b7e2
URL:
https://github.com/llvm/llvm-project/commit/0ed1c9862df408d3df171762bd8fa0dafbe1b7e2
DIFF:
https://github.com/llvm/llvm-project/commit/0ed1c9862df408d3df171762bd8fa0dafbe1b7e2.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/136440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3019,8 +3019,26 @@ SDValue NVPTXTargetLowering::LowerADDRSPACECAST(SDValue
Op,
unsigned SrcAS = N->getSrcAddressSpace();
unsigned DestAS = N->getDestAddressSpace();
if (SrcAS != llvm::ADDRESS_SPACE_GENERIC &&
- DestAS != llvm::ADDRESS_SPACE_GENERIC)
+ DestA
@@ -3019,8 +3019,26 @@ SDValue NVPTXTargetLowering::LowerADDRSPACECAST(SDValue
Op,
unsigned SrcAS = N->getSrcAddressSpace();
unsigned DestAS = N->getDestAddressSpace();
if (SrcAS != llvm::ADDRESS_SPACE_GENERIC &&
- DestAS != llvm::ADDRESS_SPACE_GENERIC)
+ DestA
@@ -25,6 +25,7 @@ enum AddressSpace : unsigned {
ADDRESS_SPACE_CONST = 4,
ADDRESS_SPACE_LOCAL = 5,
ADDRESS_SPACE_TENSOR = 6,
+ ADDRESS_SPACE_SHARED_CLUSTER = 7,
AlexMaclean wrote:
I think it would be good to rename `ADDRESS_SPACE_SHARED` to
`ADDRESS_SP
@@ -426,10 +426,7 @@ static std::optional evaluateIsSpace(Intrinsic::ID
IID, unsigned AS) {
case Intrinsic::nvvm_isspacep_shared:
return AS == NVPTXAS::ADDRESS_SPACE_SHARED;
AlexMaclean wrote:
If the address space is `ADDRESS_SPACE_SHARED_CLUSTER` this i
@@ -176,6 +176,7 @@ enum AddressSpace : AddressSpaceUnderlyingType {
Shared = 3,
AlexMaclean wrote:
Lets rename this to `SharedCTA` as well.
https://github.com/llvm/llvm-project/pull/135444
___
cfe-commits mailing l
@@ -426,10 +426,7 @@ static std::optional evaluateIsSpace(Intrinsic::ID
IID, unsigned AS) {
case Intrinsic::nvvm_isspacep_shared:
return AS == NVPTXAS::ADDRESS_SPACE_SHARED;
case Intrinsic::nvvm_isspacep_shared_cluster:
-// We can't tell shared from shared_cluster
jhuber6 wrote:
> Yeah, appending `-march=` seems to work.
Is this a functional work-around for now?
```diff
diff --git a/offload/DeviceRTL/CMakeLists.txt b/offload/DeviceRTL/CMakeLists.txt
index cce360236960..277ad9816411 100644
--- a/offload/DeviceRTL/CMakeLists.txt
+++ b/offload/DeviceRTL/CMak
jhuber6 wrote:
> No, I'm afraid that didn't change anything. However, it did if I added it to
> `target_link_options` too.
>
> That said, you want to instead:
>
> ```diff
> --- a/offload/DeviceRTL/CMakeLists.txt
> +++ b/offload/DeviceRTL/CMakeLists.txt
> @@ -132,7 +132,7 @@ function(compileDev
https://github.com/hanickadot updated
https://github.com/llvm/llvm-project/pull/136436
From b8865c8f7eddfd7bfaba1b0f5399ea03c6780070 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?=
Date: Sat, 19 Apr 2025 16:52:33 +0200
Subject: [PATCH 1/2] [clang] add -fimplicit-constexpr
@@ -413,6 +413,7 @@ BENIGN_LANGOPT(ArrowDepth, 32, 256,
"maximum number of operator->s to follow")
BENIGN_LANGOPT(InstantiationDepth, 32, 1024,
"maximum template instantiation depth")
+LANGOPT(ImplicitConstexpr, 1, 0, "evaluate everything as it is
@@ -6612,6 +6612,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
Args.AddLastArg(CmdArgs, options::OPT_fconstexpr_depth_EQ);
Args.AddLastArg(CmdArgs, options::OPT_fconstexpr_steps_EQ);
+ Args.AddLastArg(CmdArgs, options::OPT_fimplicit_constexpr);
-
mgorny wrote:
No, I'm afraid that didn't change anything. However, it did if I added it to
`target_link_options` too.
That said, you want to instead:
```diff
--- a/offload/DeviceRTL/CMakeLists.txt
+++ b/offload/DeviceRTL/CMakeLists.txt
@@ -132,7 +132,7 @@ function(compileDeviceRTLLibrary targe
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/136440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/136440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny wrote:
Yeah, appending `-march=` seems to work.
https://github.com/llvm/llvm-project/pull/126143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136440.diff
23 Files Affected:
- (modified) clang/include/clang/Parse/Parser.h (+1-1)
- (modified) clang/lib/AST/DeclBase.cpp (+1-1
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136440.diff
23 Files Affected:
- (modified) clang/include/clang/Parse/Parser.h (+1-1)
- (modified) clang/lib/AST/DeclBase.
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/136440
None
>From abff402217dafac209f3301845573efdadc9f4a4 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 19 Apr 2025 09:55:31 -0700
Subject: [PATCH] [clang] llvm::append_range (NFC)
---
clang/include/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
clang-tools-extra/clangd/ASTSignals.cpp
clang-tool
Sirraide wrote:
> > IMO this kind of flag requires an RFC. This is a non-conforming extension
> > and I don't see any rationale for why we'd want to add it.
>
> I feel like GCC compatibility might be an argument? Imo it depends a bit on
> how difficult it is to implement the flag, but an RFC t
Sirraide wrote:
Oh yeah, and one more thing I forgot about earlier: this definitely need some
tests involving templates to make sure that instantiations are also treated as
implicitly `constexpr`.
https://github.com/llvm/llvm-project/pull/136436
___
jhuber6 wrote:
> > It should only be invoking `nvptx-arch` if the user passed `-march=native`.
>
> Sorry, didn't notice this sentence. Well, _I am_ building with
> `-march=native` here — after all, other files are built for a CPU. If I
> change it to, say, `-march=zen2`, then it indeed compile
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/136436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny wrote:
> It should only be invoking `nvptx-arch` if the user passed `-march=native`.
Sorry, didn't notice this sentence. Well, *I am* building with `-march=native`
here — after all, other files are built for a CPU. If I change it to, say,
`-march=zen2`, then it indeed compiles, with a l
Sirraide wrote:
> IMO this kind of flag requires an RFC. This is a non-conforming extension and
> I don't see any rationale for why we'd want to add it.
I feel like GCC compatibility might be an argument? Imo it depends a bit on how
difficult it is to implement the flag, but an RFC to discuss
1 - 100 of 176 matches
Mail list logo
