llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/136440.diff 23 Files Affected: - (modified) clang/include/clang/Parse/Parser.h (+1-1) - (modified) clang/lib/AST/DeclBase.cpp (+1-1) - (modified) clang/lib/AST/Randstruct.cpp (+1-1) - (modified) clang/lib/Analysis/FlowSensitive/CNFFormula.cpp (+1-1) - (modified) clang/lib/Basic/Targets/RISCV.cpp (+2-2) - (modified) clang/lib/CodeGen/CGObjCMac.cpp (+1-1) - (modified) clang/lib/Interpreter/Interpreter.cpp (+2-2) - (modified) clang/lib/Parse/ParseDecl.cpp (+1-1) - (modified) clang/lib/Parse/ParseStmtAsm.cpp (+1-1) - (modified) clang/lib/Sema/SemaChecking.cpp (+1-1) - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2-2) - (modified) clang/lib/Sema/SemaHLSL.cpp (+3-3) - (modified) clang/lib/Sema/SemaLookup.cpp (+1-1) - (modified) clang/lib/Sema/TreeTransform.h (+1-1) - (modified) clang/lib/Serialization/ASTWriter.cpp (+2-2) - (modified) clang/lib/StaticAnalyzer/Core/BugReporter.cpp (+1-1) - (modified) clang/lib/StaticAnalyzer/Core/RegionStore.cpp (+1-1) - (modified) clang/lib/Tooling/Tooling.cpp (+1-1) - (modified) clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp (+1-1) - (modified) clang/unittests/Interpreter/InterpreterTest.cpp (+1-1) - (modified) clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp (+1-1) - (modified) clang/utils/TableGen/ClangAttrEmitter.cpp (+1-1) - (modified) clang/utils/TableGen/MveEmitter.cpp (+1-1) ``````````diff diff --git a/clang/include/clang/Parse/Parser.h b/clang/include/clang/Parse/Parser.h index 662f54d0e8d8a..7ffe23c73eda9 100644 --- a/clang/include/clang/Parse/Parser.h +++ b/clang/include/clang/Parse/Parser.h @@ -3739,7 +3739,7 @@ class Parser : public CodeCompletionHandler { SmallVector<Expr *> getAllExprs() { SmallVector<Expr *> Out; Out.push_back(DevNumExpr); - Out.insert(Out.end(), QueueIdExprs.begin(), QueueIdExprs.end()); + llvm::append_range(Out, QueueIdExprs); return Out; } }; diff --git a/clang/lib/AST/DeclBase.cpp b/clang/lib/AST/DeclBase.cpp index 6260b92733ab7..1afda9aac9e18 100644 --- a/clang/lib/AST/DeclBase.cpp +++ b/clang/lib/AST/DeclBase.cpp @@ -1981,7 +1981,7 @@ void DeclContext::localUncachedLookup(DeclarationName Name, // the results. if (!hasExternalVisibleStorage() && !hasExternalLexicalStorage() && Name) { lookup_result LookupResults = lookup(Name); - Results.insert(Results.end(), LookupResults.begin(), LookupResults.end()); + llvm::append_range(Results, LookupResults); if (!Results.empty()) return; } diff --git a/clang/lib/AST/Randstruct.cpp b/clang/lib/AST/Randstruct.cpp index 4537ba5309e0b..5cba2f0a3c154 100644 --- a/clang/lib/AST/Randstruct.cpp +++ b/clang/lib/AST/Randstruct.cpp @@ -159,7 +159,7 @@ void randomizeStructureLayoutImpl(const ASTContext &Context, if (!B->isBitfieldRun()) std::shuffle(std::begin(RandFields), std::end(RandFields), RNG); - FinalOrder.insert(FinalOrder.end(), RandFields.begin(), RandFields.end()); + llvm::append_range(FinalOrder, RandFields); } FieldsOut = FinalOrder; diff --git a/clang/lib/Analysis/FlowSensitive/CNFFormula.cpp b/clang/lib/Analysis/FlowSensitive/CNFFormula.cpp index 2410ce1e7bd60..39c46d73e9dda 100644 --- a/clang/lib/Analysis/FlowSensitive/CNFFormula.cpp +++ b/clang/lib/Analysis/FlowSensitive/CNFFormula.cpp @@ -110,7 +110,7 @@ void CNFFormula::addClause(ArrayRef<Literal> lits) { const size_t S = Clauses.size(); ClauseStarts.push_back(S); - Clauses.insert(Clauses.end(), lits.begin(), lits.end()); + llvm::append_range(Clauses, lits); } CNFFormula buildCNF(const llvm::ArrayRef<const Formula *> &Formulas, diff --git a/clang/lib/Basic/Targets/RISCV.cpp b/clang/lib/Basic/Targets/RISCV.cpp index fad698d985af7..390ef0f3ac884 100644 --- a/clang/lib/Basic/Targets/RISCV.cpp +++ b/clang/lib/Basic/Targets/RISCV.cpp @@ -438,7 +438,7 @@ static void populateNegativeRISCVFeatures(std::vector<std::string> &Features) { std::vector<std::string> FeatStrings = (*RII)->toFeatures(/* AddAllExtensions */ true); - Features.insert(Features.end(), FeatStrings.begin(), FeatStrings.end()); + llvm::append_range(Features, FeatStrings); } static void handleFullArchString(StringRef FullArchStr, @@ -454,7 +454,7 @@ static void handleFullArchString(StringRef FullArchStr, populateNegativeRISCVFeatures(Features); std::vector<std::string> FeatStrings = (*RII)->toFeatures(/* AddAllExtensions */ true); - Features.insert(Features.end(), FeatStrings.begin(), FeatStrings.end()); + llvm::append_range(Features, FeatStrings); } } diff --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp index 1f11347b81411..1c23a8b4db918 100644 --- a/clang/lib/CodeGen/CGObjCMac.cpp +++ b/clang/lib/CodeGen/CGObjCMac.cpp @@ -7120,7 +7120,7 @@ RValue CGObjCNonFragileABIMac::EmitVTableMessageSend( // the actual argument value blank for now. args.add(RValue::get(nullptr), ObjCTypes.MessageRefCPtrTy); - args.insert(args.end(), formalArgs.begin(), formalArgs.end()); + llvm::append_range(args, formalArgs); MessageSendInfo MSI = getMessageSendInfo(method, resultType, args); diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp index f8c8d0a425659..45fa583650f03 100644 --- a/clang/lib/Interpreter/Interpreter.cpp +++ b/clang/lib/Interpreter/Interpreter.cpp @@ -203,7 +203,7 @@ IncrementalCompilerBuilder::CreateCpp() { Argv.push_back("wasm32-unknown-emscripten"); Argv.push_back("-fvisibility=default"); #endif - Argv.insert(Argv.end(), UserArgs.begin(), UserArgs.end()); + llvm::append_range(Argv, UserArgs); std::string TT = TargetTriple ? *TargetTriple : llvm::sys::getProcessTriple(); return IncrementalCompilerBuilder::create(TT, Argv); @@ -232,7 +232,7 @@ IncrementalCompilerBuilder::createCuda(bool device) { Argv.push_back(ArchArg.c_str()); } - Argv.insert(Argv.end(), UserArgs.begin(), UserArgs.end()); + llvm::append_range(Argv, UserArgs); std::string TT = TargetTriple ? *TargetTriple : llvm::sys::getProcessTriple(); return IncrementalCompilerBuilder::create(TT, Argv); diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp index 8444ff3332e08..69d40baaf4298 100644 --- a/clang/lib/Parse/ParseDecl.cpp +++ b/clang/lib/Parse/ParseDecl.cpp @@ -673,7 +673,7 @@ unsigned Parser::ParseAttributeArgsCommon( } } - ArgExprs.insert(ArgExprs.end(), ParsedExprs.begin(), ParsedExprs.end()); + llvm::append_range(ArgExprs, ParsedExprs); } } diff --git a/clang/lib/Parse/ParseStmtAsm.cpp b/clang/lib/Parse/ParseStmtAsm.cpp index e32094bdd99b8..f3415c30dde7a 100644 --- a/clang/lib/Parse/ParseStmtAsm.cpp +++ b/clang/lib/Parse/ParseStmtAsm.cpp @@ -645,7 +645,7 @@ StmtResult Parser::ParseMicrosoftAsmStatement(SourceLocation AsmLoc) { }); // Build the vector of clobber StringRefs. - ClobberRefs.insert(ClobberRefs.end(), Clobbers.begin(), Clobbers.end()); + llvm::append_range(ClobberRefs, Clobbers); // Recast the void pointers and build the vector of constraint StringRefs. unsigned NumExprs = NumOutputs + NumInputs; diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 26c2dc655a931..c48e009fd7242 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -511,7 +511,7 @@ struct BuiltinDumpStructGenerator { Args.reserve((TheCall->getNumArgs() - 2) + /*Format*/ 1 + Exprs.size()); Args.assign(TheCall->arg_begin() + 2, TheCall->arg_end()); Args.push_back(getStringLiteral(Format)); - Args.insert(Args.end(), Exprs.begin(), Exprs.end()); + llvm::append_range(Args, Exprs); // Register a note to explain why we're performing the call. Sema::CodeSynthesisContext Ctx; diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index 394e56c465c24..d46322d75721e 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -2532,7 +2532,7 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, : &OpaqueAllocationSize); if (isAlignedAllocation(IAP.PassAlignment)) CallArgs.emplace_back(&DesiredAlignment); - CallArgs.insert(CallArgs.end(), PlacementArgs.begin(), PlacementArgs.end()); + llvm::append_range(CallArgs, PlacementArgs); DiagnoseSentinelCalls(OperatorNew, PlacementLParen, CallArgs); @@ -2969,7 +2969,7 @@ bool Sema::FindAllocationFunctions( if (IncludeAlignParam) AllocArgs.push_back(&Align); - AllocArgs.insert(AllocArgs.end(), PlaceArgs.begin(), PlaceArgs.end()); + llvm::append_range(AllocArgs, PlaceArgs); // Find the allocation function. { diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp index 10c22817b082c..65f3275b3469f 100644 --- a/clang/lib/Sema/SemaHLSL.cpp +++ b/clang/lib/Sema/SemaHLSL.cpp @@ -2749,7 +2749,7 @@ static void BuildFlattenedTypeList(QualType BaseTy, BuildFlattenedTypeList(AT->getElementType(), ElementFields); // Repeat the element's field list n times. for (uint64_t Ct = 0; Ct < AT->getZExtSize(); ++Ct) - List.insert(List.end(), ElementFields.begin(), ElementFields.end()); + llvm::append_range(List, ElementFields); continue; } // Vectors can only have element types that are builtin types, so this can @@ -2777,7 +2777,7 @@ static void BuildFlattenedTypeList(QualType BaseTy, FieldTypes.push_back(FD->getType()); // Reverse the newly added sub-range. std::reverse(FieldTypes.begin(), FieldTypes.end()); - WorkList.insert(WorkList.end(), FieldTypes.begin(), FieldTypes.end()); + llvm::append_range(WorkList, FieldTypes); // If this wasn't a standard layout type we may also have some base // classes to deal with. @@ -2786,7 +2786,7 @@ static void BuildFlattenedTypeList(QualType BaseTy, for (const auto &Base : RD->bases()) FieldTypes.push_back(Base.getType()); std::reverse(FieldTypes.begin(), FieldTypes.end()); - WorkList.insert(WorkList.end(), FieldTypes.begin(), FieldTypes.end()); + llvm::append_range(WorkList, FieldTypes); } continue; } diff --git a/clang/lib/Sema/SemaLookup.cpp b/clang/lib/Sema/SemaLookup.cpp index 58134603424a6..53f64e91588bf 100644 --- a/clang/lib/Sema/SemaLookup.cpp +++ b/clang/lib/Sema/SemaLookup.cpp @@ -5611,7 +5611,7 @@ void Sema::diagnoseMissingImport(SourceLocation Loc, const NamedDecl *Decl, llvm::SmallVector<Module*, 8> OwningModules; OwningModules.push_back(Owner); auto Merged = Context.getModulesWithMergedDefinition(Def); - OwningModules.insert(OwningModules.end(), Merged.begin(), Merged.end()); + llvm::append_range(OwningModules, Merged); diagnoseMissingImport(Loc, Def, Def->getLocation(), OwningModules, MIK, Recover); diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h index b9a09ade37c12..071389543ab68 100644 --- a/clang/lib/Sema/TreeTransform.h +++ b/clang/lib/Sema/TreeTransform.h @@ -4205,7 +4205,7 @@ class TreeTransform { ArrayRef<OpenACCClause *> Clauses) { llvm::SmallVector<Expr *> Exprs; Exprs.push_back(DevNumExpr); - Exprs.insert(Exprs.end(), QueueIdExprs.begin(), QueueIdExprs.end()); + llvm::append_range(Exprs, QueueIdExprs); return getSema().OpenACC().ActOnEndStmtDirective( OpenACCDirectiveKind::Wait, BeginLoc, DirLoc, LParenLoc, QueuesLoc, Exprs, OpenACCAtomicKind::None, RParenLoc, EndLoc, Clauses, {}); diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp index ffbe2c4e4d0f1..04e73b17af3bc 100644 --- a/clang/lib/Serialization/ASTWriter.cpp +++ b/clang/lib/Serialization/ASTWriter.cpp @@ -5242,13 +5242,13 @@ void ASTWriter::AddToken(const Token &Tok, RecordDataImpl &Record) { void ASTWriter::AddString(StringRef Str, RecordDataImpl &Record) { Record.push_back(Str.size()); - Record.insert(Record.end(), Str.begin(), Str.end()); + llvm::append_range(Record, Str); } void ASTWriter::AddStringBlob(StringRef Str, RecordDataImpl &Record, SmallVectorImpl<char> &Blob) { Record.push_back(Str.size()); - Blob.insert(Blob.end(), Str.begin(), Str.end()); + llvm::append_range(Blob, Str); } bool ASTWriter::PreparePathForOutput(SmallVectorImpl<char> &Path) { diff --git a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp index 5f78fc433275d..f8db8d0bc8343 100644 --- a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp +++ b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp @@ -2827,7 +2827,7 @@ static void CompactMacroExpandedPieces(PathPieces &path, // Now take the pieces and construct a new PathDiagnostic. path.clear(); - path.insert(path.end(), Pieces.begin(), Pieces.end()); + llvm::append_range(path, Pieces); } /// Generate notes from all visitors. diff --git a/clang/lib/StaticAnalyzer/Core/RegionStore.cpp b/clang/lib/StaticAnalyzer/Core/RegionStore.cpp index 79cb5a07701fd..1cc9cb84cbfa4 100644 --- a/clang/lib/StaticAnalyzer/Core/RegionStore.cpp +++ b/clang/lib/StaticAnalyzer/Core/RegionStore.cpp @@ -2434,7 +2434,7 @@ RegionStoreManager::getInterestingValues(nonloc::LazyCompoundVal LCV) { if (auto InnerLCV = V.getAs<nonloc::LazyCompoundVal>()) { const SValListTy &InnerList = getInterestingValues(*InnerLCV); - List.insert(List.end(), InnerList.begin(), InnerList.end()); + llvm::append_range(List, InnerList); } List.push_back(V); diff --git a/clang/lib/Tooling/Tooling.cpp b/clang/lib/Tooling/Tooling.cpp index 03523c3f17eda..f0955ef4a0829 100644 --- a/clang/lib/Tooling/Tooling.cpp +++ b/clang/lib/Tooling/Tooling.cpp @@ -198,7 +198,7 @@ getSyntaxOnlyToolArgs(const Twine &ToolName, std::vector<std::string> Args; Args.push_back(ToolName.str()); Args.push_back("-fsyntax-only"); - Args.insert(Args.end(), ExtraArgs.begin(), ExtraArgs.end()); + llvm::append_range(Args, ExtraArgs); Args.push_back(FileName.str()); return Args; } diff --git a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp index bc2bd11df6aef..c8522e9160276 100644 --- a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp +++ b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp @@ -49,7 +49,7 @@ static std::unique_ptr<Interpreter> createInterpreter(const Args &ExtraArgs = {}, DiagnosticConsumer *Client = nullptr) { Args ClangArgs = {"-Xclang", "-emit-llvm-only"}; - ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end()); + llvm::append_range(ClangArgs, ExtraArgs); auto CB = clang::IncrementalCompilerBuilder(); CB.SetCompilerArgs(ClangArgs); auto CI = cantFail(CB.CreateCpp()); diff --git a/clang/unittests/Interpreter/InterpreterTest.cpp b/clang/unittests/Interpreter/InterpreterTest.cpp index 578f1d4c0eac6..03b9c33232080 100644 --- a/clang/unittests/Interpreter/InterpreterTest.cpp +++ b/clang/unittests/Interpreter/InterpreterTest.cpp @@ -43,7 +43,7 @@ static std::unique_ptr<Interpreter> createInterpreter(const Args &ExtraArgs = {}, DiagnosticConsumer *Client = nullptr) { Args ClangArgs = {"-Xclang", "-emit-llvm-only"}; - ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end()); + llvm::append_range(ClangArgs, ExtraArgs); auto CB = clang::IncrementalCompilerBuilder(); CB.SetCompilerArgs(ClangArgs); auto CI = cantFail(CB.CreateCpp()); diff --git a/clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp b/clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp index 49eb40ec5cda5..db24874ed2498 100644 --- a/clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp +++ b/clang/unittests/Tooling/DependencyScanning/DependencyScannerTest.cpp @@ -42,7 +42,7 @@ class TestFileCollector : public DependencyFileGenerator { void finishedMainFile(DiagnosticsEngine &Diags) override { auto NewDeps = getDependencies(); - Deps.insert(Deps.end(), NewDeps.begin(), NewDeps.end()); + llvm::append_range(Deps, NewDeps); } private: diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index 07844c8f0967b..bc5033ed3c89a 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -4560,7 +4560,7 @@ static void GenerateTargetRequirements(const Record &Attr, std::vector<StringRef> DA = I.second->getValueAsDef("Target")->getValueAsListOfStrings( "Arches"); - Arches.insert(Arches.end(), DA.begin(), DA.end()); + llvm::append_range(Arches, DA); } } } diff --git a/clang/utils/TableGen/MveEmitter.cpp b/clang/utils/TableGen/MveEmitter.cpp index 7bee2996382c1..95fd658b3bde2 100644 --- a/clang/utils/TableGen/MveEmitter.cpp +++ b/clang/utils/TableGen/MveEmitter.cpp @@ -753,7 +753,7 @@ class IRIntrinsicResult : public Result { OS << "})"; } void morePrerequisites(std::vector<Ptr> &output) const override { - output.insert(output.end(), Args.begin(), Args.end()); + llvm::append_range(output, Args); } }; `````````` </details> https://github.com/llvm/llvm-project/pull/136440 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
