[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
wsehjk wrote: @tbaederr Could you review my code? I'm not sure if I did it right https://github.com/llvm/llvm-project/pull/130400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-07 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > That is, this issue is unrelated to system headers or not, but rather that > there are some declarations that are not top-level declarations. Why that's > the case, or if it's intentional, is way beyond my knowledge. I see. I think we should the very least investigate this.

[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] disable unary, vector mask (PR #130400)

2025-03-07 Thread via cfe-commits
https://github.com/wsehjk created https://github.com/llvm/llvm-project/pull/130400 This pr is to fix #92342. >From a6ca9cc820e98b093215b1bd0787d4fa3d31742d Mon Sep 17 00:00:00 2001 From: wang shiwen Date: Sat, 8 Mar 2025 15:40:22 +0800 Subject: [PATCH] disable unary, vector mask --- clang/l

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Why should we add those macros to the default list? Can't you use the [`AttributeMacros`](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#attributemacros) option instead? https://github.com/llvm/llvm-project/pull/13034

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

2025-03-07 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/6] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

2025-03-07 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/5] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

2025-03-07 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/4] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [clang][bytecode] Loosen assertion This() for array elements (PR #130399)

2025-03-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/130399 getRecord() returns null on array elements, even for composite arrays. The assertion here was overly restrictive and having an array element as instance pointer should be fine otherwise. >From a4327462a417aeb

[clang] [clang][bytecode] Implement __builtin_constant_p (PR #130143)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve2-vla-2stage` running on `linaro-g4-01` while building `clang` at step 12 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/199/builds/2062 Here is the relevant piece

[clang] [clang][bytecode] Implement __builtin_constant_p (PR #130143)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-msan` running on `sanitizer-buildbot6` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/164/builds/7889 Here is the releva

[clang] [clang][bytecode] Loosen assertion This() for array elements (PR #130399)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes getRecord() returns null on array elements, even for composite arrays. The assertion here was overly restrictive and having an array element as instance pointer should be fine otherwise. --- Full diff: http

[clang-tools-extra] [clang-tidy][misc-use-internal-linkage] fix false positives for function or variable in header file which contains macro expansion (PR #129594)

2025-03-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/129594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6f7570c - [clang-tidy][misc-use-internal-linkage] fix false positives for function or variable in header file which contains macro expansion (#129594)

2025-03-07 Thread via cfe-commits
Author: Congcong Cai Date: 2025-03-08T13:41:24+08:00 New Revision: 6f7570c200aa1ee9af9d1eb7a378d56264ee297e URL: https://github.com/llvm/llvm-project/commit/6f7570c200aa1ee9af9d1eb7a378d56264ee297e DIFF: https://github.com/llvm/llvm-project/commit/6f7570c200aa1ee9af9d1eb7a378d56264ee297e.diff

[clang-tools-extra] [clang-tidy][misc-use-internal-linkage] fix false positives for function or variable in header file which contains macro expansion (PR #129594)

2025-03-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/129594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-07 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/126846 >From 106a982e3c6bcfa3ee7c26133f0919791699f31a Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sun, 23 Feb 2025 18:16:06 -0500 Subject: [PATCH 1/5] Fix signed-unsigned comparison with UO_Not and UO_Minus ---

[clang] [clang][bytecode] Implement __builtin_constant_p (PR #130143)

2025-03-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/130143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
@@ -22,56 +22,144 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ +// RUN: -emit-llvm -o - | FileCheck %s \ // RUN: -DFNATTRS

[clang] [clang][bytecode] Implement __builtin_constant_p (PR #130143)

2025-03-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/130143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid processing declarations in system headers (PR #128150)

2025-03-07 Thread Congcong Cai via cfe-commits
Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: HerrCai0907 wrote: I prefer to start from this patch. Because it is already here without additional effort. Just like the incubator, when it has been tested by a certain number of users and is stable enough, then

[clang] [clang] Reject constexpr-unknown values as constant expressions more consistently (PR #129952)

2025-03-07 Thread Timm Baeder via cfe-commits
@@ -154,3 +154,26 @@ int g() { static_assert(f(arr) == 5); } } + +namespace GH128409 { + int &ff(); + int &x = ff(); // nointerpreter-note {{declared here}} + constinit int &z = x; // expected-error {{variable does not have a constant initializer}} +

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2025-03-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/89449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][XCore][NFC] Remove redundant setting of IsIntegratedAssemblerDefault (PR #130397)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Brad Smith (brad0) Changes IsIntegratedAssemblerDefault is already set in Generic_GCC::IsIntegratedAssemblerDefault --- Full diff: https://github.com/llvm/llvm-project/pull/130397.diff 1 Files Affected: - (modified) clang/lib/Dri

[clang] d08cf79 - [clang][bytecode] Implement __builtin_constant_p (#130143)

2025-03-07 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-08T06:06:14+01:00 New Revision: d08cf7900d2aaff9e7483ea74a58871edbdc45f2 URL: https://github.com/llvm/llvm-project/commit/d08cf7900d2aaff9e7483ea74a58871edbdc45f2 DIFF: https://github.com/llvm/llvm-project/commit/d08cf7900d2aaff9e7483ea74a58871edbdc45f2.diff L

[clang] [Driver][XCore][NFC] Remove redundant setting of IsIntegratedAssemblerDefault (PR #130397)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes IsIntegratedAssemblerDefault is already set in Generic_GCC::IsIntegratedAssemblerDefault --- Full diff: https://github.com/llvm/llvm-project/pull/130397.diff 1 Files Affected: - (modified) clang/lib/Driver/Too

[clang] [Driver][XCore][NFC] Remove redundant setting of IsIntegratedAssemblerDefault (PR #130397)

2025-03-07 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/130397 IsIntegratedAssemblerDefault is already set in Generic_GCC::IsIntegratedAssemblerDefault >From 5cb790da8c2de53ac604ea581b1baa4c2259e2a8 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 7 Mar 2025 21:50:15 -05

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-07 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/126846 >From 331ff18c3c3c3a16b7833e6c5299dc40cfacf694 Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sun, 23 Feb 2025 18:16:06 -0500 Subject: [PATCH] Fix signed-unsigned integer comparison diagnosis that contains

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-aarch64` running on `as-builder-2` while building `clang` at step 9 "test-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/6143 Here is the relevant piece of th

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-07 Thread Michael Park via cfe-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-07 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/126846 >From d7404029e8998c8c8945cfaa34cf99b743ec2b70 Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sun, 23 Feb 2025 18:16:06 -0500 Subject: [PATCH 1/4] Fix no warning for comparison of integers of different sign

[clang] [llvm] [Support] Remove output file checks from `LockFileManager` (PR #130395)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Jan Svoboda (jansvoboda11) Changes Currently, `LockFileManager` assumes the owner of the lock file creates an output file. This is problematic for at least three reasons: 1. It is orthogonal to the main purpose of this class - mutu

[clang] [llvm] [Support] Remove output file checks from `LockFileManager` (PR #130395)

2025-03-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/130395 Currently, `LockFileManager` assumes the owner of the lock file creates an output file. This is problematic for at least three reasons: 1. It is orthogonal to the main purpose of this class - mutual exclus

[clang] [HLSL] select scalar overloads for vector conditions (PR #129396)

2025-03-07 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/129396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] select scalar overloads for vector conditions (PR #129396)

2025-03-07 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/129396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] select scalar overloads for vector conditions (PR #129396)

2025-03-07 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,71 @@ +//===- hlsl_intrinsic_helpers.h - HLSL helpers intrinsics -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
https://github.com/Icohedron edited https://github.com/llvm/llvm-project/pull/130320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
@@ -22,56 +22,136 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: -DFNATTRS="spir_func noundef nofpclass(nan inf)" -DTY

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-07 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @Endilll do you understand where this test failure might come from? It passes for me locally... https://github.com/llvm/llvm-project/pull/130383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/130371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Disable gcc partially overloaded virtual warning (PR #130322)

2025-03-07 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM, same observation as Erich regarding CMAKE stuff tho https://github.com/llvm/llvm-project/pull/130322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] 7602d78 - clang/HIP: Use regex for final path separator in hip-partial-link, again (#130371)

2025-03-07 Thread via cfe-commits
Author: Matt Arsenault Date: 2025-03-08T10:53:03+07:00 New Revision: 7602d781b03427052c44537fa4b9c2a6da15697c URL: https://github.com/llvm/llvm-project/commit/7602d781b03427052c44537fa4b9c2a6da15697c DIFF: https://github.com/llvm/llvm-project/commit/7602d781b03427052c44537fa4b9c2a6da15697c.diff

[clang] [ARM] mtp = auto using hard point while arch supports thumb2 and hardtp (PR #130027)

2025-03-07 Thread via cfe-commits
Zhenhang1213 wrote: > @Zhenhang1213 : Code looks ok. Are all edge cases covered by the lit test now? > > Could you please adjust the commit message to reflect the actual changes? OK, I add more tests to cover, thx! https://github.com/llvm/llvm-project/pull/130027 __

[clang] [ARM] mtp = auto using hard point while arch supports thumb2 and hardtp (PR #130027)

2025-03-07 Thread via cfe-commits
https://github.com/Zhenhang1213 edited https://github.com/llvm/llvm-project/pull/130027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] mtp = auto using hard point while arch supports thumb2 and hardtp (PR #130027)

2025-03-07 Thread via cfe-commits
https://github.com/Zhenhang1213 edited https://github.com/llvm/llvm-project/pull/130027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] Using cp15 while mtp =auto and arch is arm_arch6k and support thumb2 (PR #130027)

2025-03-07 Thread via cfe-commits
https://github.com/Zhenhang1213 updated https://github.com/llvm/llvm-project/pull/130027 >From b7c6a38f913f5e83e9a72e0b81607de01a8a1b01 Mon Sep 17 00:00:00 2001 From: Austin Date: Thu, 6 Mar 2025 17:25:55 +0800 Subject: [PATCH] [ARM] mtp = auto using hard point while arch supports thumb2 and h

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2025-03-07 Thread Akira Hatanaka via cfe-commits
@@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -fsyntax-only -verify -fptrauth-intrinsics -std=c++11 %s +// RUN: %clang_cc1 -triple aarch64-linux-gnu -fsyntax-only -verify -fptrauth-intrinsics -std=c++11 %s + +template struct G { + T __ptrauth(0,0,1234) test; +

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2025-03-07 Thread Akira Hatanaka via cfe-commits
@@ -73,7 +73,7 @@ namespace { // value of the expression to the unqualified, non-atomic version of // the named type. if (!S.Context.getLangOpts().ObjC && !DestType->isRecordType() && - !DestType->isArrayType()) { + !DestType->isArrayType

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-07 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/130383 This covers the `File` interface changes introduced added by #120590 >From 8a206611120c15010381e1570c2b4d7548142dbd Mon Sep 17 00:00:00 2001 From: Mathias Stearn Date: Thu, 19 Dec 2024 16:22:04 +0100 Subje

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e22579a6752801a5d3ced59c7a2e2499d547c657...8a206611120c15010381e1570c2b4d7548142dbd clang

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes This covers the `File` interface changes added by #120590 --- Full diff: https://github.com/llvm/llvm-project/pull/130383.diff 3 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-07 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/130383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Jan Voung (jvoung) Changes Add support for formatting w/ absl nullability macros (https://github.com/abseil/abseil-cpp/blob/c52afac4f87ef76e6293b84874e5126a62be1f15/absl/base/nullability.h#L237). Example at https://godbolt.org/z/PYv

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread Jan Voung via cfe-commits
https://github.com/jvoung ready_for_review https://github.com/llvm/llvm-project/pull/130346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread Jan Voung via cfe-commits
https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/130346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread Jan Voung via cfe-commits
https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/130346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add support for absl nullability macros (PR #130346)

2025-03-07 Thread Jan Voung via cfe-commits
https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/130346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
@@ -22,56 +22,136 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: -DFNATTRS="spir_func noundef nofpclass(nan inf)" -DTY

[clang-tools-extra] [clang-tidy] Add new check bugprone-capture-this-by-field (PR #130297)

2025-03-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/130297 >From 8ef214f6c78d710dbd9c74b06c7c637baf93e527 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 8 Mar 2025 00:03:39 +0800 Subject: [PATCH 1/5] [clang-tidy] Add new check bugprone-capture-this-by-field

[clang-tools-extra] [clang-tidy] Add new check bugprone-capture-this-by-field (PR #130297)

2025-03-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/130297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Recognize CXXUnresolvedConstructExpr as a safe origin. (PR #130258)

2025-03-07 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/130258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add `BuiltinHeaders` flag to Config file (PR #129459)

2025-03-07 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > we've had users for whom the BuiltinHeaders: QueryDriver behaviour worked > > better and want to switch back to it (examples here, here, here, here). > > I'd argue that the fix isn't as simple as using builtin headers from a > different toolchain for those users. Beca

[clang-tools-extra] [clang-tidy] Add new check bugprone-capture-this-by-field (PR #130297)

2025-03-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/130297 >From 8ef214f6c78d710dbd9c74b06c7c637baf93e527 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 8 Mar 2025 00:03:39 +0800 Subject: [PATCH 1/2] [clang-tidy] Add new check bugprone-capture-this-by-field

[clang] [clang-tools-extra] [C2y] Implement WG14 N3409 (PR #130299)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang-tools-extra,clang` at step 7 "test-build-unified-tree-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/2142

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the PR, some after commit review. The bugprone comment should be addressed and if there are more cases we catch that are not covered by existing tests, we should add more tests. The in class member initializers feels like it would be worth doi

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
https://github.com/Icohedron edited https://github.com/llvm/llvm-project/pull/130320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-07 Thread Shafik Yaghmour via cfe-commits
@@ -12796,6 +12799,7 @@ namespace { } void VisitCXXOperatorCallExpr(CXXOperatorCallExpr *E) { + llvm::SaveAndRestore CxxOpCallScope(isInCXXOperatorCall, true); shafik wrote: We should be using [bugprone-argument-comment](https://clang.llvm.org/e

[clang] [WebAssembly] Rename functions in wasm-eh.cpp (PR #130220)

2025-03-07 Thread Heejin Ahn via cfe-commits
aheejin wrote: @llvm-ci The CI failure does not look relevant. https://github.com/llvm/llvm-project/pull/130220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-07 Thread Shafik Yaghmour via cfe-commits
@@ -892,6 +892,11 @@ namespace lambdas { return a1.x; }); A a2([&] { return a2.x; }); // ok +A a3([=] { return a3.x; }()); // expected-warning{{variable 'a3' is uninitialized when used within its own initialization}} shafik wrote: Do we now

[clang] 55f86cf - [RISCV][clang] Fix wrong VLS CC detection (#130107)

2025-03-07 Thread via cfe-commits
Author: Kito Cheng Date: 2025-03-07T11:15:20+08:00 New Revision: 55f86cf02336e0a1bce81403296cce6d4cfbb1e4 URL: https://github.com/llvm/llvm-project/commit/55f86cf02336e0a1bce81403296cce6d4cfbb1e4 DIFF: https://github.com/llvm/llvm-project/commit/55f86cf02336e0a1bce81403296cce6d4cfbb1e4.diff LO

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-07 Thread Chuanqi Xu via cfe-commits
@@ -9180,6 +9180,12 @@ bool Sema::hasAcceptableDefinition(NamedDecl *D, NamedDecl **Suggested, if (!getLangOpts().Modules && !getLangOpts().ModulesLocalVisibility) return true; + // The external source may have additional definitions of this entity that are + // visi

[clang] [C++20][Modules] Fix incomplete decl chains (PR #129982)

2025-03-07 Thread Michael Park via cfe-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
https://github.com/Icohedron edited https://github.com/llvm/llvm-project/pull/130320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
@@ -22,56 +22,136 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: -DFNATTRS="spir_func noundef nofpclass(nan inf)" -DTY

[clang] [WebAssembly] Rename functions in wasm-eh.cpp (PR #130220)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/13207 Here is th

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
@@ -22,56 +22,136 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ -// RUN: -DFNATTRS="spir_func noundef nofpclass(nan inf)" -DTY

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
@@ -22,56 +22,144 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ +// RUN: -emit-llvm -o - | FileCheck %s \ // RUN: -DFNATTRS

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/130320 >From bdb66b5a68090e304647ddbbeb403ac408fcea65 Mon Sep 17 00:00:00 2001 From: kmpeng Date: Tue, 25 Feb 2025 14:50:09 -0800 Subject: [PATCH 1/9] start implementation --- clang/lib/Headers/hlsl/hlsl_detail.h | 14

[clang] [WebAssembly] Rename functions in wasm-eh.cpp (PR #130220)

2025-03-07 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin closed https://github.com/llvm/llvm-project/pull/130220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 76393d3 - [WebAssembly] Rename functions in wasm-eh.cpp (#130220)

2025-03-07 Thread via cfe-commits
Author: Heejin Ahn Date: 2025-03-07T16:54:22-08:00 New Revision: 76393d3863bf7394edb69fb6a371b9a1c2c09ff6 URL: https://github.com/llvm/llvm-project/commit/76393d3863bf7394edb69fb6a371b9a1c2c09ff6 DIFF: https://github.com/llvm/llvm-project/commit/76393d3863bf7394edb69fb6a371b9a1c2c09ff6.diff LO

[clang] [llvm] Use global TimerGroups for both new pass manager and old pass manager timers (PR #130375)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alan Zhao (alanzhao1) Changes Additionally, remove the behavior for both pass manager's timer manager classes (`PassTimingInfo` for the old pass manager and `TimePassesHandler` for the new pass manager) where these classes would print the

[clang] [llvm] Use global TimerGroups for both new pass manager and old pass manager timers (PR #130375)

2025-03-07 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 created https://github.com/llvm/llvm-project/pull/130375 Additionally, remove the behavior for both pass manager's timer manager classes (`PassTimingInfo` for the old pass manager and `TimePassesHandler` for the new pass manager) where these classes would print the

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-07 Thread Shafik Yaghmour via cfe-commits
@@ -12609,6 +12611,7 @@ namespace { isPODType = false; isRecordType = false; isReferenceType = false; + isInCXXOperatorCall = false; shafik wrote: It feels like changing this to use in class member initializers would have been a big win

[clang] [Clang] Check for uninitialized use in lambda within CXXOperatorCallExpr (PR #129198)

2025-03-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/129198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Add alloc_size knowledge to the 2-param span constructor warning (PR #114894)

2025-03-07 Thread David Tarditi via cfe-commits
https://github.com/dtarditi commented: @ziqingluo-90 @malavikasamak thanks for adding me to this review. I left one informational comment and one piece of feedback. https://github.com/llvm/llvm-project/pull/114894 ___ cfe-commits mailing list cfe-co

[clang] [-Wunsafe-buffer-usage] Add alloc_size knowledge to the 2-param span constructor warning (PR #114894)

2025-03-07 Thread David Tarditi via cfe-commits
@@ -353,23 +355,90 @@ isInUnspecifiedUntypedContext(internal::Matcher InnerMatcher) { return stmt(anyOf(CompStmt, IfStmtThen, IfStmtElse)); } +// Returns true iff integer E1 is equivalent to integer E2. +// +// For now we only support such expressions: +//expr := DRE |

[clang] [-Wunsafe-buffer-usage] Add alloc_size knowledge to the 2-param span constructor warning (PR #114894)

2025-03-07 Thread David Tarditi via cfe-commits
https://github.com/dtarditi edited https://github.com/llvm/llvm-project/pull/114894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Add alloc_size knowledge to the 2-param span constructor warning (PR #114894)

2025-03-07 Thread David Tarditi via cfe-commits
dtarditi wrote: I agree that it is fine to not handle this for now. If we do decide to handle this, we need to be careful because this equivalence does not hold for signed integer arithmetic expressions in C. The equivalence relies on commutativity and as

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-07 Thread via cfe-commits
dzaima wrote: Would there be some way to explicitly request to not clobber vl/vtype? An asm block is quite useful as an "optimization fence" on x86 & ARM NEON, but it'd be sad if that necessarily meant extra vsetvl spam on RVV (currently clang doesn't do much optimization on RVV intrinsics so

[clang] [llvm] [HLSL][RootSignature] Implement Parsing of Descriptor Tables (PR #122982)

2025-03-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b41b86a907f653f79bab10d4c80b3a41d146c71b 4bcd12c8f699240ef19b7540ac8ac89969a1621f --e

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-03-07 Thread Trevor Gross via cfe-commits
tgross35 wrote: Nothing about the implementation stands out to me as wrong. It looks like the exponent isn't correct, I guess you could step through this portion https://github.com/llvm/llvm-project/blob/ae42f071032b29821beef6a337712580861c/compiler-rt/lib/builtins/fp_extend_impl.inc#L65-L6

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Matt Arsenault (arsenm) Changes Follow up to c6b9d5ce76a155b682b1562122f43166aaa6391d in another instance. This is still failing in unrelated PR prechecks, but passing its own check. --- Full diff: https://github.com/llvm/llvm-proje

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#130371** https://app.graphite.dev/github/pr/llvm/llvm-project/130371?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13037

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/130371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/HIP: Use regex for final path separator in hip-partial-link, again (PR #130371)

2025-03-07 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/130371 Follow up to c6b9d5ce76a155b682b1562122f43166aaa6391d in another instance. This is still failing in unrelated PR prechecks, but passing its own check. >From 41ecac5701fec0f0a358f4503f469f2562b31210 Mon Sep 17 00:

[clang] [-Wunsafe-buffer-usage] Add alloc_size knowledge to the 2-param span constructor warning (PR #114894)

2025-03-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/13202 Here is th

[clang-tools-extra] [clang-tidy] Switch misc-confusable-identifiers check to a faster algorithm. (PR #130369)

2025-03-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Richard Smith (zygoloid) Changes Optimizations: - Only build the skeleton for each identifier once, rather than once for each declaration of that identifier. - Only compute the contexts in which identifiers are declared for identifie

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Deric C. via cfe-commits
@@ -22,56 +22,144 @@ // // RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ // RUN: spirv-unknown-vulkan-compute %s -fnative-half-type \ -// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ +// RUN: -emit-llvm -o - | FileCheck %s \ // RUN: -DFNATTRS

[clang-tools-extra] [clang-tidy] Switch misc-confusable-identifiers check to a faster algorithm. (PR #130369)

2025-03-07 Thread Richard Smith via cfe-commits
https://github.com/zygoloid created https://github.com/llvm/llvm-project/pull/130369 Optimizations: - Only build the skeleton for each identifier once, rather than once for each declaration of that identifier. - Only compute the contexts in which identifiers are declared for identifiers that

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng edited https://github.com/llvm/llvm-project/pull/130320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement the `fmod` intrinsic (PR #130320)

2025-03-07 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng edited https://github.com/llvm/llvm-project/pull/130320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >