[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Same question for regular binary operators: ```c++ using VI __attribute__((ext_vector_type(4))) = int; constexpr int a() { VI a = {0, 0, 0, 0}; VI b = {1,1,1,1}; VI C = (a + b); return 0; } static_assert(a() == 0); ``` Also, might make sense to add them to `tes

[clang] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-09-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-multistage` running on `systemz-1` while building `clang,llvm,mlir` at step 11 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/98/builds/388 Here is the relevant pi

[clang] [clang][ExprConst] Explicitly reject dependent types without diagnostic (PR #108598)

2024-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/108598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-19 Thread Nathan Ridge via cfe-commits
@@ -451,8 +451,17 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl( if (LastCheckedRedecl) { if (LastCheckedRedecl == Redecl) { LastCheckedRedecl = nullptr; +continue; HighCommander4 wrote: The fix for #108145 has merged now

[clang] [Driver][Sparc] Default to -mcpu=v9 for 32-bit Linux/sparc64 (PR #109278)

2024-09-19 Thread Sam James via cfe-commits
thesamesam wrote: (I'm fine with maskray's idea as well.) https://github.com/llvm/llvm-project/pull/109278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][Sparc] Default to -mcpu=v9 for 32-bit Linux/sparc64 (PR #109278)

2024-09-19 Thread Sam James via cfe-commits
https://github.com/thesamesam approved this pull request. https://github.com/llvm/llvm-project/pull/109278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ea57880 - [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (#108475)

2024-09-19 Thread via cfe-commits
Author: Nathan Ridge Date: 2024-09-20T02:23:58-04:00 New Revision: ea578804c81bbad1f31a0c940c8f4378d6893ede URL: https://github.com/llvm/llvm-project/commit/ea578804c81bbad1f31a0c940c8f4378d6893ede DIFF: https://github.com/llvm/llvm-project/commit/ea578804c81bbad1f31a0c940c8f4378d6893ede.diff

[clang] Update ClangFormat.rst (PR #109380)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: helianthus (love1angel) Changes latest vim such as 9.1 remove python and add python3 dependency --- Full diff: https://github.com/llvm/llvm-project/pull/109380.diff 1 Files Affected: - (modified) clang/docs/ClangFormat.rst (+5-2) ```

[clang] Update ClangFormat.rst (PR #109380)

2024-09-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Update ClangFormat.rst (PR #109380)

2024-09-19 Thread via cfe-commits
https://github.com/love1angel created https://github.com/llvm/llvm-project/pull/109380 latest vim such as 9.1 remove python and add python3 dependency >From 1dfa78f2f5f0f873ddc41687158dc48588527035 Mon Sep 17 00:00:00 2001 From: helianthus <45203165+love1an...@users.noreply.github.com> Date: Fr

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-19 Thread Timm Baeder via cfe-commits
@@ -108,22 +108,16 @@ constexpr auto p2 = "test2"; constexpr bool b1 = foo(p1) == foo(p1); static_assert(b1); -constexpr bool b2 = foo(p1) == foo(p2); // ref-error {{must be initialized by a constant expression}} \ -// ref-note {{compar

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-19 Thread Timm Baeder via cfe-commits
@@ -2142,11 +2150,91 @@ static const ValueDecl *GetLValueBaseDecl(const LValue &LVal) { return LVal.Base.dyn_cast(); } -static bool IsLiteralLValue(const LValue &Value) { - if (Value.getLValueCallIndex()) +// Information about an LValueBase that is some kind of string. +st

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-19 Thread Johannes Doerfert via cfe-commits
jdoerfert wrote: > > +1 to @efriedma-quic and @jdoerfert's comments. DataLayout should remain as > > generic as possible. Trying to encode a concept of "_the_ flat address > > space" in it seems way too specific to one optimization for one or two > > targets. > > This isn't purely a nice to h

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Added release note. I put it under "Bug Fixes to AST Handling" which seemed like a good fit. https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [PAC][clang] Use cc1 instead of driver in init-fini codegen test (PR #109247)

2024-09-19 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 closed https://github.com/llvm/llvm-project/pull/109247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b0e68a9 - [PAC][clang] Use cc1 instead of driver in init-fini codegen test (#109247)

2024-09-19 Thread via cfe-commits
Author: Daniil Kovalev Date: 2024-09-20T08:53:49+03:00 New Revision: b0e68a9a53e6bc1396271ee3d79cb86c8049fe17 URL: https://github.com/llvm/llvm-project/commit/b0e68a9a53e6bc1396271ee3d79cb86c8049fe17 DIFF: https://github.com/llvm/llvm-project/commit/b0e68a9a53e6bc1396271ee3d79cb86c8049fe17.diff

[clang] [Driver][Sparc] Default to -mcpu=v9 for 32-bit Linux/sparc64 (PR #109278)

2024-09-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: We try to restrict distribution differences to things like default linker options and library paths. Affecting `-mcpu=` seems very unintuitive. There are many Debian derivatives. It's weird that Debian uses -mcpu=v9 while others use -mcpu=v8. We should not increase `IsDebian` or

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/108475 >From 1df68534d086e20572f2371239826d6b3514e58b Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 10 Sep 2024 22:34:55 -0400 Subject: [PATCH] [AST] Ensure getRawCommentsForAnyRedecl() does not miss an

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Use X86AS::GS and X86AS::FS instead of 256 and 257. NFC (PR #109342)

2024-09-19 Thread Craig Topper via cfe-commits
@@ -144,6 +144,7 @@ add_clang_library(clangCodeGen VarBypassDetector.cpp DEPENDS + vt_gen topperc wrote: I don't know how that got in here. https://github.com/llvm/llvm-project/pull/109342 ___ cfe-commits mail

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/109364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #109375)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes GlobalMethodPool, the type of MethodPool, is a type wrapping DenseMap and exposes only a subset of the DenseMap methods. This patch adds operator[] to GlobalMethodPool so that we can avoid repeated hash

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #109375)

2024-09-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109375 GlobalMethodPool, the type of MethodPool, is a type wrapping DenseMap and exposes only a subset of the DenseMap methods. This patch adds operator[] to GlobalMethodPool so that we can avoid repeated hash l

[clang-tools-extra] [clang-move] Avoid repeated hash lookups (NFC) (PR #109374)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109374.diff 1 Files Affected: - (modified) clang-tools-extra/clang-move/HelperDeclRefGraph.cpp (+1-2) ``diff diff --gi

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (Rebased) https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-move] Avoid repeated hash lookups (NFC) (PR #109374)

2024-09-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109374 None >From 5e05b5835a639eb211a381b03057b8ff9f7be6df Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 19 Sep 2024 09:39:33 -0700 Subject: [PATCH] [clang-move] Avoid repeated hash lookups (NFC) ---

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #109373)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109373.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp (+1-2) ``diff di

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/108475 >From d224e1b658f56bf741cebf8dc5b2914716d9f47b Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 10 Sep 2024 22:34:55 -0400 Subject: [PATCH] [AST] Ensure getRawCommentsForAnyRedecl() does not miss an

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #109372)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/109372.diff 1 Files Affected: - (modified) clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp (+3-5) ``diff diff --git a/clang/uti

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #109373)

2024-09-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109373 None >From 68677c82b0c2d437be7926288249a043e5325ffe Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 19 Sep 2024 09:37:59 -0700 Subject: [PATCH] [clang-tidy] Avoid repeated hash lookups (NFC) ---

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #109372)

2024-09-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109372 None >From b8009302e897f8759c18e74012ea8b4901a82481 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 19 Sep 2024 09:21:50 -0700 Subject: [PATCH] [TableGen] Avoid repeated hash lookups (NFC) --- cl

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/108475 >From 2b14e8063c21e32d771c3f82ec9fc2319a24d5a6 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 10 Sep 2024 22:34:55 -0400 Subject: [PATCH] [AST] Ensure getRawCommentsForAnyRedecl() does not miss an

[clang] [llvm] [X86] Use X86AS::GS and X86AS::FS instead of 256 and 257. NFC (PR #109342)

2024-09-19 Thread Phoebe Wang via cfe-commits
@@ -144,6 +144,7 @@ add_clang_library(clangCodeGen VarBypassDetector.cpp DEPENDS + vt_gen phoebewang wrote: Why it depends? https://github.com/llvm/llvm-project/pull/109342 ___ cfe-commits mailing list cfe-com

[clang] [Clang] Change Attribute plugin to link clang-cpp like other examples (PR #109319)

2024-09-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/109319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dab3c6d - [Clang] Change Attribute plugin to link clang-cpp like other examples (#109319)

2024-09-19 Thread via cfe-commits
Author: Thomas Fransham Date: 2024-09-20T08:05:59+03:00 New Revision: dab3c6d39458fcc0607c678263132d7ca184cddd URL: https://github.com/llvm/llvm-project/commit/dab3c6d39458fcc0607c678263132d7ca184cddd DIFF: https://github.com/llvm/llvm-project/commit/dab3c6d39458fcc0607c678263132d7ca184cddd.dif

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate pointer/reference in `if` statement (PR #109370)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #60146. --- Full diff: https://github.com/llvm/llvm-project/pull/109370.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+13-21) - (modified) clang/unittests/Format/TokenAn

[clang] [clang-format] Correctly annotate pointer/reference in `if` statement (PR #109370)

2024-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/109370 Fixes #60146. >From bbe60a2126bd90835738485955fbe05f530afb6e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 19 Sep 2024 21:12:06 -0700 Subject: [PATCH] [clang-format] Correctly annotate pointer/reference in

[clang] [AST] Ensure getRawCommentsForAnyRedecl() does not miss any redecl with a comment (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Note, I also updated the commit message to reflect the new fix approach. https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Thanks for the reviews! I'll add the release note shortly (need to update to a newer baseline first). https://github.com/llvm/llvm-project/pull/108475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
@@ -0,0 +1,99 @@ +//===- unittests/AST/RawCommentForDeclTestTest.cpp +//-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
@@ -440,14 +440,23 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl( // Any redeclarations of D that we haven't checked for comments yet? // We can't use DenseMap::iterator directly since it'd get invalid. - auto LastCheckedRedecl = [this, CanonicalD]() -> const

[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

2024-09-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/108475 >From 2b14e8063c21e32d771c3f82ec9fc2319a24d5a6 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 10 Sep 2024 22:34:55 -0400 Subject: [PATCH] [AST] Ensure getRawCommentsForAnyRedecl() does not miss an

[clang] [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (PR #109366)

2024-09-19 Thread Shilei Tian via cfe-commits
shiltian wrote: The fix looks good. A test would be preferred. https://github.com/llvm/llvm-project/pull/109366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106146 >From 40224473a7b43bc4ffe2024ab51196c2130bedc7 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Sun, 25 Aug 2024 12:00:03 -0600 Subject: [PATCH 1/2] [DirectX] Remove trivially dead functions at linkage finalize

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
https://github.com/Prabhuk ready_for_review https://github.com/llvm/llvm-project/pull/109364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/109364 >From 5686cf3c8b4f2c9d92528d3d8b2d47e831600488 Mon Sep 17 00:00:00 2001 From: Prabhuk Date: Thu, 19 Sep 2024 19:53:59 -0700 Subject: [PATCH 1/2] Reland "[Driver] Add toolchain for X86_64 UEFI target (#76838)"

[clang] [Clang] - Add libclangSerialization to clang driver unittests (PR #109329)

2024-09-19 Thread Pranav Bhandarkar via cfe-commits
bhandarkar-pranav wrote: > I just merged my revert PR #109340 I'll investigate further on the cause for > the warning that shows up in the build bots causing the test failure Sounds good. As you can see, my fix is unrelated to this issue that you are seeing which seems to be real issue worth i

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/106146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Prabhuk (Prabhuk) Changes Reverts llvm/llvm-project#109340 Addressing the failed MAC Clang Driver test as part of this reland. --- Full diff: https://github.com/llvm/llvm-project/pull/109364.diff 10 Files Affected: - (modified) c

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
https://github.com/Prabhuk edited https://github.com/llvm/llvm-project/pull/109364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (PR #109366)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: Now that we have a functional build for `libc++` on the GPU, it will now find the target specific headers in `include/amdgcn-amd-amdhsa`. This is a problem for offloading via OpenMP because we need th

[clang] [AMDGPU] Correctly use the auxiliary toolchain to include libc++ (PR #109366)

2024-09-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/109366 Summary: Now that we have a functional build for `libc++` on the GPU, it will now find the target specific headers in `include/amdgcn-amd-amdhsa`. This is a problem for offloading via OpenMP because we need the C

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Greg Roth via cfe-commits
@@ -19,20 +19,20 @@ using namespace llvm; static bool finalizeLinkage(Module &M) { - SmallPtrSet EntriesAndExports; + SmallPtrSet Funcs; // Find all entry points and export functions for (Function &EF : M.functions()) { -if (!EF.hasFnAttribute("hlsl.shader") && !

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/109364 >From b83aea6a5853a5a532d9203cc90ee96dfedc418f Mon Sep 17 00:00:00 2001 From: Prabhuk Date: Thu, 19 Sep 2024 19:53:59 -0700 Subject: [PATCH 1/2] Revert "Revert "[Driver] Add toolchain for X86_64 UEFI target" (#

[clang] Reland "[Driver] Add toolchain for X86_64 UEFI target" (PR #109364)

2024-09-19 Thread via cfe-commits
https://github.com/Prabhuk created https://github.com/llvm/llvm-project/pull/109364 Reverts llvm/llvm-project#109340 Addressing the failed MAC Clang unit test as part of this reland. >From b83aea6a5853a5a532d9203cc90ee96dfedc418f Mon Sep 17 00:00:00 2001 From: Prabhuk Date: Thu, 19 Sep 2024 1

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-09-19 Thread Peilin Ye via cfe-commits
https://github.com/peilin-ye edited https://github.com/llvm/llvm-project/pull/108636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #109167)

2024-09-19 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > Would you like to explain more why this fail previously in more detail? > > Original code in `ASTReader::finishPendingActions` looked like this: > > ``` > for (auto ID : PendingLambdas) > GetDecl(ID); > PendingLambdas.clear(); > ``` > > The issue here is tha

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-19 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/109362 >From 363e96ba9ed442698c134f7f716a667e65ba3dbb Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Mon, 8 Jul 2024 01:48:46 +0100 Subject: [PATCH 1/2] [Clang][TableGen] Add explicit symbol visibility macros to c

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3b3accb598ec87a6a30b0e18ded06071030bb78f 363e96ba9ed442698c134f7f716a667e65ba3dbb --e

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) Changes Update ClangAttrEmitter TableGen to add explicit symbol visibility macros to class declarations it creates. Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-09-19 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod created https://github.com/llvm/llvm-project/pull/109362 Update ClangAttrEmitter TableGen to add explicit symbol visibility macros to class declarations it creates. Both AnnotateFunctions and Attribute example plugins require clang::AnnotateAttr TableGen created functi

[clang] [llvm] [clang] Add cc1 --output-asm-variant= to set output syntax (PR #109360)

2024-09-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/109360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate pointer/reference in range-for loop (PR #109361)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #109358. --- Full diff: https://github.com/llvm/llvm-project/pull/109361.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+6) - (modified) clang/unittests/Format/TokenAnnot

[clang] [clang-format] Correctly annotate pointer/reference in range-for loop (PR #109361)

2024-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/109361 Fixes #109358. >From d954c56f41a96ace6b507f6e6f4531c885db9f38 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 19 Sep 2024 18:56:38 -0700 Subject: [PATCH] [clang-format] Correctly annotate pointer/reference in

[clang] [llvm] [clang] Add cc1 --output-asm-variant= to set output syntax (PR #109360)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Fangrui Song (MaskRay) Changes 2fcaa549a824efeb56e807fcf750a56bf985296b (2010) added cc1as option `-output-asm-variant` (untested) to set the output syntax. `clang -cc1as -filetype asm -output-asm-variant 1` allows AT&T input and In

[clang] [llvm] [clang] Add cc1 --output-asm-variant= to set output syntax (PR #109360)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes 2fcaa549a824efeb56e807fcf750a56bf985296b (2010) added cc1as option `-output-asm-variant` (untested) to set the output syntax. `clang -cc1as -filetype asm -output-asm-variant 1` allows AT&T input and Intel outp

[clang] [llvm] [clang] Add cc1 --output-asm-variant= to set output syntax (PR #109360)

2024-09-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/109360 2fcaa549a824efeb56e807fcf750a56bf985296b (2010) added cc1as option `-output-asm-variant` (untested) to set the output syntax. `clang -cc1as -filetype asm -output-asm-variant 1` allows AT&T input and Intel output.

[clang] [C++20] [Modules] Offer -fmodules-embed-all-files option (PR #107194)

2024-09-19 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/107194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f41f6ea - [C++20] [Modules] Offer -fmodules-embed-all-files option (#107194)

2024-09-19 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-09-20T09:57:46+08:00 New Revision: f41f6ea1f33c4f5e7c94f3d155e44292d1809c50 URL: https://github.com/llvm/llvm-project/commit/f41f6ea1f33c4f5e7c94f3d155e44292d1809c50 DIFF: https://github.com/llvm/llvm-project/commit/f41f6ea1f33c4f5e7c94f3d155e44292d1809c50.diff LO

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-sharedlibs` running on `linaro-flang-aarch64-sharedlibs` while building `clang,flang,mlir` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-09-19 Thread via cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464 >From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001 From: awson Date: Mon, 24 Jun 2024 10:34:51 +0300 Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early. --- clang/lib/Se

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-19 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/108949 >From 3601f708847f70485fae640c5b5d96fed965e7c3 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 17 Sep 2024 17:39:47 +0800 Subject: [PATCH 1/3] [clang][bytecode] Implement arithmetic, bitwise and compound as

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread Alex Rønne Petersen via cfe-commits
alexrp wrote: > OK. Then I will work on GCC with this support. Thank you, much appreciated! https://github.com/llvm/llvm-project/pull/107664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][bytecode] Implement arithmetic, bitwise and compound assignment operator (PR #108949)

2024-09-19 Thread via cfe-commits
yronglin wrote: > Does it work to _not_ discard the result of a compound operator? > > ```c++ > using VI __attribute__((ext_vector_type(4))) = int; > > constexpr int a() { > VI a = {0, 0, 0, 0}; > VI b = {1,1,1,1}; > > VI C = (a += b); > > return 0; > } > > static_assert(a()

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-latest-gcc` running on `linaro-flang-aarch64-latest-gcc` while building `clang,flang,mlir` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread YunQiang Su via cfe-commits
wzssyqa wrote: OK. Then I will work on GCC with this support. https://github.com/llvm/llvm-project/pull/107664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa closed https://github.com/llvm/llvm-project/pull/107664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 72a2180 - [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (#107664)

2024-09-19 Thread via cfe-commits
Author: Alex Rønne Petersen Date: 2024-09-20T08:53:03+08:00 New Revision: 72a218056d68b7aa65ab3eda56837117bb59f11a URL: https://github.com/llvm/llvm-project/commit/72a218056d68b7aa65ab3eda56837117bb59f11a DIFF: https://github.com/llvm/llvm-project/commit/72a218056d68b7aa65ab3eda56837117bb59f11a

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread Alex Rønne Petersen via cfe-commits
alexrp wrote: > Do you have interesting to add them to GCC? I guess we need to add > config.sub/config.guess first. I would like to see the changes mirrored there, and code-wise it doesn't seem like a lot of work to do so. But, frankly, the contribution process for GCC (and the GNU ecosystem

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `clang,flang,mlir` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/buil

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-09-19 Thread Peilin Ye via cfe-commits
peilin-ye wrote: (pushed v2 to resolve the easier issues first :-) - deleted redundant `CPU.empty()` check - for now, fall back to `ACQUIRE` and `RELEASE` if user requested weaker memory orders (`RELAXED` or `CONSUME`), until we actually support them - took Eduard's suggestion in #107343 to u

[clang] [llvm] adding clang codegen (PR #109331)

2024-09-19 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From cb1ed6bead315b9d4982a27c53501c94981777ad Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH] adding clang codegen --- clang/include/clang/Basic/Builtins

[clang] [llvm] adding clang codegen (PR #109331)

2024-09-19 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From 0059eb9640cad23ef2a7178c6b0eca327f5db6da Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH] adding clang codegen --- clang/include/clang/Basic/Builtins

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-09-19 Thread Peilin Ye via cfe-commits
https://github.com/peilin-ye updated https://github.com/llvm/llvm-project/pull/108636 >From 087c7eb6e5fdd6866ee5209ce9cea93864dd3c6d Mon Sep 17 00:00:00 2001 From: Peilin Ye Date: Thu, 15 Aug 2024 21:49:23 + Subject: [PATCH 1/3] [BPF] Refactor BPFSubtarget::initSubtargetFeatures() (NFC) R

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-19 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/102975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b3533a1 - [clang][flang][mlir] Support -frecord-command-line option (#102975)

2024-09-19 Thread via cfe-commits
Author: Tarun Prabhu Date: 2024-09-19T18:28:50-06:00 New Revision: b3533a156da92262eb19429d8c12f53e87f5ccec URL: https://github.com/llvm/llvm-project/commit/b3533a156da92262eb19429d8c12f53e87f5ccec DIFF: https://github.com/llvm/llvm-project/commit/b3533a156da92262eb19429d8c12f53e87f5ccec.diff

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-19 Thread Richard Smith via cfe-commits
@@ -8573,7 +8661,10 @@ class LValueExprEvaluator bool VisitMaterializeTemporaryExpr(const MaterializeTemporaryExpr *E); bool VisitCompoundLiteralExpr(const CompoundLiteralExpr *E); bool VisitMemberExpr(const MemberExpr *E); - bool VisitStringLiteral(const StringLiteral *

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-19 Thread Richard Smith via cfe-commits
https://github.com/zygoloid updated https://github.com/llvm/llvm-project/pull/109208 >From 81193568c17a89f6cf42f43a82fb1fbf0f90184d Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Wed, 18 Sep 2024 21:59:56 + Subject: [PATCH 01/14] Implement current CWG direction for string literal compa

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread YunQiang Su via cfe-commits
wzssyqa wrote: Sorry for the late comment. I find a problem. With the IR code like ``` define dso_local float @f1(float noundef %a, float noundef %b) local_unnamed_addr #0 { entry: %call = tail call float @llvm.minimumnum.f32(float noundef %a, float noundef %b) #2 ret float %call } `./bin/

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-19 Thread YunQiang Su via cfe-commits
wzssyqa wrote: > My understanding is that all of these `musl*` environments have been added to > GCC and LLVM on an as-needed basis for toolchains, not necessarily because > musl itself needs them. Do you have interesting to add them to GCC? I guess we need to add config.sub/config.guess firs

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-19 Thread Henrik G. Olsson via cfe-commits
@@ -443,6 +443,426 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { return false; } +AST_MATCHER_P(CallExpr, hasNumArgs, unsigned, Num) { + return Node.getNumArgs() == Num; +} + +namespace libc_func_matchers { +// Under `libc_func_matchers`, define a set of matche

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Greg Roth (pow2clk) Changes Functions are not removed even when made internal by DXILFinalizeLinkage The removal code is called from alwaysinliner and globalopt, which are invoked too early to remove functions made internal by this pass.

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Xiang Li via cfe-commits
@@ -19,20 +19,20 @@ using namespace llvm; static bool finalizeLinkage(Module &M) { - SmallPtrSet EntriesAndExports; + SmallPtrSet Funcs; // Find all entry points and export functions for (Function &EF : M.functions()) { -if (!EF.hasFnAttribute("hlsl.shader") && !

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/106146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Remove trivially dead functions at linkage finalize (PR #106146)

2024-09-19 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/106146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >