jdoerfert wrote: > > +1 to @efriedma-quic and @jdoerfert's comments. DataLayout should remain as > > generic as possible. Trying to encode a concept of "_the_ flat address > > space" in it seems way too specific to one optimization for one or two > > targets. > > This isn't purely a nice to have optimisation aid though, is it? There are > cases where you need a safe (portable?) default that the target can perhaps > optimise, but, absent that, would at least work, and at the moment there's no > handy way to query that generically (or from Clang). We do handwave 0 as > being that safe default, and hope for the best, but as mentioned that relies > on targets using 0 to correspond to flat/generic/whatever we call it, which > they are not bound to do. To me, adding this is not entirely different from > encoding the Alloca AS, which we already do.
Your argument is my point 3), right? https://github.com/llvm/llvm-project/pull/108786#issuecomment-2357327866 Why is that a DL property and not just a target property? Or even just "computable" by asking query 1) for different ASs? https://github.com/llvm/llvm-project/pull/108786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
