[clang] b67ce7e - [clang] Use StringRef::starts_with (NFC)

2024-01-31 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-31T23:54:09-08:00 New Revision: b67ce7e34948d4d954d3cfedb29ffc94861ca0b2 URL: https://github.com/llvm/llvm-project/commit/b67ce7e34948d4d954d3cfedb29ffc94861ca0b2 DIFF: https://github.com/llvm/llvm-project/commit/b67ce7e34948d4d954d3cfedb29ffc94861ca0b2.diff L

[llvm] [clang] [RISCV] Support constraint "s" (PR #80201)

2024-01-31 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng approved this pull request. Just one minor comment, otherwise LGTM :) https://github.com/llvm/llvm-project/pull/80201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm] [clang] [RISCV] Support constraint "s" (PR #80201)

2024-01-31 Thread Kito Cheng via cfe-commits
@@ -0,0 +1,76 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -relocation-model=static < %s | FileCheck %s --check-prefix=RV32 +; RUN: llc -mtriple=riscv64 -relocation-model=pic < %s | FileCheck %s --check-prefix=RV6

[llvm] [clang] [RISCV] Support constraint "s" (PR #80201)

2024-01-31 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng edited https://github.com/llvm/llvm-project/pull/80201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add Automatic and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
https://github.com/rmarker edited https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
https://github.com/rmarker edited https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > The issue is up: #80252 Thanks. Although I feel it is too implementor's view, (I mean the end users can hardly understand it), it is much better. > Yeah, looking at the similarities, there is a decent chance this is the same > issue, it's worth trying it out. Yeah, let's

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 -I %t %t/A.cppm -emit-module-interface -o %t/A.pcm -verify +// RUN: %clang_cc1 -std=c++20 -I %t %t/B.cpp -fmodule-file=A=%t/A.pcm -fsyntax-only -verify -ast-dump-all -

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > IIRC, in #79959, you're saying the patch have the potential to fix #78850? Is > it true? Yeah, looking at the similarities, there is a decent chance this is the same issue, it's worth trying it out. https://github.com/llvm/llvm-project/pull/80245

[llvm] [clang] [compiler-rt] [clang-repl] [ORC] Add support for out-of-process execution on ELF (PR #79936)

2024-01-31 Thread Vassil Vassilev via cfe-commits
@@ -16,13 +16,24 @@ #include "clang/Interpreter/CodeCompletion.h" #include "clang/Interpreter/Interpreter.h" +#include "llvm/ADT/StringExtras.h" +#include "llvm/ExecutionEngine/Orc/ExecutorProcessControl.h" #include "llvm/ExecutionEngine/Orc/LLJIT.h" +#include "llvm/Execution

[llvm] [compiler-rt] [clang] [clang-repl] [ORC] Add support for out-of-process execution on ELF (PR #79936)

2024-01-31 Thread Vassil Vassilev via cfe-commits
@@ -143,6 +169,201 @@ ReplListCompleter::operator()(llvm::StringRef Buffer, size_t Pos, return Comps; } +static llvm::Error sanitizeOopArguments(const char *ArgV0) { + llvm::Triple SystemTriple(llvm::sys::getProcessTriple()); + if ((OutOfProcessExecutor.getNumOccurrences(

[llvm] [compiler-rt] [clang] [clang-repl] [ORC] Add support for out-of-process execution on ELF (PR #79936)

2024-01-31 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,61 @@ +// REQUIRES: host-supports-jit, x86_64-linux vgvassilev wrote: I believe this test copies some content from other tests. Would it make sense to add an extra `RUN` line to the tests themselves? https://github.com/llvm/llvm-project/pull/79936 __

[llvm] [compiler-rt] [clang] [clang-repl] [ORC] Add support for out-of-process execution on ELF (PR #79936)

2024-01-31 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev commented: Thank you for working on this. This looks very good. I have left comments from my first review pass. We probably want to wait for @lhames and @weliveindetail to take a look. https://github.com/llvm/llvm-project/pull/79936 ___

[clang] [compiler-rt] [llvm] [clang-repl] [ORC] Add support for out-of-process execution on ELF (PR #79936)

2024-01-31 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/79936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Convert __builtin_dynamic_object_size into a calculation (PR #80256)

2024-01-31 Thread Bill Wendling via cfe-commits
bwendling wrote: This is a first step in improving our `__bdos` implementation. It doesn't address the "sub-object" discussion from the previous PR (https://github.com/llvm/llvm-project/pull/78526), that will come later on. This patch takes care of a common use of `__bdos` that can't be calcul

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode rmarker wrote: Done https://github.com/llvm/llvm-project/pull/78011 ___

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
rmarker wrote: > +1. In addition, we should deprecate `None` (in documentation only) and > rename `AllowShortType` to `Automatic`, followed by `ExceptShortType` which > means "`Automatic` except for short return types". Then IMO `ExceptShortType` > is unambiguous. If you still think `NeverShor

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread via cfe-commits
https://github.com/rmarker updated https://github.com/llvm/llvm-project/pull/78011 >From a1312a0a463bb946f336977b5b01ef7afbede678 Mon Sep 17 00:00:00 2001 From: rmarker Date: Thu, 11 Jan 2024 15:01:18 +1030 Subject: [PATCH 01/15] [clang-format] Add ShortReturnTypeColumn option. --- clang/docs

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: The issue is up: https://github.com/llvm/llvm-project/issues/80252 https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][test] Limit library search when linking shared lib (PR #80253)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/80253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Convert __builtin_dynamic_object_size into a calculation (PR #80256)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes If we're able to, we convert a call to __builtin_dynamic_object_size into a calculation. This is a cleaner implementation, and has the potential to improve optimizations and, especially, inlining, because

[clang] [Clang] Convert __builtin_dynamic_object_size into a calculation (PR #80256)

2024-01-31 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/80256 If we're able to, we convert a call to __builtin_dynamic_object_size into a calculation. This is a cleaner implementation, and has the potential to improve optimizations and, especially, inlining, because opti

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 -I %t %t/A.cppm -emit-module-interface -o %t/A.pcm -verify +// RUN: %clang_cc1 -std=c++20 -I %t %t/B.cpp -fmodule-file=A=%t/A.pcm -fsyntax-only -verify -ast-dump-all -

[llvm] [clang] [AArch64] Support optional constant offset for constraint "S" (PR #80255)

2024-01-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: I have some notes about these constraints https://maskray.me/blog/2024-01-30-raw-symbol-names-in-inline-assembly https://github.com/llvm/llvm-project/pull/80255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Clang][test] Limit library search when linking shared lib (PR #80253)

2024-01-31 Thread Wei Wang via cfe-commits
apolloww wrote: Our internal builds run in chroot and the test fails with the following error ``` /bin/ld: cannot find crti.o: No such file or directory /bin/ld: cannot find crtbeginS.o: No such file or directory /bin/ld: cannot find -lgcc /bin/ld: cannot find -lgcc_s /bin/ld: cannot find -lc /b

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [llvm] [AArch64] Support optional constant offset for constraint "S" (PR #80255)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-aarch64 Author: Fangrui Song (MaskRay) Changes Modify the initial implementation (https://reviews.llvm.org/D46745) to support a constant offset so that the following code will compile: ``` int a[2][2]; void foo() { asm(

[clang] [llvm] [AArch64] Support optional constant offset for constraint "S" (PR #80255)

2024-01-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/80255 Modify the initial implementation (https://reviews.llvm.org/D46745) to support a constant offset so that the following code will compile: ``` int a[2][2]; void foo() { asm("// %0" :: "S"(&a[1][1])); } ``` We use

[clang] [Clang][test] Limit library search when linking shared lib (PR #80253)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Wei Wang (apolloww) Changes Don't search for unnecessary libs when linking the shared lib. This allows the test to run in chroot environment. --- Full diff: https://github.com/llvm/llvm-project/pull/80253.diff 1 Files Affected: - (modi

[clang-tools-extra] [clang] [llvm] [mlir] [mlir][docs] Clarified Dialect creation tutorial + fixed typos (PR #77820)

2024-01-31 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/77820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [mlir] [clang] [mlir][docs] Clarified Dialect creation tutorial + fixed typos (PR #77820)

2024-01-31 Thread Mehdi Amini via cfe-commits
@@ -106,6 +106,12 @@ the LINK_COMPONENTS descriptor. This allows cmake infrastructure to generate new library targets with correct linkage, in particular, when BUILD_SHARED_LIBS=on or LLVM_LINK_LLVM_DYLIB=on are specified. +Registration of the dialect can be performed global

[clang] [Clang][test] Limit library search when linking shared lib (PR #80253)

2024-01-31 Thread Wei Wang via cfe-commits
https://github.com/apolloww created https://github.com/llvm/llvm-project/pull/80253 Don't search for unnecessary libs when linking the shared lib. This allows the test to run in chroot environment. >From adc0635a10fc4d77842863c4f9b731733c9b8062 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: We

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From 23a0d731cfe8593c338fc8ad7920f7aa9270afaa Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:07:16 -0300 Subject: [PATCH 1/2] [NFC] [clang] add test for merging of UsingShadowDecl ---

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [flang] [llvm] [clang-tools-extra] [mlir] [mlir][tosa] Add dialect version. (PR #79514)

2024-01-31 Thread Mehdi Amini via cfe-commits
joker-eph wrote: > To be able to flag incompatible bytecode files rather than have it fail later > in mysterious ways. E.g., allows for a more strict failure. That would require some sort of principles and policy around the changes that affect the serialization of this and the maintenance of t

[llvm] [clang] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

2024-01-31 Thread Jeremy Morse via cfe-commits
jmorse wrote: ...ah, actually is it malformed because there's a DICompositeType in the retainedNodes list for a DISubprogram? I remember that the verifier considered that illegal before your patch landed, but not after. https://github.com/llvm/llvm-project/pull/75385 __

[clang] 48f8b74 - [clang][Interp] Support GenericSelectionExprs

2024-01-31 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-01T08:15:11+01:00 New Revision: 48f8b74c35991fd3842e135481960449b1e25363 URL: https://github.com/llvm/llvm-project/commit/48f8b74c35991fd3842e135481960449b1e25363 DIFF: https://github.com/llvm/llvm-project/commit/48f8b74c35991fd3842e135481960449b1e25363.diff LO

[clang] fa98e28 - [clang][Interp][NFC] Remove unused RecordScope

2024-01-31 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-01T08:03:49+01:00 New Revision: fa98e2861dadaf436b0eb4b38e96a2ccf7c41072 URL: https://github.com/llvm/llvm-project/commit/fa98e2861dadaf436b0eb4b38e96a2ccf7c41072 DIFF: https://github.com/llvm/llvm-project/commit/fa98e2861dadaf436b0eb4b38e96a2ccf7c41072.diff LO

[clang] a9e8309 - [clang][Interp] Protect Inc/Dec ops against dummy pointers

2024-01-31 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-01T08:03:49+01:00 New Revision: a9e830910bc07733b7a9d4b935cd12a9041623b3 URL: https://github.com/llvm/llvm-project/commit/a9e830910bc07733b7a9d4b935cd12a9041623b3 DIFF: https://github.com/llvm/llvm-project/commit/a9e830910bc07733b7a9d4b935cd12a9041623b3.diff LO

[polly] [clang-tools-extra] [llvm] [clang] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-01-31 Thread Karthika Devi C via cfe-commits
https://github.com/kartcq updated https://github.com/llvm/llvm-project/pull/78549 >From 1aeb149cb15e83c8880a99aa94db224737331aa6 Mon Sep 17 00:00:00 2001 From: kartcq Date: Fri, 15 Dec 2023 02:58:40 -0800 Subject: [PATCH 1/3] [polly] Add polly-debug flag to print debug info from all parts of p

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[polly] [clang-tools-extra] [llvm] [clang] [polly] Add polly-debug flag to print debug info from all parts of polly (PR #78549)

2024-01-31 Thread Karthika Devi C via cfe-commits
https://github.com/kartcq updated https://github.com/llvm/llvm-project/pull/78549 >From 1aeb149cb15e83c8880a99aa94db224737331aa6 Mon Sep 17 00:00:00 2001 From: kartcq Date: Fri, 15 Dec 2023 02:58:40 -0800 Subject: [PATCH 1/3] [polly] Add polly-debug flag to print debug info from all parts of p

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: IIRC, in https://github.com/llvm/llvm-project/pull/79959, you're saying the patch have the potential to fix https://github.com/llvm/llvm-project/issues/78850? Is it true? https://github.com/llvm/llvm-project/pull/80245 __

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 -I %t %t/A.cppm -emit-module-interface -o %t/A.pcm -verify +// RUN: %clang_cc1 -std=c++20 -I %t %t/B.cpp -fmodule-file=A=%t/A.pcm -fsyntax-only -verify -ast-dump-all -

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Hmm I have been doing user branches for a while, this saves me time in case I want to split the patch off in a separate MR. It's already the case that this is split into test adding + fixing commits. In any case, the user branch will be deleted as soon as this is merged. Can we

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Before looking into it, I remember the user branch is only allowed for stacked review. If this patch is not the case, let's try to create a new PR. https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-comm

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Accept lambdas in C++03 as an extensions (PR #73376)

2024-01-31 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This LGTM but we need @llvm-beanz to review https://github.com/llvm/llvm-project/pull/73376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6ff431b - [clang][Interp] Handle imaginary literals (#79130)

2024-01-31 Thread via cfe-commits
Author: Timm Baeder Date: 2024-02-01T07:13:10+01:00 New Revision: 6ff431b01e29e99c7dbfcda96bdefdff91dcdf7f URL: https://github.com/llvm/llvm-project/commit/6ff431b01e29e99c7dbfcda96bdefdff91dcdf7f DIFF: https://github.com/llvm/llvm-project/commit/6ff431b01e29e99c7dbfcda96bdefdff91dcdf7f.diff L

[clang] [clang] Fix crash when declaring invalid lambda member (PR #74110)

2024-01-31 Thread Shafik Yaghmour via cfe-commits
@@ -1526,10 +1526,9 @@ bool CXXRecordDecl::isGenericLambda() const { #ifndef NDEBUG static bool allLookupResultsAreTheSame(const DeclContext::lookup_result &R) { - for (auto *D : R) -if (!declaresSameEntity(D, R.front())) - return false; - return true; + return llv

[clang] a8f317a - [clang][Interp] complex binary operators aren't always initializing

2024-01-31 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-01T07:09:43+01:00 New Revision: a8f317aeaccaa052c9c4cfa4660c40554fbbf223 URL: https://github.com/llvm/llvm-project/commit/a8f317aeaccaa052c9c4cfa4660c40554fbbf223 DIFF: https://github.com/llvm/llvm-project/commit/a8f317aeaccaa052c9c4cfa4660c40554fbbf223.diff LO

[clang] [clang-format] Allow decltype in requires clause (PR #78847)

2024-01-31 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/78847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9b68c09 - [clang-format] Allow decltype in requires clause (#78847)

2024-01-31 Thread via cfe-commits
Author: Emilia Kond Date: 2024-02-01T08:00:45+02:00 New Revision: 9b68c095d6b52d6ec0390c653528f65c42e5f570 URL: https://github.com/llvm/llvm-project/commit/9b68c095d6b52d6ec0390c653528f65c42e5f570 DIFF: https://github.com/llvm/llvm-project/commit/9b68c095d6b52d6ec0390c653528f65c42e5f570.diff L

[clang] Users/mizvekov/bug/clang merge usingshadowdecl (PR #80245)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes [clang] fix merging of UsingShadowDecl Previously, when deciding if two UsingShadowDecls where mergeable, we would incorrectly only look for both pointing to the exact r

[clang] Users/mizvekov/bug/clang merge usingshadowdecl (PR #80245)

2024-01-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/80245 [clang] fix merging of UsingShadowDecl Previously, when deciding if two UsingShadowDecls where mergeable, we would incorrectly only look for both pointing to the exact redecla ration, whereas the correct thing i

[clang] [clang-format] Allow decltype in requires clause (PR #78847)

2024-01-31 Thread Owen Pan via cfe-commits
owenca wrote: Should we merge this patch? https://github.com/llvm/llvm-project/pull/78847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Introduce reduced BMI (PR #75894)

2024-01-31 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @mizvekov would you like to take a look at this? This is related (in some level) to what you say https://github.com/llvm/llvm-project/pull/79959. In short, in the direction, in the one-phase compilation, the pcm won't be compiled into object files. (But it still will in the t

[clang-tools-extra] [clang-tidy] Add AllowStringArrays option to modernize-avoid-c-arrays (PR #71701)

2024-01-31 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/71701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] b777bb7 - [clang-tidy] Add AllowStringArrays option to modernize-avoid-c-arrays (#71701)

2024-01-31 Thread via cfe-commits
Author: Piotr Zegar Date: 2024-02-01T06:47:53+01:00 New Revision: b777bb78b302055eba876a0258ea4b2625ffe71a URL: https://github.com/llvm/llvm-project/commit/b777bb78b302055eba876a0258ea4b2625ffe71a DIFF: https://github.com/llvm/llvm-project/commit/b777bb78b302055eba876a0258ea4b2625ffe71a.diff L

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-01-31 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/79959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8eea582 - [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (#79959)

2024-01-31 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-02-01T13:44:32+08:00 New Revision: 8eea582dcb900afb45866a09296624b6fef9dd20 URL: https://github.com/llvm/llvm-project/commit/8eea582dcb900afb45866a09296624b6fef9dd20 DIFF: https://github.com/llvm/llvm-project/commit/8eea582dcb900afb45866a09296624b6fef9dd20.diff LO

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-01-31 Thread Chuanqi Xu via cfe-commits
@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: There is no need to update the release notes for new option values. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode owenca wrote: Change the comments (lines 917-927) to something like the foll

[clang] [polly] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
@@ -922,8 +922,39 @@ struct FormatStyle { /// }; /// int f(); /// int f() { return 1; } +/// int LongName:: +/// AnotherLongName(); /// \endcode RTBS_None, +/// Break after return type automatically. +/// This mode doesn't hav

[clang] [clang][Diagnostic] Don't warn about binary literals when using C23. (PR #80244)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Collin Funk (collinfunk) Changes The C23 standard brought binary literals which were previously GNU extensions. Silence warnings from -Wgnu-binary-literal when using C23. This warning is implied by -Wpedantic. --- Full diff: https://gith

[clang] [clang][Diagnostic] Don't warn about binary literals when using C23. (PR #80244)

2024-01-31 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][Diagnostic] Don't warn about binary literals when using C23. (PR #80244)

2024-01-31 Thread Collin Funk via cfe-commits
https://github.com/collinfunk created https://github.com/llvm/llvm-project/pull/80244 The C23 standard brought binary literals which were previously GNU extensions. Silence warnings from -Wgnu-binary-literal when using C23. This warning is implied by -Wpedantic. >From ef443507e06adcbc604ad8e0

[libcxx] [llvm] [lldb] [clang-tools-extra] [libc] [clang] [flang] [compiler-rt] [lld] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-31 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/5] Make clang report invalid target versions for all environme

[clang] [clang][Interp] Handle imaginary literals (PR #79130)

2024-01-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79130 >From db25ed3917079ea9bf3c05a899b40415e3c5df8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 23 Jan 2024 09:14:02 +0100 Subject: [PATCH] [clang][Interp] Handle imaginary literals Initi

[polly] [clang] [clang-format] Add AllowShortType and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-31 Thread Owen Pan via cfe-commits
owenca wrote: > Now that we've got both options, should we keep them? Currently, `None` > sometimes forbids breaking after short return types and sometimes allows it > and just bases things off the penalty configuration. I feel like there will > be some people who use `None` who would want the

[clang] [clang-format] Update FormatToken::isSimpleTypeSpecifier() (PR #79115)

2024-01-31 Thread Owen Pan via cfe-commits
owenca wrote: See #80241. https://github.com/llvm/llvm-project/pull/79115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Update FormatToken::isSimpleTypeSpecifier() (PR #79115)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/79115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Update FormatToken::isSimpleTypeSpecifier() (PR #80241)

2024-01-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Now with a8279a8bc541, we can make the update. --- Full diff: https://github.com/llvm/llvm-project/pull/80241.diff 4 Files Affected: - (modified) clang/include/clang/Format/Format.h (+2) - (modified) cl

[clang] [clang-format] Update FormatToken::isSimpleTypeSpecifier() (PR #80241)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/80241 Now with a8279a8bc541, we can make the update. >From fda19165bc1195be01159c7d071839822ff3f929 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 31 Jan 2024 20:43:29 -0800 Subject: [PATCH] [clang-format] Update F

[clang] [Clang][RISCV] Add assumptions to vsetvli/vsetvlimax (PR #79975)

2024-01-31 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: > I'm concerned that llvm.assume is handled differently than a branch to > unreachable in the middle end. Actually the CodeGen part is written by referring to the LLVM IR generated by unreachable way (https://godbolt.org/z/vf1v7f744). > Have you tested that these assumes hav

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-31 Thread Brendan Sweeney via cfe-commits
mehnadnerd wrote: It has been approved to be pursued as a fast track extension (https://lists.riscv.org/g/tech-unprivileged/topic/arc_architecture_review/101951698). It has not yet been approved by the chairs. https://github.com/llvm/llvm-project/pull/79911

[clang] [clang][dataflow] Display line numbers in the HTML logger timeline. (PR #80130)

2024-01-31 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/80130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0c36127 - [clang][dataflow] Display line numbers in the HTML logger timeline. (#80130)

2024-01-31 Thread via cfe-commits
Author: martinboehme Date: 2024-02-01T05:33:03+01:00 New Revision: 0c361270afff83cd6433cf865ed5a410dadfb33f URL: https://github.com/llvm/llvm-project/commit/0c361270afff83cd6433cf865ed5a410dadfb33f DIFF: https://github.com/llvm/llvm-project/commit/0c361270afff83cd6433cf865ed5a410dadfb33f.diff

[clang] [clang][dataflow] Display line numbers in the HTML logger timeline. (PR #80130)

2024-01-31 Thread via cfe-commits
martinboehme wrote: Failing check is a clang-format check for clang/docs/HIPSupport.rst, which this PR does not modify. https://github.com/llvm/llvm-project/pull/80130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang][dataflow][NFC] Rename a confusingly named variable. (PR #80182)

2024-01-31 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/80182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 994493c - [clang][dataflow][NFC] Rename a confusingly named variable. (#80182)

2024-01-31 Thread via cfe-commits
Author: martinboehme Date: 2024-02-01T05:31:32+01:00 New Revision: 994493ce05ab7351cd92d30fb1bd23985b292851 URL: https://github.com/llvm/llvm-project/commit/994493ce05ab7351cd92d30fb1bd23985b292851 DIFF: https://github.com/llvm/llvm-project/commit/994493ce05ab7351cd92d30fb1bd23985b292851.diff

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/79796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 908fd09 - [clang-format] Simplify the AfterPlacementOperator option (#79796)

2024-01-31 Thread via cfe-commits
Author: Owen Pan Date: 2024-01-31T20:20:26-08:00 New Revision: 908fd09a13b2e89a52282478544f7f70cf0a887f URL: https://github.com/llvm/llvm-project/commit/908fd09a13b2e89a52282478544f7f70cf0a887f DIFF: https://github.com/llvm/llvm-project/commit/908fd09a13b2e89a52282478544f7f70cf0a887f.diff LOG:

[clang] [clang][NFC] Move isSimpleTypeSpecifier() from Sema to Token (PR #80101)

2024-01-31 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/80101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a8279a8 - [clang][NFC] Move isSimpleTypeSpecifier() from Sema to Token (#80101)

2024-01-31 Thread via cfe-commits
Author: Owen Pan Date: 2024-01-31T20:16:18-08:00 New Revision: a8279a8bc541b6027087dd497daa63b6602b7f4b URL: https://github.com/llvm/llvm-project/commit/a8279a8bc541b6027087dd497daa63b6602b7f4b DIFF: https://github.com/llvm/llvm-project/commit/a8279a8bc541b6027087dd497daa63b6602b7f4b.diff LOG:

  1   2   3   4   5   >