llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Collin Funk (collinfunk) <details> <summary>Changes</summary> The C23 standard brought binary literals which were previously GNU extensions. Silence warnings from -Wgnu-binary-literal when using C23. This warning is implied by -Wpedantic. --- Full diff: https://github.com/llvm/llvm-project/pull/80244.diff 1 Files Affected: - (modified) clang/lib/Lex/LiteralSupport.cpp (+11-5) ``````````diff diff --git a/clang/lib/Lex/LiteralSupport.cpp b/clang/lib/Lex/LiteralSupport.cpp index 0a78638f68051..add4ca76678de 100644 --- a/clang/lib/Lex/LiteralSupport.cpp +++ b/clang/lib/Lex/LiteralSupport.cpp @@ -1358,11 +1358,17 @@ void NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) { // Handle simple binary numbers 0b01010 if ((c1 == 'b' || c1 == 'B') && (s[1] == '0' || s[1] == '1')) { - // 0b101010 is a C++1y / GCC extension. - Diags.Report(TokLoc, LangOpts.CPlusPlus14 - ? diag::warn_cxx11_compat_binary_literal - : LangOpts.CPlusPlus ? diag::ext_binary_literal_cxx14 - : diag::ext_binary_literal); + // 0b101010 is a GCC extension subsequently standardized by C23 and C++14. + if (LangOpts.CPlusPlus) { + if (LangOpts.CPlusPlus14) + Diags.Report(TokLoc, diag::warn_cxx11_compat_binary_literal); + else + Diags.Report(TokLoc, diag::ext_binary_literal_cxx14); + } else { + // TODO: Need new DiagGroup for C23. + if (!LangOpts.C23) + Diags.Report(TokLoc, diag::ext_binary_literal); + } ++s; assert(s < ThisTokEnd && "didn't maximally munch?"); radix = 2; `````````` </details> https://github.com/llvm/llvm-project/pull/80244 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
